Re: [flac-dev] Patch to fix compiler warnings and error status collisions

2014-04-07 Thread Erik de Castro Lopo
Lenny Maiorani wrote: > I am new around here, so I am not sure of all your procedures > for submitting patches/pull requests. A patch like you sent is fine. When I commit that I will add a Patch-from line to the commit. Otherwise, you can commit to you local repo and then use the git format-patc

Re: [flac-dev] Patch to fix compiler warnings and error status collisions

2014-04-07 Thread lvqcl
Lenny Maiorani wrote: > Hi, > > I am new around here, so I am not sure of all your procedures for submitting > patches/pull requests. > > The attached patch fixes all Clang compilation warnings. BTW, there was a discussion about FLAC__CPUINFO_IA32_CPUID_ constants: http://lists.xiph.org/pip

Re: [flac-dev] [PATCH] Website news and non-ASCII issues

2014-04-07 Thread Erik de Castro Lopo
Martijn van Beurden wrote: > This patch adds two news items, most importantly on the recently > announced PonoMusic service, which is said to offer only FLAC > files. This patch also fixes some problems with non-ASCII > characters. Finally, this patch also adds a few artists to the > links pag

Re: [flac-dev] Patch to fix compiler warnings and error status collisions

2014-04-07 Thread Lenny Maiorani
On Apr 7, 2014, at 4:07 AM, Erik de Castro Lopo wrote: > Lenny Maiorani wrote: > >> I am new around here, so I am not sure of all your procedures >> for submitting patches/pull requests. > > A patch like you sent is fine. When I commit that I will add > a Patch-from line to the commit. > > Ot