[flac-dev] [PATCH 1/2] Revert "configure.ac : If gcc is version 4.2, use -fgnu89-inline."

2013-11-20 Thread Rafaël Carré
This reverts commit 2860f1780ca92c779ee0a2c545ae1b9c4818dc53. Conflicts: configure.ac Do not use -fgnu89-inline as it can emit duplicate symbols for inline functions that are declared in multiple object files being linked together. For example on clang 5.0 targetting iOS (clang advertise

[flac-dev] [PATCH 2/2] Use -fvisibility for osx targets too

2013-11-20 Thread Rafaël Carré
--- configure.ac | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index fa6f4fb..19306ed 100644 --- a/configure.ac +++ b/configure.ac @@ -405,7 +405,7 @@ if test x$ac_cv_c_compiler_gnu = xyes ; then XIPH_ADD_CXXFLAGS([-Weffc++]) AC_LAN

Re: [flac-dev] [PATCH 1/2] Revert "configure.ac : If gcc is version 4.2, use -fgnu89-inline."

2013-11-20 Thread Erik de Castro Lopo
Rafaël Carré wrote: > This reverts commit 2860f1780ca92c779ee0a2c545ae1b9c4818dc53. > > Conflicts: > configure.ac > > Do not use -fgnu89-inline as it can emit duplicate symbols for > inline functions that are declared in multiple object files > being linked together. > > For example on cl

Re: [flac-dev] [PATCH 1/2] Revert "configure.ac : If gcc is version 4.2, use -fgnu89-inline."

2013-11-20 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: > Rafaël Carré wrote: > > > This reverts commit 2860f1780ca92c779ee0a2c545ae1b9c4818dc53. > > > > Conflicts: > > configure.ac > > > > Do not use -fgnu89-inline as it can emit duplicate symbols for > > inline functions that are declared in multiple object files > >