Re: [flac-dev] PATCH for rice_parameter calculation

2013-10-11 Thread Erik de Castro Lopo
lvqcl wrote: > MSVS profiler shows that the following code in stream_encoder.c takes > several percent of CPU time: This has been applied. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ __

Re: [flac-dev] unsigned long long suffix

2013-10-11 Thread Erik de Castro Lopo
lvqcl wrote: > Erik de Castro Lopo wrote: > > >> #define FLAC__U64L(x) x##ULL > > > > I like that one! If that works in VS2005 and later I see no reason to use > > anything else. > > MSVS 2005 Express compiles the code... > > #define FLAC__U64L(x) x##ULL > int test = FLAC__U64L(0x1234567890); >

Re: [flac-dev] PATCH for rice_parameter calculation

2013-10-11 Thread Brian Willoughby
Hmm, maybe I'm missing something, but what about this: rice_parameter = 0; k = partition_samples; int n = mean - k; if (n > 0) { rice_parameter += n; k <<= n; } I've not looked at this code in its context within stream_encoder.c, s

Re: [flac-dev] PATCH for rice_parameter calculation

2013-10-11 Thread Brian Willoughby
Or, I was originally thinking: rice_parameter = 0; k = partition_samples; if (k < mean) { int n = mean - k; rice_parameter += n; k <<= n; } (sorry for the hasty post) On Oct 11, 2013, at 10:34, Brian Willoughby wrote: > Hmm