Re: [flac-dev] Circular preprocessor define with MSVC

2013-04-07 Thread Janne Hyvärinen
On 6.4.2013 23:30, Ulrich Klauer wrote: Hi, in include/share/alloc.h there is this section: #ifndef SIZE_MAX # ifndef SIZE_T_MAX # ifdef _MSC_VER # define SIZE_T_MAX SIZE_MAX # else # error # endif # endif # define SIZE_MAX SIZE_T_MAX #endif So, if we are on MSVC and have neither SIZE_MA

Re: [flac-dev] Circular preprocessor define with MSVC

2013-04-07 Thread Erik de Castro Lopo
Janne Hyvärinen wrote: > On 6.4.2013 23:30, Ulrich Klauer wrote: > > Hi, > > in include/share/alloc.h there is this section: > > > > #ifndef SIZE_MAX > > # ifndef SIZE_T_MAX > > # ifdef _MSC_VER > > # define SIZE_T_MAX SIZE_MAX > > # else > > # error > > # endif > > # endif > > # define SIZ

Re: [flac-dev] flac 1.3.0pre3 pre-release

2013-04-07 Thread Janne Hyvärinen
On 2.4.2013 12:57, Erik de Castro Lopo wrote: I noticed compat.h patch didn't make it into git. I know it may not be perfect patch but unistd.h is in two different #ifdef checks. First one is fine when it's excluded on _WIN32 but second check gives is for everyone if __CYGWIN__ or __EMX__ isn't

Re: [flac-dev] flac 1.3.0pre3 pre-release

2013-04-07 Thread Erik de Castro Lopo
Janne Hyvärinen wrote: > Here's one more try to solve the compilation problem when non-existing > unistd.h is tried to include with MSVC. It now includes it like before > the cleanup so it shouldn't do any harm to environments that have worked > in the past. Patch applied. Thanks. Erik -- --

Re: [flac-dev] flac 1.3.0pre3 pre-release

2013-04-07 Thread Dagobert Michelsen
Hi Erik, Am 07.04.2013 um 04:19 schrieb Erik de Castro Lopo : > Dagobert Michelsen wrote: >> There compilation on Solaris 10 Sparc with Sun Studio 12 gives the following >> compile errors: >> >>> CC bitreader.lo >>> "bitreader.c", line 494: warning: implicit function declaration: MIN >>> C

Re: [flac-dev] flac 1.3.0pre3 pre-release

2013-04-07 Thread Erik de Castro Lopo
Dagobert Michelsen wrote: > Yes, C99 is on and according to B.2.18 from > http://docs.oracle.com/cd/E19205-01/819-5265/bjapp/index.html > also casual use. What does not work is the inclusion of a static function > from extern inline. It also does work if I declare bitwriter_grow_ also > as "inli