Re: [flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite

2013-03-12 Thread Jaren Stangret
Seems time is going to be a constraint for me in the coming week, but I'll try and get more of these out to you as fast as I can get them written and tested. Keeping the patches in a separate branch for now seems like a good idea to me. Attached is a patch for 'test_streams.sh' On Tue, Mar 12,

Re: [flac-dev] flac 1.3.0pre2 pre-release

2013-03-12 Thread Janne Hyvärinen
On 11.3.2013 21:21, Erik de Castro Lopo wrote: Error9error LNK2001: unresolved external symbol _safe_malloc_mul_2op_ G:\Programming\flac-1.3.0pre2\src\flac\utf8_static.lib(utf8.obj) flac Error10error LNK1120: 9 unresolved externals G:\Programming\flac-1.3.0pre2\objs\release\bin\f

Re: [flac-dev] flac 1.3.0pre2 pre-release

2013-03-12 Thread Erik de Castro Lopo
Janne Hyvärinen wrote: > I thought Ben Allison would have made a patch. Here's a patch for this. > I suppose we were all blind at first for the cause. Applied thanks. I'd now like to look at the 2/4Gig off_t issue in your original support_2gb_output patch. Unlike your original patch, you will h

Re: [flac-dev] Can't cross-compile from git now.

2013-03-12 Thread Erik de Castro Lopo
Erik de Castro Lopo wrote: > JonY wrote: > > > Please do a link time test instead, I am not getting this error and > > would like to keep stack protector on. > > I'll write an m4 macro. I have attampted to write a macro that reliably detects the availability of stack smash protection. I curren

[flac-dev] Flac compression levels?

2013-03-12 Thread Marcus Johnson
"Using FLAC binary : /Users/Marcus/flac/test/../src/flac/flac Original file size 441044 bytes. Compression level 1, file size 421393 bytes. Compression level 2, file size 421393 bytes. Compression level 3, file size 373613 bytes. Compression level 4, file size 369517 bytes. Compression le

Re: [flac-dev] Flac compression levels?

2013-03-12 Thread Erik de Castro Lopo
Marcus Johnson wrote: > So, basically compression levels 1 & 2 result in the same file size, 4-7 > also result in the same file size, now is it just a coincidence, That is the results for that particular file, a file that was already part of the FLAC test suite called "noisy-sine.wav". For anoth

Re: [flac-dev] Flac compression levels?

2013-03-12 Thread Xavier Morel
On 2013-03-12, at 12:11 , Marcus Johnson wrote: > now is it just a coincidence, > considering the test files are small It is, testing on a >6mn piece (Endless, Nameless from Nirvana's Nevermind, 6:21) using flac 1.2.1 on OSX 10.6 I get the following: 71495116 base.wav 54517574 level-0.flac 534409

Re: [flac-dev] Can't cross-compile from git now.

2013-03-12 Thread JonY
On 3/12/2013 18:58, Erik de Castro Lopo wrote: > Erik de Castro Lopo wrote: > >> JonY wrote: >> >>> Please do a link time test instead, I am not getting this error and >>> would like to keep stack protector on. >> >> I'll write an m4 macro. > > I have attampted to write a macro that reliably dete

Re: [flac-dev] Flac compression levels?

2013-03-12 Thread Declan Kelly
On Tue, Mar 12, 2013 at 12:36:29PM +0100, catch-...@masklinn.net wrote: > > > now is it just a coincidence, > > It is, testing on a >6mn piece (Endless, Nameless from Nirvana's > Nevermind, 6:21) Does that track have a long period of silence in the middle? (...checks Discogs...) Nope: "Endless,

Re: [flac-dev] Flac compression levels?

2013-03-12 Thread Xavier Morel
On 2013-03-12, at 20:00 , Declan Kelly wrote: > On Tue, Mar 12, 2013 at 12:36:29PM +0100, catch-...@masklinn.net wrote: >> >>> now is it just a coincidence, >> >> It is, testing on a >6mn piece (Endless, Nameless from Nirvana's >> Nevermind, 6:21) > > Does that track have a long period of sile

Re: [flac-dev] Can't cross-compile from git now.

2013-03-12 Thread Erik de Castro Lopo
JonY wrote: > What is your link test checking and how does it fail? My m4 macro is really simple, TRY_LINK a simple program with the stack protect CFLAGS: AC_DEFUN([XIPH_GCC_STACK_PROTECTOR], [AC_LANG_ASSERT(C) AC_MSG_CHECKING([if $CC supports stack smash protection]) xip

Re: [flac-dev] Can't cross-compile from git now.

2013-03-12 Thread Dave Yeo
On 03/12/13 12:39 pm, Erik de Castro Lopo wrote: > For the Linux -> Windows cross compile for instance, this detects > SSP as working, but when I compile it fails with: > > CC stream_encoder_framing.lo > CC window.lo > CCLD libFLAC.la >Creating library file: .libs/libF

Re: [flac-dev] Can't cross-compile from git now.

2013-03-12 Thread JonY
On 3/13/2013 03:50, Dave Yeo wrote: > On 03/12/13 12:39 pm, Erik de Castro Lopo wrote: >> For the Linux -> Windows cross compile for instance, this detects >> SSP as working, but when I compile it fails with: >> >> CC stream_encoder_framing.lo >> CC window.lo >> CCLD libFL

Re: [flac-dev] Can't cross-compile from git now.

2013-03-12 Thread Erik de Castro Lopo
Dave Yeo wrote: > I can get around the undefined symbol errors by doing make LDFLAGS=-lssp > Perhaps Windows and FreeBSD will also work if linked against ssp.a / > ssp.dll. OF course this introduces another dependency. Yes, *highly* un-desirable. Erik -- --

Re: [flac-dev] Can't cross-compile from git now.

2013-03-12 Thread Erik de Castro Lopo
JonY wrote: > Dave, my toolchain automatically links libssp already, I am using > vanilla sources. Are you doing a native Windows compile with MinGW or cross compiling from Linux? > Why not also check if -lssp is required? If the toolchain has SSP > disabled it should not be passing. Check onces

Re: [flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite

2013-03-12 Thread Jaren Stangret
Attached is a patch for 'test_compression.sh'. Interestingly, I noticed compression level '0' is omitted, so I've added it in. Also, I tested this on a 24bit/96kHz FLAC file and the test failed between compression level 0 and compression level 1 -- the file size was greater with a compression lev

Re: [flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite

2013-03-12 Thread Erik de Castro Lopo
Jaren Stangret wrote: > Interestingly, I noticed compression level '0' is omitted, so I've added it > in. Thanks. > Also, I tested this on a 24bit/96kHz FLAC file and the test failed between > compression level 0 and compression level 1 -- the file size was greater > with a compression level of

Re: [flac-dev] [flac 1.3.0pre2 pre-release] Updates to test suite

2013-03-12 Thread Jaren Stangret
Attached is a patch for 'test_grabbag.sh'. Continuing in the same vein as the other patches, this patch consists of minor reworks of functions/commands as well as heavily commenting what's going on. More than halfway there! Thanks, Jaren On Tue, Mar 12, 2013 at 9:40 PM, Erik de Castro Lopo wro