Ben Allison wrote:
> This should be enough to fix it
Applied, thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists
Ben Allison wrote:
> This is the delta that should fix everything up.
> I hope that #include "share/compat.h" is acceptable from the test_streams
> binary.
Yes, the share/* header files are shared between the library internals,
the test suite programs and flac and metaflac binary executables.
>
Hi
I have a problem now cross-compiling FLAC from latest git.
With Ubuntu 12.04 and g++-mingw-w64-i686 (4.6.3-1ubuntu5+5ubuntu1).
I think that the problem might have been introduced on 5 Mar 2013 with commit
05609d5 (configure.ac : Add hardening compile options.)
Gives errors like this:-
/home
> Are the changes for FLAC/ordinals.h really necessary? Yhe FLAC/*.h
> header files specify libFLAC's public API. In a previous thread on
> this mailing list back in February we decided that for compilers
> that didn't supply the developer should supply something
> suitable. Here's the commit:
Ye
On 13-03-08 8:39 AM, bat guano wrote:
> /home/user/FLAC_build/flac-05609d5/src/libFLAC/.libs/libFLAC.a(ogg_helper.o):ogg_helper.c:(.text+0x173):
> undefined reference to `___stack_chk_guard'
I have a vague memory that -fstack-protector doesn't work in mingw, but
the configure check passed. Maybe
Can you
> re-run with --disable-silent-rules
Hi
I added "--disable-silent-rules" to config.
Like this:-
PKG_CONFIG_PATH="$HOME/FLAC_build/lib/pkgconfig"
LDFLAGS="-L$HOME/FLAC_build/lib" CFLAGS="-I$HOME/FLAC_build/include"
./configure --prefix=$HOME/
bat guano wrote:
>
> Hi
> I have a problem now cross-compiling FLAC from latest git.
> With Ubuntu 12.04 and g++-mingw-w64-i686 (4.6.3-1ubuntu5+5ubuntu1).
>
> I think that the problem might have been introduced on 5 Mar 2013
> with commit 05609d5 (configure.ac : Add hardening compile options.)
>
> That was fixed with
>
> commit d5b03bcc36474ff1c9f2da2dcb5212e810208a6f
> Author: Erik de Castro Lopo
> Date: Sat Mar 9 08:55:37 2013 +1100
>
> configure.ac : Don't enable stack protector for mingw* host_os.
>
Yes, it's fixed.
Thanks.
:-)
Ben Allison wrote:
> Yes, they are necessary. Here is the rationale
>
> 1) FLAC/ordinals.h is a public header file, so replacing this file with an
> MSVC-compatible version is not only the responsibility of a developer
> building libFLAC, but also a developer using libFLAC.
I was aware of that.
