Re: [flac-dev] flac 1.3.0pre1 prelease

2013-03-04 Thread Erik de Castro Lopo
Ralph Giles wrote: > On 13-03-02 3:22 PM, Erik de Castro Lopo wrote: > > > http://downloads.xiph.org/releases/flac/beta/ > > On Mac 10.7.5 Apple clang 4.2, 'make check' fails because BSD and GNU > coreutils have incompatible format options for 'stat'. > > If I change test/test_compression.s

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-04 Thread Erik de Castro Lopo
Ben Allison wrote: > Visual Studio files (which don't use config.h, but define various things > in the project settings) are compiling with the wrong FLAC version string > (1.2.0 or 1.2.1) > > I've attached the patch. Ben, I'll apply this patch when all the other issues are sorted out. Thanks.

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-04 Thread Ben Allison
Here's another go at it. I only have VS2008 and VS2010 to test with right now. VS6.0, VS2003 and VS2005 are untested. I'm still not too happy with it, but it does work. I would recommend using FLAC__uint32 instead of uint32_t to avoid these small #if _MSC_VER < things everywhere, although

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-04 Thread Andy Hawkins
Hi, In article <20130304070023.141c9f101622a34c46d68...@mega-nerd.com>, Erik de Castro Lopo wrote: >> project tends to be a pain unless one of the principal developers is using >> it on a daily basis (as I know you've experienced with libsndfile, Erik). > > Yes, painfully aware of this.

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-04 Thread Erik de Castro Lopo
Ben Allison wrote: > Here's another go at it. I only have VS2008 and VS2010 to test with right > now. VS6.0, VS2003 and VS2005 are untested. Thanks for your work on this Ben. > I would recommend using FLAC__uint32 instead of uint32_t to avoid these > small #if _MSC_VER < things everywhere

[flac-dev] 2GB limit patch

2013-03-04 Thread Martijn van Beurden
Hi all, I was reading the discussion about this 1.3.0pre1 release on HydrogenAudio and someone linked an old thread in which one patched FLAC 1.2.1 to support WAV-files larger then 2GB. It might be worth investigating: http://www.hydrogenaudio.org/forums/?showtopic=84014#entry725304 ___

Re: [flac-dev] flac 1.3.0pre1 prelease

2013-03-04 Thread Martijn van Beurden
On 03-03-13 00:22, Erik de Castro Lopo wrote: > I have personally tested this code on: > > x86-linux > x86_64-linux > powerpc-linux Have you tried static building too? I just tried a bunch of switches for ../configure and both "--enable-static" as well as "--disable-shared --enabl

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-04 Thread Richard Ash
On Tue, 5 Mar 2013 07:21:49 +1100 Erik de Castro Lopo wrote: > Ben Allison wrote: > > > Here's another go at it. I only have VS2008 and VS2010 to test > > with right now. VS6.0, VS2003 and VS2005 are untested. > > Thanks for your work on this Ben. Thanks also from the Audacity developers - th

Re: [flac-dev] 2GB limit patch

2013-03-04 Thread Erik de Castro Lopo
Martijn van Beurden wrote: > I was reading the discussion about this 1.3.0pre1 release on > HydrogenAudio Link please? > and someone linked an old thread in which one patched FLAC > 1.2.1 to support WAV-files larger then 2GB. It might be worth investigating: > > http://www.hydrogenaudio.org/f

Re: [flac-dev] 2GB limit patch

2013-03-04 Thread Martijn van Beurden
On 04-03-13 23:19, Erik de Castro Lopo wrote: > Link please? http://www.hydrogenaudio.org/forums/index.php?showtopic=99757 > Err, thats a link to a post talking about flac's WAV reader being limited > to 4Gig files. Problem is, *all* WAV files greater than 4Gig are mal-formed. > Due to limitation

Re: [flac-dev] flac 1.3.0pre1 prelease

2013-03-04 Thread Erik de Castro Lopo
Martijn van Beurden wrote: > > 'chown', declared with attribute warn_unused_result [-Wunused-result] > > metadata_iterators.c:3299:2: warning: ignoring return value of > > 'chown', declared with attribute warn_unused_result [-Wunused-result] > > In file included from /usr/include/stdio.h:934:0,

Re: [flac-dev] 2GB limit patch

2013-03-04 Thread Timothy B. Terriberry
Erik de Castro Lopo wrote: > Err, thats a link to a post talking about flac's WAV reader being limited > to 4Gig files. Problem is, *all* WAV files greater than 4Gig are mal-formed. > Due to limitations in the way WAV files are specified, no valid WAV file > can ever be over 4Gig. And most don't w

Re: [flac-dev] flac 1.3.0pre1 prelease

2013-03-04 Thread Martijn van Beurden
On 04-03-13 23:36, Erik de Castro Lopo wrote: > However, you should be getting them regardless of whether you are > compiling static or shared. Yes, I get those for shared as well, but the error that follows it (error: inlining failed in call to always_inline 'fread' etc.) is only when compili

Re: [flac-dev] 2GB limit patch

2013-03-04 Thread Cristian Adam
On 3/4/2013 11:26 PM, Martijn van Beurden wrote: > On 04-03-13 23:19, Erik de Castro Lopo wrote: >> Link please? > http://www.hydrogenaudio.org/forums/index.php?showtopic=99757 > >> Err, thats a link to a post talking about flac's WAV reader being limited >> to 4Gig files. Problem is, *all* WAV fil

Re: [flac-dev] 2GB limit patch

2013-03-04 Thread nu774
> This is an older issue reported in 2007: > http://lists.xiph.org/pipermail/flac-dev/2007-September/002423.html > > The fix would be to use _ftelli64 instead of ftell with Visual Studio. > http://msdn.microsoft.com/en-us/library/0ys3hc0b%28v=vs.110%29.aspx That's not enough. At least, the followi

Re: [flac-dev] 2GB limit patch

2013-03-04 Thread nu774
(2013/03/05 7:19), Erik de Castro Lopo wrote: > Err, thats a link to a post talking about flac's WAV reader being limited > to 4Gig files. Problem is, *all* WAV files greater than 4Gig are mal-formed. > Due to limitations in the way WAV files are specified, no valid WAV file > can ever be over 4Gig

Re: [flac-dev] 2GB limit patch

2013-03-04 Thread Cristian Rodríguez
On 03/04/2013 10:57 PM, nu774 wrote: >> This is an older issue reported in 2007: >> http://lists.xiph.org/pipermail/flac-dev/2007-September/002423.html >> >> The fix would be to use _ftelli64 instead of ftell with Visual Studio. >> http://msdn.microsoft.com/en-us/library/0ys3hc0b%28v=vs.110%29.aspx

Re: [flac-dev] flac 1.3.0pre1 prelease

2013-03-04 Thread Cristian Rodríguez
On 03/04/2013 07:36 PM, Erik de Castro Lopo wrote: > Martijn van Beurden wrote: > >>> 'chown', declared with attribute warn_unused_result [-Wunused-result] >>> metadata_iterators.c:3299:2: warning: ignoring return value of >>> 'chown', declared with attribute warn_unused_result [-Wunused-result] >>

Re: [flac-dev] 2GB limit patch

2013-03-04 Thread nu774
(2013/03/05 12:27), Cristian Rodríguez wrote: > Nothing against you code, that's ugly ..but as it is a first step it can > be forgiven :-) > > I will just force flac to be built with 64 bit file offsets and just > reject any caller trying to include/link libflac into a non-lfs program > like > > ht

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-04 Thread Erik de Castro Lopo
Andy Hawkins wrote: > Hi, > > In article <20130304070023.141c9f101622a34c46d68...@mega-nerd.com>, >Erik de Castro Lopo wrote: > >> project tends to be a pain unless one of the principal developers is using > >> it on a daily basis (as I know you've experienced with libsndfile, Erik).

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-04 Thread LRN
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 05.03.2013 10:32, Erik de Castro Lopo wrote: > Andy Hawkins wrote: > >> Hi, >> >> In article >> <20130304070023.141c9f101622a34c46d68...@mega-nerd.com>, Erik de >> Castro Lopo wrote: project tends to be a pain unless one of the principal

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-04 Thread Cristian Rodríguez
On 03/05/2013 03:32 AM, Erik de Castro Lopo wrote: > May look at CMake after this current release. That will make the situation reverse, that is, better for windows, insane for the rest of the world. ___ flac-dev mailing list flac-dev@xiph.org http:/

Re: [flac-dev] 2GB limit patch

2013-03-04 Thread Erik de Castro Lopo
nu774 wrote: > (2013/03/05 7:19), Erik de Castro Lopo wrote: > > Err, thats a link to a post talking about flac's WAV reader being limited > > to 4Gig files. Problem is, *all* WAV files greater than 4Gig are mal-formed. > > Due to limitations in the way WAV files are specified, no valid WAV file >

Re: [flac-dev] 2GB limit patch

2013-03-04 Thread Erik de Castro Lopo
nu774 wrote: > (2013/03/05 12:27), Cristian Rodríguez wrote: > > Nothing against you code, that's ugly ..but as it is a first step it can > > be forgiven :-) > > > > I will just force flac to be built with 64 bit file offsets and just > > reject any caller trying to include/link libflac into a non

Re: [flac-dev] Fwd: flac 1.3.0pre1 prelease

2013-03-04 Thread Erik de Castro Lopo
Cristian Rodríguez wrote: > On 03/05/2013 03:32 AM, Erik de Castro Lopo wrote: > > > May look at CMake after this current release. > > That will make the situation reverse, that is, better for windows, > insane for the rest of the world. *If* I get around to it, it will be in a branch, not in