Re: [flac-dev] [PATCH] for cpu.c

2014-08-08 Thread Erik de Castro Lopo
lvqcl wrote: > This patch moves all > > info->ia32.fxsr = info->ia32.sse = info->ia32.sse2 = info->ia32.sse3 = > info->ia32.ssse3 = info->ia32.sse41 = info->ia32.sse42 = false; > > expressions into a static function disable_sse(FLAC__CPUInfo *info). Applied. Thanks. Erik --

Re: [flac-dev] PATCH for cpu.c

2014-03-27 Thread Erik de Castro Lopo
lvqcl wrote: > Explanation of changes in this patch: Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists

Re: [flac-dev] PATCH for cpu.c

2014-03-23 Thread Oliver Stöneberg
> Oliver Stöneberg wrote: > > >> Unfortunately it breaks x86_64 build (where FLAC__CPU_X86_64 is defined, > >> and > >> FLAC__CPU_IA32 isn't). Maybe it's simpler to turn them into #defines such > >> as > >> > >> #define FLAC__CPUINFO_IA32_CPUID_CMOV 0x8000U > >> #define FLAC__CPUI

Re: [flac-dev] PATCH for cpu.c

2014-03-23 Thread lvqcl
Oliver Stöneberg wrote: >> Unfortunately it breaks x86_64 build (where FLAC__CPU_X86_64 is defined, and >> FLAC__CPU_IA32 isn't). Maybe it's simpler to turn them into #defines such as >> >> #define FLAC__CPUINFO_IA32_CPUID_CMOV 0x8000U >> #define FLAC__CPUINFO_IA32_CPUID_EXTENDED_AMD

Re: [flac-dev] PATCH for cpu.c

2014-03-23 Thread Oliver Stöneberg
> Oliver Stöneberg wrote: > > > This is simply fixed by putting those unused constants into the > > proper defines. I attached a patch against git 70b078c. > > Unfortunately it breaks x86_64 build (where FLAC__CPU_X86_64 is defined, and > FLAC__CPU_IA32 isn't). Maybe it's simpler to turn them in

Re: [flac-dev] PATCH for cpu.c

2014-03-22 Thread lvqcl
Oliver Stöneberg wrote: > This is simply fixed by putting those unused constants into the > proper defines. I attached a patch against git 70b078c. Unfortunately it breaks x86_64 build (where FLAC__CPU_X86_64 is defined, and FLAC__CPU_IA32 isn't). Maybe it's simpler to turn them into #defines suc

Re: [flac-dev] PATCH for cpu.c

2013-08-21 Thread Erik de Castro Lopo
Timothy B. Terriberry wrote: > Erik de Castro Lopo wrote: > > Its crufty old code. I should be removed. It makes no sense to keep > > supporting 20 year old compilers (MSVC6 was was released in 1989 and > > MSVC7 in 1992 [0]). > > That's not quite accurate. MSC6 was released in 1989. MSVC was rel

Re: [flac-dev] PATCH for cpu.c

2013-08-21 Thread Timothy B. Terriberry
Timothy B. Terriberry wrote: > That's not quite accurate. MSC6 was released in 1989. MSVC was released > in 1998. So only 15 years old :). *MSVC6, I meant. ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] PATCH for cpu.c

2013-08-21 Thread Timothy B. Terriberry
Erik de Castro Lopo wrote: > Its crufty old code. I should be removed. It makes no sense to keep > supporting 20 year old compilers (MSVC6 was was released in 1989 and > MSVC7 in 1992 [0]). That's not quite accurate. MSC6 was released in 1989. MSVC was released in 1998. So only 15 years old :).

Re: [flac-dev] PATCH for cpu.c

2013-08-21 Thread Erik de Castro Lopo
Ozkan Sezer wrote: > On 8/21/13, lvqcl wrote: > > 1) Some time ago all project files for MSVC 6 were removed; it makes sense > > to remove the code that is necessary only for MSVC 6 and older compilers. > > > > One may still compile using command line instead of a project file. Does > it really

Re: [flac-dev] PATCH for cpu.c

2013-08-21 Thread Ozkan Sezer
On 8/21/13, lvqcl wrote: > 1) Some time ago all project files for MSVC 6 were removed; it makes sense > to remove the code that is necessary only for MSVC 6 and older compilers. > One may still compile using command line instead of a project file. Does it really hurt keeping such code? -- O.S. _