Re: [flac-dev] PATCH: OS SSE support detection, version 2

2014-03-15 Thread Martijn van Beurden
op 15-03-14 06:15, lvqcl schreef: > I hope that this code will help to avoid "bug" reports such as > http://sourceforge.net/p/flac/bugs/409/ It's even mentioned in the FAQ, so it's really nog a bug, not even a "bug" :) http://xiph.org/flac/faq.html#tools__different_sizes ___

Re: [flac-dev] PATCH: OS SSE support detection, version 2

2014-03-15 Thread lvqcl
Erik de Castro Lopo wrote: > It looks like I applied the the part1 patch and didn't apply the > part2 patch. > > Please check commit 99d5154f436b389758d6a9020e448b8dbedb14bc. > Well, it's part2 as far as i can see... My message contained 2 attached files: 1) cpu_part1.patch that begins with di

Re: [flac-dev] PATCH: OS SSE support detection, version 2

2014-03-15 Thread Erik de Castro Lopo
lvqcl wrote: > So, about the patches from > http://lists.xiph.org/pipermail/flac-dev/2014-March/004577.html > >* The patch cpu_part1.patch should be applied; > >* The patch cpu_part2.patch (already applied) is almost useless now, so > why keep it? > It can be useful only for those

Re: [flac-dev] PATCH: OS SSE support detection, version 2

2014-03-14 Thread lvqcl
Erik de Castro Lopo wrote: >> About part 1:does it have any problems? I can split it into several patches >> (1 fix = 1 patch) or explain the changes in it in detail. > > I didn't apply patch1 because I mis-read your comment here: > > http://lists.xiph.org/pipermail/flac-dev/2014-March/004582.

Re: [flac-dev] PATCH: OS SSE support detection, version 2

2014-03-14 Thread Erik de Castro Lopo
Dave Yeo wrote: > On 03/14/14 10:15 PM, lvqcl wrote: > > Maybe it's better and simpler to change configure.ac so that --enable-sse > > is on by default if the target OS is Windows? > > Why not just reverse the --enable-sse so it is the default and if anyone > really needs to support something wi

Re: [flac-dev] PATCH: OS SSE support detection, version 2

2014-03-14 Thread Dave Yeo
On 03/14/14 10:15 PM, lvqcl wrote: > Maybe it's better and simpler to change configure.ac so that --enable-sse > is on by default if the target OS is Windows? Why not just reverse the --enable-sse so it is the default and if anyone really needs to support something without kernel support for sse

Re: [flac-dev] PATCH: OS SSE support detection, version 2

2014-03-14 Thread Erik de Castro Lopo
lvqcl wrote: > Thanks. I hope that this code will help to avoid "bug" reports > such as http://sourceforge.net/p/flac/bugs/409/ (it seems that > the author of this report compiled FLAC without --enable-sse option). Oh, wow, I didn't even realise that the sourceforge bug tracker was still being us

Re: [flac-dev] PATCH: OS SSE support detection, version 2

2014-03-14 Thread lvqcl
Erik de Castro Lopo wrote: >> part 1: fixes >> >> part 2: new code >> >> Any comments? > > Applied cpu_part2.patch. Thanks! Thanks. I hope that this code will help to avoid "bug" reports such as http://sourceforge.net/p/flac/bugs/409/ (it seems that the author of this report compiled FLAC without

Re: [flac-dev] PATCH: OS SSE support detection, version 2

2014-03-13 Thread Erik de Castro Lopo
lvqcl wrote: > The second version of the patch for OS SSE support detection > > part 1: fixes > > part 2: new code > > Any comments? Applied cpu_part2.patch. Thanks! Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ _