Wow, bad last sentence there. I meant to say that I'm actively following
HEAD, so go ahead and make any changes and I'll merge them into my local
repository. No need to worry about clashing.
Thanks!
On Sat, Mar 23, 2013 at 9:14 AM, Jaren Stangret wrote:
> Erik,
>
> There are changes coming,
Erik,
There are changes coming, but I can't give an ETA. I finally have a
uniform "feel" to the changes I want to incorporate. The biggest hurdle
right now is 'test_flac.sh'. It is a BIG script with a lot of hard to read
expressions. Most of my time is spent trying to break it up and make it
m
Jaren Stangret wrote:
> Attached is a patch for 'test_grabbag.sh'. Continuing in the same vein as
> the other patches, this patch consists of minor reworks of
> functions/commands as well as heavily commenting what's going on.
>
> More than halfway there!
Jaren,
Any sign of the patches for the
>> Jaren Stangret wrote:
>>
>>> Testing the metadata-handling properties of flac-to-flac encoding...
>>> case00a... Files case00a-expect.meta and out.meta differ
>>> ERROR: metadata does not match expected case00a-expect.meta
>>> make: *** [fullcheck] Error 1
>>
>> Last night I did a git bisect on
> Jaren Stangret wrote:
>
>> Testing the metadata-handling properties of flac-to-flac encoding...
>> case00a... Files case00a-expect.meta and out.meta differ
>> ERROR: metadata does not match expected case00a-expect.meta
>> make: *** [fullcheck] Error 1
>
> Last night I did a git bisect on this iss
Jaren Stangret wrote:
> Testing the metadata-handling properties of flac-to-flac encoding...
> case00a... Files case00a-expect.meta and out.meta differ
> ERROR: metadata does not match expected case00a-expect.meta
> make: *** [fullcheck] Error 1
Last night I did a git bisect on this issue and thi
Jaren Stangret wrote:
> Testing the metadata-handling properties of flac-to-flac encoding...
> case00a... Files case00a-expect.meta and out.meta differ
> ERROR: metadata does not match expected case00a-expect.meta
> make: *** [fullcheck] Error 1
>
> Anyone else hitting this or is just my system?
I'd also like to note that this is happening for me with current HEAD
(619b43df36b725e11e12db768d558b1930a583b6).
On Mon, Mar 18, 2013 at 11:25 PM, Jaren Stangret wrote:
> I've been trying to get the test suite cleaned up and even with the
> original "untouched" test suite via flac 1.3.0pre2, I
I've been trying to get the test suite cleaned up and even with the
original "untouched" test suite via flac 1.3.0pre2, I'm getting a test
suite failure.
*flac 1.3.0pre2*
*
*
*configure options:*
./configure --prefix=/usr --build=i686-pc-linux-gnu
--host=i686-pc-linux-gnu --mandir=/usr/share/man -
Janne Hyvärinen wrote:
>
> On 14.3.2013 9:37, Erik de Castro Lopo wrote:
> > Janne Hyvärinen wrote:
> >
> >> The patch was made from the published pre2 version. It missed the MinGW
> >> changes that were applied to git version.
> > Patch applied. Thanks.
> >
> > Erik
>
> Unfortunately with this
On 14.3.2013 9:37, Erik de Castro Lopo wrote:
Janne Hyvärinen wrote:
The patch was made from the published pre2 version. It missed the MinGW
changes that were applied to git version.
Patch applied. Thanks.
Erik
Unfortunately with this commit the LRN's patch from commit
b85cc57d73a286a07e5
Janne Hyvärinen wrote:
> The patch was made from the published pre2 version. It missed the MinGW
> changes that were applied to git version.
Patch applied. Thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
_
Janne Hyvärinen wrote:
> The patch was made from the published pre2 version. It missed the MinGW
> changes that were applied to git version.
And a couple of others. Usually better to go from the code that's actually
in git.
Anyway I have the code that you intended to sumbit. I will do a thoroug
Janne Hyvärinen wrote:
> I re-did the patch with these limitations. I also noticed I had left
> stat() and fstat() functions unfixed previously. And encoder was limited
> to 4G in many places when printing status info.
Unfortunately, this patch did not apply cleanly.
There were two problems; o
Attached is a patch for 'test_grabbag.sh'. Continuing in the same vein as
the other patches, this patch consists of minor reworks of
functions/commands as well as heavily commenting what's going on.
More than halfway there!
Thanks,
Jaren
On Tue, Mar 12, 2013 at 9:40 PM, Erik de Castro Lopo
wro
Jaren Stangret wrote:
> Interestingly, I noticed compression level '0' is omitted, so I've added it
> in.
Thanks.
> Also, I tested this on a 24bit/96kHz FLAC file and the test failed between
> compression level 0 and compression level 1 -- the file size was greater
> with a compression level of
Attached is a patch for 'test_compression.sh'.
Interestingly, I noticed compression level '0' is omitted, so I've added it
in.
Also, I tested this on a 24bit/96kHz FLAC file and the test failed between
compression level 0 and compression level 1 -- the file size was greater
with a compression lev
Janne Hyvärinen wrote:
> I thought Ben Allison would have made a patch. Here's a patch for this.
> I suppose we were all blind at first for the cause.
Applied thanks.
I'd now like to look at the 2/4Gig off_t issue in your original
support_2gb_output patch. Unlike your original patch, you will
h
On 11.3.2013 21:21, Erik de Castro Lopo wrote:
Error9error LNK2001: unresolved external symbol
_safe_malloc_mul_2op_
G:\Programming\flac-1.3.0pre2\src\flac\utf8_static.lib(utf8.obj) flac
Error10error LNK1120: 9 unresolved externals
G:\Programming\flac-1.3.0pre2\objs\release\bin\f
Seems time is going to be a constraint for me in the coming week, but I'll
try and get more of these out to you as fast as I can get them written and
tested. Keeping the patches in a separate branch for now seems like a good
idea to me.
Attached is a patch for 'test_streams.sh'
On Tue, Mar 12,
Jaren Stangret wrote:
> Attached are only three patches (each patch is for a different test
> script). If everyone is happy with these three patches, I'll continue and
> rework the rest of the scripts.
These look good so far. I've commited them to a branch. When I
get the rest I'll test them th
Brian Willoughby wrote:
> Hmm, if this huge patch breaks the tests, how do we know whether
> 1.3.0 is performing identically to 1.2.1?
The only way I can conceive of this "breaking the tests" is by
making the test fail in a very obvious manner.
> I'm thinking that there is a possibility that
Dave Yeo wrote:
> OS/2 now needs this patch.
> --- configure.ac.orig 2013-03-11 21:52:54.0 -0700
> +++ configure.ac2013-03-11 21:53:30.0 -0700
> @@ -378,7 +378,7 @@
> XIPH_ADD_CFLAGS([-D_FORTIFY_SOURCE=2])
>
> case "$host_os" in
> - mingw32msvc | mingw32 | freebs
Ben Allison wrote:
> >> On Mon, Mar 11, 2013 at 08:30:18AM -0400, Ben Allison wrote:
> > I will redo the patch with these 'extern' function definitions defined
> > inside the corresponding .c files.
>
> As promised, here is the patch to declare the inline functions as external
> definitions.
Tha
Hi,
On 03/09/13 03:37 am, Erik de Castro Lopo wrote:
> Hi all,
>
> Second and hopefully final pre-release is here:
>
> http://downloads.xiph.org/releases/flac/beta/
OS/2 now needs this patch.
--- configure.ac.orig 2013-03-11 21:52:54.0 -0700
+++ configure.ac2013-03-11 21:
On Mar 11, 2013, at 21:37, Erik de Castro Lopo wrote:
> Jaren Stangret wrote:
>
>> Hi all,
>>
>> I'm currently going through the massive test suite, updating all the
>> scripts making sure they conform to the POSIX standard.
>>
>> I've added a bunch of comments to them and have slightly changed/
Jaren Stangret wrote:
> Hi all,
>
> I'm currently going through the massive test suite, updating all the
> scripts making sure they conform to the POSIX standard.
>
> I've added a bunch of comments to them and have slightly changed/reworked
> some of the functions to make it easier to read and p
>> On Mon, Mar 11, 2013 at 08:30:18AM -0400, Ben Allison wrote:
> I will redo the patch with these 'extern' function definitions defined
> inside the corresponding .c files.
As promised, here is the patch to declare the inline functions as external
definitions.
-Ben Allison
FLAC-1-3-0-inline-ext
Hi all,
I'm currently going through the massive test suite, updating all the
scripts making sure they conform to the POSIX standard.
I've added a bunch of comments to them and have slightly changed/reworked
some of the functions to make it easier to read and process.
I'm also eliminating the use
Janne Hyvärinen wrote:
> With the sources as they are compiling produces these errors (this on
> MSVC 2012 SP1 Express):
>
> Error1error LNK2001: unresolved external symbol
> _FLAC__bitreader_bits_left_for_byte_alignment
> G:\Programming\flac-1.3.0pre2\src\flac\libFLAC_static.lib(strea
On Mon, Mar 11, 2013 at 08:51:43AM -0400, Ben Allison wrote:
> >> From 6.7.4.6
> >> An inline definition does not provide an external definition for the
> >> function, and does not forbid an external definition in another
> >> translation unit. An inline definition provides an alternative to an
> >
> On Mon, Mar 11, 2013 at 08:30:18AM -0400, Ben Allison wrote:
>> From 6.7.4.6
>> An inline definition does not provide an external definition for the
>> function, and does not forbid an external definition in another
>> translation unit. An inline definition provides an alternative to an
>> extern
On Mon, Mar 11, 2013 at 08:30:18AM -0400, Ben Allison wrote:
> Take, for example, the function FLAC__bitreader_is_consumed_byte_aligned.
> It is prototyped in bitreader.h It is used in stream_decoder.c, so it
> must be defined and made available to the linker ("external definition").
> However, t
> Ben Allison wrote:
>
>> As mentioned before, this removes some of the 'inline' from the
>> bitreader
>> and bitwriter functions that were used in another translation unit.
>> I'm
>> surprised that this code works on other platform. It must be a bug in
>> GCC, or maybe deliberately non-standard b
On 11.3.2013 13:05, Erik de Castro Lopo wrote:
>> It includes Ben Allison's MSVC changes and JonY's MinGW changes with
>> some tweaks to make both environments happy.
> Please don't do that. Adding bits of other patches makes it more
> difficult to evaluate and review this patch which is already d
Ben Allison wrote:
> As mentioned before, this removes some of the 'inline' from the bitreader
> and bitwriter functions that were used in another translation unit. I'm
> surprised that this code works on other platform. It must be a bug in
> GCC, or maybe deliberately non-standard behavior.
Janne Hyvärinen wrote:
> Here's a patch that fixes the creation of larger than 2 GB FLAC files.
> Without this patch both GCC and MSVC compiles of FLAC will fail on
> Windows when they have written 2 GB file while encoding from stdin. And
> after 4GB when encoding from WAV file.
Ok.
> It incl
On Sat, Mar 09, 2013 at 12:28:28PM -0500, Ben Allison wrote:
> Erik,
>
> Sorry for the confusion. There is one more patch. I had it in the first
> attempt I made but somehow these changes weren't in the redone patch.
>
> As mentioned before, this removes some of the 'inline' from the bitreader
LRN wrote:
> -BEGIN PGP SIGNED MESSAGE-
> Hash: SHA1
>
> On 09.03.2013 15:37, Erik de Castro Lopo wrote:
> > Hi all,
> >
> > Second and hopefully final pre-release is here:
> >
> > http://downloads.xiph.org/releases/flac/beta/
> >
> src/libFLAC/metadata_iterators.c:442:4: warning: impl
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
On 09.03.2013 15:37, Erik de Castro Lopo wrote:
> Hi all,
>
> Second and hopefully final pre-release is here:
>
> http://downloads.xiph.org/releases/flac/beta/
>
src/libFLAC/metadata_iterators.c:442:4: warning: implicit declaration
of function 'ftel
Erik,
Sorry for the confusion. There is one more patch. I had it in the first
attempt I made but somehow these changes weren't in the redone patch.
As mentioned before, this removes some of the 'inline' from the bitreader
and bitwriter functions that were used in another translation unit. I'm
Hi all,
Second and hopefully final pre-release is here:
http://downloads.xiph.org/releases/flac/beta/
I have personally tested this code on:
x86-linux
x86_64-linux
powerpc-linux
armhf-linux
i386-freebsd9.1
i386-openbsd5.2
I also cross-compiled from Linux to 32 bit W
42 matches
Mail list logo
