Re: [flac-dev] Windows file buffering

2015-12-11 Thread Erik de Castro Lopo
lvqcl wrote: > The attached patch *should* resolve the issue. libFLAC will call > setvbuf(file, ...) > only if GetFileType(...file...) == FILE_TYPE_DISK. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com

Re: [flac-dev] Windows file buffering

2015-12-10 Thread lvqcl
LRN wrote: >> Maybe you mean some other commit? For example, >> >> ? > Yes, that is exactly what i meant. > >> >> The attached patch *should* resolve the issue. libFLAC will call >> setvbuf(file, ...) >> on

Re: [flac-dev] Windows file buffering

2015-12-10 Thread LRN
On 10.12.2015 19:58, lvqcl wrote: > LRN wrote: > >> The commit mentioned in the feature request should not cause such >> behaviour, as it only does short-lived operations (opens a file, does >> stuff, closes the file immediately after) and is clearly distinguishing >> between disk files and pipes

Re: [flac-dev] Windows file buffering

2015-12-10 Thread lvqcl
Christoph Terasa wrote: >> The attached patch *should* resolve the issue. libFLAC will call >> setvbuf(file, ...) >> only if GetFileType(...file...) == FILE_TYPE_DISK. > I probably don't know enough about the intricates of Win32, but why not > prefer this for clarity: > - setvbuf(file, NULL

Re: [flac-dev] Windows file buffering

2015-12-10 Thread Christoph Terasa
On 12/10/2015 5:58 PM, lvqcl wrote: Erik de Castro Lopo wrote: lvqcl, Would you be able to have alook at this one? I think its Windows related: https://sourceforge.net/p/flac/feature-requests/114/ The relevant changes are

Re: [flac-dev] Windows file buffering

2015-12-10 Thread lvqcl
Erik de Castro Lopo wrote: lvqcl, Would you be able to have alook at this one? I think its Windows related: https://sourceforge.net/p/flac/feature-requests/114/ The relevant changes are and

Re: [flac-dev] Windows file buffering

2015-12-10 Thread LRN
On 10.12.2015 10:39, Erik de Castro Lopo wrote: > lvqcl, > > Would you be able to have alook at this one? I think its > Windows related: > > https://sourceforge.net/p/flac/feature-requests/114/ > The commit mentioned in the feature request should not cause such behaviour, as it only does sh

[flac-dev] Windows file buffering

2015-12-09 Thread Erik de Castro Lopo
lvqcl, Would you be able to have alook at this one? I think its Windows related: https://sourceforge.net/p/flac/feature-requests/114/ Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/