Ben Allison wrote:
> Yes. And we could add VS2010 and VS2012 project files at the same time.
Maybe not at the same time since the MSVS 6 files are now history :-).
> The project files could also stand a bit of an overhaul. It would be good
> to use project references rather than hardcoding .li
Martijn van Beurden wrote:
> On 09-03-13 01:01, Erik de Castro Lopo wrote:
> > I would like to know how many years I have to wait before we can ditch
> > this stuff. I intend to do some testing on platforms I have available
> > today and roll a second pre-release after my testing.
>
> Talking a
> Talking about ditching, there are still .dsp files in the repository,
> these are MSVC 6 files. I haven't seen anyone on the list testing the
> source with that version (MSVC 2005 was the first version to have a free
> express version so this one hasn't) so these are probably broken as well.
>
>
On 09-03-13 01:01, Erik de Castro Lopo wrote:
> I would like to know how many years I have to wait before we can ditch
> this stuff. I intend to do some testing on platforms I have available
> today and roll a second pre-release after my testing.
Talking about ditching, there are still .dsp file
Ben Allison wrote:
> Yes, they are necessary. Here is the rationale
>
> 1) FLAC/ordinals.h is a public header file, so replacing this file with an
> MSVC-compatible version is not only the responsibility of a developer
> building libFLAC, but also a developer using libFLAC.
I was aware of that.
> Are the changes for FLAC/ordinals.h really necessary? Yhe FLAC/*.h
> header files specify libFLAC's public API. In a previous thread on
> this mailing list back in February we decided that for compilers
> that didn't supply the developer should supply something
> suitable. Here's the commit:
Ye
Ben Allison wrote:
> This is the delta that should fix everything up.
> I hope that #include "share/compat.h" is acceptable from the test_streams
> binary.
Yes, the share/* header files are shared between the library internals,
the test suite programs and flac and metaflac binary executables.
>
Ben Allison wrote:
> This should be enough to fix it
Applied, thanks.
Erik
--
--
Erik de Castro Lopo
http://www.mega-nerd.com/
___
flac-dev mailing list
flac-dev@xiph.org
http://lists
This should be enough to fix it
> Great.
>
> I need to correct my statement, the check for _MSC_VER <= 1600
> was the culprit, like this case:
>
> #if defined _MSC_VER || defined __BORLANDC__ || defined __MINGW32__
> #include /* for off_t */
> #if _MSC_VER <= 1600 || defined __BORLANDC__ /* @@@ [
Great.
I need to correct my statement, the check for _MSC_VER <= 1600
was the culprit, like this case:
#if defined _MSC_VER || defined __BORLANDC__ || defined __MINGW32__
#include /* for off_t */
#if _MSC_VER <= 1600 || defined __BORLANDC__ /* @@@ [2G limit] */
#ifndef fseeko
#define fseeko fsee
Those checks account for compiler changes/improvements introduced in
Visual Studio 2010 that are not present in Visual Studio 2008.
I will grab Visual Studio 2012 off of MSDN and make sure everything is OK
there.
-Ben
> Hi Ben,
>
> Can you please remove the _MSC_VER >= 1600 check?
>
> _MSC_VER 1
Hi Ben,
Can you please remove the _MSC_VER >= 1600 check?
_MSC_VER 1600 is set for Visual Studio 2010, which means
that Visual Studio 2012 will get a lot of errors because _MSC_VER
is defined as 1700.
Cheers,
Cristian.
On Wed, Mar 6, 2013 at 5:53 PM, Ben Allison wrote:
> Thanks, Erik.
>
> Thi
Thanks, Erik.
This is the delta that should fix everything up.
I hope that #include "share/compat.h" is acceptable from the test_streams
binary. If not, you can probably change it to FLAC/ordinals.h instead
Also don't forget to commit my earlier VERSION="1.3.0" patch. You can add
the "pre1" in
Ben Allison wrote:
> Erik, et al.
>
> This fixes the entire library and does it more cleanly. It puts most of
> the guts into share/compat.h
Thanks Ben.
I applied a slightly tweaked version of the patch. The patch had to be
tweaked because it broke the Linux build :-). Specifically, the file
i
Erik, et al.
This fixes the entire library and does it more cleanly. It puts most of
the guts into share/compat.h
-Ben Allison
flac-1-3-0-MSVC.patch
Description: Binary data
___
flac-dev mailing list
flac-dev@xiph.org
http://lists.xiph.org/mailman/lis
15 matches
Mail list logo
