[flac-dev] Patch for website, updates docs

Hi all, Attached is a patch for the flac-website git. This patch copies some corrections from the source code documentation to the website, updates copyright dates, fixes a charset issue on changelog.html and updates git links. Kind regards, Martijn van Beurden From c99423ddbdb6d686df5fbb079a5dcd

[flac-dev] Patch for website, updates docs

Hi all, Attached is a patch for the flac-website git. This patch copies some corrections from the source code documentation to the website, updates copyright dates, fixes a charset issue on changelog.html and updates git links. Kind regards, Martijn van Beurden P.S. I've sent this e-mail two tim

[flac-dev] Patch of documentation, analyse function and compression ratio display

Hi all, Attached are three patches. The first patch changes links to git.xiph.org to gitlab.xiph.org. The second patch enables the flac analyse function to be able to handle frames which are over 4Gbit in size. The third one fixes the compression ratio display of very small files. Kind regards,

[flac-dev] [PATCH] Switch to utimensat for newer POSIX versions

Some libcs like uClibc-ng can optionally disable deprecated functions. utime is one of them. When done so, both the header and the function go missing. This fixes flac_utime to work in such a situation. --- include/share/compat.h | 10 +- src/libFLAC/metadata_iterators.c | 9 ++

Re: [flac-dev] [PATCH 4/5] SIMD: accelerate decoding of 16-bit FLAC

I do see some improvements in x64 build using SSE4.1. (VS2017) You didn't see any improvements on your end ? Le 18/02/2017 à 17:47, lvqcl a écrit : This patch adds 2 new functions, FLAC__lpc_restore_signal_intrin_sse41() and FLAC__lpc_restore_signal_16_intrin_sse41(). The decoding speed of Sub

Re: [flac-dev] [PATCH] move CreateFile() function from libFLAC

lvqcl wrote: > This patch renames flac_internal_CreateFile_utf8() function to > grabbag__CreateFile_utf8() and > moves it from /src/libFLAC/windows_unicode_filenames.c into > src/share/grabbag/file.c > This function is not used by libFLAC anyway. > > After this, it should be possible to compile l

[flac-dev] [PATCH] move CreateFile() function from libFLAC

This patch renames flac_internal_CreateFile_utf8() function to grabbag__CreateFile_utf8() and moves it from /src/libFLAC/windows_unicode_filenames.c into src/share/grabbag/file.c This function is not used by libFLAC anyway. After this, it should be possible to compile libFLAC as UWP. In the old c

[flac-dev] [PATCH 3/2] Free memory on errors in all safe_realloc_*() functions

--- include/share/alloc.h | 36 +--- 1 file changed, 25 insertions(+), 11 deletions(-) diff --git a/include/share/alloc.h b/include/share/alloc.h index 63878db0..97752f0c 100644 --- a/include/share/alloc.h +++ b/include/share/alloc.h @@ -174,34 +174,46 @@ static in

[flac-dev] [PATCH 2/2] Fix safe_realloc_add_2op_() to free memory when reallocation fails

--- include/share/alloc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/share/alloc.h b/include/share/alloc.h index 914de9ba..63878db0 100644 --- a/include/share/alloc.h +++ b/include/share/alloc.h @@ -168,7 +168,7 @@ static inline void *safe_realloc_add_2op_(void *pt

[flac-dev] [PATCH 1/2] Avoid double free in iconvert()

When safe_realloc_add_2op_(utfbuf, ...) is called with an invalid size and returns 0, set utfbuf to 0 to avoid second deallocation later in the function. --- src/share/utf8/iconvert.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/share/utf8/iconvert.c b/src/share/utf8/

Re: [flac-dev] [PATCH 0/7] PowerPC64 performance improvements

Hi, > Are those all Virtual Machines? If so, how do you really know that > the performance is 3.3x? I have access to a number of different POWER9 systems, all native. Thanks, Anton ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailm

Re: [flac-dev] [PATCH 0/7] PowerPC64 performance improvements

On Jul 11, 2018, at 5:59 PM, Anton Blanchard wrote: > Hi Brian, > >> Thank you for this collection of patches. >> >> How can I test them? What platforms (computers) have the ppc64 or >> POWER9 processor? > > The IBM Bounty Source page has a list of resources: > > https://www.bountysource.com/

Re: [flac-dev] [PATCH 0/7] PowerPC64 performance improvements

> > How can I test them? What platforms (computers) have the ppc64 or > > POWER9 processor? > > The IBM Bounty Source page has a list of resources: > > https://www.bountysource.com/teams/ibm/bounties > > Travis also has ppc64le support, so if you add the linux-ppc64le > target then FLAC will

Re: [flac-dev] [PATCH 0/7] PowerPC64 performance improvements

Hi Brian, > Thank you for this collection of patches. > > How can I test them? What platforms (computers) have the ppc64 or > POWER9 processor? The IBM Bounty Source page has a list of resources: https://www.bountysource.com/teams/ibm/bounties Travis also has ppc64le support, so if you add the

Re: [flac-dev] [PATCH 0/7] PowerPC64 performance improvements

Thank you for this collection of patches. How can I test them? What platforms (computers) have the ppc64 or POWER9 processor? Brian On Jul 10, 2018, at 2:31 PM, Anton Blanchard wrote: > > The following series adds initial vector support for PowerPC64. > On POWER9, flac --best is about 3.3x f

[flac-dev] [PATCH 7/7] Add VSX optimised versions of autocorrelation loops

Add a POWER8 and POWER9 version of the autocorrelation functions. flac --best is about 3.3x faster on POWER9 with this patch. Signed-off-by: Anton Blanchard --- src/libFLAC/Makefile.am | 1 + src/libFLAC/include/private/lpc.h | 14 + src/libFLAC/lpc_intrin_vsx.c | 942

[flac-dev] [PATCH 6/7] Add runtime detection of POWER8 and POWER9

Use getauxval() to determine if we are on POWER8 or POWER9 or newer. POWER8 is represented by version 2.07 and POWER9 by version 3.00. Signed-off-by: Anton Blanchard --- src/libFLAC/cpu.c | 31 +++ src/libFLAC/include/private/cpu.h | 6 ++ 2 files

[flac-dev] [PATCH 4/7] Add m4 macro to check for C __attribute__ features

From: Amitay Isaacs Signed-off-by: Amitay Isaacs --- m4/c_attribute.m4 | 18 ++ 1 file changed, 18 insertions(+) create mode 100644 m4/c_attribute.m4 diff --git a/m4/c_attribute.m4 b/m4/c_attribute.m4 new file mode 100644 index ..48aa6223 --- /dev/null +++ b/m4/c_attri

[flac-dev] [PATCH 5/7] Check if compiler supports target attribute on ppc64

From: Amitay Isaacs Check if the compiler supports __attribute__((target("cpu=power8"))) and __attribute__((target("cpu=power9"))) Signed-off-by: Amitay Isaacs --- configure.ac | 20 1 file changed, 20 insertions(+) diff --git a/configure.ac b/configure.ac index 55078293.

[flac-dev] [PATCH 3/7] configure.ac: Fix FLAC__CPU_PPC on little endian, and add FLAC__CPU_PPC64

FLAC__CPU_PPC wasn't catching powerpcle or powerpc64le. Fix that and add a new define for FLAC__CPU_PPC64. Signed-off-by: Anton Blanchard --- configure.ac | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/configure.ac b/configure.ac index 592e7750..55078293 100644

[flac-dev] [PATCH 1/7] configure.ac: Remove SPE detection code

We don't have any SPE code, so there's no need to detect it at configure time. Signed-off-by: Anton Blanchard --- configure.ac | 8 1 file changed, 8 deletions(-) diff --git a/configure.ac b/configure.ac index ffde189a..77e3628e 100644 --- a/configure.ac +++ b/configure.ac @@ -174,14 +

[flac-dev] [PATCH 2/7] configure.ac: Add VSX enable/disable

We want to create functions with PowerPC VSX instructions, so add a configure check. Signed-off-by: Anton Blanchard --- configure.ac | 13 + 1 file changed, 13 insertions(+) diff --git a/configure.ac b/configure.ac index 77e3628e..592e7750 100644 --- a/configure.ac +++ b/configure.a

[flac-dev] [PATCH 0/7] PowerPC64 performance improvements

The following series adds initial vector support for PowerPC64. On POWER9, flac --best is about 3.3x faster. Amitay Isaacs (2): Add m4 macro to check for C __attribute__ features Check if compiler supports target attribute on ppc64 Anton Blanchard (5): configure.ac: Remove SPE detection cod

Re: [flac-dev] [PATCH] Fix more GCC warnings about case fall-through

lvqcl wrote: > THere was a patch that silences GCC -Wimplicit-fallthrough warnings, see > https://git.xiph.org/?p=flac.git;a=commit;h=1b5c09e4c692e243239945be3cba3ec72ea1699f > > There are a few more places that need this treatment. The patch is attached. Applied. Thanks! Erik --

Re: [flac-dev] [PATCH] More generic version of MSVC bug workaround

lvqcl wrote: > There was a fix for a bug in MSVC 2015 update2: > https://github.com/xiph/flac/commit/94a61241b02064c7d9fe508f72a742f2a90b8492 Applied, thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___

[flac-dev] [PATCH] Fix more GCC warnings about case fall-through

THere was a patch that silences GCC -Wimplicit-fallthrough warnings, see https://git.xiph.org/?p=flac.git;a=commit;h=1b5c09e4c692e243239945be3cba3ec72ea1699f There are a few more places that need this treatment. The patch is attached. Fix-more-GCC-implicit-fallthrough-warnings.patch Description:

[flac-dev] [PATCH] More generic version of MSVC bug workaround

There was a fix for a bug in MSVC 2015 update2: https://github.com/xiph/flac/commit/94a61241b02064c7d9fe508f72a742f2a90b8492 It seems that it's not the only version affected, see comment from 40th in this commit. Also, JRMC is affected: https://yabb.jriver.com/interact/index.php/topic,115742.0.htm

Re: [flac-dev] [PATCH] doc: Add notes about subframe sample size

Ruud van Asseldonk wrote: > Here you go. Wonderful. Thank you! Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.o

Re: [flac-dev] [PATCH] doc: Add notes about subframe sample size

Ruud van Asseldonk wrote: >I hope this helps future implementers. Thank you very much, Ruud! I posted our advice on GitHub: https://github.com/privatezero/flac_markdown/issues/53 Best regards, Reto ___ flac-dev mailing list flac-dev@xiph.org http:/

Re: [flac-dev] [PATCH] doc: Add notes about subframe sample size

Hi Ruud van Asseldonk, > On Jun 11, 2017, at 7:24 AM, Ruud van Asseldonk wrote: > >>> I'm jumping in on this thread to make a few remarks about the spec. I >>> implemented a FLAC decoder by only looking at the spec, and I have a few >>> notes that would have saved me a lot of time if the spec ha

[flac-dev] [PATCH] doc: Add notes about subframe sample size

>> I'm jumping in on this thread to make a few remarks about the spec. I >> implemented a FLAC decoder by only looking at the spec, and I have a few >> notes that would have saved me a lot of time if the spec had mentioned >> them. They are obvious in hindsight, of course. >> >> * If the channel as

Re: [flac-dev] [PATCH] some typos in header files.

lvqcl wrote: > The attached patch fixes a few typos. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists

[flac-dev] [PATCH] some typos in header files.

The attached patch fixes a few typos. fix_typos.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH] fix LLVM compile

Olivier Tristan wrote: > Please find attached a patch that fixes the OSX build with llvm > only __asm__ is supported but GCC support both so it's not an issue using > this one AFAIK. Applied. Thanks. Erik -- -- Erik de Castro L

Re: [flac-dev] [PATCH] fix LLVM compile

Olivier Tristan wrote: Hi guys, Please find attached a patch that fixes the OSX build with llvm only __asm__ is supported but GCC support both so it's not an issue using this one AFAIK. lvqcl can probably confirm this. I can obly confirm that it works in GCC/MinGW, but that's expected. Al

[flac-dev] [PATCH] fix LLVM compile

Hi guys, Please find attached a patch that fixes the OSX build with llvm only __asm__ is supported but GCC support both so it's not an issue using this one AFAIK. lvqcl can probably confirm this. Thanks ! -- Olivier Tristan Research & Development www.uvi.net diff --git a/src/libFLAC/cpu.c b/

Re: [flac-dev] [PATCH 6/5] comments in stream_decoder.c

lvqcl wrote: > There are 2 comments in stream_decoder.c that mention > FLAC__lpc_restore_signal_asm_ia32_mmx() requirement for > the output array. > The text is updated to include intrinsic functions too. Applied. Thanks. Erik -- -

Re: [flac-dev] [PATCH 5/5] SIMD: remove outdated SSE2 code

lvqcl wrote: > > The patch is attached. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/ma

[flac-dev] [PATCH 6/5] comments in stream_decoder.c

There are 2 comments in stream_decoder.c that mention FLAC__lpc_restore_signal_asm_ia32_mmx() requirement for the output array. The text is updated to include intrinsic functions too. 06_decoder_comment.patch Description: Binary data ___ flac-dev mailin

Re: [flac-dev] [PATCH 5/5] SIMD: remove outdated SSE2 code

Erik de Castro Lopo wrote: lvqcl wrote: Ok, will do it, but currently xiph git still contains old code. Sorry, should be updated now. The patch is attached. 05_v2_remove_old_intrin_func.patch Description: Binary data ___ flac-dev mailing list f

Re: [flac-dev] [PATCH 5/5] SIMD: remove outdated SSE2 code

lvqcl wrote: > > Ok, will do it, but currently xiph git still contains old code. Sorry, should be updated now. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev m

Re: [flac-dev] [PATCH 5/5] SIMD: remove outdated SSE2 code

Erik de Castro Lopo wrote: Sorry, this patch fails to apply on top of the others. Would you be able to rebase against what's currently in the tree? Ok, will do it, but currently xiph git still contains old code. ___ flac-dev mailing list flac-dev@xip

Re: [flac-dev] [PATCH 2/5] SIMD: remove extra space

I agree with Erik regarding this patch. On Feb 19, 2017, at 12:17 PM, Erik de Castro Lopo wrote: > lvqcl wrote: >> Most libFLAC code don't have a space between if and a parenthesis, >> so the patch removes them from lpc_intrin_sseNN.c files. > > I don't really agree with this one. If anything I

Re: [flac-dev] [PATCH 5/5] SIMD: remove outdated SSE2 code

lvqcl wrote: > This patch removes FLAC__lpc_restore_signal_16_intrin_sse2(). > > It's faster than C code, but not faster than MMX-accelerated > ASM functions. It's also slower than the new SSE4.1 functions > that were added by the previous patch. > So this function wasn't very useful before, and

Re: [flac-dev] [PATCH 2/5] SIMD: remove extra space

lvqcl wrote: > Most libFLAC code don't have a space between if and a parenthesis, > so the patch removes them from lpc_intrin_sseNN.c files. I don't really agree with this one. If anything I think we should slowly move to making the code insert a space between the `if` and the open parenthesis be

Re: [flac-dev] [PATCH 4/5] SIMD: accelerate decoding of 16-bit FLAC

lvqcl wrote: > This patch adds 2 new functions, > FLAC__lpc_restore_signal_intrin_sse41() and > FLAC__lpc_restore_signal_16_intrin_sse41(). > > The decoding speed of Subset-compatible 16-bit FLAC files > is slightly increased on SSE4.1-compatible CPUs. Applied. Thanks. Erik -- ---

Re: [flac-dev] [PATCH 3/5] SIMD: accelerate decoding of some 24-bit FLAC

lvqcl wrote: > This patch accelerates decoding of non-Subset 24-bit FLAC files > (where lpc_order > 12). > > (The improved function is FLAC__lpc_restore_signal_wide_intrin_sse41(). > It requires SSE4.1 and it's used only by 32-bit libFLAC) Applied. Thanks. Erik --

Re: [flac-dev] [PATCH 1/5] SIMD: add const qualifier

lvqcl wrote: > This patch adds const to some variables, to make code slightly easier to > read. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-de

Re: [flac-dev] [PATCH 5/5] SIMD: remove outdated SSE2 code

Olivier Tristan wrote: Is the SSE 4.1 support detected at runtime ? i.e you compile with 4.1 support in order to get the intrinsincs by the compiler but the actual code >is only called at runtime when 4.1 is supported by the computer Correct (if the compiler isn't too outdated). ___

Re: [flac-dev] [PATCH 5/5] SIMD: remove outdated SSE2 code

Is the SSE 4.1 support detected at runtime ? i.e you compile with 4.1 support in order to get the intrinsincs by the compiler but the actual code is only called at runtime when 4.1 is supported by the computer Thanks ! 2017-02-18 17:56 GMT+01:00 lvqcl : > This patch removes FLAC__lpc_restore_sig

[flac-dev] [PATCH 5/5] SIMD: remove outdated SSE2 code

This patch removes FLAC__lpc_restore_signal_16_intrin_sse2(). It's faster than C code, but not faster than MMX-accelerated ASM functions. It's also slower than the new SSE4.1 functions that were added by the previous patch. So this function wasn't very useful before, and now it's even less useful

[flac-dev] [PATCH 4/5] SIMD: accelerate decoding of 16-bit FLAC

This patch adds 2 new functions, FLAC__lpc_restore_signal_intrin_sse41() and FLAC__lpc_restore_signal_16_intrin_sse41(). The decoding speed of Subset-compatible 16-bit FLAC files is slightly increased on SSE4.1-compatible CPUs. 04_add_new_intrin_func.patch Description: Binary data __

[flac-dev] [PATCH 3/5] SIMD: accelerate decoding of some 24-bit FLAC

This patch accelerates decoding of non-Subset 24-bit FLAC files (where lpc_order > 12). (The improved function is FLAC__lpc_restore_signal_wide_intrin_sse41(). It requires SSE4.1 and it's used only by 32-bit libFLAC) 03_wide_decode.patch Description: Binary data _

[flac-dev] [PATCH 2/5] SIMD: remove extra space

Most libFLAC code don't have a space between if and a parenthesis, so the patch removes them from lpc_intrin_sseNN.c files. 02_spaces.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-

[flac-dev] [PATCH 1/5] SIMD: add const qualifier

This patch adds const to some variables, to make code slightly easier to read. 01_const.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH] cpu.h: add defines for clang

lvqcl wrote: > I forgot that all avx2 functions are inside "#ifdef FLAC__AVX2_SUPPORTED" > conditional, so they simply don't exist if FLAC__AVX2_SUPPORTED is not set. > > Anyway, stream_encoder_intrin_avx2-after.txt shows that the code > contains AVX2 instructions such as vpabsd/vpaddd/vphaddd, s

Re: [flac-dev] [PATCH] cpu.h: add defines for clang

Erik de Castro Lopo wrote: How reliable a test is that? I do 99.9% of my dev work on a laptop and whenever I need to benchmark something I need to do so on a desketop machine because the laptop doesn't give consistent results. About 1.5 years ago I tested AVX2 speed increase on Haswell (i7-477

Re: [flac-dev] [PATCH] cpu.h: add defines for clang

Erik de Castro Lopo wrote: > What am I looking for? Is posting the before and after versions > sufficient? Disassembly of the object files (before and after) is here: http://mega-nerd.com/tmp/stream_encoder_intrin_avx2-before.txt http://mega-nerd.com/tmp/stream_encoder_intrin_avx2-after.

Re: [flac-dev] [PATCH] cpu.h: add defines for clang

lvqcl wrote: > Currently cpu.h lacks FLAC__SSE_TARGET and FLAC__SSEnn_SUPPORTED > macros for clang. I added them, but I cannot properly test them > as I can't get compiled flac.exe under Windows (don't know > how to setup clang under MSYS2). I can relatively easily install Clang on Linux. > If s

Re: [flac-dev] [PATCH] Fix compile with cygwin

Rosen Penev wrote: > The underscores are wrong. The comment is also correct. > > Also remove the configure.ac option. Otherwise it tries to compile the > windows unicode stuff which POSIX(cygwin) does not understand. Applied. Thanks. Erik --

[flac-dev] [PATCH] Fix compile with cygwin

The underscores are wrong. The comment is also correct. Also remove the configure.ac option. Otherwise it tries to compile the windows unicode stuff which POSIX(cygwin) does not understand. --- configure.ac | 2 +- include/share/compat.h | 2 +- src/libFLAC/stream_decoder.c

Re: [flac-dev] [PATCH] Clean up CFLAGS detecting code and add AX macro for _FORTIFY_SOURCE

David Seifert wrote: > --- Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo

Re: [flac-dev] [PATCH] Clean up CFLAGS detecting code and add AX macro for _FORTIFY_SOURCE

On Sun, 2017-02-05 at 20:47 +1100, Erik de Castro Lopo wrote: > David Seifert wrote: > > > - AC_PROG_SED > > - CFLAGS=$(echo "$CFLAGS" | $SED 's/-O2//') > > - CFLAGS="-O3 -funroll-loops $CFLAGS" > > + CFLAGS="-O3 -funroll-loops" > > Doesn't this mean that `-O2` and `-O3` will end up in CF

Re: [flac-dev] [PATCH] Clean up CFLAGS detecting code and add AX macro for _FORTIFY_SOURCE

David Seifert wrote: > - AC_PROG_SED > - CFLAGS=$(echo "$CFLAGS" | $SED 's/-O2//') > - CFLAGS="-O3 -funroll-loops $CFLAGS" > + CFLAGS="-O3 -funroll-loops" Doesn't this mean that `-O2` and `-O3` will end up in CFLAGS? Erik -- -

[flac-dev] [PATCH] Clean up CFLAGS detecting code and add AX macro for _FORTIFY_SOURCE

--- configure.ac| 23 ++-- m4/ax_add_fortify_source.m4 | 53 + 2 files changed, 55 insertions(+), 21 deletions(-) create mode 100644 m4/ax_add_fortify_source.m4 diff --git a/configure.ac b/configure.ac index 8576cae5..c5

Re: [flac-dev] [PATCH 1/2] for lpc_intrin_sseNN.c

lvqcl wrote: > This patch fixes bracket placement, extra space, etc > in lpc_intrin_sse2.c and lpc_intrin_sse41.c Both patches applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ __

[flac-dev] [PATCH 1/2] for lpc_intrin_sseNN.c

This patch fixes bracket placement, extra space, etc in lpc_intrin_sse2.c and lpc_intrin_sse41.c ident_fix.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

[flac-dev] [PATCH] cpu.h: add defines for clang

Currently cpu.h lacks FLAC__SSE_TARGET and FLAC__SSEnn_SUPPORTED macros for clang. I added them, but I cannot properly test them as I can't get compiled flac.exe under Windows (don't know how to setup clang under MSYS2). If somebody has working clang, please test this patch. Does it affect en/dec

Re: [flac-dev] [PATCH] for compat.h

lvqcl wrote: > Description: redefine inline as __inline only for C, not for C++. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list fl

[flac-dev] [PATCH] for compat.h

Description: redefine inline as __inline only for C, not for C++. compat_inline.patch Description: Binary data ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo/flac-dev

Re: [flac-dev] [PATCH 1/2] Do not override CFLAGS, as CFLAGS is a user flag.

David Seifert wrote: > * Furthermore, use NDEBUG globally to detect the presence > of building with more debug output information. > AX_CHECK_ENABLE_DEBUG is easier to use, and nowadays > Gnome has also switched to it from its own custom solution. Applied. Thanks. Erik --

Re: [flac-dev] [PATCH] Fix cppcheck warnings

Rosen Penev wrote: > src/libFLAC/bitreader.c | 4 ++-- > src/libFLAC/bitwriter.c | 4 ++-- > src/plugin_xmms/plugin.c| 2 +- > src/share/utf8/charset.c| 1 + > src/test_libFLAC++/encoders.cpp | 8 > src/test_libFLAC/decoders.c | 4 ++-- > src/test_libF

Re: [flac-dev] [PATCH] Fix cppcheck warnings

Rosen Penev wrote: > index 432e32d..0c2d1ee 100644 > --- a/src/share/utf8/charset.c > +++ b/src/share/utf8/charset.c > @@ -522,6 +522,7 @@ int charset_convert(const char *fromcode, const char > *tocode, >if (to) { > newbuf = realloc(tobuf, p - tobuf); > *to = newbuf ? newbuf : tobuf

Re: [flac-dev] [PATCH] Fix cppcheck warnings

Rosen Penev wrote: > fedora comes with 1.75 so I used that. I also used some additional > flags: cppcheck --enable=all --inconclusive --std=posix --force Thanks! I had wanted to use verison 1.76.1 from Debian in CI, but never enabled it because it was giving me a false positive even with relative

Re: [flac-dev] [PATCH] Fix cppcheck warnings

fedora comes with 1.75 so I used that. I also used some additional flags: cppcheck --enable=all --inconclusive --std=posix --force On Wed, Jan 18, 2017 at 11:36 PM, Erik de Castro Lopo wrote: > Rosen Penev wrote: > >> src/libFLAC/bitreader.c | 4 ++-- >> src/libFLAC/bitwriter.c |

Re: [flac-dev] [PATCH] Fix cppcheck warnings

Rosen Penev wrote: > src/libFLAC/bitreader.c | 4 ++-- > src/libFLAC/bitwriter.c | 4 ++-- > src/plugin_xmms/plugin.c| 2 +- > src/share/utf8/charset.c| 1 + > src/test_libFLAC++/encoders.cpp | 8 > src/test_libFLAC/decoders.c | 4 ++-- > src/test_libF

Re: [flac-dev] [PATCH] fix MSVC 2005/2008 build

lvqcl wrote: > Thanks. But I can't see new file share/msvc2005_int.h in > the current git snapshot. Yeah, fixed in a later commit. This is why I prefer git patches over plain diffs :). Erik -- -- Erik de Castro Lopo http://www.

[flac-dev] [PATCH] Fix cppcheck warnings

--- src/libFLAC/bitreader.c | 4 ++-- src/libFLAC/bitwriter.c | 4 ++-- src/plugin_xmms/plugin.c| 2 +- src/share/utf8/charset.c| 1 + src/test_libFLAC++/encoders.cpp | 8 src/test_libFLAC/decoders.c | 4 ++-- src/test_libFLAC/encoders.c | 8 ---

Re: [flac-dev] [PATCH] fix MSVC 2005/2008 build

Erik de Castro Lopo wrote: The definitions of these types are inside #if block with _MSC_VER < 1600 condition, so these changes affect only MS Visual Studio compilers with _MSC_VER < 1600 (i.e. MSVS 2005 and 2008). Thats a really great solution to this problem. Applied! Thanks. But I can't s

Re: [flac-dev] [PATCH] fix MSVC 2005/2008 build

On 1/18/17, Erik de Castro Lopo wrote: > lvqcl wrote: > >> > These versions of Visual Studio don't have stdint.h and >> > all [u]intNN_t types. But now these types are everywhere >> > in FLAC codebase. >> >> Here is the patch that fixes the problem: >> it moves definitions of all [u]intNN_t types

Re: [flac-dev] [PATCH] fix MSVC 2005/2008 build

lvqcl wrote: > > These versions of Visual Studio don't have stdint.h and > > all [u]intNN_t types. But now these types are everywhere > > in FLAC codebase. > > Here is the patch that fixes the problem: > it moves definitions of all [u]intNN_t types from share/compat.h > into new file share/msvc20

Re: [flac-dev] [PATCH 0/5] Allow multiple targets to be disabled

On 01/15/2017 03:21 AM, Erik de Castro Lopo wrote: lvqcl wrote: I think that FLAC sources should remain compatible with Visual Studio 2010 (and probably earlier), people still need it. For example: Is it possible to simply exclude win_utf8_io.c from com

Re: [flac-dev] [PATCH 2/2] Only compile and run tests when running 'make check'

David Seifert wrote: > --- Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list flac-dev@xiph.org http://lists.xiph.org/mailman/listinfo

Re: [flac-dev] [PATCH] fix getopt.c

lvqcl wrote: > This patch fixes 2 problems in getopt.c: > > 1) MSVC 2005 (and probably 2008) can't compile it because > it doesn't have stdint.h > > 2) nameend and nextchar are pointers and the difference > between them should be casted to 'size_t' type, not > 'unsigned int' or 'uint32_t'. Appl

[flac-dev] [PATCH] fix getopt.c

This patch fixes 2 problems in getopt.c: 1) MSVC 2005 (and probably 2008) can't compile it because it doesn't have stdint.h 2) nameend and nextchar are pointers and the difference between them should be casted to 'size_t' type, not 'unsigned int' or 'uint32_t'. getopt_fix.patch Description: Bin

[flac-dev] [PATCH 2/2] Only compile and run tests when running 'make check'

--- src/test_grabbag/cuesheet/Makefile.am | 2 +- src/test_grabbag/picture/Makefile.am | 2 +- src/test_libFLAC++/Makefile.am| 2 +- src/test_libFLAC/Makefile.am | 2 +- src/test_seeking/Makefile.am | 2 +- src/test_streams/Makefile.am | 2 +- 6 files changed, 6

[flac-dev] [PATCH 1/2] Do not override CFLAGS, as CFLAGS is a user flag.

* Furthermore, use NDEBUG globally to detect the presence of building with more debug output information. AX_CHECK_ENABLE_DEBUG is easier to use, and nowadays Gnome has also switched to it from its own custom solution. --- configure.ac | 52 -- include/FLAC/

Re: [flac-dev] [PATCH 1/4] Do not override CFLAGS, as CFLAGS is a user flag.

David Seifert wrote: > * Furthermore, use NDEBUG globally to detect the presence > of building with more debug output information. > AX_CHECK_ENABLE_DEBUG is easier to use, and nowadays > Gnome has also switched to it from its own custom solution. This patch removes `-funroll-loops` which f

Re: [flac-dev] [PATCH 0/5] Allow multiple targets to be disabled

lvqcl wrote: > I think that FLAC sources should remain compatible with Visual > Studio 2010 (and probably earlier), people still need it. > For example: > > Is it possible to simply exclude win_utf8_io.c from compiling > if target OS is WinRT/non-desktop?

Re: [flac-dev] [PATCH] add missing string.h include to cpu.c (for memset())

Ozkan Sezer wrote: > On 1/13/17, Ozkan Sezer wrote: > > Attached patch adds missing string.h include to cpu.c (for memset()) > > Simpler patch attached, which just replaces memory.h with string.h > cpu.c was the only source to use memory.h instead of string.h. Applied. Thanks. Erik -- ---

Re: [flac-dev] [PATCH 3/4] Honor user's $(htmldir) and do not override GNU defaults for $(docdir)

David Seifert wrote: > * HTML files should be installed to $(htmldir), and $(docdir) should > not be changed, as this is a user flag in the GNU conventions. Applied, but this one required a few extra tweaks to keep "make distcheck" working. Erik -- ---

Re: [flac-dev] [PATCH 4/4] When using libtool, use LTLIBICONV instead.

David Seifert wrote: > * This is required, as otherwise -Wl,--as-needed could fail. Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list

Re: [flac-dev] [PATCH 2/4] Make building/installing examples optional

David Seifert wrote: > --- > Makefile.am | 6 +- > configure.ac | 5 + > 2 files changed, 10 insertions(+), 1 deletion(-) Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ _

Re: [flac-dev] [PATCH] add missing string.h include to cpu.c (for memset())

On 1/13/17, Ozkan Sezer wrote: > Attached patch adds missing string.h include to cpu.c (for memset()) Simpler patch attached, which just replaces memory.h with string.h cpu.c was the only source to use memory.h instead of string.h. -- O.S. 0001-replace-memory.h-include-with-string.h-in-cpu.c.p

Re: [flac-dev] [PATCH 0/5] Allow multiple targets to be disabled

Hugo Beauzée-Luyssen wrote: configure.ac: Allow the programs to be disabled configure.ac: Allow bench to be disabled configure.ac: Don't build any tests when they are explicitely disabled configure.ac: Allow examples to be disabled win_utf8_io: Avoid forbidden functions when building f

Re: [flac-dev] [PATCH 0/5] Allow multiple targets to be disabled

On 01/06/2017 01:53 PM, Hugo Beauzée-Luyssen wrote: > Hi, > > This patchet allows a few targets to be disabled when unrequired. > The rational is coming from VLC's contrib buildsystem, so far we use make -C > to select only some subparts of the available targets. > It would be easier and cleaner

Re: [flac-dev] [PATCH] workaround for DJGPP missing wcswidth()

Ozkan Sezer wrote: > Attached patch works around for DJGPP missing wcswidth() > in flac/utils.c:strlen_console() Applied, thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/

Re: [flac-dev] [PATCH] support nasm coff obj format for djgpp

Ozkan Sezer wrote: > Attached patch adds support nasm coff obj format for djgpp Applied. Thanks. Erik -- -- Erik de Castro Lopo http://www.mega-nerd.com/ ___ flac-dev mailing list fla

[flac-dev] [PATCH 4/4] When using libtool, use LTLIBICONV instead.

* This is required, as otherwise -Wl,--as-needed could fail. --- src/flac/Makefile.am | 2 +- src/metaflac/Makefile.am | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/flac/Makefile.am b/src/flac/Makefile.am index bf3bf468..fe6fa489 100644 --- a/src/flac/Makefile.am +

[flac-dev] [PATCH 1/4] Do not override CFLAGS, as CFLAGS is a user flag.

* Furthermore, use NDEBUG globally to detect the presence of building with more debug output information. AX_CHECK_ENABLE_DEBUG is easier to use, and nowadays Gnome has also switched to it from its own custom solution. --- configure.ac | 19 +-- include/FLAC/assert.h

  1   2   3   4   5   6   7   8   9   10   >