Re: [flac-dev] [PATCH] fix UB in bitwriter.c

2015-12-20 Thread Erik de Castro Lopo
lvqcl wrote: > The commit > > fixed UB in bitwriter.c. But there are 2 unused functions - > FLAC__bitwriter_rice_bits() and FLAC__bitwriter_write_rice_signed() > that also have this UB. IMHO it makes sense t

[flac-dev] [PATCH] fix UB in bitwriter.c

2015-12-16 Thread lvqcl
The commit fixed UB in bitwriter.c. But there are 2 unused functions - FLAC__bitwriter_rice_bits() and FLAC__bitwriter_write_rice_signed() that also have this UB. IMHO it makes sense to fix their code as wel