[FFmpeg-devel] avcodec/videotoolboxenc: fix encoding frame crash on iOS 11

is zero, we simply return with no other operation. This crash often occurs on iOS 11 for example encoding 720p@25fps. Signed-off-by: sharpbai --- libavcodec/videotoolboxenc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/vid

[FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: fix encoding frame crash on iOS 11

is zero, we simply return with no other operation. This crash often occurs on iOS 11 for example encoding 720p@25fps. Signed-off-by: sharpbai --- libavcodec/videotoolboxenc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec/vid

[FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: ignore encoded h264 SEI nalu by default

need these encoded SEI nalu, so we just reserve a switch and set not to output by default. Signed-off-by: sharpbai --- libavcodec/videotoolboxenc.c | 51 +--- 1 file changed, 30 insertions(+), 21 deletions(-) diff --git a/libavcodec/videotoolboxenc.c b/libavcodec

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: ignore encoded h264 SEI nalu by default

as Rheinhardt < > andreas.rheinha...@gmail.com> wrote: > >> sharpbai: >> Before macOS 11, the encoded h264 sample contains fixed SEI before >> IDR frame, which the content is below >> >> 06 05 10 b9 ed b9 30 5d 21 4b 71 83 71 2c 10 a3 >> 14

[FFmpeg-devel] [PATCH] avcodec/h264_metadata: add change pic_order_cnt_type option

reversed, it will minimize the decoding delay on some decoder implementations. Signed-off-by: sharpbai --- libavcodec/cbs_h264.h | 1 + libavcodec/cbs_h264_syntax_template.c | 16 libavcodec/h264_metadata_bsf.c| 9 + 3 files changed, 26 insertions

Re: [FFmpeg-devel] [PATCH] avcodec/h264_metadata: add change pic_order_cnt_type option

To Andreas Rheinhardt, > This is wrong. Instead you should make the SPS that you are modifying > writable and update it. (The h264_metadata bsf uses separate > CodedBitstreamContexts for input and output and the SPS is normally > shared between them, so if someone wants to modify a field one needs

Re: [FFmpeg-devel] [PATCH] avcodec/h264_metadata: add change pic_order_cnt_type option

To Andreas Rheinhardt, > What does "will not accept a smaller value (such as 0)" mean? As your said, the max_dec_frame_buffering is limited to 16. Set it to 0 (on condition that we do know there is no reordered frames) is not possible. > Does it error out? It is safe and will not break any file

Re: [FFmpeg-devel] [PATCH] avcodec/h264_metadata: add change pic_order_cnt_type option

To Andreas Rheinhardt, > Why is this not possible? I just told you how you could set > max_dec_frame_buffering to a lower value. It seems you haven't tried it. Ahh...I thought what you care about is the unsafety of directly modifing num_reorder_frames and num_reorder_frames to a lower value. We

Re: [FFmpeg-devel] [PATCH] avcodec/h264_metadata: add change pic_order_cnt_type option

generate a bytestream on iOS to verify it. sharpbai ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-req

[FFmpeg-devel] [PATCH] Notify user when encode a CBR mp3 file without "-write_xing false". This may result in mp3 file duration incorect on ios safari browser and webview. I try to fix it but it can’t

From: sharpbai Bug example: ffmpeg -i a.mp3 -c:a mp3 -ab 32k -ar 44100 -ac 1 b.mp3 The duration of the generated file b.mp3 is wrong on ios safari browser from ios7 to ios10. --- libavformat/mp3enc.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat

[FFmpeg-devel] [PATCH] libavformat/mp3enc: Notify to add "-write_xing false" in CBR mode

From: sharpbai Encoding a CBR mp3 file without "-write_xing false" may result in mp3 file duration incorect on ios safari browser and webview. I try to fix it but it can’t be done as mp3 muxer don’t know it is a CBR file until encode process finished. And it’s hard to remove the firs

[FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

From: sharpbai feature: add scaleFactor attribute for avfoundation added by: siyuan.w...@duobei.com added by: yiren...@duobei.com --- libavdevice/avfoundation.m | 5 + 1 file changed, 5 insertions(+) diff --git a/libavdevice/avfoundation.m b/libavdevice/avfoundation.m index e2ddf47

[FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

From: sharpbai feature: add scaleFactor attribute for avfoundation added by: siyuan.w...@duobei.com added by: yiren...@duobei.com --- doc/indevs.texi| 3 +++ libavdevice/avfoundation.m | 6 ++ 2 files changed, 9 insertions(+) diff --git a/doc/indevs.texi b/doc/indevs.texi index

[FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

From: sharpbai feature: add scaleFactor attribute for avfoundation added by: siyuan.w...@duobei.com added by: yiren...@duobei.com --- doc/indevs.texi| 6 ++ libavdevice/avfoundation.m | 6 ++ 2 files changed, 12 insertions(+) diff --git a/doc/indevs.texi b/doc/indevs.texi

[FFmpeg-devel] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

From: sharpbai feature: add scaleFactor attribute for avfoundation added by: siyuan.w...@duobei.com added by: yiren...@duobei.com --- doc/indevs.texi| 6 ++ libavdevice/avfoundation.m | 8 2 files changed, 14 insertions(+) diff --git a/doc/indevs.texi b/doc/indevs.texi

[FFmpeg-devel] [PATCH] [PATCH] avdevice/avfoundation: add scaleFactor attribute for avfoundation

From: sharpbai feature: add scaleFactor attribute for avfoundation added by: siyuan.w...@duobei.com added by: yiren...@duobei.com --- doc/indevs.texi| 22 ++ libavdevice/avfoundation.m | 6 ++ 2 files changed, 28 insertions(+) diff --git a/doc/indevs.texi b