[FFmpeg-devel] [PATCH] flac: add GIF image support

2021-01-28 Thread leo60228
The FLAC specification requires GIF images to contain their number of colors. While I can't find a specific reference to that effect, I'm assuming that's why GIF images were previously unsupported. This was implemented by just writing AVPALETTE_COUNT for paletted images. --- Changelog

[FFmpeg-devel] [PATCH v2] flac: add GIF image support

2021-01-29 Thread leo60228
This patch no longer makes an (accidental) change to adjacent code and isn't included in the changelog. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffm

[FFmpeg-devel] [PATCH] flac: add GIF image support

2021-01-29 Thread leo60228
The FLAC specification requires GIF images to contain their number of colors. While I can't find a specific reference to that effect, I'm assuming that's why GIF images were previously unsupported. This was implemented by just writing AVPALETTE_COUNT for paletted images. --- libavformat/flacenc.c

[FFmpeg-devel] [PATCH v3] flac: add GIF image support

2021-01-29 Thread leo60228
The FLAC specification requires GIF images to contain their number of colors. While I can't find a specific reference to that effect, I'm assuming that's why GIF images were previously unsupported. This was implemented by just writing AVPALETTE_COUNT for paletted images. --- This version no longer

Re: [FFmpeg-devel] [PATCH v3] flac: add GIF image support

2021-01-31 Thread leo60228
27;m wrong on any of this, please let me know. On Sun, Jan 31, 2021 at 3:07 PM Derek Buitenhuis wrote: > On 29/01/2021 16:12, leo60228 wrote: > > +if (st->codecpar->format == AV_PIX_FMT_PAL8) > > +avio_wb32(pb, AVPALETTE_COUNT); > > +else > > +

Re: [FFmpeg-devel] [PATCH v3] flac: add GIF image support

2021-01-31 Thread leo60228
t color for GIF, despite having a comment acknowledging that this may be incorrect. On Sun, Jan 31, 2021 at 3:41 PM leo60228 wrote: > That's true, but as far as I can tell FFmpeg assumes that all paletted > images have 256 colors, and thus there isn't a way to get the exact number