[FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

2014-09-09 Thread jon
>From 5ae0b5a9cf9c37e11d5a3fea05c80c66b7c00c3e Mon Sep 17 00:00:00 2001 From: Jon Morley Date: Tue, 9 Sep 2014 11:48:02 -0700 Subject: [PATCH] libavformat/mov.c: Set stream time_base from frameduration/timescale Use tmcd atom's timescale and frameduration to for stream time base instead of 1/

[FFmpeg-devel] Set AV_TIMECODE_FLAG_ALLOWNEGATIVE in avutil/timecode.c av_timecode_init_from_string

2014-09-09 Thread jon
If the timecode value is negative it certainly seems safe to set the AV_TIMECODE_FLAG_ALLOWNEGATIVE on the AVTimecode object. >From 35ae38f9557e1ff01040d0e681e843d1727f979b Mon Sep 17 00:00:00 2001 From: Jon Morley Date: Tue, 9 Sep 2014 12:12:17 -0700 Subject: [PATCH 2/2] libavutil/timecod

[FFmpeg-devel] [PATCH] avformat/rtpdec: fix integer overflow in start_time_realtime calculation

2024-09-04 Thread jon
From: Jonathan Baudanza I encountered this problem with NTP timestamps that are extremely old, like from January, 1990. Although RFC3550 suggests that the timestamps in the RTCP packets use the actual wallclock, some implementations use other clocks, such as the CLOCK_MONOTONIC on linux. I'm my

[FFmpeg-devel] fix for colorspace minimum option value

2014-11-10 Thread jon
From 616d5017d8d2e566db3deb2696cc1672f2019777 Mon Sep 17 00:00:00 2001 From: Jon Morley Date: Mon, 10 Nov 2014 10:43:42 -0800 Subject: [PATCH] options_table.h: min value for colorspace is 0 (AVCOL_SPC_RGB) The min value for colorspace should be zero and not one since the first valid index into

Re: [FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

2015-01-22 Thread jon
that before as well, but I think it was too large. Please let me know how else I can help with this enhancement. Feel free to send clarification questions to me. Thanks, Jon On 09/09/2014 12:01 PM, jon wrote: Hi ffmpeg developers. I am still new to attempting contributing here, so please

Re: [FFmpeg-devel] Suggested Patch for timecode timebase calculation in mov.c

2015-01-23 Thread jon
et and when it is not. My work was based on deciphering the samples I had at my disposal in conjunction with my interpretation of the reference pdf. Thanks, Jon On 1/23/15 5:12 AM, Michael Niedermayer wrote: On Fri, Jan 23, 2015 at 04:26:59AM +0100, Michael Niedermayer wrote: On Thu, Jan 22, 2015

[FFmpeg-devel] [RFC PATCH] avformat/rtpdec: Audio level RTP extension RFC6464

2024-02-10 Thread jon
From: Jonathan Baudanza libwebrtc will add audio level (in decibels) and VAD status to each RTP packet. This patch will add both values to the packet sidedata. I've been using this patch in production for about a year on live audio RTP streams to detect when users are speaking without needing t

[FFmpeg-devel] [RFC PATCH] avformat/rtpdec: fix another int overflow in start_time_realtime

2024-11-25 Thread jon
From: Jonathan Baudanza This was previously adjusted by me in 6b3f9c2e92b. Unfortunately, I traded one integer overflow bug for another. Currently, ntp timestamps that exceed INT64_MAX (~Jan 20, 1968) will cause an overflow when passed to av_rescale. This patch replaces av_rescale, which oper

[FFmpeg-devel] [PATCH] avformat/rtpdec: int overflow in start_time_realtime

2025-01-07 Thread jon
From: Jonathan Baudanza This was previously adjusted by me in 6b3f9c2e92b. Unfortunately, I traded one integer overflow bug for another. Currently, NTP timestamps that exceed INT64_MAX (~Jan 20, 1968) will cause an overflow when passed to av_rescale. This patch replaces av_rescale, which operat

[FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Set height and width alignment when using mjpeg_qsv

2020-01-20 Thread Jon Cook
From: JonCookCubic Currently width_align and height_align are zero which cases "Error submitting the frame for encoding". This change sets the alignments. Signed-off-by: Jon Cook --- libavcodec/qsvenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/qsvenc.c b/

[FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Set height and width alignment when using mjpeg_qsv

2020-01-20 Thread Jon Cook
From: JonCookCubic Currently width_align and height_align are zero which cases "Error submitting the frame for encoding". This change sets the alignments. Signed-off-by: Jon Cook --- libavcodec/qsvenc.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/qsvenc.c b/

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Set height and width alignment when using mjpeg_qsv

2020-01-21 Thread Jon Cook
ith the output without the changes applied. Input video is not important, any video will do. There is a little bit more about the problem here http://ffmpeg.org/pipermail/ffmpeg-user/2019-November/046143.html Regards, Jon $ ./ffmpeg.exe -loglevel debug -y -i C:/Users/jcook/Desktop/sample.avi

[FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Set height and width alignment when using mjpeg_qsv

2020-01-21 Thread Jon Cook
From: JonCookCubic Setting FrameInfo.Width and Height as per review comments Signed-off-by: JonCookCubic --- libavcodec/qsvenc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index 9e416500e9..40904af388 100644 --- a/libavcodec/qsvenc.c +++

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Set height and width alignment when using mjpeg_qsv

2020-01-21 Thread Jon Cook
Updated patch with FrameInfo.Width and Height set as per review comments Jon On Tue, 21 Jan 2020 at 11:47, Jon Cook wrote: > Hi Zhong, > > Thanks for your reply. > > > IMHO If you set the aligned value, FrameInfo.Width/Height shoule > > be changed to be: > > >

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Set height and width alignment when using mjpeg_qsv

2020-01-21 Thread Jon Cook
Giving up on how to update the patch. Going to delete this ticket and create a new one! Jon On Tue, 21 Jan 2020 at 12:30, Jon Cook wrote: > Updated patch with FrameInfo.Width and Height set as per review comments > > Jon > > On Tue, 21 Jan 2020 at 11:47, Jon Cook wrote

[FFmpeg-devel] [PATCH] libavcodec/qsvenc.c: Set height and width alignment when encoding with mjpeg_qsv

2020-01-21 Thread Jon Cook
From: JonCookCubic Currently width_align and height_align are zero when encoding with mjpeg_qsv which causes "Error submitting the frame for encoding". This patch sets the alignments. There is a little bit more about the problem here http://ffmpeg.org/pipermail/ffmpeg-user/2019-November/04614

[FFmpeg-devel] Patch vf_blackdetect

2017-12-04 Thread Jon bae
This patch unify vf_blackdetect with af_silencedetect. Now the logging prints black_start and black_end in separate lines. This is the same behavior like af_silencedetect and it is also more useful for monitoring streams. 0001-unify-blackdetect-with-af_silencedetect.-Is-more-use.patch Description

[FFmpeg-devel] Last Patch: vf_blackdetect

2017-12-04 Thread Jon bae
Please forget the last patch! Something is not working right. Sorry! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] Patch vf_blackdetect

2017-12-04 Thread Jon bae
This is now the working version from my last patch. Description: This patch unify vf_blackdetect with af_silencedetect. Now the logging prints black_start and black_end in separate lines. This is the same behavior like af_silencedetect and it is also more useful for monitoring streams. Is it ok,

[FFmpeg-devel] [PATCH 2/2] lavf/mp3enc: write encoder delay/padding upon closing

2016-10-17 Thread Jon Toohill
--- libavformat/mp3enc.c | 34 -- 1 file changed, 28 insertions(+), 6 deletions(-) diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c index de63401..4c97fa1 100644 --- a/libavformat/mp3enc.c +++ b/libavformat/mp3enc.c @@ -111,6 +111,8 @@ typedef struct MP3Con

[FFmpeg-devel] [PATCH 1/2] lavc/libmp3lame: send encoder delay/padding in packet side data

2016-10-17 Thread Jon Toohill
--- libavcodec/libmp3lame.c | 27 ++- 1 file changed, 26 insertions(+), 1 deletion(-) diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c index 5642264..e55aa85 100644 --- a/libavcodec/libmp3lame.c +++ b/libavcodec/libmp3lame.c @@ -50,6 +50,7 @@ typedef struct L

[FFmpeg-devel] [PATCH 0/2] Fix gapless encoding/remuxing for MP3

2016-10-17 Thread Jon Toohill
Round trip wav->mp3->wav now preserves the correct number of samples. Remuxing mp3->mp3 with -c:a copy also preserves any existing gapless metadata in the Info tag. The code in libmp3lame.c to set AV_PKT_DATA_SKIP_SAMPLES was mostly copied from libopusenc.c. Jon Toohill (2): lavc/l

[FFmpeg-devel] [PATCH 1/5] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

2016-07-12 Thread Jon Toohill
--- libavformat/mp3dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 56c7f8c..345fa88 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -239,6 +239,8 @@ static void mp3_parse_info_tag(AVFormatContext *s, AVStream *st,

[FFmpeg-devel] [PATCH 5/5] lavf/mp3enc: write trailing_padding in Xing header

2016-07-12 Thread Jon Toohill
--- libavformat/mp3enc.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c index 3b77d29..da70d13 100644 --- a/libavformat/mp3enc.c +++ b/libavformat/mp3enc.c @@ -248,11 +248,14 @@ static int mp3_write_xing(AVFormatContext *s)

[FFmpeg-devel] [PATCH 4/5] ffmpeg: copy trailing_padding when using -acodec copy

2016-07-12 Thread Jon Toohill
--- ffmpeg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ffmpeg.c b/ffmpeg.c index 652774f..442f818 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -3001,6 +3001,7 @@ static int transcode_init(void) enc_ctx->audio_service_type = dec_ctx->audio_service_type; enc_ct

[FFmpeg-devel] [PATCH 2/5] libmp3lame + mp3enc: removes decoder delay compensation

2016-07-12 Thread Jon Toohill
initial_padding specifies only encoder delay, decoder delay is handled by start_skip_samples. --- doc/APIchanges | 4 libavcodec/libmp3lame.c | 2 +- libavcodec/version.h| 2 +- libavformat/mp3enc.c| 4 ++-- 4 files changed, 8 insertions(+), 4 deletions(-) diff --git a/doc/A

[FFmpeg-devel] [PATCH 0/2] Minor fixes for encoder padding

2016-08-15 Thread Jon Toohill
arate patch set. Jon Toohill (2): lavc: add trailing_padding to AVCodecContext to match AVCodecParameters. ffmpeg: copy trailing_padding when using -acodec copy doc/APIchanges | 4 ffmpeg.c | 1 + libavcodec/avcodec.h | 11 +++ libavcodec/utils.c

[FFmpeg-devel] [PATCH 1/2] lavc: add trailing_padding to AVCodecContext to match AVCodecParameters.

2016-08-15 Thread Jon Toohill
Shows encoder delay/padding in the stream summary if they are set. --- doc/APIchanges | 4 libavcodec/avcodec.h | 11 +++ libavcodec/utils.c | 40 +++- libavcodec/version.h | 2 +- 4 files changed, 39 insertions(+), 18 deletions(-) diff -

[FFmpeg-devel] [PATCH 2/2] ffmpeg: copy trailing_padding when using -acodec copy

2016-08-15 Thread Jon Toohill
--- ffmpeg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ffmpeg.c b/ffmpeg.c index bae515d..49a1b03 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -3001,6 +3001,7 @@ static int transcode_init(void) enc_ctx->audio_service_type = dec_ctx->audio_service_type; enc_ct

[FFmpeg-devel] [PATCH 1/4] ffmpeg: re-copy codec contexts after encoding

2016-09-26 Thread Jon Toohill
This preserves changes to fields of AVCodecContext that get updated during encoding, such as trailing_padding (which may not be known until encoding is complete). --- ffmpeg.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ffmpeg.c b/ffmpeg.c index df55a49..1e973f5 100644 ---

[FFmpeg-devel] [PATCH 2/4] lavc/libmp3lame: set trailing_padding after flushing encoder

2016-09-26 Thread Jon Toohill
--- libavcodec/libmp3lame.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c index 5642264..1566921 100644 --- a/libavcodec/libmp3lame.c +++ b/libavcodec/libmp3lame.c @@ -218,6 +218,7 @@ static int mp3lame_encode_frame(AVCodecContext *avctx, AV

[FFmpeg-devel] [PATCH 0/4] Handle trailing_padding in MP3 Info tag

2016-09-26 Thread Jon Toohill
Trimming trailing_padding samples from the end of the track is not yet implemented. Jon Toohill (4): ffmpeg: re-copy codec contexts after encoding lavc/libmp3lame: set trailing_padding after flushing encoder lavf/mp3enc: write encoder delay/padding upon closing lavf/mp3dec: read encoder

[FFmpeg-devel] [PATCH 4/4] lavf/mp3dec: read encoder delay/padding from Info tag

2016-09-26 Thread Jon Toohill
--- libavformat/mp3dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 56c7f8c..9cc85a3 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -239,6 +239,8 @@ static void mp3_parse_info_tag(AVFormatContext *s, AVStream *st,

[FFmpeg-devel] [PATCH 3/4] lavf/mp3enc: write encoder delay/padding upon closing

2016-09-26 Thread Jon Toohill
trailing_padding is not known before encoding. --- libavformat/mp3enc.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c index de63401..433b070 100644 --- a/libavformat/mp3enc.c +++ b/libavformat/mp3enc.c @@ -247,

Re: [FFmpeg-devel] [PATCH 4/4] lavf/mp3dec: read encoder delay/padding from Info tag

2016-09-26 Thread Jon Toohill
a concrete case where knowing trailing_padding at the start of a stream is necessary, then that's not possible, but I'm pretty new to this and don't know of one. Thoughts? Jon Toohill | Google Play Music | jtooh...@google.com | (650) 215-0770 On Mon, Sep 26, 2016 at 11:30 AM, wm4

[FFmpeg-devel] [PATCH 0/4] Handle trailing_padding in MP3 Info tag

2016-09-28 Thread Jon Toohill
Trimming trailing_padding samples from the end of the track is not yet implemented. Jon Toohill (4): ffmpeg: re-copy codec parameters after encoding lavc/libmp3lame: set trailing_padding after flushing encoder lavf/mp3enc: write encoder delay/padding upon closing lavf/mp3dec: read encoder

[FFmpeg-devel] [PATCH 2/4] lavc/libmp3lame: set trailing_padding after flushing encoder

2016-09-28 Thread Jon Toohill
--- libavcodec/libmp3lame.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c index 5642264..1566921 100644 --- a/libavcodec/libmp3lame.c +++ b/libavcodec/libmp3lame.c @@ -218,6 +218,7 @@ static int mp3lame_encode_frame(AVCodecContext *avctx, AV

[FFmpeg-devel] [PATCH 1/4] ffmpeg: re-copy codec contexts after encoding

2016-09-28 Thread Jon Toohill
This preserves changes to fields of AVCodecContext that get updated during encoding, such as trailing_padding (which may not be known until encoding is complete). --- ffmpeg.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ffmpeg.c b/ffmpeg.c index df55a49..1e973f5 100644 ---

[FFmpeg-devel] [PATCH 1/4] ffmpeg: re-copy codec parameters after encoding

2016-09-28 Thread Jon Toohill
This preserves changes to fields of AVCodecParameters that get updated during encoding, such as trailing_padding (which may not be known until encoding is complete). --- ffmpeg.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/ffmpeg.c b/ffmpeg.c index d0f247e..0cdc762 100644

Re: [FFmpeg-devel] [PATCH 2/4] lavc/libmp3lame: set trailing_padding after flushing encoder

2016-09-28 Thread Jon Toohill
On Tue, Sep 27, 2016 at 1:04 AM, Carl Eugen Hoyos wrote: > 2016-09-26 19:13 GMT+02:00 Jon Toohill >: > > > +avctx->trailing_padding = FFMAX(lame_get_encoder_padding(s->gfp) > - 528 - 1, 0); > > Can you confirm that this function exists in lame 3.98.3? >

[FFmpeg-devel] [PATCH 3/4] lavf/mp3enc: write encoder delay/padding upon closing

2016-09-28 Thread Jon Toohill
trailing_padding is not known before encoding. --- libavformat/mp3enc.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c index de63401..37608f1 100644 --- a/libavformat/mp3enc.c +++ b/libavformat/mp3enc.c @@ -247,

[FFmpeg-devel] [PATCH 4/4] lavf/mp3dec: read encoder delay/padding from Info tag

2016-09-28 Thread Jon Toohill
--- libavformat/mp3dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 56c7f8c..9cc85a3 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -239,6 +239,8 @@ static void mp3_parse_info_tag(AVFormatContext *s, AVStream *st,

Re: [FFmpeg-devel] [PATCH 0/4] Handle trailing_padding in MP3 Info tag

2016-09-28 Thread Jon Toohill
Oops, forgot to send this in reply to the previous thread. Should I re-send? http://ffmpeg.org/pipermail/ffmpeg-devel/2016-September/200092.html On Wed, Sep 28, 2016 at 11:28 AM, Jon Toohill wrote: > Trimming trailing_padding samples from the end of the track is not yet > implemented. &

Re: [FFmpeg-devel] [PATCH 1/4] ffmpeg: re-copy codec contexts after encoding

2016-09-28 Thread Jon Toohill
This was sent in error, please disregard. Jon Toohill | Google Play Music | jtooh...@google.com | (650) 215-0770 On Wed, Sep 28, 2016 at 11:28 AM, Jon Toohill wrote: > This preserves changes to fields of AVCodecContext that get > updated during encoding, such as trailing_padding

[FFmpeg-devel] [PATCH 1/3] lavc/libmp3lame: send encoder padding in side data of final packet

2016-10-03 Thread Jon Toohill
--- libavcodec/libmp3lame.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c index 5642264..a1bf122 100644 --- a/libavcodec/libmp3lame.c +++ b/libavcodec/libmp3lame.c @@ -185,7 +185,7 @@ static int mp3lame_e

[FFmpeg-devel] [PATCH 2/3] lavf/mp3enc: write encoder delay/padding upon closing

2016-10-03 Thread Jon Toohill
--- libavformat/mp3enc.c | 32 +--- 1 file changed, 25 insertions(+), 7 deletions(-) diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c index de63401..48cb0b4 100644 --- a/libavformat/mp3enc.c +++ b/libavformat/mp3enc.c @@ -111,6 +111,7 @@ typedef struct MP3Conte

[FFmpeg-devel] [PATCH 0/3] Fix gapless encoding/decoding for MP3

2016-10-03 Thread Jon Toohill
Round trip wav->mp3->wav now preserves the correct number of samples. Remuxing mp3->mp3 with -c:a copy also preserves any existing gapless metadata in the Info tag. The code in libmp3lame.c to set AV_PKT_DATA_SKIP_SAMPLES was mostly copied from libopusenc.c. Jon Toohill (3): lavc/l

[FFmpeg-devel] [PATCH 3/3] lavf/mp3dec: read encoder delay/padding from Info tag

2016-10-03 Thread Jon Toohill
Muxers can check AVCodecParameters.initial_padding for the encoder+decoder delay, and read the AV_PKT_DATA_SKIP_SAMPLES side data from the last packet for the encoder padding. This change also fixes the first_discard_sample calculation which erroneously included the decoder delay. Decoder delay is

Re: [FFmpeg-devel] [PATCH 3/3] lavf/mp3dec: read encoder delay/padding from Info tag

2016-10-05 Thread Jon Toohill
On Tue, Oct 4, 2016 at 7:19 AM, wm4 wrote: > On Mon, 3 Oct 2016 17:45:08 -0700 > Jon Toohill wrote: > > > Muxers can check AVCodecParameters.initial_padding for the > > encoder+decoder delay, and read the AV_PKT_DATA_SKIP_SAMPLES > > side data from the last pac

Re: [FFmpeg-devel] [PATCH 3/3] lavf/mp3dec: read encoder delay/padding from Info tag

2016-10-05 Thread Jon Toohill
On Tue, Oct 4, 2016 at 9:10 AM, Michael Niedermayer wrote: > On Mon, Oct 03, 2016 at 05:45:08PM -0700, Jon Toohill wrote: > > Muxers can check AVCodecParameters.initial_padding for the > > encoder+decoder delay, and read the AV_PKT_DATA_SKIP_SAMPLES > > side data from th

Re: [FFmpeg-devel] [PATCH 3/3] lavf/mp3dec: read encoder delay/padding from Info tag

2016-10-05 Thread Jon Toohill
On Wed, Oct 5, 2016 at 10:40 AM, Jon Toohill wrote: > On Tue, Oct 4, 2016 at 7:19 AM, wm4 wrote: > >> On Mon, 3 Oct 2016 17:45:08 -0700 >> Jon Toohill wrote: >> >> > Muxers can check AVCodecParameters.initial_padding for the >> > encoder+decoder de

Re: [FFmpeg-devel] [PATCH 3/3] lavf/mp3dec: read encoder delay/padding from Info tag

2016-10-05 Thread Jon Toohill
On Wed, Oct 5, 2016 at 11:03 AM, wm4 wrote: > On Wed, 5 Oct 2016 10:42:13 -0700 > Jon Toohill wrote: > > > On Wed, Oct 5, 2016 at 10:40 AM, Jon Toohill > wrote: > > > > > On Tue, Oct 4, 2016 at 7:19 AM, wm4 wrote: > > > > > >> On Mon

[FFmpeg-devel] [PATCH 0/2] Fix gapless encoding/remuxing for MP3

2016-10-05 Thread Jon Toohill
Round trip wav->mp3->wav now preserves the correct number of samples. Remuxing mp3->mp3 with -c:a copy also preserves any existing gapless metadata in the Info tag. The code in libmp3lame.c to set AV_PKT_DATA_SKIP_SAMPLES was mostly copied from libopusenc.c. Jon Toohill (2): lavc/l

[FFmpeg-devel] [PATCH 1/2] lavc/libmp3lame: send encoder delay/padding in packet side data

2016-10-05 Thread Jon Toohill
--- libavcodec/libmp3lame.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/libavcodec/libmp3lame.c b/libavcodec/libmp3lame.c index 5642264..b3ba0d8 100644 --- a/libavcodec/libmp3lame.c +++ b/libavcodec/libmp3lame.c @@ -50,6 +50,7 @@ typedef struct LA

[FFmpeg-devel] [PATCH 2/2] lavf/mp3enc: write encoder delay/padding upon closing

2016-10-05 Thread Jon Toohill
--- libavformat/mp3enc.c | 34 +++--- 1 file changed, 27 insertions(+), 7 deletions(-) diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c index de63401..ddf4b93 100644 --- a/libavformat/mp3enc.c +++ b/libavformat/mp3enc.c @@ -111,6 +111,8 @@ typedef struct MP3Con

[FFmpeg-devel] dh option in nnedi3

2016-10-06 Thread Jon bae
Hello All, sorry for that question - I know is open source and we can add option by ours self, but my knowledge is to limited for that. Is it possible to integrate the dh (double high) option from vapoursynth nnedi3 filter to the ffmpeg nnedi filter? I have start copy parts from the sources, but

[FFmpeg-devel] [PATCH 0/2] Pass Xing gapless metadata to users during mp3 parsing

2016-05-24 Thread Jon Toohill
These patches expose the encoder delay/padding parsed from an mp3's Xing header to users of lavc/lavf, and show gapless info in the stream summary string. Jon Toohill (2): lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters lavc: show gapless info in stream summary libav

[FFmpeg-devel] [PATCH 1/2] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

2016-05-24 Thread Jon Toohill
From: Jon Toohill --- libavformat/mp3dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 3725d67..192f5ef 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -234,6 +234,8 @@ static void mp3_parse_info_tag(AVFormatContext *s

[FFmpeg-devel] [PATCH 2/2] lavc: show gapless info in stream summary

2016-05-24 Thread Jon Toohill
From: Jon Toohill Also adds trailing_padding to AVCodecContext to match AVCodecParameters so that it doesn't get lost when mapping between them. --- libavcodec/avcodec.h | 11 +++ libavcodec/utils.c | 38 ++ 2 files changed, 33 insertions(+

Re: [FFmpeg-devel] [PATCH 0/2] Pass Xing gapless metadata to users during mp3 parsing

2016-05-24 Thread Jon Toohill
Forgot to fix the author line in those patches, it should read "Jon Toohill " instead. I can fix it when sending updated patches if there are revisions to make, otherwise can you change it before merging (or should I send updated patches)? Jon Toohill | Google Play Music | jtooh...@

[FFmpeg-devel] [PATCH 2/2] lavc: show gapless info in stream summary

2016-05-25 Thread Jon Toohill
Also adds trailing_padding to AVCodecContext to match AVCodecParameters so that it doesn't get lost when mapping between them. --- doc/APIchanges | 4 libavcodec/avcodec.h | 11 +++ libavcodec/utils.c | 38 ++ libavcodec/version.h | 2 +-

[FFmpeg-devel] [PATCH 0/2] Pass Xing gapless metadata to users during mp3 parsing

2016-05-25 Thread Jon Toohill
These patches expose the encoder delay/padding parsed from an mp3's Xing header to users of lavc/lavf, and show gapless info in the stream summary string. Jon Toohill (2): lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters lavc: show gapless info in stream summary doc/APIch

[FFmpeg-devel] [PATCH 1/2] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

2016-05-25 Thread Jon Toohill
--- libavformat/mp3dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 3725d67..192f5ef 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -234,6 +234,8 @@ static void mp3_parse_info_tag(AVFormatContext *s, AVStream *st,

Re: [FFmpeg-devel] [PATCH 1/2] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

2016-06-01 Thread Jon Toohill
libmp3lame adds the 528 + 1 only to have mp3dec subtract it, so I'm not sure why that's done. IIUC start_skip_samples is the mechanism that actually accounts for the extra delay when decoding. [1]: http://gabriel.mp3-tech.org/mp3infotag.html#delays [2]: http://lame.sourceforge.net/tech-FAQ.

Re: [FFmpeg-devel] [PATCH 1/2] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

2016-06-08 Thread Jon Toohill
Michael et al., is this good to merge as-is? I just tested and a round trip with ffmpeg from wav -> mp3 -> wav retains the correct number of samples. Jon Toohill | Google Play Music | jtooh...@google.com | (650) 215-0770 On Wed, Jun 1, 2016 at 5:58 PM, Jon Toohill wrote: > Ba

[FFmpeg-devel] [PATCH 0/3] Pass Xing gapless metadata to users during mp3 parsing

2016-06-16 Thread Jon Toohill
t set properly when encoding with libmp3lame, causing an encode/decode round trip to add trailing silence. This is not a regression from current behavior, and will be addressed in a separate patch set. Jon Toohill (3): lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters lavc: show gapless

[FFmpeg-devel] [PATCH 1/3] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

2016-06-16 Thread Jon Toohill
Also removes decoder delay compensation from libmp3lame and mp3enc. initial_padding specifies only encoder delay, decoder delay is handled by start_skip_samples. --- libavcodec/libmp3lame.c | 2 +- libavformat/mp3dec.c| 2 ++ libavformat/mp3enc.c| 9 ++--- 3 files changed, 9 insertions

[FFmpeg-devel] [PATCH 2/3] lavc: show gapless info in stream summary

2016-06-16 Thread Jon Toohill
Also adds trailing_padding to AVCodecContext to match AVCodecParameters so that it doesn't get lost when mapping between them. --- doc/APIchanges | 4 libavcodec/avcodec.h | 11 +++ libavcodec/utils.c | 40 +++- libavcodec/version.h | 2 +-

[FFmpeg-devel] [PATCH 3/3] ffmpeg: copy trailing_padding when using -acodec copy

2016-06-16 Thread Jon Toohill
--- ffmpeg.c | 1 + 1 file changed, 1 insertion(+) diff --git a/ffmpeg.c b/ffmpeg.c index 652774f..442f818 100644 --- a/ffmpeg.c +++ b/ffmpeg.c @@ -3001,6 +3001,7 @@ static int transcode_init(void) enc_ctx->audio_service_type = dec_ctx->audio_service_type; enc_ct

Re: [FFmpeg-devel] [PATCH 1/3] lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters

2016-07-12 Thread Jon Toohill
including documentation and another minor version bump. Jon Toohill | Google Play Music | jtooh...@google.com | (650) 215-0770 On Fri, Jun 17, 2016 at 5:32 PM, Michael Niedermayer wrote: > On Thu, Jun 16, 2016 at 11:16:05AM -0700, Jon Toohill wrote: > > Also removes decoder dela

[FFmpeg-devel] [PATCH 0/5] Pass Xing gapless metadata to users during mp3 parsing

2016-07-12 Thread Jon Toohill
t set properly when encoding with libmp3lame, causing an encode/decode round trip to add trailing silence. This is not a regression from current behavior, and will be addressed in a separate patch set. Jon Toohill (5): lavf/mp3dec: pass Xing gapless metadata to AVCodecParameters libmp3lame + m

[FFmpeg-devel] [PATCH 3/5] lavc: show gapless info in stream summary

2016-07-12 Thread Jon Toohill
Also adds trailing_padding to AVCodecContext to match AVCodecParameters so that it doesn't get lost when mapping between them. --- doc/APIchanges | 4 libavcodec/avcodec.h | 11 +++ libavcodec/utils.c | 40 +++- libavcodec/version.h | 2 +-

[FFmpeg-devel] I dont know asm too well =( but I have a tip: mem+sync and machine learning

2024-04-09 Thread Jon Maser
i got this idea from postresql, a very small sql database server i see ffmpeg is broken down into optimized asm libraries for embedding in c etc programs, and i know a few things about asm, ie, hardware registers on cpu+, pump in data into a register, get data out, think it goes down the system bu

[FFmpeg-devel] fix for decklink_common.cpp

2014-12-02 Thread Jon bae
Hello everybody, on the Zeranoe forum we find out that there is two bugs in the decklink_common.cpp file. I build I patch and want to send them now to you. I hope is all right, I never did before a git format-patch... Regards! Jonathan fix-device_list-and-COM-initialization-failed_in decklink_c

Re: [FFmpeg-devel] fix for decklink_common.cpp

2014-12-02 Thread Jon bae
en is ok for you, I copy your answer to the zeranoe forum, then they can help me to fix it. 2014-12-02 16:45 GMT+01:00 Carl Eugen Hoyos : > Jon bae gmail.com> writes: > > > I hope is all right, I never did before a > > git format-patch... > > You used git format-patch p

[FFmpeg-devel] Patch for heap corruption run time error in decklink_common.cpp

2014-12-02 Thread Jon bae
Ok here a second run, I try to follow the instruction from Carl Eugen. This is the first patch for decklink_common.cpp. It fix this error: Unhandled exception at 0x76FA4102 (ntdll.dll) in ffmpeg.exe: 0xC374: A heap has been corrupted (parameters: 0x7701B4B0). Regards

[FFmpeg-devel] Patch for device list error in decklink_common.cpp

2014-12-02 Thread Jon bae
Here is the other patch for decklink_common.cpp. It fix the error: COM initialization failed [decklink @ 02e5b520] Could not create DeckLink iterator dummy: Immediate exit request Regards Jonathan >From 203eba2fad14dd6d84552d6c22899792e80b53bb Mon Sep 17 00:00:00 2001 From: Jonathan B

Re: [FFmpeg-devel] Patch for device list error in decklink_common.cpp

2014-12-03 Thread Jon bae
Thanks Ramiro for the correction! Here is the new patch. (Is it better to post directly the patch, or is ok as a attachment?) Regards Jonathan 2014-12-02 22:19 GMT+01:00 Ramiro Polla : > > On 02.12.2014 20:30, Jon bae wrote: > >> Here is the other patch for decklink_common.cpp. I

Re: [FFmpeg-devel] Patch for device list error in decklink_common.cpp

2014-12-03 Thread Jon bae
2014-12-03 15:46 GMT+01:00 Ramiro Polla : > > On 03.12.2014 12:06, Jon bae wrote: > >> Thanks Ramiro for the correction! >> Here is the new patch. (Is it better to post directly the patch, or is ok >> as a attachment?) >> > > Attachment is better. But please

[FFmpeg-devel] Question about supported_fps in libavutil/timecode.c::check_fps

2015-01-23 Thread jon morley
k_fps that I am overlooking. Thanks, Jon ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Question about supported_fps in libavutil/timecode.c::check_fps

2015-01-23 Thread jon morley
Patch attached for consideration. On 1/23/15 8:03 AM, jon morley wrote: Currently check_fps has the following logic: static int check_fps(int fps) { int i; static const int supported_fps[] = {24, 25, 30, 48, 50, 60}; for (i = 0; i < FF_ARRAY_ELEMS(supported_fps)

Re: [FFmpeg-devel] Question about supported_fps in libavutil/timecode.c::check_fps

2015-01-24 Thread jon morley
ot find anywhere that benefited from the explicit list the method currently used, but that doesn't mean it isn't out there. Thanks, Jon On 1/24/15 2:27 AM, Clément Bœsch wrote: On Fri, Jan 23, 2015 at 08:48:37AM -0800, jon morley wrote: Patch attached for consideration. On 1/23/15

Re: [FFmpeg-devel] Question about supported_fps in libavutil/timecode.c::check_fps

2015-01-24 Thread jon morley
is to send your patches to the ffmpeg-devel mailing list following the guidelines illustrated in the remainder of this document." I will stick to mailing patches exclusively in the future. Patches reflecting your suggestions attached. Sincerely, Jon On 1/24/15 8:21 AM, Clément Bœsch wrot

[FFmpeg-devel] libavformat/movenc.c: Correct color range when writing DNxHD atoms

2015-01-27 Thread jon morley
>From 0097277471810ab1d9d737c64a57c2278a039153 Mon Sep 17 00:00:00 2001 From: Jon Morley Date: Tue, 27 Jan 2015 11:10:27 -0800 Subject: [PATCH] libavformat/movenc.c: Correct color range when writing DNxHD atoms The meaning of the color range values in the AVdn.ACLR atom was swapped. This cha

Re: [FFmpeg-devel] libavformat/movenc.c: Correct color range when writing DNxHD atoms

2015-01-28 Thread jon morley
-0800, jon morley wrote: movenc.c |9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) 6317011578bca8bf065f5bd4de2dfce803557e81 0001-libavformat-movenc.c-Correct-color-range-when-writin.patch From 0097277471810ab1d9d737c64a57c2278a039153 Mon Sep 17 00:00:00 2001 From: Jon Morley