[FFmpeg-devel] [PATCH] avformat/hls: Add option to retry failed segments for hls

2022-10-10 Thread gnattu
Current HLS implementation simply skip a failed segment to catch up the stream, but this is not optimal for some use cases like livestream recording. Add an option to retry a failed segment to ensure the output file is a complete stream. Signed-off-by: gnattu --- libavformat/hls.c | 15

[FFmpeg-devel] [PATCH v2] avformat/hls: Add option to retry failed segments for hls

2022-10-10 Thread gnattu
Current HLS implementation simply skip a failed segment to catch up the stream, but this is not optimal for some use cases like livestream recording. Add an option to retry a failed segment to ensure the output file is a complete stream. Signed-off-by: gnattu --- Previous version was trashed

[FFmpeg-devel] [PATCH v3] avformat/hls: Add option to retry failed segments for hls

2022-10-10 Thread gnattu
Current HLS implementation simply skip a failed segment to catch up the stream, but this is not optimal for some use cases like livestream recording. Add an option to retry a failed segment to ensure the output file is a complete stream. Signed-off-by: gnattu --- Fixed commit message wrap

[FFmpeg-devel] [PATCH v4] avformat/hls: Add option to retry failed segments for hls

2022-10-12 Thread gnattu
Current HLS implementation simply skip a failed segment to catch up the stream, but this is not optimal for some use cases like livestream recording. Add an option to retry a failed segment to ensure the output file is a complete stream. Signed-off-by: gnattu --- v4 added docs explaining the

[FFmpeg-devel] [PATCH v4] avformat/hls: Add option to retry failed segments for hls

2022-10-19 Thread gnattu
Current HLS implementation simply skip a failed segment to catch up the stream, but this is not optimal for some use cases like livestream recording. Add an option to retry a failed segment to ensure the output file is a complete stream. Signed-off-by: gnattu --- v4 added documentation for the

[FFmpeg-devel] [PATCH v5] avformat/hls: Add option to retry failed segments for hls

2022-10-20 Thread gnattu
Current HLS implementation simply skip a failed segment to catch up the stream, but this is not optimal for some use cases like livestream recording. Add an option to retry a failed segment to ensure the output file is a complete stream. Signed-off-by: gnattu --- v5 changed coding style as

[FFmpeg-devel] [PATCH] avformat/hls: Add option to retry failed segments for hls

2022-10-10 Thread Gnattu OC
Current HLS implementation simply skip a failed segment to catch up the stream, but this is not optimal for some use cases like livestream recording. Add an option to retry a failed segment to ensure the output file is a complete stream. Signed-off-by: gnattu --- libavformat/hls.c | 15

[FFmpeg-devel] [PATCH] lavc/videotoolboxenc: add MJPEG support

2024-03-28 Thread gnattu via ffmpeg-devel
For example: ./ffmpeg -hwaccel videotoolbox\ -i INPUT -c:v mjpeg_videotoolbox\ out.mp4 This encoder does not have many options and can only use ``-q:v` to control quality. Signed-off-by: Gnattu OC --- Changelog| 1 + configure| 2 ++ libavcodec

[FFmpeg-devel] [PATCH] avfilter: add vf_overlay_videotoolbox

2024-02-20 Thread gnattu via ffmpeg-devel
Overlay filter for VideoToolbox hwframes. Unlike most hardware overlay filters, this filter does not require the two inputs to have the same pixel format; instead, it will perform format conversion automatically with hardware accelerated methods. Signed-off-by: Gnattu OC --- Changelog

[FFmpeg-devel] [PATCH v2] Overlay filter for VideoToolbox hwframes. Unlike most hardware overlay filters, this filter does not require the two inputs to have the same pixel format; instead, it will pe

2024-02-20 Thread gnattu via ffmpeg-devel
Signed-off-by: Gnattu OC --- Changelog | 1 + configure | 1 + doc/filters.texi | 52 +++ libavfilter/Makefile | 3 +++ libavfilter/allfilters.c | 1 + libavfilter/metal/utils.h | 1 - libavfilter/metal

[FFmpeg-devel] [PATCH v2] avfilter: add vf_overlay_videotoolbox

2024-02-20 Thread gnattu via ffmpeg-devel
Overlay filter for VideoToolbox hwframes. Unlike most hardware overlay filters, this filter does not require the two inputs to have the same pixel format; instead, it will perform format conversion automatically with hardware accelerated methods. Signed-off-by: Gnattu OC --- Changelog

[FFmpeg-devel] [PATCH v3] avfilter: add vf_overlay_videotoolbox

2024-02-20 Thread gnattu via ffmpeg-devel
Overlay filter for VideoToolbox hwframes. Unlike most hardware overlay filters, this filter does not require the two inputs to have the same pixel format; instead, it will perform format conversion automatically with hardware accelerated methods. Signed-off-by: Gnattu OC --- Changelog

[FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread gnattu via ffmpeg-devel
There is no device context to be setup, nor devices to be selected with VideoToolbox. Just a simple return would allow us to use derived device in filters like `hwupload=derive_device=videotoolbox` Signed-off-by: Gnattu OC --- libavutil/hwcontext_videotoolbox.c | 9 + 1 file changed, 9

[FFmpeg-devel] [PATCH v4] avfilter: add vf_overlay_videotoolbox

2024-02-27 Thread gnattu via ffmpeg-devel
Overlay filter for VideoToolbox hwframes. Unlike most hardware overlay filters, this filter does not require the two inputs to have the same pixel format; instead, it will perform format conversion automatically with hardware accelerated methods. Signed-off-by: Gnattu OC --- Changes from v3

[FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Check CVBufferCopyAttachments during configure

2024-07-21 Thread gnattu via ffmpeg-devel
The __builtin_available function does not do compile time check for the availablity of the CVBufferCopyAttachments function which will fail the build. Check the availability during configure. Signed-off-by: Gnattu OC --- configure | 2 ++ 1 file changed, 2 insertions(+) diff --git a/configure

[FFmpeg-devel] [PATCH v2] avutil/hwcontext_videotoolbox: Check CVBufferCopyAttachments during configure

2024-07-21 Thread gnattu via ffmpeg-devel
The __builtin_available function does not do compile time check for the availablity of the CVBufferCopyAttachments function which will fail the build. Check the availability during configure. Signed-off-by: Gnattu OC --- configure | 2 ++ libavutil

[FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Allocate attachments dictionary

2024-08-01 Thread gnattu via ffmpeg-devel
From: Gnattu OC Allocate a dedicated attachments dictionary instead of trying to get one from the pixel buffer. The attachments got from the pixel buffer confuses the CVImageBufferCreateColorSpaceFromAttachments method and will make it to output a wrong colorspace that causes problem like #10884

[FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Correctly set trc

2024-08-01 Thread gnattu via ffmpeg-devel
The color trc key was assigned a color primaries value which causes the resulting colorspace is always SDR. Fixes #10884. Signed-off-by: Gnattu OC --- libavutil/hwcontext_videotoolbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/hwcontext_videotoolbox.c b

[FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: always release supported_props

2024-08-09 Thread gnattu via ffmpeg-devel
In vtenc_populate_extradata, supported_props should always be released to avoid memory leak. Regression from cd2f8a22e94700c68b1de7968df11e8bebfd315b Signed-off-by: gnattu --- libavcodec/videotoolboxenc.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a

[FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: silence warning for RGB

2024-08-09 Thread gnattu via ffmpeg-devel
Hardware frames with RGB colorspace will not have a YCbCrMatrixKey. Currently, it will spam the console with warning if rgb frame is uploaded. Signed-off-by: Gnattu OC --- libavutil/hwcontext_videotoolbox.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil

[FFmpeg-devel] [PATCH] avfilter: inherit input color range for videotoolbox filters

2024-08-15 Thread gnattu via ffmpeg-devel
The color range should be set to match the input when creating the VideoToolbox context. Otherwise, the new context will default to limited range, creates inconsistencies with full range inputs. Signed-off-by: Gnattu OC --- libavfilter/vf_scale_vt.c | 1 + libavfilter

[FFmpeg-devel] [PATCH] avcodec/bsf/dovi_rpu: remove EL when stripping dovi metadata

2024-10-15 Thread gnattu via ffmpeg-devel
When RPU is removed EL should also be removed. This only applies to HEVC as AV1 based Profile 10 does not support EL at all. Signed-off-by: Gnattu OC --- libavcodec/bsf/dovi_rpu.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/bsf/dovi_rpu.c b/libavcodec

Re: [FFmpeg-devel] [PATCH v2] avutil/hwcontext_videotoolbox: Set proper CVBuffer colorspace

2024-05-20 Thread Gnattu OC via ffmpeg-devel
> On May 20, 2024, at 09:12, Marvin Scholz wrote: > > Fix #10884 > --- > libavutil/hwcontext_videotoolbox.c | 54 +- > 1 file changed, 38 insertions(+), 16 deletions(-) > > diff --git a/libavutil/hwcontext_videotoolbox.c > b/libavutil/hwcontext_videotoolbox.c > ind

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-22 Thread Gnattu OC via ffmpeg-devel
wrote: >>> >>> On 22/02/2024 18:46, gnattu via ffmpeg-devel wrote: >>>> There is no device context to be setup, nor devices to be >>>> selected with VideoToolbox. Just a simple return would allow >>>> us to use derived device in fi

Re: [FFmpeg-devel] [PATCH v3] avfilter: add vf_overlay_videotoolbox

2024-02-23 Thread Gnattu OC via ffmpeg-devel
A ping for this. > On Feb 21, 2024, at 09:53, gnattu wrote: > > Overlay filter for VideoToolbox hwframes. Unlike most hardware > overlay filters, this filter does not require the two inputs to > have the same pixel format; instead, it will perform format > conversion automatic

Re: [FFmpeg-devel] [PATCH] hwcontext_videotoolbox: add vt_device_derive

2024-02-23 Thread Gnattu OC via ffmpeg-devel
I’ve tested and confirmed to work, and `reverse=1` also works for chaining to other videotoolbox filters. > On Feb 23, 2024, at 22:25, Zhao Zhili wrote: > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listin

Re: [FFmpeg-devel] [PATCH v4] avfilter: add vf_overlay_videotoolbox

2024-03-05 Thread Gnattu OC via ffmpeg-devel
A ping for this as it is already a week. > On Feb 28, 2024, at 00:35, gnattu via ffmpeg-devel > wrote: > > Overlay filter for VideoToolbox hwframes. Unlike most hardware > overlay filters, this filter does not require the two inputs to > have the same pixel format; instea

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-16 Thread Gnattu OC via ffmpeg-devel
If you are using Xcode >= 15 then you will need to add `-Wl,-ld_classic` to LDFLAGS. During configure you will also need to set `--host-ldflags='-Wl,-ld_classic’`. > On Mar 16, 2024, at 09:04, Helmut K. C. Tessarek wrote: > > Hello, > > It's me again - the dude who compiles ffmpeg for macOS.

Re: [FFmpeg-devel] duplicate symbol '_dec_init' in: fftools/ffmpeg_dec.o

2024-03-17 Thread Gnattu OC via ffmpeg-devel
Can you try to change the `BD_PRIVATE` to `__attribute__((visibility("hidden")))` in the line defines `dec_init` src/libbluray/disc/dec.h then recompile libbluray to see if it fixes the linking issue? > On Mar 17, 2024, at 05:09, Helmut K. C. Tessarek wrote: > > Hi, > > On 2024-03-16 10:26,

Re: [FFmpeg-devel] videotoolbox increases min target to macOS 12

2024-07-08 Thread Gnattu OC via ffmpeg-devel
> On Jul 9, 2024, at 13:47, Helmut K. C. Tessarek wrote: > > I'm very sorry to bother the dev list with this, but this is the 2nd time in > less than a year that the min version of macOS was changed in videotoolbox. > > 2023-09-22: macOS 10.13 > now: macOS 12 > > Will ffmpeg soon only compil

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix build with older SDKs

2024-07-21 Thread Gnattu OC via ffmpeg-devel
> On Jul 22, 2024, at 06:04, Sean McGovern wrote: > > Hi Marvin, > > > On Tue, Jul 9, 2024, 10:47 Marvin Scholz wrote: > >> I've accidentally used API not available on the checked version. >> Additionally check for the SDK to be new enough to even have the >> CVImageBufferCreateColorSpaceF

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix build with older SDKs

2024-07-21 Thread Gnattu OC via ffmpeg-devel
> On Jul 22, 2024, at 06:45, Gnattu OC via ffmpeg-devel > wrote: > > > >> On Jul 22, 2024, at 06:04, Sean McGovern wrote: >> >> Hi Marvin, >> >> >> On Tue, Jul 9, 2024, 10:47 Marvin Scholz wrote: >> >>> I've accid

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Allocate attachments dictionary

2024-08-01 Thread Gnattu OC via ffmpeg-devel
Replaced by: https://ffmpeg.org//pipermail/ffmpeg-devel/2024-August/331962.html > On Aug 2, 2024, at 06:47, epira...@gmail.com wrote: > > > > On 2 Aug 2024, at 0:25, gnattu via ffmpeg-devel wrote: > >> From: Gnattu OC >> >> Allocate a dedicated attachm

Re: [FFmpeg-devel] [PATCH] avcodec/videotoolboxenc: always release supported_props

2024-08-15 Thread Gnattu OC via ffmpeg-devel
> On Aug 15, 2024, at 19:59, Zhao Zhili wrote: > > > >> On Aug 10, 2024, at 14:06, gnattu via ffmpeg-devel >> wrote: >> >> In vtenc_populate_extradata, supported_props should always be released >> to avoid memory leak. >> >> Re

Re: [FFmpeg-devel] [PATCH] libavdevice: fix compilation for Mac OS X 10.7-10.12, iOS < 11

2024-08-20 Thread Gnattu OC via ffmpeg-devel
> On Aug 21, 2024, at 07:17, epira...@gmail.com wrote: > > > > On 21 Aug 2024, at 0:43, Erik Bråthen Solem wrote: > >> avfoundation.m uses constants prefixed with AVMediaType on Mac OS X > 10.6. >> In 10.7 through 10.12 their type was NSString*, but starting with 10.13 a >> new AVMediaType st