Hi, it's been a while, can I get a review on this patch set? It would close
https://trac.ffmpeg.org/ticket/4448.
Thanks in advance!
Zsolt
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscr
It's done similarly to how the flac muxer does it, so I reused most of the code
and adapted it.
Signed-off-by: Zsolt Vadasz
---
libavformat/oggenc.c | 293 +--
1 file changed, 254 insertions(+), 39 deletions(-)
diff --git a/libavformat/oggenc.c b/libavfo
On Sunday, January 1st, 2023 at 10:41 AM, Jean-Baptiste Kempf
wrote:
> On Thu, 29 Dec 2022, at 22:05, Zsolt Vadász wrote:
>
> > It's done similarly to how the flac muxer does it, so I reused most of
> > the code and adapted it.
>
>
> Would a common function m
This patch fixes #9642.
Signed-off-by: Zsolt Vadasz
---
libavformat/oggparsevorbis.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/libavformat/oggparsevorbis.c b/libavformat/oggparsevorbis.c
index 061840c2ed..02be4e07b8 100644
--- a/libavformat/oggparsevorbis.c
+
Signed-off-by: Zsolt Vadasz
---
libavformat/flac_picture.c | 132 +++
libavformat/flac_picture.h | 5 +
libavformat/flacenc.c | 90 +---
libavformat/oggenc.c | 207 ++---
4 files changed, 308 insertions(+), 126 deletion
Signed-off-by: Zsolt Vadasz
---
libavformat/flac_picture.c | 132 +++
libavformat/flac_picture.h | 5 +
libavformat/flacenc.c | 90 +---
libavformat/oggenc.c | 207 ++---
4 files changed, 308 insertions(+), 126 deletion
Signed-off-by: Zsolt Vadasz
---
libavformat/flac_picture.c | 132 ++
libavformat/flac_picture.h | 5 +
libavformat/flacenc.c | 90 +--
libavformat/oggenc.c | 217 ++---
4 files changed, 319 insertions(+), 125 deletions(
This version can actually be applied to master. Also added checks to
ensure there won't be an OGGStreamContext for the cover art to suppress
warnings in mpv.
Signed-off-by: Zsolt Vadasz
---
libavformat/flac_picture.c | 132 ++
libavformat/flac_picture.h | 5 +
libavformat/f
This function is able to write cover art into both FLAC and Ogg files
Signed-off-by: Zsolt Vadasz
---
libavformat/flac_picture.c | 132 +
libavformat/flac_picture.h | 5 ++
libavformat/flacenc.c | 90 +
3 files changed, 140 inse
Fixes #4448. The cover art must have DISPOSITION_ATTACHED_PIC.
Signed-off-by: Zsolt Vadasz
---
libavformat/oggenc.c | 214 +++
1 file changed, 176 insertions(+), 38 deletions(-)
diff --git a/libavformat/oggenc.c b/libavformat/oggenc.c
index 2e582d0754..ac
Attached.From 1b7a510ff5720d21868f0284c7a50489034bee7d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zsolt=20Vad=C3=A1sz?=
Date: Fri, 10 Mar 2023 11:23:13 +
Subject: [PATCH v6 1/2] avformat/flac_picture: Add ff_flac_write_picture
This function is able to write cover art into both FLAC and Ogg file
Attached.From 38716e20b2e8b3a711cc22f7e7abc45731aa79b3 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Zsolt=20Vad=C3=A1sz?=
Date: Fri, 10 Mar 2023 11:26:27 +
Subject: [PATCH v6 2/2] avformat/oggenc: Add support for embedding cover art
Fixes #4448.
Signed-off-by: Zsolt Vadasz
---
libavformat/ogge
---
libavcodec/libjxlenc.c | 69 +++---
1 file changed, 45 insertions(+), 24 deletions(-)
diff --git a/libavcodec/libjxlenc.c b/libavcodec/libjxlenc.c
index 92a458d51a..6110c42a7c 100644
--- a/libavcodec/libjxlenc.c
+++ b/libavcodec/libjxlenc.c
@@ -50,6 +50,9 @
---
libavcodec/libjxlenc.c | 45 +-
1 file changed, 23 insertions(+), 22 deletions(-)
diff --git a/libavcodec/libjxlenc.c b/libavcodec/libjxlenc.c
index d707f3a61b..92a458d51a 100644
--- a/libavcodec/libjxlenc.c
+++ b/libavcodec/libjxlenc.c
@@ -49,6 +49,7 @
---
libavcodec/allcodecs.c | 1 +
libavcodec/libjxlenc.c | 197 -
2 files changed, 157 insertions(+), 41 deletions(-)
diff --git a/libavcodec/allcodecs.c b/libavcodec/allcodecs.c
index b0f004e15c..e6733b0d4f 100644
--- a/libavcodec/allcodecs.c
+++ b/libav
On Tuesday, December 12th, 2023 at 9:17 PM, Leo Izen wrote:
> On 12/11/23 12:05, Zsolt Vadász via ffmpeg-devel wrote:
>
> > ---
> > libavcodec/libjxlenc.c | 45 +-
> > 1 file changed, 23 insertions(+), 22 deletions(-)
> >
This patchset adds support for encoding animated JPEG XL images via a
new encoder (libjxl_animated). When using the encoder, the output format
needs to be set to raw video, as shown below:
`ffmpeg -i sample.gif -c:v libjxl_animated -f rawvideo out.jxl`
V2 changes:
- This version doesn't move the J
---
configure | 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/libjxlenc.c | 214 +
3 files changed, 177 insertions(+), 39 deletions(-)
diff --git a/configure b/configure
index 7d2ee66000..a334a9b1e0 100755
--- a/configure
+++ b/configure
@@
On Friday, December 15th, 2023 at 12:20 AM, Leo Izen wrote:
> > + AVFrame *last;
>
>
> I don't see the purpose of keeping this here.
>
The name is misleading, I should have named it `previous`, since it always
contains the previous frame.
I did it this way so I could call JxlEncoderCloseInp
On Friday, December 15th, 2023 at 10:12 PM, Leo Izen wrote:
> On 12/15/23 11:40, Zsolt Vadász via ffmpeg-devel wrote:
>
> > On Friday, December 15th, 2023 at 12:20 AM, Leo Izen leo.i...@gmail.com
> > wrote:
> >
> > > > + AVFrame *last;
> > >
On Friday, December 15th, 2023 at 11:18 PM, Leo Izen wrote:
> On 12/15/23 16:31, Zsolt Vadász via ffmpeg-devel wrote:
>
> > On Friday, December 15th, 2023 at 10:12 PM, Leo Izen leo.i...@gmail.com
> > wrote:
> >
> > > On 12/15/23 11:40, Zsolt Vadász via ffmp
---
configure | 1 +
libavcodec/allcodecs.c | 1 +
libavcodec/libjxlenc.c | 226 ++---
3 files changed, 189 insertions(+), 39 deletions(-)
diff --git a/configure b/configure
index 7d2ee66000..2d27d8015a 100755
--- a/configure
+++ b/configure
@@
consistency
- PTS is now calculated
- JxlFrameHeader.duration is calculated from PTS instead of relying on
AVFrame->duration being set
- This version also does not rely on AVCodecContext->frame_num either
- Disabled the container container format (JxlEncoderUseContainer)
Zsolt Vadász (1):
a
This version is basically
https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=10105
applied with a 3-way merge, squashed into a single commit,
with an added NULL check added at the end of
`ogg_finish_header`.
---
libavformat/flac_picture.c | 133 +++
libavformat/flac_pi
24 matches
Mail list logo
