Re: [FFmpeg-devel] [PATCH] avformat/argo_asf: Use memcpy to copy string without its NUL

2021-09-25 Thread Zane van Iperen
On 26/9/21 1:09 pm, Andreas Rheinhardt wrote: This avoids a -Wstringop-truncation warning from GCC which takes issue with the fact that the destination might not be NUL terminated. Signed-off-by: Andreas Rheinhardt --- libavformat/argo_asf.c | 20 +++- 1 file changed, 7 in

[FFmpeg-devel] [PATCH 1/2] avformat/argo_asf: pass name through as metadata

2021-10-11 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 5 + libavformat/argo_asf.h | 3 ++- tests/ref/acodec/adpcm-argo | 2 +- 3 files changed, 8 insertions(+), 2 deletions(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index 7e759c7c0c..f729a393ad 100644

[FFmpeg-devel] [PATCH 2/2] avformat/argo_asf: use title metadata when muxing

2021-10-11 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index f729a393ad..1171d9b7a7 100644 --- a/libavformat/argo_asf.c +++ b/libavformat/argo_asf.c

[FFmpeg-devel] [PATCH v2 1/3] avformat/argo_asf: cleanup and NULL-terminate name field in header

2021-10-12 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 8 libavformat/argo_asf.h | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index 7e759c7c0c..acf30839b9 100644 --- a/libavformat/argo_asf.c +++ b

[FFmpeg-devel] [PATCH v2 3/3] avformat/argo_asf: use title metadata when muxing

2021-10-12 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index 740680ece1..2b3569ebc3 100644 --- a/libavformat/argo_asf.c +++ b/libavformat/argo_asf.c @@ -358,14

[FFmpeg-devel] [PATCH v2 2/3] avformat/argo_asf: pass name through as metadata

2021-10-12 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 2 ++ tests/ref/acodec/adpcm-argo | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index acf30839b9..740680ece1 100644 --- a/libavformat/argo_asf.c +++ b

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/argo_asf: cleanup and NULL-terminate name field in header

2021-10-14 Thread Zane van Iperen
Will apply tomorrow if no objections. Zane On 12/10/21 9:02 pm, Zane van Iperen wrote: Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 8 libavformat/argo_asf.h | 3 ++- 2 files changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/argo_asf.c b

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/argo_asf: cleanup and NULL-terminate name field in header

2021-10-14 Thread Zane van Iperen
On 14/10/21 10:11 pm, "zhilizhao(赵志立)" wrote: typedef struct ArgoASFFileHeader { uint32_tmagic; /*< Magic Number, {'A', 'S', 'F', '\0'} */ @@ -40,7 +41,7 @@ typedef struct ArgoASFFileHeader { uint16_tversion_minor; /*< File Minor Version. */ uint32_tnum_chu

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/argo_asf: cleanup and NULL-terminate name field in header

2021-10-14 Thread Zane van Iperen
On 14/10/21 10:45 pm, "zhilizhao(赵志立)" wrote: } ArgoASFFileHeader; I failed to see why null-terminator is needed from the commit message or from the source code. See https://ffmpeg.org/pipermail/ffmpeg-devel/2021-October/286939.html Sorry for the noise, email client doesn’t show the patc

[FFmpeg-devel] [PATCH] fftools/ffplay: don't disable x11 compositing

2021-10-26 Thread Zane van Iperen
Prevents desktop stutters caused by the change (specifically on KDE). We're not a game, we don't actually need it disabled. Signed-off-by: Zane van Iperen --- fftools/ffplay.c | 4 1 file changed, 4 insertions(+) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index

Re: [FFmpeg-devel] [PATCH] avformat/scd: add demuxer

2021-11-12 Thread Zane van Iperen
Ping? Pretty sure most people didn't get this as I was making DMARC changes at the time. I can re-send if necessary. On 4/11/21 00:29, Zane van Iperen wrote: Adds demuxer for Square Enux SCD files. s/Enux/Enix/ Based off [1] and personal investigation. This has only been tested ag

Re: [FFmpeg-devel] [PATCH] avformat/scd: add demuxer

2021-11-22 Thread Zane van Iperen
Ping again? I'll merge in a few days if no objections. On 13/11/21 04:22, Zane van Iperen wrote: Ping? Pretty sure most people didn't get this as I was making DMARC changes at the time. I can re-send if necessary. On 4/11/21 00:29, Zane van Iperen wrote: Adds demuxer for Squar

Re: [FFmpeg-devel] [PATCH] avformat/scd: add demuxer

2021-11-22 Thread Zane van Iperen
On 23/11/21 16:18, Peter Ross wrote: index cbfadcb639..1054ac9667 100644 --- a/libavformat/allformats.c +++ b/libavformat/allformats.c @@ -392,6 +392,7 @@ extern const AVOutputFormat ff_sbc_muxer;   extern const AVInputFormat  ff_sbg_demuxer;   extern const AVInputFormat  ff_scc_demuxer;  

Re: [FFmpeg-devel] [PATCH] avformat/scd: add demuxer

2021-11-26 Thread Zane van Iperen
On 27/11/21 01:32, Andreas Rheinhardt wrote: Zane van Iperen: + +static int scd_seek(AVFormatContext *s, int stream_index, +int64_t pts, int flags) +{ +SCDDemuxContext *ctx = s->priv_data; +SCDTrackHeader *trk = ctx->tracks + stream_index; + +if (pt

[FFmpeg-devel] [PATCH v2] avformat/scd: add demuxer

2021-11-26 Thread Zane van Iperen
. [1]: http://ffxivexplorer.fragmenterworks.com/research/scd%20files.txt Signed-off-by: Zane van Iperen --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/scd.c| 378 +++ 3 files changed, 380 insertions(+) create mode

Re: [FFmpeg-devel] [PATCH v2] avformat/scd: add demuxer

2021-11-29 Thread Zane van Iperen
Ping, will apply in a few days if no objections. On 27/11/21 13:51, Zane van Iperen wrote: Adds demuxer for Square Enux SCD files. Based off [1] and personal investigation. This has only been tested against Drakengard 3 (PS3) *_SCD.XXX files (big-endian). As it is highly likely that FFXIV

[FFmpeg-devel] [PATCH 2/4] avformat: add demuxer for LEGO Racers' ALP format

2020-03-04 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/alp.c| 135 +++ libavformat/version.h| 4 +- 4 files changed, 139 insertions(+), 2 deletions(-) create mode 100644 libavformat

[FFmpeg-devel] [PATCH 3/4] changelog: add adpcm_ima_alp decoder and alp demuxer

2020-03-04 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Changelog b/Changelog index cb310a3abc..0503069daa 100644 --- a/Changelog +++ b/Changelog @@ -43,7 +43,8 @@ version : - Rayman 2 ADPCM decoder - Rayman 2 APM demuxer - cas video

[FFmpeg-devel] [PATCH 4/4] doc: add adpcm_ima_alp

2020-03-04 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- doc/general.texi | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/general.texi b/doc/general.texi index dbdc348598..87eaad7791 100644 --- a/doc/general.texi +++ b/doc/general.texi @@ -1100,6 +1100,7 @@ following image formats are supported: @item ADPCM

[FFmpeg-devel] [PATCH 0/4] High Voltage Software ALP demuxer + decoder.

2020-03-04 Thread Zane van Iperen
Adds support for the .TUN and .PCM files used by some High Voltage Software games. Zane van Iperen (4): avcodec: add decoder for High Voltage Software's ALP ADPCM avformat: add demuxer for LEGO Racers' ALP format changelog: add adpcm_ima_alp decoder and alp demuxer doc: add adp

[FFmpeg-devel] [PATCH 1/4] avcodec: add decoder for High Voltage Software's ALP ADPCM

2020-03-04 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/Makefile | 1 + libavcodec/adpcm.c | 36 libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/version.h| 4 ++-- 6 files changed, 48

Re: [FFmpeg-devel] [PATCH 2/4] avformat: add demuxer for LEGO Racers' ALP format

2020-03-04 Thread Zane van Iperen
On Thu, 5 Mar 2020 02:26:38 +0100 "Andreas Rheinhardt" wrote: > Am 05.03.2020 um 01:40 schrieb Zane van Iperen: > > Signed-off-by: Zane van Iperen > > --- > > libavformat/Makefile | 1 + > > libavformat/allformats.c | 1

[FFmpeg-devel] [PATCH v2 0/4] High Voltage Software ALP demuxer + decoder.

2020-03-07 Thread Zane van Iperen
Adds support for the .TUN and .PCM files used by some High Voltage Software games. v2: - check for header size and "ADPCM" magic in probe - error if sample rate > 44100 to catch possible overflow - don't allocate stream until after header is validated - formatting fixe

[FFmpeg-devel] [PATCH v2 1/4] avcodec: add decoder for High Voltage Software's ALP ADPCM

2020-03-07 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/Makefile | 1 + libavcodec/adpcm.c | 36 libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/version.h| 4 ++-- 6 files changed, 48

[FFmpeg-devel] [PATCH v2 2/4] avformat: add demuxer for LEGO Racers' ALP format

2020-03-07 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/alp.c| 146 +++ libavformat/version.h| 4 +- 4 files changed, 150 insertions(+), 2 deletions(-) create mode 100644 libavformat

[FFmpeg-devel] [PATCH v2 3/4] changelog: add adpcm_ima_alp decoder and alp demuxer

2020-03-07 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Changelog b/Changelog index cb310a3abc..0503069daa 100644 --- a/Changelog +++ b/Changelog @@ -43,7 +43,8 @@ version : - Rayman 2 ADPCM decoder - Rayman 2 APM demuxer - cas video

[FFmpeg-devel] [PATCH v2 4/4] doc: add adpcm_ima_alp

2020-03-07 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- doc/general.texi | 1 + 1 file changed, 1 insertion(+) diff --git a/doc/general.texi b/doc/general.texi index dbdc348598..87eaad7791 100644 --- a/doc/general.texi +++ b/doc/general.texi @@ -1100,6 +1100,7 @@ following image formats are supported: @item ADPCM

[FFmpeg-devel] [PATCH v3 0/2] High Voltage Software ALP demuxer + decoder.

2020-03-08 Thread Zane van Iperen
te > 44100 to catch possible overflow - don't allocate stream until after header is validated - formatting fixes Zane van Iperen (2): avcodec: add decoder for High Voltage Software's ALP ADPCM avformat: add demuxer for LEGO Racers' ALP format Changelog

[FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for LEGO Racers' ALP format

2020-03-08 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/alp.c| 146 +++ libavformat/version.h| 4 +- 5 files changed, 151 insertions(+), 2 deletions

[FFmpeg-devel] [PATCH v3 1/2] avcodec: add decoder for High Voltage Software's ALP ADPCM

2020-03-08 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 36 libavcodec/allcodecs.c | 1 + libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 7

[FFmpeg-devel] [PATCH] avformat/alp: tweak probe function to return MAX-1

2020-03-09 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavformat/alp.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/alp.c b/libavformat/alp.c index c0c7905380..4c2e8f0652 100644 --- a/libavformat/alp.c +++ b/libavformat/alp.c @@ -51,7 +51,7 @@ static int alp_probe(const

[FFmpeg-devel] [PATCH] fate/adpcm: add adpcm_ima_alp tests

2020-03-09 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- tests/fate/adpcm.mak| 6 ++ tests/ref/fate/adpcm-ima-alp-mono | 1 + tests/ref/fate/adpcm-ima-alp-stereo | 1 + 3 files changed, 8 insertions(+) create mode 100644 tests/ref/fate/adpcm-ima-alp-mono create mode 100644 tests/ref/fate/adpcm

[FFmpeg-devel] [PATCH] avcodec/adpcm: consolidate tables into adpcm_data.c

2020-03-10 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 67 +++-- libavcodec/adpcm_data.c | 29 ++ libavcodec/adpcm_data.h | 4 +++ 3 files changed, 51 insertions(+), 49 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: consolidate tables into adpcm_data.c

2020-03-10 Thread Zane van Iperen
On Tue, 10 Mar 2020 14:52:25 +0100 "Paul B Mahol" wrote: > I fail to see how useful this is. > Unless you plan to write encoder it is not useful. > It was just to clean things up a bit by keeping them together. Otherwise, 'tis no matter. Zane ___ ff

Re: [FFmpeg-devel] [PATCH] avcodec/adpcm: consolidate tables into adpcm_data.c

2020-03-10 Thread Zane van Iperen
On Tue, 10 Mar 2020 15:47:08 +0100 "Moritz Barsnick" wrote: > On Tue, Mar 10, 2020 at 14:15:26 +0000, Zane van Iperen wrote: > > It was just to clean things up a bit by keeping them together. > > Otherwise, 'tis no matter. > > Does it actually build? Not

[FFmpeg-devel] [PATCH 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-03-15 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 33 + libavcodec/adpcm_data.c | 13 + libavcodec/adpcm_data.h | 2 ++ libavcodec/allcodecs.c

[FFmpeg-devel] [PATCH 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-03-15 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/pp_bnk.c | 213 +++ libavformat/version.h| 2 +- 5 files changed, 217 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-03-15 Thread Zane van Iperen
Adds support for the soundbank files used by the Pro Pinball series of games. Please ping for review. Zane van Iperen (2): avcodec: add support for Cunning Developments' ADPCM avformat: add demuxer for Pro Pinball Series' Soundbanks Changelog| 2 + doc/ge

[FFmpeg-devel] [PATCH v2 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-03-18 Thread Zane van Iperen
Adds support for the soundbank files used by the Pro Pinball series of games. Please ping for review. v2: - Add sanity checks in header fields - Formatting and comment fixes - Change the struct names to match the files Zane van Iperen (2): avcodec: add support for Cunning Developments

[FFmpeg-devel] [PATCH v2 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-03-18 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 33 + libavcodec/adpcm_data.c | 13 + libavcodec/adpcm_data.h | 2 ++ libavcodec/allcodecs.c

[FFmpeg-devel] [PATCH v2 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-03-18 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/pp_bnk.c | 218 +++ libavformat/version.h| 2 +- 5 files changed, 222 insertions(+), 1 deletion

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-03-18 Thread Zane van Iperen
On Wed, 18 Mar 2020 15:19:19 +0100 "Carl Eugen Hoyos" wrote: > Am Mi., 18. März 2020 um 15:12 Uhr schrieb Zane van Iperen > : > > > > Signed-off-by: Zane van Iperen > > --- > > Changelog| 1 + > > libavformat/Makefile

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-03-18 Thread Zane van Iperen
On Wed, 18 Mar 2020 15:33:47 +0100 "Carl Eugen Hoyos" wrote: > Am Mi., 18. März 2020 um 15:30 Uhr schrieb Zane van Iperen > : > > > > On Wed, 18 Mar 2020 15:19:19 +0100 > > "Carl Eugen Hoyos" wrote: > > > > >

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-03-19 Thread Zane van Iperen
On Wed, 18 Mar 2020 16:05:40 +0100 "Andreas Rheinhardt" wrote: > > + > > +typedef struct PPBnkCtx { > > +int track_count; > > +PPBnkCtxTrack *tracks; > > +uint32_ti; > > How about using a more descriptive name for this like current_track? > Done. > > + > >

[FFmpeg-devel] [PATCH v3 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-03-19 Thread Zane van Iperen
header fields - Formatting and comment fixes - Change the struct names to match the files Zane van Iperen (2): avcodec: add support for Cunning Developments' ADPCM avformat: add demuxer for Pro Pinball Series' Soundbanks Changelog| 2 + doc/general.texi

[FFmpeg-devel] [PATCH v3 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-03-19 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/pp_bnk.c | 229 +++ libavformat/version.h| 2 +- 5 files changed, 233 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH v3 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-03-19 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 33 + libavcodec/adpcm_data.c | 13 + libavcodec/adpcm_data.h | 2 ++ libavcodec/allcodecs.c

[FFmpeg-devel] [PATCH] avformat/argo_asf: add missing #include

2020-03-20 Thread Zane van Iperen
Fixes the use of the implicit declaration of avpriv_request_sample(). Signed-off-by: Zane van Iperen --- libavformat/argo_asf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index 3339425244..cf1c7472c1 100644 --- a/libavformat/argo_asf.c

Re: [FFmpeg-devel] [PATCH] avformat/argo_asf: add missing #include

2020-03-20 Thread Zane van Iperen
On Fri, 20 Mar 2020 22:28:28 +0100 "Carl Eugen Hoyos" wrote: > Am Fr., 20. März 2020 um 16:53 Uhr schrieb Zane van Iperen > : > > > > Fixes the use of the implicit declaration > > of avpriv_request_sample(). > > I don't see such a warning... >

Re: [FFmpeg-devel] [PATCH v3 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-03-23 Thread Zane van Iperen
Hi all, Could I please get some reviews on this? Thanks, Zane On Thu, 19 Mar 2020 12:00:15 + "Zane van Iperen" wrote: > Adds support for the soundbank files used by the Pro Pinball series > of games. > > Please ping for review. > > v3: > - fix poten

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-03-24 Thread Zane van Iperen
On Mon, 23 Mar 2020 19:24:27 +0100 "Michael Niedermayer" wrote: > > + > > +const int16_t ff_adpcm_ima_cunning_index_table[8] = { > > +-1, -1, -1, -1, 1, 2, 3, 4, > > +}; > > this could be int8_t > Thanks, fixed. Will send a follow-up patch shortly. > https://ffmpeg.org/mailman/listinfo

[FFmpeg-devel] [PATCH v4 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-03-24 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/pp_bnk.c | 229 +++ libavformat/version.h| 2 +- 5 files changed, 233 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH v4 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-03-24 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 33 + libavcodec/adpcm_data.c | 13 + libavcodec/adpcm_data.h | 2 ++ libavcodec/allcodecs.c

[FFmpeg-devel] [PATCH v4 0/2] [PATCH v3 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-03-24 Thread Zane van Iperen
sanity checks in header fields - Formatting and comment fixes - Change the struct names to match the files Zane van Iperen (2): avcodec: add support for Cunning Developments' ADPCM avformat: add demuxer for Pro Pinball Series' Soundbanks Changelog| 2 + doc/ge

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-03-27 Thread Zane van Iperen
On Wed, 18 Mar 2020 15:19:19 +0100 "Carl Eugen Hoyos" wrote: > > Any restrictions on track_count and sample_rate that can be used for > auto-detection? > I've done a preliminary probe function. How's this? On all the files I tested, I received one of two values: 99 - For music (these have an e

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-03-29 Thread Zane van Iperen
On Sun, 29 Mar 2020 01:49:32 +0100 "Carl Eugen Hoyos" wrote: > Apart from what I wrote on irc: > What surprises me most is that iirc, you explained that the > sample_rate is written repeatedly to the file and is always identical > in one file. Why is that not checked? > The main reason is that

[FFmpeg-devel] [PATCH v5 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-03-29 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 33 + libavcodec/adpcm_data.c | 13 + libavcodec/adpcm_data.h | 2 ++ libavcodec/allcodecs.c

[FFmpeg-devel] [PATCH v5 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-03-29 Thread Zane van Iperen
efore updating state - remove unneeded check - naming fixes v2: - Add sanity checks in header fields - Formatting and comment fixes - Change the struct names to match the files Zane van Iperen (2): avcodec: add support for Cunning Developments' ADPCM avformat: add demuxer for P

[FFmpeg-devel] [PATCH v5 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-03-29 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/pp_bnk.c | 259 +++ libavformat/version.h| 2 +- 5 files changed, 263 insertions(+), 1 deletion

Re: [FFmpeg-devel] [PATCH v5 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-03-29 Thread Zane van Iperen
On Sun, 29 Mar 2020 18:21:37 +0200 "Michael Niedermayer" wrote: > On Sun, Mar 29, 2020 at 01:30:36PM +0000, Zane van Iperen wrote: > [...] > > > +static int pp_bnk_probe(const AVProbeData *p) > > +{ > > +uint32_t sample_rate = AV_RL32(p->buf + 4); &

[FFmpeg-devel] [PATCH v6 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-03-29 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 33 + libavcodec/adpcm_data.c | 13 + libavcodec/adpcm_data.h | 2 ++ libavcodec/allcodecs.c

[FFmpeg-devel] [PATCH v6 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-03-29 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/pp_bnk.c | 263 +++ libavformat/version.h| 2 +- 5 files changed, 267 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH v6 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-03-29 Thread Zane van Iperen
fix a buffer overread - attempt seek before updating state - remove unneeded check - naming fixes v2: - Add sanity checks in header fields - Formatting and comment fixes - Change the struct names to match the files Zane van Iperen (2): avcodec: add support for Cunning Developments&#

Re: [FFmpeg-devel] [PATCH v6 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-03 Thread Zane van Iperen
On Sun, 29 Mar 2020 17:18:08 + "Zane van Iperen" wrote: > Adds support for the soundbank files used by the Pro Pinball series > of games. > > Please CC for review. > > v6: > - fix tools/probetest failure > > v5: > - add probe function > -

Re: [FFmpeg-devel] [PATCH v6 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-06 Thread Zane van Iperen
On Mon, 6 Apr 2020 15:03:50 +0200 "Andreas Rheinhardt" wrote: > > > > I have a few minor changes but they're just slight comment changes, > > which aren't worth sending as a v7. I can send them as a separate > > patch afterwards. > > > This is not good as this separate patch would essentially j

Re: [FFmpeg-devel] [PATCH v6 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-06 Thread Zane van Iperen
On Mon, 06 Apr 2020 15:00:01 +0200 "Anton Khirnov" wrote: > Quoting Zane van Iperen (2020-03-29 19:18:20) > > Signed-off-by: Zane van Iperen > > +static int pp_bnk_read_header(AVFormatContext *s) > > +{ > > +int ret; > > +AVStream *st; > &g

[FFmpeg-devel] [PATCH v7 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-04-06 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 33 + libavcodec/adpcm_data.c | 13 + libavcodec/adpcm_data.h | 2 ++ libavcodec/allcodecs.c

[FFmpeg-devel] [PATCH v7 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-06 Thread Zane van Iperen
- naming fixes v2: - Add sanity checks in header fields - Formatting and comment fixes - Change the struct names to match the files Zane van Iperen (2): avcodec: add support for Cunning Developments' ADPCM avformat: add demuxer for Pro Pinball Series' Soundbanks Changelog

[FFmpeg-devel] [PATCH v7 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-06 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/pp_bnk.c | 271 +++ libavformat/version.h| 2 +- 5 files changed, 275 insertions(+), 1 deletion

Re: [FFmpeg-devel] [PATCH v7 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-07 Thread Zane van Iperen
On Mon, 6 Apr 2020 17:39:13 +0200 "Andreas Rheinhardt" wrote: > > +/* Parse and validate each track. */ > > +for (int i = 0; i < hdr.track_count; i++) { > > +PPBnkTrack e; > > + > > +if ((ret = avio_read(s->pb, buf, PP_BNK_TRACK_SIZE)) < 0) { > > +goto done; >

[FFmpeg-devel] [PATCH v8 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-04-07 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 33 + libavcodec/adpcm_data.c | 13 + libavcodec/adpcm_data.h | 2 ++ libavcodec/allcodecs.c

[FFmpeg-devel] [PATCH v8 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-07 Thread Zane van Iperen
- fix potential memory leak if read_header() fails - fix a buffer overread - attempt seek before updating state - remove unneeded check - naming fixes v2: - Add sanity checks in header fields - Formatting and comment fixes - Change the struct names to match the files Zane van Iperen (

[FFmpeg-devel] [PATCH v8 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-07 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/pp_bnk.c | 290 +++ libavformat/version.h| 2 +- 5 files changed, 294 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH 2/2] avformat: add kvag muxer

2020-04-09 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/kvag.c | 78 +++- libavformat/version.h| 2 +- 5 files changed, 81 insertions(+), 2 deletions(-) diff

[FFmpeg-devel] [PATCH 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-09 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 30 ++ libavcodec/allcodecs.c | 1 + libavcodec/utils.c | 1 + libavcodec/version.h | 4 ++-- 7 files

[FFmpeg-devel] [PATCH v2 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-10 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 30 ++ libavcodec/allcodecs.c | 1 + libavcodec/utils.c | 1 + libavcodec/version.h | 4 ++-- 7 files

[FFmpeg-devel] [PATCH v2 2/2] avformat: add kvag muxer

2020-04-10 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/kvag.c | 84 +++- libavformat/version.h| 2 +- 5 files changed, 87 insertions(+), 2 deletions(-) diff

[FFmpeg-devel] [PATCH v3 2/2] avformat: add kvag muxer

2020-04-10 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/kvag.c | 84 +++- libavformat/version.h| 2 +- 5 files changed, 87 insertions(+), 2 deletions(-) diff

[FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-10 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi | 2 +- libavcodec/Makefile| 1 + libavcodec/adpcmenc.c | 30 ++ libavcodec/allcodecs.c | 1 + libavcodec/utils.c | 1 + libavcodec/version.h | 2 +- 7 files

[FFmpeg-devel] [PATCH] avcodec/adpcm: remove unused shift parameter from adpcm_ima_qt_expand_nibble()

2020-04-11 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index e9abddc43c..ee18875579 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -348,7 +348,7 @@ static

Re: [FFmpeg-devel] [PATCH v8 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-11 Thread Zane van Iperen
On Tue, 07 Apr 2020 10:48:53 + "Zane van Iperen" wrote: > Adds support for the soundbank files used by the Pro Pinball series > of games. > > Please CC for review. > > v8: > - change "goto done" to a return + "goto fail" > - H

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-11 Thread Zane van Iperen
On Fri, 10 Apr 2020 12:26:50 + "Zane van Iperen" wrote: > Signed-off-by: Zane van Iperen > --- > Changelog | 1 + > doc/general.texi | 2 +- > libavcodec/Makefile| 1 + > libavcodec/adpcmenc.c | 30 ++ &g

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-12 Thread Zane van Iperen
On Sat, 11 Apr 2020 22:02:26 +0200 "Paul B Mahol" wrote: > > > > Ping. > > > > Also, could someone please clarify something for me? > > > > When encoding, there's no inherit differences between trellis and > > non-trellis other then a potentially more-accurate set of nibbles? > > > > And the deco

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-12 Thread Zane van Iperen
On Sun, 12 Apr 2020 11:41:40 +0200 "Paul B Mahol" wrote: > On 4/12/20, Zane van Iperen wrote: > > On Sat, 11 Apr 2020 22:02:26 +0200 > > "Paul B Mahol" wrote: > > > >> > > >> > Ping. > >> > > >> > Als

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-12 Thread Zane van Iperen
On Sun, 12 Apr 2020 15:01:39 +0200 "Paul B Mahol" wrote: > > > > I probably should have mentioned that yes, I had already added the > > appropriate SSI code to adpcm_compress_trellis(). > > The one that updates node predictor? > > > > Yep, wherever there was a check for QT, I added a check for

Re: [FFmpeg-devel] [PATCH v3 1/2] avcodec: add adpcm_ima_ssi encoder

2020-04-12 Thread Zane van Iperen
On Sun, 12 Apr 2020 16:38:06 +0200 "Paul B Mahol" wrote: > On 4/12/20, Zane van Iperen wrote: > > On Sun, 12 Apr 2020 15:01:39 +0200 > > "Paul B Mahol" wrote: > > > >> > > >> > I probably should have mentioned

Re: [FFmpeg-devel] [PATCH v8 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-15 Thread Zane van Iperen
On Tue, 07 Apr 2020 10:48:53 + "Zane van Iperen" wrote: > Adds support for the soundbank files used by the Pro Pinball series > of games. > Ping 2. Could I please have some reviews on this, it's been over a week. I have a rebased version here, if required: ht

Re: [FFmpeg-devel] [PATCH v8 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-04-15 Thread Zane van Iperen
On Wed, 15 Apr 2020 19:31:44 +0200 "Michael Niedermayer" wrote: > On Tue, Apr 07, 2020 at 10:48:58AM +0000, Zane van Iperen wrote: > > Signed-off-by: Zane van Iperen > > --- > > Changelog | 1 + > > doc/general.texi|

[FFmpeg-devel] [PATCH v9 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-16 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/pp_bnk.c | 293 +++ libavformat/version.h| 2 +- 5 files changed, 297 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH v9 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-04-16 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 34 ++ libavcodec/adpcm_data.c | 13 + libavcodec/adpcm_data.h | 2 ++ libavcodec/allcodecs.c

[FFmpeg-devel] [PATCH v9 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-16 Thread Zane van Iperen
://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/259864.html [5]: https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/259863.html [6]: https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/260706.html Zane van Iperen (2): avcodec: add support for Cunning Developments' ADPCM avformat:

Re: [FFmpeg-devel] [PATCH v8 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-04-16 Thread Zane van Iperen
On Thu, 16 Apr 2020 21:37:54 +0200 "Michael Niedermayer" wrote: > > > > @@ -1304,6 +1329,13 @@ static int > > > > adpcm_decode_frame(AVCodecContext *avctx, void *data, samples > > > > += avctx->channels; } > > > > break; > > > > +case AV_CODEC_ID_ADPCM_IMA_CUNNING: > > > > +w

Re: [FFmpeg-devel] [PATCH v8 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-04-17 Thread Zane van Iperen
On Fri, 17 Apr 2020 18:50:05 +0200 "Michael Niedermayer" wrote: > On Thu, Apr 16, 2020 at 11:39:00PM +0000, Zane van Iperen wrote: > > On Thu, 16 Apr 2020 21:37:54 +0200 > > "Michael Niedermayer" wrote: > > > > > > > > @@ -1

[FFmpeg-devel] [PATCH v10 2/2] avformat: add demuxer for Pro Pinball Series' Soundbanks

2020-04-17 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog| 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/pp_bnk.c | 293 +++ libavformat/version.h| 2 +- 5 files changed, 297 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH v10 1/2] avcodec: add support for Cunning Developments' ADPCM

2020-04-17 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- Changelog | 1 + doc/general.texi| 1 + libavcodec/Makefile | 1 + libavcodec/adpcm.c | 33 + libavcodec/adpcm_data.c | 13 + libavcodec/adpcm_data.h | 2 ++ libavcodec/allcodecs.c

[FFmpeg-devel] [PATCH v10 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-17 Thread Zane van Iperen
evel/2020-March/259278.html [4]: https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/259864.html [5]: https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/259863.html [6]: https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/260706.html [7]: https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/2

[FFmpeg-devel] [PATCH 1/2] avcodec/adpcm_ima_{apc, ssi, oki}: replace while() with for()

2020-04-17 Thread Zane van Iperen
Per discussion at https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/260854.html Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index ee18875579..7d35884056 100644 --- a

[FFmpeg-devel] [PATCH 2/2] avcodec/adpcm: update get_nb_samples() doc

2020-04-17 Thread Zane van Iperen
Signed-off-by: Zane van Iperen --- libavcodec/adpcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index 7d35884056..9ea6a268eb 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -668,7 +668,7 @@ static inline int16_t

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/adpcm_ima_{apc, ssi, oki}: replace while() with for()

2020-04-19 Thread Zane van Iperen
On Sat, 18 Apr 2020 00:59:25 + "Zane van Iperen" wrote: > Per discussion at > https://ffmpeg.org/pipermail/ffmpeg-devel/2020-April/260854.html > > Signed-off-by: Zane van Iperen > --- > libavcodec/adpcm.c | 6 +++--- > 1 file changed, 3 insertions(+)

Re: [FFmpeg-devel] [PATCH v10 0/2] Pro Pinball Series Soundbank demuxer + decoder.

2020-04-21 Thread Zane van Iperen
On Sat, 18 Apr 2020 00:20:30 + "Zane van Iperen" wrote: > > Zane van Iperen (2): > avcodec: add support for Cunning Developments' ADPCM > avformat: add demuxer for Pro Pinball Series' Soundbanks > > Changelog| 2 + > doc/g

  1   2   3   4   5   6   7   >