Re: [FFmpeg-devel] fftools/ffmpeg_optc AVDictionary **opts, If memory allocation fails,

2021-12-03 Thread Yy
> 2021年12月3日 下午5:42,Andreas Rheinhardt 写道: > > Yu Yang: >> Opts is assigned by setup_find_stream_info_opts(). Opts may be NULL. >> This situation is compatible in avformat_find_stream_info(). >> Before av_dict_free(), the necessary checks were ignored. >> >> // in fftools/ffmpeg_opt.c:1266 >>

Re: [FFmpeg-devel] [PATCH] libavcodec/avpacketc packet release exception

2021-12-03 Thread Yy
> 2021年12月3日 下午5:45,Andreas Rheinhardt 写道: > > Yu Yang: >> 'pkt' and '*pkt' should be judged separately for release. >> SEGV by a READ memory access (address points to the zero page) >> >> ```c >> // in fftools/ffmpeg.c:515 >> 515 static void ffmpeg_cleanup(int ret) >> 516 { >> ... >>

Re: [FFmpeg-devel] [PATCH] Exception when frame is set NULL

2021-12-03 Thread Yy
> 2021年12月3日 下午6:04,Andreas Rheinhardt 写道: > > Yu Yang: >> fftools/ffmpegc When `ost->last_frame` is NULL, 'SEGV' occurs when >> accessing its pts. >> >> libavutil/framec `ost->last_frame` may be set NULL by av_frame_alloc(). In >> this situation, >> av_frame_unref() and av_

Re: [FFmpeg-devel] [PATCH v2] fftools/cmdutils: Avoid crash when opts is empty

2021-12-05 Thread Yy
> 2021年12月5日 下午6:56,Andreas Rheinhardt 写道: > > Yu Yang: >> Opts is assigned by setup_find_stream_info_opts(). Could not get opts when >> nb_streams == 0. >> It should not return NULL but print AV_LOG_ERROR. when no alloc memory for >> stream options, >> it also need return an error to avoid c

Re: [FFmpeg-devel] fftools/ffmpeg_optc AVDictionary **opts, If memory allocation fails,

2021-12-06 Thread Yy
> 2021年12月3日 下午8:06,Yy 写道: > > > >> 2021年12月3日 下午5:42,Andreas Rheinhardt > <mailto:andreas.rheinha...@outlook.com>> 写道: >> >> Yu Yang: >>> Opts is assigned by setup_find_stream_info_opts(). Opts may be NULL. >>> This situati

Re: [FFmpeg-devel] fftools/ffmpeg_optc AVDictionary **opts, If memory allocation fails,

2021-12-06 Thread Yy
> 2021年12月7日 上午1:48,Andreas Rheinhardt 写道: > > Yy: >> >> >>> 2021年12月3日 下午8:06,Yy 写道: >>> >>> >>> >>>> 2021年12月3日 下午5:42,Andreas Rheinhardt >>> <mailto:andreas.rheinha...@outlook.com>> 写道: >&g

Re: [FFmpeg-devel] [PATCH v3] fftools/opts: Avoid crash when opts could not be allocated

2021-12-07 Thread Yy
> 2021年12月7日 下午5:00,Andreas Rheinhardt 写道: > > Yu Yang: >> If 'opts' could not be allocated, exiting the program to avoid crash when >> release it. >> Before setup_find_stream_info_opts(), checking 'orig_nb_streams' is > 0. >> If 'orig_nb_streams' == 0, it doesn't need 'opts' to getting strea

Re: [FFmpeg-devel] [PATCH] libswresample/swresamplec: Err num(negative-size) was used as a function parameter

2021-12-07 Thread Yy
> 2021年12月7日 下午7:25,Michael Niedermayer 写道: > > On Mon, Dec 06, 2021 at 08:21:42PM +0800, Yu Yang wrote: >> If cannot allocate memory, ERROR(ENOMEM) '-12' as a parameter will be >> constantly being returned. >> When run resample() firstly, negative size param would cause buffer-overflow >> an

Re: [FFmpeg-devel] [PATCH] libswresample/swresamplec: Err num(negative-size) was used as a function parameter

2021-12-07 Thread Yy
> 2021年12月7日 下午8:42,Michael Niedermayer 写道: > > On Tue, Dec 07, 2021 at 08:12:53PM +0800, Yy wrote: >> >> >>> 2021年12月7日 下午7:25,Michael Niedermayer 写道: >>> >>> On Mon, Dec 06, 2021 at 08:21:42PM +0800, Yu Yang wrote: >>>> If can

Re: [FFmpeg-devel] [PATCH v2] libswresample/swresamplec: Err num(negative-size) was used as a function parameter

2021-12-09 Thread Yy
> 2021年12月9日 下午8:10,Michael Niedermayer 写道: > > On Wed, Dec 08, 2021 at 11:17:13AM +0800, Yu Yang wrote: >> If cannot allocate memory, ERROR(ENOMEM) '-12' as a parameter will be >> constantly being returned. >> When run resample() firstly, negative size param would cause buffer-overflow >> an

Re: [FFmpeg-devel] [PATCH v4] fftools/opts: Avoid crash when opts could not be allocated

2021-12-13 Thread Yy
Ping for patch v4: fftools/opts: Avoid crash when opts could not be allocated. > 2021年12月8日 上午10:35,Yu Yang 写道: > > If 'opts' could not be allocated, exiting the program to avoid crash when > release it. > Before setup_find_stream_info_opts(), checking 'orig_nb_streams' is > 0. > > Reported-

Re: [FFmpeg-devel] [PATCH] libavcodec/pthread_framec: remove duplicate pointers

2021-12-19 Thread Yy
Ping for this patch. -Yu Yang > 2021年12月15日 上午10:17,Yu Yang 写道: > > From: Yu Yang > > '*src' and '*avctx' point to the same memory. It is enough to keep one of > them. > > Signed-off-by: Yu Yang > --- > libavcodec/pthread_frame.c | 13 ++--- > 1 file changed, 6 insertions(+), 7 delet

Re: [FFmpeg-devel] [PATCH] libavcodec/pthread_framec: remove duplicate pointers

2021-12-23 Thread Yy
Ping for this patch. May be my understanding of this part is not correct enough, Please tell me, thx -Yu Yang > 2021年12月20日 上午11:03,Yy 写道: > > Ping for this patch. > -Yu Yang > >> 2021年12月15日 上午10:17,Yu Yang 写道: >> >> From: Yu Yang >> >> '