Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-17 Thread Vitaly Buka via ffmpeg-devel
19:12, Vitaly Buka via ffmpeg-devel wrote: > > UBSAN by default is just prints a mesage and > > moves on. This hides a few UBs in fate-suite. > > > > Signed-off-by: Vitaly Buka > > --- > > configure | 4 ++-- > > libavcodec/aacen

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-17 Thread Vitaly Buka via ffmpeg-devel
On Fri, Jan 17, 2025 at 3:12 PM James Almer wrote: > On 1/17/2025 7:53 PM, Vitaly Buka via ffmpeg-devel wrote: > > My confusion here is that it looks like ffmpeg developers care about UB, > I > > see from time to time large cleanups, but there are a bunch of unfixed >

Re: [FFmpeg-devel] [PATCH] avcodec/hevc/hevcdec: Don't add to null pointer

2025-01-29 Thread Vitaly Buka via ffmpeg-devel
Hello, Would it be possible to merge this patch? Thanks, Vitaly ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subje

[FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
UBSAN by default is just prints a mesage and moves on. This hides a few UBs in fate-suite. Signed-off-by: Vitaly Buka --- configure | 4 ++-- libavcodec/aacenc_pred.c | 1 + libavcodec/ffv1dec.c | 1 + libavcodec/ffv1enc_template.c | 1 + libavcodec/get_bits.h

[FFmpeg-devel] [PATCH 1/2] .gitignore: ignore fate-suite

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
Signed-off-by: Vitaly Buka --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 9cfc78b414..6fcbddad3c 100644 --- a/.gitignore +++ b/.gitignore @@ -43,3 +43,4 @@ /tools/python/__pycache__/ /libavcodec/vulkan/*.c /libavfilter/vulkan/*.c +/fate-suite/

Re: [FFmpeg-devel] [PATCH 2/2] configure: Use -fno-sanitize-recover

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
I assume "recover" mode is there unintentionally. "-fno-sanitize-recover" helps to keep the code clean. On Thu, Jan 16, 2025 at 11:13 AM Vitaly Buka wrote: > UBSAN by default is just prints a mesage and > moves on. This hides a few UBs in fate-suite. > > Signed-off-by: Vitaly Buka > --- > conf

[FFmpeg-devel] [PATCH] avcodec/hevc/hevcdec: Don't add to null pointer

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
`POS(1,` and `POS(2,` may trigger UBSAN report: "runtime error: applying non-zero offset 304 to null pointer" Looks like values are not used without `chroma_format_idc`, so maybe there is no other issues than the UB. Can't reproduce with "fate". Signed-off-by: Vitaly Buka --- libavcodec/hevc/h

Re: [FFmpeg-devel] [PATCH 1/2] .gitignore: ignore fate-suite

2025-01-16 Thread Vitaly Buka via ffmpeg-devel
Sorry, I messed up my subscription, so will reply slightly off-thread. Timo Rothenpieler via ffmpeg-devel wrote: > I don't think the fate-suite should be sitting in the source tree. > Also, there is no guarantee every user/developer will name it that exact > name? Or is that where it gets synce