Re: [FFmpeg-devel] [PATCH 4/6] lavc/libvpxenc: remove redundant condition check

2019-05-10 Thread Vignesh Venkatasubramanian
From: Jun Zhao Date: Fri, May 10, 2019 at 9:06 AM To: Cc: Jun Zhao > From: Jun Zhao > > Redundant condition: '!A || B' is equivalent to '!A || (A && B)' but > more clearly. > > Signed-off-by: Jun Zhao > --- > libavcodec/libvpxenc.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-)

[FFmpeg-devel] [PATCH] webm_dash_manifest: Add option to specify bandwidth

2017-04-11 Thread Vignesh Venkatasubramanian
Add an option to webm_dash_manifest demuxer to specify a value for "bandwidth" field in the DASH manifest. The value is then used by the muxer. Fixes an existing FIXME in the code. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/matroskadec.c

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest_demuxer: Fix initialization range for files with cues at the front

2017-04-24 Thread Vignesh Venkatasubramanian
On Fri, Apr 21, 2017 at 8:40 AM, Derek Buitenhuis wrote: > The WebM DASH spec states: > The Initialization Segment shall not contain Clusters or Cues. > The Segment Index corresponds to the Cues. > > Previously, it included the cues if they were at the front. Looks good. Thanks. > > Sign

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest_demuxer: Fix UB in cue timestamp string code and make it actually work

2017-04-24 Thread Vignesh Venkatasubramanian
On Thu, Apr 20, 2017 at 7:02 AM, Derek Buitenhuis wrote: > The original author apparently never read the documentation for snprintf, > or even tested that the output was correct. I was the original author and i am sorry about the mistake. > Passing overlapping memory > to snprintf causes undefin

Re: [FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-14 Thread Vignesh Venkatasubramanian
On Tue, Jul 12, 2016 at 12:22 PM, James Almer wrote: > On 7/12/2016 3:48 PM, Vignesh Venkatasubramanian wrote: >> VPx (VP8/VP9) alpha encoding has been part of FFmpeg. Now, add the >> ability to decode such files with alpha channel. >> >> Signed-off-by:

[FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-14 Thread Vignesh Venkatasubramanian
VPx (VP8/VP9) alpha encoding has been part of FFmpeg. Now, add the ability to decode such files with alpha channel. Signed-off-by: Vignesh Venkatasubramanian --- libavcodec/libvpxdec.c | 102 +++-- 1 file changed, 82 insertions(+), 20 deletions

Re: [FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-14 Thread Vignesh Venkatasubramanian
On Tue, Jul 12, 2016 at 1:47 PM, James Almer wrote: > On 7/12/2016 3:48 PM, Vignesh Venkatasubramanian wrote: >> VPx (VP8/VP9) alpha encoding has been part of FFmpeg. Now, add the >> ability to decode such files with alpha channel. >> >> Signed-off-by:

[FFmpeg-devel] [PATCH] webm_chunk: Set pts precision to milliseconds

2016-08-22 Thread Vignesh Venkatasubramanian
Milliseconds is the de-factor precision for timestamps in Matroska/WebM media. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/webm_chunk.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/webm_chunk.c b/libavformat/webm_chunk.c index 9db4fab..44a1695 100644 --- a

Re: [FFmpeg-devel] [PATCH] webm_chunk: Set pts precision to milliseconds

2016-08-25 Thread Vignesh Venkatasubramanian
On Mon, Aug 22, 2016 at 5:13 PM, Vignesh Venkatasubramanian wrote: > Milliseconds is the de-factor precision for timestamps in > Matroska/WebM media. > > Signed-off-by: Vignesh Venkatasubramanian > --- > libavformat/webm_chunk.c | 5 + > 1 file changed, 5 insertion

[FFmpeg-devel] [PATCH] libavformat/webm_chunk: Option to specify HTTP header

2016-09-13 Thread Vignesh Venkatasubramanian
Add an option to specify HTTP header in the WebM Chunk Muxer (this works the same way as the 'method' parameter in the HLS muxer). Signed-off-by: Vignesh Venkatasubramanian --- libavformat/webm_chunk.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) di

[FFmpeg-devel] [PATCH] libavformat/webm_chunk: Option to specify HTTP header

2016-09-15 Thread Vignesh Venkatasubramanian
Add an option to specify HTTP header in the WebM Chunk Muxer (this works the same way as the 'method' parameter in the HLS muxer). Signed-off-by: Vignesh Venkatasubramanian --- libavformat/webm_chunk.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) di

Re: [FFmpeg-devel] [PATCH] libavformat/webm_chunk: Option to specify HTTP header

2016-09-15 Thread Vignesh Venkatasubramanian
On Wed, Sep 14, 2016 at 8:46 AM, Carl Eugen Hoyos wrote: > > 2016-09-13 22:12 GMT+02:00 Vignesh Venkatasubramanian > : > > Add an option to specify HTTP header in the WebM Chunk Muxer > > > (this works the same way as the 'method' parameter in the HLS muxer).

Re: [FFmpeg-devel] [PATCH] Add support for vp9 in iso-bmff

2016-06-13 Thread Vignesh Venkatasubramanian
On Sat, Jun 11, 2016 at 2:22 PM, Ronald S. Bultje wrote: > > Hi, > > On Fri, Jun 10, 2016 at 6:25 PM, Kongqun Yang wrote: > > > Implemented according to the draft specification > > "VP Codec ISO Media File Format Binding": > > > > http://www.webmproject.org/vp9/#draft-vp-codec-iso-media-file-form

[FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-06-30 Thread Vignesh Venkatasubramanian
Chrome canary now supports decoding of VP9 streams with alpha channel [1]. Add support to ffmpeg for creating such files. [1] https://codereview.chromium.org/2096813002/ Signed-off-by: Vignesh Venkatasubramanian --- libavcodec/libvpx.c| 3 +++ libavcodec/libvpxenc.c | 1 + 2 files changed

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-07-01 Thread Vignesh Venkatasubramanian
On Thu, Jun 30, 2016 at 10:37 PM, James Zern wrote: > On Thu, Jun 30, 2016 at 4:16 PM, Vignesh Venkatasubramanian > wrote: >> Chrome canary now supports decoding of VP9 streams with alpha >> channel [1]. Add support to ffmpeg for creating such files. >> >> [1] h

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-07-01 Thread Vignesh Venkatasubramanian
On Fri, Jul 1, 2016 at 11:06 AM, James Almer wrote: > On 7/1/2016 2:53 PM, Ronald S. Bultje wrote: >> Hi, >> >> On Fri, Jul 1, 2016 at 1:40 PM, James Zern >> wrote: >> >>> On Fri, Jul 1, 2016 at 10:07 AM, Carl Eugen Hoyos >>> wrote: > Do we have decoder support (for either vp8 or vp9) for th

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-07-01 Thread Vignesh Venkatasubramanian
On Fri, Jul 1, 2016 at 12:48 PM, Ronald S. Bultje wrote: > Hi, > > On Fri, Jul 1, 2016 at 3:29 PM, Ronald S. Bultje wrote: > >> Hi, >> >> On Fri, Jul 1, 2016 at 3:12 PM, Vignesh Venkatasubramanian < >> vigneshv-at-google@ffmpeg.org> wrote: >>

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-07-06 Thread Vignesh Venkatasubramanian
On Fri, Jul 1, 2016 at 3:03 PM, Ronald S. Bultje wrote: > Hi, > > On Fri, Jul 1, 2016 at 5:27 PM, Vignesh Venkatasubramanian < > vigneshv-at-google@ffmpeg.org> wrote: > >> On Fri, Jul 1, 2016 at 12:48 PM, Ronald S. Bultje >> wrote: >> > Hi, >>

[FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-07 Thread Vignesh Venkatasubramanian
VPx (VP8/VP9) alpha encoding has been part of FFmpeg. Now, add the ability to decode such files with alpha channel. Signed-off-by: Vignesh Venkatasubramanian --- libavcodec/libvpxdec.c | 111 --- tests/fate/vpx.mak | 3 + tests/ref/fate

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-07-07 Thread Vignesh Venkatasubramanian
On Wed, Jul 6, 2016 at 4:50 PM, Vignesh Venkatasubramanian wrote: > On Fri, Jul 1, 2016 at 3:03 PM, Ronald S. Bultje wrote: >> Hi, >> >> On Fri, Jul 1, 2016 at 5:27 PM, Vignesh Venkatasubramanian < >> vigneshv-at-google@ffmpeg.org> wrote: >> >&g

[FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-12 Thread Vignesh Venkatasubramanian
VPx (VP8/VP9) alpha encoding has been part of FFmpeg. Now, add the ability to decode such files with alpha channel. Signed-off-by: Vignesh Venkatasubramanian --- libavcodec/libvpxdec.c | 102 +--- tests/fate/vpx.mak | 3 + tests/ref/fate/vp8

Re: [FFmpeg-devel] [PATCH] libavcodec/libvpx: Add VPx alpha decode support

2016-07-12 Thread Vignesh Venkatasubramanian
On Mon, Jul 11, 2016 at 5:55 PM, James Zern wrote: > On Thu, Jul 7, 2016 at 11:43 AM, Vignesh Venkatasubramanian > wrote: >> VPx (VP8/VP9) alpha encoding has been part of FFmpeg. Now, add the >> ability to decode such files with alpha channel. >> >> Signed-off-

Re: [FFmpeg-devel] [PATCH] libvpx: Enable vp9 alpha encoding

2016-07-12 Thread Vignesh Venkatasubramanian
On Thu, Jul 7, 2016 at 12:02 PM, Ronald S. Bultje wrote: > Hi Vignesh, > > On Thu, Jul 7, 2016 at 2:44 PM, Vignesh Venkatasubramanian < > vigneshv-at-google@ffmpeg.org> wrote: > >> On Wed, Jul 6, 2016 at 4:50 PM, Vignesh Venkatasubramanian >> wrote: &g

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-02-02 Thread Vignesh Venkatasubramanian
On Tue, Jan 31, 2017 at 10:18 PM, wm4 wrote: > > On Tue, 31 Jan 2017 12:02:01 -0800 > Chris Cunningham wrote: > > > Thanks for taking a look. > > > > Definitely missing a "break;" - will fix in subsequent patch. > > > > Agree timestamps should be relative (didn't realize this). Vignesh points > >

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-02-03 Thread Vignesh Venkatasubramanian
On Thu, Feb 2, 2017 at 10:16 PM, wm4 wrote: > On Thu, 2 Feb 2017 10:47:52 -0800 > Vignesh Venkatasubramanian wrote: > >> On Tue, Jan 31, 2017 at 10:18 PM, wm4 wrote: >> > >> > On Tue, 31 Jan 2017 12:02:01 -0800 >> > Chris Cunningham w

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: fix is_keyframe for early Blocks

2017-02-03 Thread Vignesh Venkatasubramanian
On Fri, Feb 3, 2017 at 2:42 PM, Chris Cunningham wrote: > Blocks are marked as key frames whenever the "reference" field is > zero. This breaks for non-keyframe Blocks with a reference timestamp > of zero. > > The likelihood of reference timestamp being zero is increased by a > longstanding bug in

[FFmpeg-devel] [PATCH 2/2] fate: Add basic tests for WebM Dash Manifest

2014-08-25 Thread Vignesh Venkatasubramanian
Add fate tests that test out the functionality of WebM DASH Manifest XML generation. This patch contains the vpx.mak file changes and the reference gold XML files. --- tests/fate/vpx.mak | 9 tests/ref/fate/webm-dash-manifest | 48

Re: [FFmpeg-devel] [PATCH 1/2] fate-run.sh: add function to execute raw ffmpeg command

2014-08-25 Thread Vignesh Venkatasubramanian
On Mon, Aug 25, 2014 at 1:17 PM, Timothy Gu wrote: > On Mon, Aug 25, 2014 at 12:27 PM, Vignesh Venkatasubramanian > wrote: >> add ffmpeg_raw() function to fate-run.sh which will run the exact >> ffmpeg command as specified in the *.mak file without any changes. >> --- &

Re: [FFmpeg-devel] [PATCH 2/2] fate: Add basic tests for WebM Dash Manifest

2014-08-26 Thread Vignesh Venkatasubramanian
On Mon, Aug 25, 2014 at 4:35 PM, Lou Logan wrote: > On Mon, 25 Aug 2014 16:26:16 -0700, Vignesh Venkatasubramanian wrote: > >> i sent the files associated with this fate test as a tarball to this >> mailing list and got a reply saying "message is awaiting moderator

[FFmpeg-devel] [PATCH 1/3] lavf/webm_dash: fix hardcode in cues_end computation

2014-10-01 Thread Vignesh Venkatasubramanian
Fix an incorrect hard code in cues_end computation. Updating the fate test reference files related to the fix as well. The earlier computation was clearly wrong as the cues_end field was greater than the file size itself in some cases. Signed-off-by: Vignesh Venkatasubramanian --- libavformat

Re: [FFmpeg-devel] [PATCH] Fix writing first audio Cues in dash mode.

2014-10-09 Thread Vignesh Venkatasubramanian
On Thu, Oct 9, 2014 at 8:28 AM, Frank Galligan wrote: > In dahsmode Matroska is not writing the first Cluster for every > audio stream in the Cues element. > > Signed-off-by: Frank Galligan > --- > libavformat/matroskaenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add -min-gf-interval

2022-09-19 Thread Vignesh Venkatasubramanian
On Tue, Sep 13, 2022 at 5:28 PM James Zern wrote: > > this maps to the vpxenc argument with the same name and the > VP9E_SET_MIN_GF_INTERVAL codec control > > Signed-off-by: James Zern > --- > doc/encoders.texi | 2 ++ > libavcodec/libvpxenc.c | 11 +++ > libavcodec/version.h |

[FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha

2022-09-19 Thread Vignesh Venkatasubramanian
sting function. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/movenc.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index c8b2e141cb..754f95912a 100644 --- a/libavformat/movenc.c +++ b/l

[FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha

2022-09-20 Thread Vignesh Venkatasubramanian
terize and re-use the existing function. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/movenc.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index c8b2e141cb..754f95912a 100644 --- a/libavfor

Re: [FFmpeg-devel] [PATCH] avformat/movenc: Write auxi box for animated AVIF with alpha

2022-09-20 Thread Vignesh Venkatasubramanian
On Tue, Sep 20, 2022 at 12:38 PM James Zern wrote: > > On Mon, Sep 19, 2022 at 4:03 PM Vignesh Venkatasubramanian > wrote: > > > > According to the HEIF specification Section 7.5.3.1, tracks with > > It might be worth adding ISO/IEC 23008-12 for added precision. >

Re: [FFmpeg-devel] [PATCH] avcodec/libaomdec: fix pix_fmt w/AVCOL_SPC_RGB

2022-10-25 Thread Vignesh Venkatasubramanian
On Tue, Oct 25, 2022 at 11:28 AM James Zern wrote: > > Signed-off-by: James Zern > --- > libavcodec/libaomdec.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/libaomdec.c b/libavcodec/libaomdec.c > index 378d638a89..53982559d9 100644 > --- a/libavcode

[FFmpeg-devel] [PATCH 1/2] avformat/movenc: Add movie_timescale option to AVIF

2023-01-04 Thread Vignesh Venkatasubramanian
movie headers after this change (instead of writing 0). Signed-off-by: Vignesh Venkatasubramanian --- libavformat/movenc.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 7d49892283..36c76f7f60 100644 --- a/libavformat/movenc.c

[FFmpeg-devel] [PATCH 2/2] avformat/movenc: Add loop parameter to animated AVIF

2023-01-04 Thread Vignesh Venkatasubramanian
produced files. * Chrome is able to play back the produced files. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/movenc.c | 35 +++ libavformat/movenc.h | 1 + 2 files changed, 32 insertions(+), 4 deletions(-) diff --git a/libavformat/movenc.c b/libavformat

Re: [FFmpeg-devel] [PATCH 1/2] avformat/movenc: Add movie_timescale option to AVIF

2023-01-05 Thread Vignesh Venkatasubramanian
On Thu, Jan 5, 2023 at 1:34 AM "zhilizhao(赵志立)" wrote: > > > > > On Jan 5, 2023, at 06:16, Vignesh Venkatasubramanian > > wrote: > > > > Allow specifying the movie_timescale options to AVIF ouptut. > > > > This also makes sure that when mov

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: Add loop parameter to animated AVIF

2023-01-05 Thread Vignesh Venkatasubramanian
On Thu, Jan 5, 2023 at 1:45 AM "zhilizhao(赵志立)" wrote: > > > > > On Jan 5, 2023, at 06:16, Vignesh Venkatasubramanian > > wrote: > > > > The HEIF specification permits specifying the looping behavior of > > animated sequences by using the EditLi

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: Add loop parameter to animated AVIF

2023-01-12 Thread Vignesh Venkatasubramanian
On Fri, Jan 6, 2023 at 1:45 AM "zhilizhao(赵志立)" wrote: > > > > > On Jan 6, 2023, at 01:34, Vignesh Venkatasubramanian > > wrote: > > > > On Thu, Jan 5, 2023 at 1:45 AM "zhilizhao(赵志立)" > > wrote: > >> > >>

[FFmpeg-devel] [PATCH 2/2] avformat/movenc: Add loop parameter to animated AVIF

2023-01-12 Thread Vignesh Venkatasubramanian
produced files. * Chrome is able to play back the produced files. [1] https://github.com/AOMediaCodec/libavif/commit/4d2776a3af53ae1aefdaed463b75ba12fd9cf8c2 Signed-off-by: Vignesh Venkatasubramanian --- libavformat/movenc.c | 35 +++ libavformat/movenc.h | 1 + 2

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: Add loop parameter to animated AVIF

2023-01-13 Thread Vignesh Venkatasubramanian
On Thu, Jan 12, 2023 at 8:40 PM "zhilizhao(赵志立)" wrote: > > > > > On Jan 13, 2023, at 04:45, Vignesh Venkatasubramanian > > wrote: > > > > The HEIF specification permits specifying the looping behavior of > > animated sequences by using the Ed

[FFmpeg-devel] [PATCH] lavf/webmdashenc: fix unchecked strftime

2015-05-14 Thread Vignesh Venkatasubramanian
Fix unchecked strftime return value. This patch fixes Coverity CID 1295086. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/webmdashenc.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c

[FFmpeg-devel] [PATCH] lavf/matroskaenc: Write Block Keyframe correctly

2015-06-02 Thread Vignesh Venkatasubramanian
/index.html#block_structure Signed-off-by: Vignesh Venkatasubramanian --- libavformat/matroskaenc.c | 30 +++--- 1 file changed, 23 insertions(+), 7 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index aa9d119..98b6500 100644 --- a/libavformat

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc: Write Block Keyframe correctly

2015-06-02 Thread Vignesh Venkatasubramanian
On Mon, Jun 1, 2015 at 5:35 PM, James Almer wrote: > On 01/06/15 9:07 PM, Vignesh Venkatasubramanian wrote: >> Per matroska Block Structure [1], for keyframes 0th bit of the flag >> should not be set (unlike SimpleBlocks). For Blocks, keyframes is >> inferred by the abse

[FFmpeg-devel] [PATCH] lavf: Add support for WebM Live Muxing

2015-03-30 Thread Vignesh Venkatasubramanian
This patch adds support for WebM Live Muxing by adding a new WebM Chunk muxer. It writes out live WebM Chunks which can be used for playback using Live DASH Clients. Please see muxers.texi for sample usage. Signed-off-by: Vignesh Venkatasubramanian --- Changelog | 1 + doc

[FFmpeg-devel] [PATCH] lavf: Add support for WebM Live Muxing

2015-03-30 Thread Vignesh Venkatasubramanian
This patch adds support for WebM Live Muxing by adding a new WebM Chunk muxer. It writes out live WebM Chunks which can be used for playback using Live DASH Clients. Please see muxers.texi for sample usage. Signed-off-by: Vignesh Venkatasubramanian --- Changelog | 1 + doc

[FFmpeg-devel] [PATCH 2/2] webmdashenc: Support for live stream manifests

2015-03-31 Thread Vignesh Venkatasubramanian
This patch adds support for creating DASH manifests for WebM Live Streams. It also updates the documentation and adds a fate test to verify the behavior of the new muxer flag. Signed-off-by: Vignesh Venkatasubramanian --- doc/muxers.texi| 27 - libavformat

Re: [FFmpeg-devel] [PATCH 2/2] webmdashenc: Support for live stream manifests

2015-03-31 Thread Vignesh Venkatasubramanian
On Tue, Mar 31, 2015 at 6:45 PM, Timothy Gu wrote: > > > On Tue, Mar 31, 2015 at 5:11 PM Vignesh Venkatasubramanian > wrote: >> >> This patch adds support for creating DASH manifests for WebM Live >> Streams. It also updates the documentation and adds a fate test to

Re: [FFmpeg-devel] [PATCH] lavf: Add support for WebM Live Muxing

2015-04-06 Thread Vignesh Venkatasubramanian
On Sat, Apr 4, 2015 at 3:38 PM, Michael Niedermayer wrote: > On Mon, Mar 30, 2015 at 02:46:10PM -0700, Vignesh Venkatasubramanian wrote: >> This patch adds support for WebM Live Muxing by adding a new WebM >> Chunk muxer. It writes out live WebM Chunks which can be used for >>

Re: [FFmpeg-devel] [PATCH] webmdashenc: Fix fate in MSVC

2015-04-07 Thread Vignesh Venkatasubramanian
On Tue, Apr 7, 2015 at 12:50 PM, Michael Niedermayer wrote: > On Tue, Apr 07, 2015 at 12:21:02PM -0700, Vignesh Venkatasubramanian wrote: >> MSVC does not support the %F and %T format specifiers in strftime. >> Replace that with the expanded version. This fixes the broken fate &

[FFmpeg-devel] [PATCH 2/2] webmdashenc: Fix potential leak in realloc

2015-04-13 Thread Vignesh Venkatasubramanian
Fix potential leak in av_realloc call where the output was being overwritten by using a temporary variable. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/webmdashenc.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavformat/webmdashenc.c b/libavformat

[FFmpeg-devel] [PATCH 1/2] webdashenc: Add failure check for av_malloc.

2015-04-13 Thread Vignesh Venkatasubramanian
Add a missing failure check for av_malloc call. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/webmdashenc.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c index c5347a9..80266f7 100644 --- a/libavformat

Re: [FFmpeg-devel] [PATCH 1/2] webdashenc: Add failure check for av_malloc.

2015-04-13 Thread Vignesh Venkatasubramanian
On Mon, Apr 13, 2015 at 12:46 PM, Michael Niedermayer wrote: > On Mon, Apr 13, 2015 at 12:16:31PM -0700, Vignesh Venkatasubramanian wrote: >> Add a missing failure check for av_malloc call. >> >> Signed-off-by: Vignesh Venkatasubramanian >> --- >> libavformat/we

[FFmpeg-devel] [PATCH] webmdashenc: Fix potential memory leak

2015-04-20 Thread Vignesh Venkatasubramanian
Fix potential memory leak in WebM DASH Muxer. This fixes coverity scan CID 1295088. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/webmdashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c index a8eb8ac

[FFmpeg-devel] [PATCH] webmdashenc: parameter'ize minimumUpdatePeriod

2015-04-21 Thread Vignesh Venkatasubramanian
Some players do not support setting minimumUpdatePeriod to zero. This patch adds a new parameter that will let the users set any value to this field. Also updates the test and the documentation. Signed-off-by: Vignesh Venkatasubramanian --- doc/muxers.texi| 4

[FFmpeg-devel] [PATCH] webmdashenc: Fix UTCTiming Element

2015-04-27 Thread Vignesh Venkatasubramanian
element with the http profile only if a URL is passed as a parameter. Update the fate test to reflect this change. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/webmdashenc.c | 10 +- tests/ref/fate/webm-dash-manifest-live | 3 --- 2 files changed, 5 insertions

[FFmpeg-devel] [PATCH 1/3] avcodec/libaomenc: Add parameter for avif single image encoding

2022-02-16 Thread Vignesh Venkatasubramanian
Fixing Trac ticket #7621 [1] https://aomediacodec.github.io/av1-avif Signed-off-by:: Vignesh Venkatasubramanian --- libavcodec/libaomenc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index 963cc1bcbc..0398060a2f 100644 --- a

[FFmpeg-devel] [PATCH 2/3] avformat/av1: Add a parameter to av1c to omit seq header

2022-02-16 Thread Vignesh Venkatasubramanian
Add a parameter to omit seq header when generating the av1C atom. For now, this does not change any behavior. This will be used by a follow-up patch to add AVIF support. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/av1.c | 7 +-- libavformat/av1.h | 4

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-02-16 Thread Vignesh Venkatasubramanian
still images, firefox does not support animated AVIF yet). 3) Verfied to be valid by Compliance Warden: https://github.com/gpac/ComplianceWarden Fixes the encoder/muxer part of Trac Ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- configure| 1 + libavformat

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/libaomenc: Add parameter for avif single image encoding

2022-02-17 Thread Vignesh Venkatasubramanian
On Thu, Feb 17, 2022 at 10:09 AM James Zern wrote: > > On Wed, Feb 16, 2022 at 9:51 PM Vignesh Venkatasubramanian > wrote: > > > > Add a parameter to libaom-av1 encoder to enforce some of the single > > image constraints in the AV1 encoder. Setting this flag wi

[FFmpeg-devel] [PATCH] avcodec/libaomenc: Add parameter for avif single image encoding

2022-02-17 Thread Vignesh Venkatasubramanian
Fixing Trac ticket #7621 [1] https://aomediacodec.github.io/av1-avif Signed-off-by:: Vignesh Venkatasubramanian --- libavcodec/libaomenc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index 963cc1bcbc..638c1deca6 100644 --- a

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/libaomenc: Add parameter for avif single image encoding

2022-02-17 Thread Vignesh Venkatasubramanian
On Thu, Feb 17, 2022 at 1:00 PM James Almer wrote: > > > > On 2/17/2022 2:51 AM, Vignesh Venkatasubramanian wrote: > > Add a parameter to libaom-av1 encoder to enforce some of the single > > image constraints in the AV1 encoder. Setting this flag will limit > > th

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-02-22 Thread Vignesh Venkatasubramanian
still images, firefox does not support animated AVIF yet). 3) Verfied to be valid by Compliance Warden: https://github.com/gpac/ComplianceWarden Fixes the encoder/muxer part of Trac Ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- configure| 1 + libavformat

[FFmpeg-devel] [PATCH 1/3] avcodec/libaomenc: Add parameter for avif single image encoding

2022-02-22 Thread Vignesh Venkatasubramanian
Fixing Trac ticket #7621 [1] https://aomediacodec.github.io/av1-avif Signed-off-by:: Vignesh Venkatasubramanian --- libavcodec/libaomenc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index 963cc1bcbc..a6d752ab4a 100644 --- a

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-02-22 Thread Vignesh Venkatasubramanian
still images, firefox does not support animated AVIF yet). 3) Verfied to be valid by Compliance Warden: https://github.com/gpac/ComplianceWarden Fixes the encoder/muxer part of Trac Ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- configure| 1 + libavformat

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-02-22 Thread Vignesh Venkatasubramanian
On Tue, Feb 22, 2022 at 12:03 PM James Almer wrote: > > > On 2/22/2022 3:40 PM, Vignesh Venkatasubramanian wrote: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > > > AVIF Specifiation: https://aomediacodec.github.io/av1-avif > > > > S

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-02-22 Thread Vignesh Venkatasubramanian
still images, firefox does not support animated AVIF yet). 3) Verfied to be valid by Compliance Warden: https://github.com/gpac/ComplianceWarden Fixes the encoder/muxer part of Trac Ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- configure| 1 + libavformat

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-02-24 Thread Vignesh Venkatasubramanian
On Tue, Feb 22, 2022 at 1:43 PM Vignesh Venkatasubramanian wrote: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > AVIF Specifiation: https://aomediacodec.github.io/av1-avif > > Sample usage for still image: > ffmpeg -i image.png -c:v libaom-av1 -av

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-01 Thread Vignesh Venkatasubramanian
On Thu, Feb 24, 2022 at 9:34 AM Vignesh Venkatasubramanian wrote: > > On Tue, Feb 22, 2022 at 1:43 PM Vignesh Venkatasubramanian > wrote: > > > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > > > AVIF Specifiation: https://aomediacodec.github

[FFmpeg-devel] [PATCH 2/3] avformat/av1: Add a parameter to av1c to omit seq header

2022-03-02 Thread Vignesh Venkatasubramanian
Add a parameter to omit seq header when generating the av1C atom. For now, this does not change any behavior. This will be used by a follow-up patch to add AVIF support. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/av1.c | 7 +-- libavformat/av1.h | 4

Re: [FFmpeg-devel] [PATCH 2/3] avformat/av1: Add a parameter to av1c to omit seq header

2022-03-02 Thread Vignesh Venkatasubramanian
On Wed, Mar 2, 2022 at 2:57 PM James Almer wrote: > > On 2/17/2022 2:51 AM, Vignesh Venkatasubramanian wrote: > > Add a parameter to omit seq header when generating the av1C atom. > > > > For now, this does not change any behavior. This will be used by a > > follo

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-03 Thread Vignesh Venkatasubramanian
still images, firefox does not support animated AVIF yet). 3) Verfied to be valid by Compliance Warden: https://github.com/gpac/ComplianceWarden Fixes the encoder/muxer part of Trac Ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- configure| 1 + libavformat

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-03 Thread Vignesh Venkatasubramanian
On Thu, Mar 3, 2022 at 7:36 AM James Almer wrote: > > On 2/22/2022 6:43 PM, Vignesh Venkatasubramanian wrote: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > > > AVIF Specifiation: https://aomediacodec.github.io/av1-avif > > > > Sample

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-03 Thread Vignesh Venkatasubramanian
On Thu, Mar 3, 2022 at 11:46 AM James Almer wrote: > > > > On 3/3/2022 4:20 PM, Vignesh Venkatasubramanian wrote: > > On Thu, Mar 3, 2022 at 7:36 AM James Almer wrote: > >> > >> On 2/22/2022 6:43 PM, Vignesh Venkatasubramanian wrote: > >>> Add an

[FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-03 Thread Vignesh Venkatasubramanian
image.avif image.png Partially fixes trac ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- libavformat/isom.h | 1 + libavformat/mov.c | 142 + 2 files changed, 143 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-04 Thread Vignesh Venkatasubramanian
still images, firefox does not support animated AVIF yet). 3) Verfied to be valid by Compliance Warden: https://github.com/gpac/ComplianceWarden Fixes the encoder/muxer part of Trac Ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- configure| 1 + libavformat

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-04 Thread Vignesh Venkatasubramanian
On Fri, Mar 4, 2022 at 3:24 AM James Almer wrote: > > On 3/3/2022 4:16 PM, Vignesh Venkatasubramanian wrote: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > > > AVIF Specifiation: https://aomediacodec.github.io/av1-avif > > > > Sample

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-09 Thread Vignesh Venkatasubramanian
On Fri, Mar 4, 2022 at 9:54 AM Vignesh Venkatasubramanian wrote: > > On Fri, Mar 4, 2022 at 3:24 AM James Almer wrote: > > > > On 3/3/2022 4:16 PM, Vignesh Venkatasubramanian wrote: > > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > >

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-10 Thread Vignesh Venkatasubramanian
still images, firefox does not support animated AVIF yet). 3) Verfied to be valid by Compliance Warden: https://github.com/gpac/ComplianceWarden Fixes the encoder/muxer part of Trac Ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- configure| 1 + libavformat

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-10 Thread Vignesh Venkatasubramanian
On Thu, Mar 10, 2022 at 8:01 AM Andreas Rheinhardt wrote: > > Vignesh Venkatasubramanian: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > > > AVIF Specifiation: https://aomediacodec.github.io/av1-avif > > > > Sample usage for still image:

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-15 Thread Vignesh Venkatasubramanian
On Thu, Mar 10, 2022 at 10:14 AM Vignesh Venkatasubramanian wrote: > > On Thu, Mar 10, 2022 at 8:01 AM Andreas Rheinhardt > wrote: > > > > Vignesh Venkatasubramanian: > > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > > > > > A

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-15 Thread Vignesh Venkatasubramanian
On Thu, Mar 3, 2022 at 3:58 PM Vignesh Venkatasubramanian wrote: > > Add support for parsing AVIF still images. This patches supports > AVIF still images that have exactly 1 item (i.e.) no alpha channel. > Essentially, we will have to parse the "iloc" box and populate >

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-16 Thread Vignesh Venkatasubramanian
On Wed, Mar 16, 2022 at 5:41 AM Lynne wrote: > > 15 Mar 2022, 22:38 by vigneshv-at-google@ffmpeg.org: > > > On Thu, Mar 3, 2022 at 3:58 PM Vignesh Venkatasubramanian > > wrote: > > > >> > >> Add support for parsing AVIF still images. This patc

[FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-16 Thread Vignesh Venkatasubramanian
image.avif image.png Partially fixes trac ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- libavformat/isom.h | 1 + libavformat/mov.c | 142 + 2 files changed, 143 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index

[FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-16 Thread Vignesh Venkatasubramanian
image.avif image.png Partially fixes trac ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- libavformat/isom.h | 1 + libavformat/mov.c | 142 + 2 files changed, 143 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-21 Thread Vignesh Venkatasubramanian
On Tue, Mar 15, 2022 at 8:59 AM Vignesh Venkatasubramanian wrote: > > On Thu, Mar 10, 2022 at 10:14 AM Vignesh Venkatasubramanian > wrote: > > > > On Thu, Mar 10, 2022 at 8:01 AM Andreas Rheinhardt > > wrote: > > > > > > Vignesh Venkatasubramani

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-22 Thread Vignesh Venkatasubramanian
On Mon, Mar 21, 2022 at 1:46 PM Andreas Rheinhardt wrote: > > Vignesh Venkatasubramanian: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > > > AVIF Specifiation: https://aomediacodec.github.io/av1-avif > > > > Sample usage for still image:

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-22 Thread Vignesh Venkatasubramanian
still images, firefox does not support animated AVIF yet). 3) Verfied to be valid by Compliance Warden: https://github.com/gpac/ComplianceWarden Fixes the encoder/muxer part of Trac Ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- configure| 1 + libavformat

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-22 Thread Vignesh Venkatasubramanian
On Wed, Mar 16, 2022 at 10:02 AM Vignesh Venkatasubramanian wrote: > > Add support for parsing AVIF still images. This patches supports > AVIF still images that have exactly 1 item (i.e.) no alpha channel. > Essentially, we will have to parse the "iloc" box and populate >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-28 Thread Vignesh Venkatasubramanian
On Tue, Mar 22, 2022 at 9:46 AM Vignesh Venkatasubramanian wrote: > > Add an AVIF muxer by re-using the existing the mov/mp4 muxer. > > AVIF Specifiation: https://aomediacodec.github.io/av1-avif > > Sample usage for still image: > ffmpeg -i image.png -c:v libaom-av1 -av

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-28 Thread Vignesh Venkatasubramanian
On Tue, Mar 22, 2022 at 2:56 PM Vignesh Venkatasubramanian wrote: > > On Wed, Mar 16, 2022 at 10:02 AM Vignesh Venkatasubramanian > wrote: > > > > Add support for parsing AVIF still images. This patches supports > > AVIF still images that have exactly 1 i

Re: [FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-28 Thread Vignesh Venkatasubramanian
On Mon, Mar 28, 2022 at 10:11 AM Paul B Mahol wrote: > > On Mon, Mar 28, 2022 at 7:07 PM Vignesh Venkatasubramanian < > vigneshv-at-google@ffmpeg.org> wrote: > > > On Tue, Mar 22, 2022 at 2:56 PM Vignesh Venkatasubramanian > > wrote: > > > > &g

[FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-28 Thread Vignesh Venkatasubramanian
image.avif image.png Partially fixes trac ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- libavformat/isom.h | 1 + libavformat/mov.c | 142 + 2 files changed, 143 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index

[FFmpeg-devel] [PATCH] avformat/mov: Add support for still image AVIF parsing

2022-03-28 Thread Vignesh Venkatasubramanian
image.avif image.png Partially fixes trac ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- libavformat/isom.h | 1 + libavformat/mov.c | 148 + 2 files changed, 149 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index

[FFmpeg-devel] [PATCH 1/3] avcodec/libaomenc: Add parameter for avif single image encoding

2022-03-28 Thread Vignesh Venkatasubramanian
Fixing Trac ticket #7621 [1] https://aomediacodec.github.io/av1-avif Signed-off-by:: Vignesh Venkatasubramanian --- libavcodec/libaomenc.c | 14 ++ 1 file changed, 14 insertions(+) diff --git a/libavcodec/libaomenc.c b/libavcodec/libaomenc.c index 7dbb6f6f39..ccd0823b97 100644 --- a

[FFmpeg-devel] [PATCH 2/3] avformat/av1: Add a parameter to av1c to omit seq header

2022-03-28 Thread Vignesh Venkatasubramanian
Add a parameter to omit seq header when generating the av1C atom. For now, this does not change any behavior. This will be used by a follow-up patch to add AVIF support. Signed-off-by: Vignesh Venkatasubramanian --- libavformat/av1.c | 7 +-- libavformat/av1.h | 4

[FFmpeg-devel] [PATCH 3/3] avformat/movenc: Add support for AVIF muxing

2022-03-28 Thread Vignesh Venkatasubramanian
still images, firefox does not support animated AVIF yet). 3) Verfied to be valid by Compliance Warden: https://github.com/gpac/ComplianceWarden Fixes the encoder/muxer part of Trac Ticket #7621 Signed-off-by: Vignesh Venkatasubramanian --- configure| 1 + libavformat

[FFmpeg-devel] [PATCH] libsvtav1: Add workaround for gop_size == 1

2023-06-26 Thread Vignesh Venkatasubramanian
frames are keyframes. SVT-AV1 Bug: https://gitlab.com/AOMediaCodec/SVT-AV1/-/issues/2076 Example command: ffmpeg -f lavfi -i testsrc=duration=1:size=64x64:rate=30 -c:v libsvtav1 -g 1 -y test.webm Before: Only first frame is keyframe. After: All frames are keyframes. Signed-off-by: Vignesh

  1   2   >