[FFmpeg-devel] [PATCH] avformat/hls: Fixes #EXT-X-PROGRAM-DATE-TIME value of existing segments from getting over written with new value when appending new segments to an existing playlist file

2020-11-21 Thread Vignesh Ravichandran
Signed-off-by: Vignesh Ravichandran --- libavformat/hlsenc.c | 35 +++ 1 file changed, 31 insertions(+), 4 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index cbfd8f7c0d..030a2d3b97 100644 --- a/libavformat/hlsenc.c +++ b/libavformat

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes #EXT-X-PROGRAM-DATE-TIME value of existing segments from getting over written with new value when appending new segments to an existing playlist file

2020-11-24 Thread Vignesh Ravichandran
Friendly reminder for review. Thank you. Thanks, Vignesh On Sat, Nov 21, 2020 at 8:44 PM Vignesh Ravichandran < vignesh.ravichandra...@gmail.com> wrote: > Signed-off-by: Vignesh Ravichandran > --- > libavformat/hlsenc.c | 35 +++ > 1 file chan

[FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist

2020-11-24 Thread Vignesh Ravichandran
set, then use that value for "EXT-X-PROGRAM-DATE-TIME" else use the value present in vs->initial_prog_date_time Signed-off-by: Vignesh Ravichandran --- libavformat/hlsenc.c | 35 +++ 1 file changed, 31 insertions(+), 4 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes #EXT-X-PROGRAM-DATE-TIME value of existing segments from getting over written with new value when appending new segments to an existing playlist file

2020-11-24 Thread Vignesh Ravichandran
I have amended the commit message and resubmitted the patch - http://ffmpeg.org/pipermail/ffmpeg-devel/2020-November/272924.html Please review. Thanks, Vignesh On Wed, Nov 25, 2020 at 8:38 AM Steven Liu wrote: > Vignesh Ravichandran 于2020年11月21日周六 > 下午11:22写道: > > > > Sign

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist

2020-11-25 Thread Vignesh Ravichandran
iu wrote: > > > > 2020年11月25日 下午1:16,Vignesh Ravichandran < > vignesh.ravichandra...@gmail.com> 写道: > > > > Bug ID: 8989 > > > > This is is due to the following behavior in the current code: > > 1. The initial_prog_date_time gets set to the

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist

2020-11-25 Thread Vignesh Ravichandran
} On Wed, Nov 25, 2020 at 5:31 PM Steven Liu wrote: > > > > 2020年11月25日 下午7:49,Vignesh Ravichandran < > vignesh.ravichandra...@gmail.com> 写道: > > > > We could add a simple check like below to prevent it: > > > > if (sscanf(ptr, "%d-%d-%dT%d:%d:

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist

2020-11-25 Thread Vignesh Ravichandran
value splited by ‘-‘ > 3. If the value is int, that is correct result. > 4. Else not. > > > > On Wed, Nov 25, 2020 at 5:31 PM Steven Liu wrote: > > > >> > >> > >>> 2020年11月25日 下午7:49,Vignesh Ravichandran < > >> vignesh.r

[FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist Bug ID: 8989

2020-11-26 Thread Vignesh Ravichandran
that value for "EXT-X-PROGRAM-DATE-TIME" else use the value present in vs->initial_prog_date_time Signed-off-by: Vignesh Ravichandran --- libavformat/hlsenc.c | 83 ++-- 1 file changed, 80 insertions(+), 3 deletions(-) diff --git a/libavform

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist

2020-11-26 Thread Vignesh Ravichandran
Sounds good :D I have incorporated the changes and resubmitted the patch - http://ffmpeg.org/pipermail/ffmpeg-devel/2020-November/272964.html Please review. Thanks, Vignesh On Thu, Nov 26, 2020 at 12:37 PM Steven Liu wrote: > > > > 2020年11月26日 下午12:43,Vignesh

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist Bug ID: 8989

2020-11-26 Thread Vignesh Ravichandran
月26日 下午10:21,Vignesh Ravichandran < > vignesh.ravichandra...@gmail.com> 写道: > > > > This is is due to the following behavior in the current code: > > 1. The initial_prog_date_time gets set to the current local time > > 2. The existing playlist (.m3u8) file gets parse

[FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist

2020-12-01 Thread Vignesh Ravichandran
set, then use that value for "EXT-X-PROGRAM-DATE-TIME" else use the value present in vs->initial_prog_date_time Signed-off-by: Vignesh Ravichandran --- libavformat/hlsenc.c | 33 ++--- 1 file changed, 30 insertions(+), 3 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist Bug ID: 8989

2020-12-01 Thread Vignesh Ravichandran
...@gmail.com/). Could you please advise if this is acceptable? Thanks, Vignesh On Fri, Nov 27, 2020 at 12:11 PM Steven Liu wrote: > > > > 2020年11月27日 下午2:36,Vignesh Ravichandran < > vignesh.ravichandra...@gmail.com> 写道: > > > > av_isdigit seems to only check if the

Re: [FFmpeg-devel] [PATCH] avformat/hls: Fixes overwriting existing #EXT-X-PROGRAM-DATE-TIME value in HLS playlist

2020-12-07 Thread Vignesh Ravichandran
Friendly ping to check if the patch has been pushed. Thanks, Vignesh On Fri, Dec 4, 2020 at 8:04 AM Steven Liu wrote: > > > > 2020年12月1日 下午6:10,Vignesh Ravichandran > 写道: > > > > Bug ID: 8989 > > > > This is is due to the following b

[FFmpeg-devel] EXT-X-PROGRAM-DATE-TIME value drifts behind the actual time on the start of the corresponding segment video

2021-01-22 Thread Vignesh Ravichandran
I am trying to create a video by stitching multiple HLS segments (.ts files) together based on a start time and end time. Basically, create a video of a particular timeline in the HLS stream. My setup has a camera pointing to a monitor that displays the system clock (The camera control and the

Re: [FFmpeg-devel] EXT-X-PROGRAM-DATE-TIME value drifts behind the actual time on the start of the corresponding segment video

2021-01-25 Thread Vignesh Ravichandran
Friendly ping. Would greatly appreciate some input on this. Thanks, Vignesh On Fri, Jan 22, 2021 at 3:35 PM Vignesh Ravichandran < vignesh.ravichandra...@gmail.com> wrote: > I am trying to create a video by stitching multiple HLS segments (.ts > files) together based on a start