When an Info-tag is present, marking initial and trailing samples as
padding, those samples should not be included in the calculation of track
duration.
This solves a surprising user experience where converting a WAV->MP3->WAV,
ffprobe will show the duration of the mp3 as slightly longer than both
iced a fate-test failed (due to it including
padding-samples in the reference output for duration), and a
formatting error in the patch itself. Will fix and resubmit.
Den ons 23 aug. 2023 kl 11:18 skrev Tomas Härdin :
>
> tis 2023-08-22 klockan 14:03 +0200 skrev Ulrik Mikaelsson:
> > Whe
When an Info-tag is present, marking initial and trailing samples as
padding, those samples should not be included in the calculation of track
duration.
This solves a surprising user experience where converting a WAV->MP3->WAV,
ffprobe will show the duration of the mp3 as slightly longer than both
When an Info-tag is present, marking initial and trailing samples as
padding, those samples should not be included in the calculation of track
duration.
This solves a surprising user experience where converting a WAV->MP3->WAV,
ffprobe will show the duration of the mp3 as slightly longer than both
> This still fails fate-seek-extra-mp3
I noticed. Apologies for the noise, I'm unfamiliar with the FATE suite
and failed to realize "make fate" won't run the _whole_ thing.
I have just submitted a 3d revision of this patch, fixing the review
comments and fully passing `make fate SAMPLES=./fate-su
Just noticed that there is a ticket
https://trac.ffmpeg.org/ticket/10163 about this, that I believe is
solved with this patch.
Den ons 23 aug. 2023 kl 20:33 skrev Ulrik Mikaelsson
:
>
> When an Info-tag is present, marking initial and trailing samples as
> padding, those samples shou
