Re: [FFmpeg-devel] [PATCH] avformat: add AV1 RTP depacketizer and packetizer

2024-11-25 Thread Tristan Matthews via ffmpeg-devel
Hi, On Monday, November 25th, 2024 at 2:29 AM, Chris Hodges wrote: > Hi Anton (sorry for the PM), > > > Your mailer mangled the newlines in the patch. Consider a different > > mailer or sending it as an attachment. > > > Thanks for the info, had sent it with Thunderbird. Resending it as > at

Re: [FFmpeg-devel] [PATCH] avformat: add AV1 RTP depacketizer and packetizer

2024-12-11 Thread Tristan Matthews via ffmpeg-devel
Hi, On Friday, December 6th, 2024 at 12:39 PM, Tristan Matthews via ffmpeg-devel wrote: > Hi (also apologies if my client mangles the inline version of the patch, it's > the first time I've tried to review an attached patch with it)... > > On Monday, December 2nd,

Re: [FFmpeg-devel] [PATCH v3] avformat: add AV1 RTP depacketizer and packetizer

2024-12-17 Thread Tristan Matthews via ffmpeg-devel
Hi, > I see. I've put the code in an #if block, so you can try if > > it makes a difference to anything you may encounter. > > The spec says: https://aomediacodec.github.io/av1-spec/#ordering-of-obus > > "Sequence header OBUs may appear in any order within a coded video > sequence. Within a parti

Re: [FFmpeg-devel] [PATCH] avformat: add AV1 RTP depacketizer and packetizer

2024-12-13 Thread Tristan Matthews via ffmpeg-devel
On Thursday, December 12th, 2024 at 4:18 AM, Chris Hodges wrote: > Hi Tristan, > > thanks for taking the time reviewing. > > On 12/6/24 18:39, Tristan Matthews via ffmpeg-devel wrote: > > > Hi (also apologies if my client mangles the inline version of the patch, >

Re: [FFmpeg-devel] [PATCH] avformat: add AV1 RTP depacketizer and packetizer

2024-12-13 Thread Tristan Matthews via ffmpeg-devel
can discuss the changes and it gives me more time to look into the > issue below. > > On 12/11/24 23:53, Tristan Matthews via ffmpeg-devel wrote: > > > Aside from my minor comments on the patch, one thing that came up in terms > > of testing is that while the packetization seems

Re: [FFmpeg-devel] [PATCH] avformat: add AV1 RTP depacketizer and packetizer

2024-12-06 Thread Tristan Matthews via ffmpeg-devel
Hi (also apologies if my client mangles the inline version of the patch, it's the first time I've tried to review an attached patch with it)... On Monday, December 2nd, 2024 at 9:57 AM, Chris Hodges wrote: > Hi, > > On 11/25/24 18:47, Tristan Matthews via ffmpeg-devel wr

Re: [FFmpeg-devel] [PATCH] speexdec: fix framesize for ultra-wideband

2025-03-25 Thread Tristan Matthews via ffmpeg-devel
On Thursday, March 13th, 2025 at 2:54 PM, Tristan Matthews wrote: > This matches how the libspeex decoder is calculating frame size (except in > clamp form). > > Fixes #11495 > --- > libavcodec/speexdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/speex

Re: [FFmpeg-devel] [PATCH v4] avformat: add AV1 RTP depacketizer and packetizer

2025-02-26 Thread Tristan Matthews via ffmpeg-devel
On Friday, February 21st, 2025 at 5:15 AM, Chris Hodges wrote: > Hi Tristan, > > On 12/13/24 14:44, Tristan Matthews via ffmpeg-devel wrote: > > > Nice, looking forward to testing the next iteration. > > > Sorry for the long delay, I got sidetracked with other wor

Re: [FFmpeg-devel] [PATCH 1/2] rtpdec: add fmtp parsing of sprop-maxcapturerate for opus

2025-05-22 Thread Tristan Matthews via ffmpeg-devel
Hi, On Monday, May 5th, 2025 at 4:07 PM, Marvin Scholz wrote: > From: Erik Linge eri...@axis.com > > > Co-authored-by: Marvin Scholz epira...@gmail.com > > Signed-off-by: Marvin Scholz epira...@gmail.com > > --- > libavformat/Makefile | 1 + > libavformat/rtpdec.c | 8 + > libavformat/rtpd

Re: [FFmpeg-devel] STF RaptorQ

2025-05-23 Thread Tristan Matthews via ffmpeg-devel
Hi, > > > But Lynne is insisting it's not a protocol. The work would just be the low > level RaptorQ algorithm. > > UDP based retransmit/FEC protocols are essentially impossible to develop > well without an event loop / timers. > > You can look at libsrt and librist of examples of how trying

Re: [FFmpeg-devel] [PATCH] h264dsp: h264_luma_dc_dequant_idct: constify input

2025-06-20 Thread Tristan Matthews via ffmpeg-devel
--- Begin Message --- On Friday, June 13th, 2025 at 4:03 PM, Tristan Matthews wrote: > --- > libavcodec/h264dsp.h | 2 +- > libavcodec/h264idct.h | 2 +- > libavcodec/h264idct_template.c | 2 +- > libavcodec/loongarch/h264dsp_loongarch.h | 2 +- > libavcodec/loongarch/h264idct.S | 2 +- > libavcodec/

Re: [FFmpeg-devel] [PATCH] checkasm/h264dsp: Fix stack-buffer-overflow, effective-type violations

2025-06-16 Thread Tristan Matthews via ffmpeg-devel
--- Begin Message --- Sent with Proton Mail secure email. On Monday, June 16th, 2025 at 6:53 AM, Andreas Rheinhardt wrote: > Patch attached. > LGTM, and sorry about that, for future reference did you do anything in particular (instrumentation wise) to catch the stack overflow? I tried m

Re: [FFmpeg-devel] Fuzzer fixes

2025-05-28 Thread Tristan Matthews via ffmpeg-devel
On Wednesday, May 28th, 2025 at 11:17 AM, Michael Niedermayer wrote: > Hi > > If someone has spare time, there are some public open issues on: > https://issues.oss-fuzz.com/issues?q=status:open componentid:1638179 > title:ffmpeg > > check if they have pending fixes on the ML first and if so h

Re: [FFmpeg-devel] [PATCH] checkasm/h264dsp: Fix stack-buffer-overflow, effective-type violations

2025-06-25 Thread Tristan Matthews via ffmpeg-devel
--- Begin Message --- On Monday, June 16th, 2025 at 2:22 PM, Andreas Rheinhardt wrote: > Tristan Matthews via ffmpeg-devel: > > > On Monday, June 16th, 2025 at 6:53 AM, Andreas Rheinhardt > > andreas.rheinha...@outlook.com wrote: > > > > > Patch attached. &g