On Sun, Oct 11, 2015 at 11:29 AM Ronald S. Bultje
wrote:
> It's an a non-installed header and only used in one place (flacenc).
> Since ff_ctz is static inline, it's fine to use that instead.
> ---
> libavcodec/flacenc.c | 2 +-
> libavutil/intmath.c | 5 -
> libavutil/intmath.h | 8 --
On Sun, Oct 11, 2015 at 12:16 PM Ganesh Ajjanagadde
wrote:
> Alternatively (for now, more sustainable is a proper hook), could you
> post here your alias to do this?
>
git remote set-url origin --push --add g...@github.com:FFmpeg/FFmpeg.git
Timothy
__
On Sun, Oct 11, 2015 at 6:31 PM Ganesh Ajjanagadde wrote:
> Just to make this clear: suppose (hypothetically) av_ctz was public.
> If my application never used av_ctz, but I (or my distro) upgrades
> libav*, then I don't need to recompile/relink my code?
>
If we are only talking about av_ctz her
El martes, 13 de octubre de 2015, Michael Niedermayer
escribió:
> On Sun, Oct 11, 2015 at 04:27:49PM -0400, Ganesh Ajjanagadde wrote:
> > ---
> > .gitignore | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/.gitignore b/.gitignore
> > index 0b26f68..b215828 100644
> > --- a/.gitigno
lp".
Type "apropos word" to search for commands related to "word"...
Reading symbols from ffmpeg_g...done.
(gdb) r -loglevel debug -f lavfi -i allrgb -vf chromakey=green:opencl=1 -f
null -
Starting program: /home/timothy-gu/ffmpeg/ffmpeg/ffmpeg_g -loglevel debug
-f lavfi -i allrg
---
libavfilter/vf_chromakey.c | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/libavfilter/vf_chromakey.c b/libavfilter/vf_chromakey.c
index 47fdea631..3309748 100644
--- a/libavfilter/vf_chromakey.c
+++ b/libavfilter/vf_chromakey.c
@@ -35,6 +35,9 @@
---
libavutil/opencl.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavutil/opencl.c b/libavutil/opencl.c
index 8686493..c2956fd 100644
--- a/libavutil/opencl.c
+++ b/libavutil/opencl.c
@@ -484,7 +484,8 @@ cl_program av_opencl_compile(const char *program_name,
const cha
Useful when debugging.
---
libavutil/opencl.c | 33 ++---
1 file changed, 30 insertions(+), 3 deletions(-)
diff --git a/libavutil/opencl.c b/libavutil/opencl.c
index c2956fd..f720ce0 100644
--- a/libavutil/opencl.c
+++ b/libavutil/opencl.c
@@ -449,12 +449,14 @@ end:
c
All other classes use lowercase names.
---
libavutil/opencl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavutil/opencl.c b/libavutil/opencl.c
index f720ce0..62706f3 100644
--- a/libavutil/opencl.c
+++ b/libavutil/opencl.c
@@ -84,7 +84,7 @@ static const AVOption opencl_o
Silences warnings regarding `clCreateCommandQueue` being deprecated.
Only a very limited number of products support 2.0. Since the
replacement API (`clCreateCommandQueueWithProperties`) is only available
in 2.0, we should not update it just yet.
---
libavutil/opencl.h | 1 +
1 file changed, 1 ins
On Tue, Oct 13, 2015 at 6:24 PM Ganesh Ajjanagadde wrote:
> On Tue, Oct 13, 2015 at 9:20 PM, Timothy Gu wrote:
> > Patch LGTM.
>
> Go ahead and push
Pushed, thanks.
Timothy
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
ht
On Wed, Oct 14, 2015 at 8:08 PM Ganesh Ajjanagadde
wrote:
> pushed. Please let me know if such things are ok or not in the future
> - technically I guess doc maintainers need to respond before I can
> push, but as this change was trivial I thought I would do it.\
>
As a documentation maintainer,
On Wed, Oct 14, 2015 at 8:05 PM Ganesh Ajjanagadde
wrote:
> This clarifies and Doxygen's the comment for ff_fmt_is_in.
^
gajjanag.c:1:23: error: unexpected token ‘adjective’
>
> Signed-off-by: Ganesh Ajjanagadde
> ---
> libavfilter/internal.h | 8 +++-
> 1 file change
On Wed, Oct 14, 2015 at 2:21 PM Michael Niedermayer
wrote:
> On Tue, Oct 13, 2015 at 09:48:35PM -0700, Timothy Gu wrote:
> > ---
> > libavutil/opencl.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
>
> LGTM
>
&g
On Tue, Oct 13, 2015 at 9:33 PM Timothy Gu wrote:
> ---
> libavfilter/vf_chromakey.c | 25 +
> 1 file changed, 17 insertions(+), 8 deletions(-)
>
Reviewed by Timo on IRC and pushed.
Timothy
___
ffmpeg-devel
On Sat, Oct 17, 2015 at 7:59 AM Ganesh Ajjanagadde
wrote:
> On Thu, Oct 15, 2015 at 6:26 AM, Ganesh Ajjanagadde
> wrote:
> > On Thu, Oct 15, 2015 at 1:45 AM, Timothy Gu
> wrote:
> >> On Wed, Oct 14, 2015 at 8:05 PM Ganesh Ajjanagadde <
> gajjanaga...@gmail.com>
This function does not exist.
---
libavcodec/x86/fpel.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavcodec/x86/fpel.h b/libavcodec/x86/fpel.h
index 625c47d..4e83cf7 100644
--- a/libavcodec/x86/fpel.h
+++ b/libavcodec/x86/fpel.h
@@ -40,8 +40,6 @@ void ff_put_pixels4_mmx(uint8_t *block,
---
libavcodec/x86/fpel.h | 6 ++
libavcodec/x86/h264_qpel.c | 4
2 files changed, 6 insertions(+), 4 deletions(-)
diff --git a/libavcodec/x86/fpel.h b/libavcodec/x86/fpel.h
index 4d93959..625c47d 100644
--- a/libavcodec/x86/fpel.h
+++ b/libavcodec/x86/fpel.h
@@ -22,6 +22,10 @@
#in
That's where all yasm initiation steps are. Also removes the overlap
between the two files.
---
libavcodec/x86/vc1dsp_init.c | 36 +---
libavcodec/x86/vc1dsp_mmx.c | 27 ---
2 files changed, 25 insertions(+), 38 deletions(-)
diff --git a/li
This function is only used within other inline asm functions, hence the
HAVE_MMX_INLINE guard. Per recent discussions, we should not worry about
the performance of inline asm-only builds.
---
libavcodec/x86/vc1dsp.asm | 89 -
libavcodec/x86/vc1dsp_mmx.
This function is only used within other inline asm functions, hence the
HAVE_MMX_INLINE guard. Per recent discussions, we should not worry about
the performance of inline asm-only builds.
---
The conversion process has to start _somewhere_...
Difference from previous version: use mova/h, correct
This reverts commit 628e6d0164febc8e69b0f10dfa487e8a2dd1a28a and uses
a better fix.
Before:
4483 decicycles in get_pixels_8x4_sym, 131032 runs, 40 skips
After:
2569 decicycles in get_pixels_8x4_sym, 131054 runs, 18 skips
---
libavcodec/dnxhdenc.c | 24
1 file c
Before:
15543 decicycles in get_pixels, 4193214 runs, 1090 skips
After:
5713 decicycles in get_pixels, 8387564 runs, 1044 skips
---
libavcodec/pixblockdsp.c | 38 -
libavcodec/pixblockdsp_template.c | 40 ---
It is done this way in huffyuvdsp as well.
---
libavcodec/huffyuvencdsp.c | 4 ++--
libavcodec/huffyuvencdsp.h | 4 ++--
libavcodec/x86/huffyuvencdsp_mmx.c | 5 +++--
3 files changed, 7 insertions(+), 6 deletions(-)
diff --git a/libavcodec/huffyuvencdsp.c b/libavcodec/huffyuvencds
@@
+;
+;* SIMD-optimized HuffYUV encoding functions
+;* Copyright (c) 2000, 2001 Fabrice Bellard
+;* Copyright (c) 2002-2004 Michael Niedermayer
+;*
+;* MMX optimization by Nick Kurshev
+;* Conversion to NASM format by Tiancheng "Ti
4% to 35% faster depending on the width.
---
libavcodec/x86/huffyuvencdsp.asm | 31 ---
libavcodec/x86/huffyuvencdsp_mmx.c | 8 +++-
2 files changed, 27 insertions(+), 12 deletions(-)
diff --git a/libavcodec/x86/huffyuvencdsp.asm b/libavcodec/x86/huffyuvencdsp.a
About 16% faster on large clips (>1200px width), more than 2x slower on small
clips
(352px). So using a heuristic to select with one to use.
---
libavcodec/huffyuvenc.c| 6 +++---
libavcodec/huffyuvencdsp.c | 4 ++--
libavcodec/huffyuvencdsp.h | 4 ++--
libavcodec/pnge
On Mon, Oct 19, 2015 at 1:44 PM Ganesh Ajjanagadde wrote:
> On Mon, Oct 19, 2015 at 4:41 PM, Hendrik Leppkes
> wrote:
> > On Mon, Oct 19, 2015 at 10:36 PM, Ganesh Ajjanagadde
> wrote:
> >> On Mon, Oct 19, 2015 at 4:00 PM, Timothy Gu
> wrote:
> >>> A
On Sat, Oct 17, 2015 at 4:49 PM Timothy Gu wrote:
> ---
> libavcodec/x86/fpel.h | 6 ++
> libavcodec/x86/h264_qpel.c | 4
> 2 files changed, 6 insertions(+), 4 deletions(-)
>
Pushed.
Timothy
___
ffmpeg-devel mailing li
On Sat, Oct 17, 2015 at 6:31 PM Michael Niedermayer
wrote:
> On Sat, Oct 17, 2015 at 04:48:59PM -0700, Timothy Gu wrote:
> > This function does not exist.
> > ---
> > libavcodec/x86/fpel.h | 2 --
> > 1 file changed, 2 deletions(-)
>
>
On Sat, Oct 17, 2015 at 4:49 PM Timothy Gu wrote:
> That's where all yasm initiation steps are. Also removes the overlap
> between the two files.
> ---
> libavcodec/x86/vc1dsp_init.c | 36 +---
> libavcodec/x86/vc1dsp_mmx.c | 27
On Mon, Oct 19, 2015 at 3:53 PM Michael Niedermayer
wrote:
> On Mon, Oct 19, 2015 at 01:00:43PM -0700, Timothy Gu wrote:
> > It is done this way in huffyuvdsp as well.
> > ---
> > libavcodec/huffyuvencdsp.c | 4 ++--
> > libavcodec/huffyuvencdsp.h |
llard
+;* Copyright (c) 2002-2004 Michael Niedermayer
+;*
+;* MMX optimization by Nick Kurshev
+;* Conversion to NASM format by Tiancheng "Timothy" Gu
+;*
+;* This file is part of FFmpeg.
+;*
+;* FFmpeg is free software; you can redistribute it and/or
+;* modify it under the terms of the GNU
On Tue, Oct 20, 2015 at 9:30 AM Michael Niedermayer
wrote:
> On Sat, Oct 17, 2015 at 06:05:45PM -0700, Timothy Gu wrote:
> > This reverts commit 628e6d0164febc8e69b0f10dfa487e8a2dd1a28a and uses
> > a better fix.
> >
> > Before:
> > 4483 decicycles in get_pix
Before:
15543 decicycles in get_pixels, 4193214 runs, 1090 skips
After:
5713 decicycles in get_pixels, 8387564 runs, 1044 skips
---
libavcodec/pixblockdsp.c | 36 ++-
libavcodec/pixblockdsp_template.c | 40 ---
2
On Tue, Oct 20, 2015 at 2:18 PM James Almer wrote:
> Removing this will make the INLINE_MMXEXT if statement below fail to
> compile on
> builds with inline asm disabled (msvc, etc). Even with dead code
> elimination in
> mind you'd need at least a prototype for the relevant functions.
> Just move
SSE2 version 4%-35% faster than MMX depending on the width.
AVX2 version 1%-13% faster than SSE2 depending on the width.
---
Addressed James's and Henrik's advices. Removed heuristics based on width.
Made available both aligned and unaligned versions. For AVX2 version,
gracefully fall back on SSE2
On Tue, Oct 20, 2015 at 7:09 PM Ganesh Ajjanagadde wrote:
> Hi all,
>
> It is known that there exist at least certain parts of the codebase
> that do not work correctly if ints are 64 bits. One of them I noticed
> was in avutil/intmath.h: ff_ctz_c does not compute the right thing if
> int is 64 b
On Tue, Oct 20, 2015 at 7:36 PM James Almer wrote:
> On 10/20/2015 10:32 PM, Timothy Gu wrote:
> > +; mov type used for src1q, dstq, first reg, second reg
> > +%macro DIFF_BYTES_LOOP_CORE 4
> > +%if regsize != 16
>
> %if mmsize != 16
>
> By checking regsize you
On Wed, Oct 21, 2015 at 10:32 AM Timothy Gu wrote:
> On Tue, Oct 20, 2015 at 7:36 PM James Almer wrote:
>
>> On 10/20/2015 10:32 PM, Timothy Gu wrote:
>>
> > +; mov type used for src1q, dstq, first reg, second reg
>> > +%macro DIFF_BYTES_LOOP_CORE 4
>>
On Wed, Oct 21, 2015 at 10:46 AM Christophe Gisquet <
christophe.gisq...@gmail.com> wrote:
> 2015-10-18 2:47 GMT+02:00 Timothy Gu :
> > This function is only used within other inline asm functions, hence the
> > HAVE_MMX_INLINE guard. Per recent discussions, we should no
On Thu, Oct 22, 2015 at 5:01 PM Ganesh Ajjanagadde
wrote:
> Sample benchmark (x86-64, Haswell, GNU/Linux), fraps-v2 from FATE:
> new:
> 280110 decicycles in qsort, 1 runs, 0 skips
> 268260 decicycles in qsort, 2 runs, 0 skips
>
> old:
> 1469910 decicycles in qsort, 1 r
On Sat, Oct 24, 2015 at 11:03 AM James Almer wrote:
> Gentoo and Debian both seem to ship it. Arch does as well but on their
> Community repository (ffmpeg adopting it may be incentive enough for them
> to move it to Extra).
>
In fact, at least two of the reverse dependencies (out of 8, not count
On Tue, Oct 20, 2015 at 11:29 PM Michael Niedermayer
wrote:
> > diff --git a/libavcodec/pixblockdsp.c b/libavcodec/pixblockdsp.c
> > index 322e1dd..0f23d8a 100644
> > --- a/libavcodec/pixblockdsp.c
> > +++ b/libavcodec/pixblockdsp.c
> > @@ -23,12 +23,38 @@
> > #include "avcodec.h"
> > #include
---
libavcodec/x86/pixblockdsp.asm | 66 --
1 file changed, 31 insertions(+), 35 deletions(-)
diff --git a/libavcodec/x86/pixblockdsp.asm b/libavcodec/x86/pixblockdsp.asm
index 7c5377b..a7d9816 100644
--- a/libavcodec/x86/pixblockdsp.asm
+++ b/libavcodec/x8
b/tests/checkasm/pixblockdsp.c
new file mode 100644
index 000..d59d162
--- /dev/null
+++ b/tests/checkasm/pixblockdsp.c
@@ -0,0 +1,107 @@
+/*
+ * Copyright (c) 2015 Tiancheng "Timothy" Gu
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and
---
libavfilter/vf_boxblur.c | 110 +++
1 file changed, 44 insertions(+), 66 deletions(-)
diff --git a/libavfilter/vf_boxblur.c b/libavfilter/vf_boxblur.c
index ef01cf9..6934076 100644
--- a/libavfilter/vf_boxblur.c
+++ b/libavfilter/vf_boxblur.c
@@ -20
On Sun, Nov 1, 2015 at 11:10 AM Ganesh Ajjanagadde wrote:
> Have not tested, but just a general comment. Personally, I follow the
> twice repition is ok, thrice means it is good to factor out. I would
> have been happier if the diff-stat was better than 44+/66- in terms of
> deletions.
The most
On Sun, Nov 1, 2015 at 4:45 PM Michael Niedermayer
wrote:
> On Sun, Nov 01, 2015 at 10:40:03AM -0800, Timothy Gu wrote:
> > ---
> > libavfilter/vf_boxblur.c | 110
> +++
> > 1 file changed, 44 insertions(+), 66 deletions(-)
On Mon, Nov 2, 2015 at 8:23 PM Rostislav Pehlivanov
wrote:
> >if one removes the crippling
> >-fno-tree-vectorize
> Yes, I think a config option to turn this flag on (like the unsafe
> bitstream reader) would be good. Defaulting to off by default if it doesn't
> break anything for at least a few
On Tue, Nov 3, 2015 at 4:47 AM Ganesh Ajjanagadde > - GCC vectorization
slows down compilation A LOT in all versions. The newer
> > the worse.
>
> A ~ 20% slowdown on a build for a ~ 20% improvement in an overall FATE
> bench - sounds like a win to me especially with ccache.
Of course, but unfor
On Sun, Nov 1, 2015 at 8:59 AM Timothy Gu wrote:
> ---
> libavcodec/x86/pixblockdsp.asm | 66
> --
> 1 file changed, 31 insertions(+), 35 deletions(-)
>
Ping set.
Timothy
___
ffmpeg-devel mail
On Fri, Nov 06, 2015 at 08:18:39PM +0100, Andreas Cadhalpun wrote:
[...]
> diff --git a/src/download b/src/download
> index 5691fbd..6d3517e 100644
> --- a/src/download
> +++ b/src/download
> @@ -53,13 +53,22 @@
>
> Linux Packages
>
> + href="https://track
On Fri, Nov 06, 2015 at 09:11:40PM +0100, Andreas Cadhalpun wrote:
> Subject: [FFmpeg-devel] [PATCH] jvdec: avoid unsized overflow in comparison
*unsigned
[...]
Timothy
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/lis
diff --git a/tests/checkasm/pixblockdsp.c b/tests/checkasm/pixblockdsp.c
new file mode 100644
index 000..70e7f74
--- /dev/null
+++ b/tests/checkasm/pixblockdsp.c
@@ -0,0 +1,107 @@
+/*
+ * Copyright (c) 2015 Tiancheng "Timothy" Gu
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free
@@
+/*
+ * Raw v210 video demuxer
+ * Copyright (c) 2015 Tiancheng "Timothy" Gu
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software
@@
+/*
+ * Raw v210 video demuxer
+ * Copyright (c) 2015 Tiancheng "Timothy" Gu
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software
/null
+++ b/libavformat/v210.c
@@ -0,0 +1,133 @@
+/*
+ * Raw v210 video demuxer
+ * Copyright (c) 2015 Tiancheng "Timothy" Gu
+ *
+ * This file is part of FFmpeg.
+ *
+ * FFmpeg is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser Gene
On Sat, Nov 07, 2015 at 10:22:34PM -0300, James Almer wrote:
> On 11/7/2015 9:45 PM, Timothy Gu wrote:
> > +#define OFFSET(x) offsetof(V210DemuxerContext, x)
> > +#define DEC AV_OPT_FLAG_DECODING_PARAM
> > +static const AVOption v210_options[] = {
> > +{ "video
On Sun, Nov 08, 2015 at 03:04:21AM +0100, Michael Niedermayer wrote:
> On Sat, Nov 07, 2015 at 03:58:28PM -0800, Timothy Gu wrote:
> > ---
> >
> > Consolidates BUF_SIZE macros
> >
> > ---
> > tests/checkasm/Makefile | 1 +
> > tests/checka
---
libavcodec/aaccoder_twoloop.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/aaccoder_twoloop.h b/libavcodec/aaccoder_twoloop.h
index e53257f..328d7c8 100644
--- a/libavcodec/aaccoder_twoloop.h
+++ b/libavcodec/aaccoder_twoloop.h
@@ -691,7 +691,7 @@ static void
---
libavformat/genh.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/libavformat/genh.c b/libavformat/genh.c
index 260e320..44862b3 100644
--- a/libavformat/genh.c
+++ b/libavformat/genh.c
@@ -40,7 +40,6 @@ static int genh_read_header(AVFormatContext *s)
{
unsigned s
On Sun, Nov 8, 2015 at 9:28 AM Claudio Freire
wrote:
> This particular piece of code is going to disappear soon, so not sure
> it's worth applying the patch.
>
Oh, okay then.
> Is the warning causing any troubles?
>
No, other than the minor annoyance it causes when compiling.
Timothy
___
On Mon, Nov 9, 2015 at 10:26 AM Calvin Walton
wrote:
> The ffmpeg command-line tool actually maps the "-s" and "-r" input
> options to "video_size" and "framerate" respectively on the input
> format. This will work automatically.
>
Thanks for the clarification :)
Timothy
___
On Sun, Nov 8, 2015 at 7:24 AM Kieran Kunhya wrote:
> On 8 November 2015 at 00:30, Timothy Gu wrote:
> > Allows one to do:
> >
> > ffmpeg -s 1920x1080 -i blah.v210 ...
> > ffmpeg -s 1920x1080 -f v210x -i blah.yuv10 ...
> >
> > Fixes #1869
tr -d '\r' ?
Timothy
El El lun, 16 de nov de 2015 a las 4:26 AM, Marton Balint
escribió:
> Sed \r is not portable, it does not work on freebsd, hopefully awk will.
>
> Signed-off-by: Marton Balint
> ---
> tests/fate-run.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
More readable and less breakable.
---
libavutil/imgutils.c | 14 --
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c
index 8956ae3..a189a50 100644
--- a/libavutil/imgutils.c
+++ b/libavutil/imgutils.c
@@ -236,11 +236,21 @@ typed
Calculate packet size only once, and propagate errors earlier in the chain.
Also remove use of the deprecated av_image_get_buffer_size().
---
libavformat/rawvideodec.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/libavformat/rawvideodec.c b/libavformat/raw
Fixes a floating point exception when width and height are not supplied
(and therefore are zero).
---
libavformat/v210.c | 17 +
1 file changed, 9 insertions(+), 8 deletions(-)
diff --git a/libavformat/v210.c b/libavformat/v210.c
index ab29171..7503d5d 100644
--- a/libavformat/v21
On Sat, Nov 21, 2015 at 07:23:08PM +0100, Michael Niedermayer wrote:
> width and height are unused after this
> patch should be fine otherwise
Fixed and pushed. Thanks!
Timothy
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mail
On Sat, Nov 21, 2015 at 07:20:48PM +0100, Michael Niedermayer wrote:
> width and height are unused after this patch
Fixed and pushed. Thanks!
Timothy
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On Wed, Nov 25, 2015 at 12:35:03AM +0100, Andreas Cadhalpun wrote:
> They are not very helpful and feel out-of-place.
>
> Suggested-by: Timothy Gu
> Signed-off-by: Andreas Cadhalpun
> ---
> src/download | 6 +-
> 1 file changed, 1 insertion(+), 5 deletio
On Wed, Nov 25, 2015 at 05:17:29PM -0500, Ganesh Ajjanagadde wrote:
> +double f = value * cbrt_lut[value] * pow(2, (exponent - 400) *
> 0.25 + FRAC_BITS + 5) / IMDCT_SCALAR;
While at it, you could change pow(2 to exp2(, which has a libm.h shim
and is easily 4 times faster than pow() o
On Wed, Nov 25, 2015 at 6:03 PM Timothy Gu wrote:
> On Wed, Nov 25, 2015 at 05:17:29PM -0500, Ganesh Ajjanagadde wrote:
> > +double f = value * cbrt_lut[value] * pow(2, (exponent -
> 400) * 0.25 + FRAC_BITS + 5) / IMDCT_SCALAR;
>
> While at it, you could change pow
Fixes FATE failures on --enable-small builds.
---
tests/fate-run.sh | 4 ++--
tests/ref/fate/concat-demuxer-extended-lavf-mxf | 2 +-
tests/ref/fate/concat-demuxer-extended-lavf-mxf_d10 | 2 +-
tests/ref/fate/concat-demuxer-simple1-lavf-mxf | 4 ++--
test
---
ffprobe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ffprobe.c b/ffprobe.c
index c304a6d..216db379 100644
--- a/ffprobe.c
+++ b/ffprobe.c
@@ -2148,7 +2148,7 @@ static int show_stream(WriterContext *w, AVFormatContext
*fmt_ctx, int stream_id
}
}
On Fri, Nov 27, 2015 at 03:08:05PM +, Rostislav Pehlivanov wrote:
> I've just pushed a patch which makes the AAC encoder threadsafe, so now
> it should be safe to always generate that table at runtime.
This commit seems to break FATE on a couple of platforms (not sure about
Linux yet but proba
Instead, print "unknown" if it's unknown, or their numerical values if
they are known.
---
Addresses Nicholas's comment.
---
ffprobe.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/ffprobe.c b/ffprobe.c
index c304a6d..7128083 100644
--- a/ffprobe.c
+++ b/ffprob
Fixes FATE failures on --enable-small builds.
---
tests/fate-run.sh | 4 ++--
tests/ref/fate/concat-demuxer-extended-lavf-mxf | 2 +-
tests/ref/fate/concat-demuxer-extended-lavf-mxf_d10 | 2 +-
tests/ref/fate/concat-demuxer-simple1-lavf-mxf | 4 ++--
test
On Sat, Nov 28, 2015 at 02:06:07PM -0500, Rick Kern wrote:
> vtenc.c was updated to match the coding style of the project.
>
> I used several other files to get a feel for the project's coding
> style. Is there documentation for this?
Yes: https://ffmpeg.org/developer.html#Coding-Rules-1
Timothy
On Sat, Nov 28, 2015 at 05:48:57PM -0500, Rick Kern wrote:
> K&R coding style is implied but not listed in 'Coding Rules'.
>
> Signed-off-by: Rick Kern
> ---
> doc/developer.texi | 3 +++
> 1 file changed, 3 insertions(+)
LGTM as well. Applied, thanks!
Timothy
_
On Fri, Nov 27, 2015 at 02:33:02PM -0800, Timothy Gu wrote:
> Instead, print "unknown" if it's unknown, or their numerical values if
> they are known.
> ---
>
> Addresses Nicholas's comment.
>
> ---
> ffprobe.c | 12 +---
> 1 file changed,
CCFLAGS is equivalent to CPPFLAGS + CFLAGS.
---
common.mak | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/common.mak b/common.mak
index d611ef8..05836ba 100644
--- a/common.mak
+++ b/common.mak
@@ -63,7 +63,7 @@ COMPILE_HOSTC = $(call COMPILE,HOSTCC)
$(COMPILE_C)
%.
---
libavdevice/decklink_common.cpp | 4
libavdevice/decklink_common.h | 8 +++-
libavdevice/decklink_common_c.h | 2 ++
libavdevice/decklink_dec.cpp| 4
libavdevice/decklink_dec.h | 2 ++
libavdevice/decklink_enc.cpp| 4
libavdevice/decklink_enc.h | 2 ++
7
It is a C++ file, incompatible with the checkheaders infrastructure.
---
libavdevice/Makefile | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavdevice/Makefile b/libavdevice/Makefile
index f57ec0b..8394e87 100644
--- a/libavdevice/Makefile
+++ b/libavdevice/Makefile
@@ -58
On Wed, Dec 02, 2015 at 08:03:33PM +0100, Michael Niedermayer wrote:
> On Tue, Dec 01, 2015 at 09:46:04PM -0800, Timothy Gu wrote:
> > CCFLAGS is equivalent to CPPFLAGS + CFLAGS.
> > ---
> > common.mak | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
&g
Hi,
Please do not top post.
On Fri, Dec 4, 2015 at 10:57 AM Eran Kornblau
wrote:
> Thank you !
>
> Opened a pull request here: https://github.com/FFmpeg/FFmpeg/pull/162
>
Please send the patches to the mailing list. See
https://github.com/FFmpeg/FFmpeg/pull/153
> I used libavutil/aes as you
On Sat, Dec 05, 2015 at 07:14:43PM +, Rostislav Pehlivanov wrote:
> Signed-off-by: Rostislav Pehlivanov
> ---
> src/index | 21 +
> 1 file changed, 21 insertions(+)
>
> diff --git a/src/index b/src/index
> index d1d4a58..0c54046 100644
> --- a/src/index
> +++ b/src/index
The _de facto_ policy on patch submission has always been "sending it to
the mailing list."
---
doc/developer.texi | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/doc/developer.texi b/doc/developer.texi
index 9a901d8..9383b21 100644
--- a/doc/developer.texi
+++ b/doc/develop
Hi,
On Sat, Dec 19, 2015 at 11:23 AM Matthias Hunstock <
matthias.hunst...@tu-ilmenau.de> wrote:
> Am 18.12.2015 um 20:25 schrieb Matthias Hunstock:
> > Introduces new option.
>
> PS. I did not find any ressources on how to properly name new FFmpeg
> options, e.g. to be consistent. Using the exis
---
libavfilter/avf_showspectrum.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libavfilter/avf_showspectrum.c b/libavfilter/avf_showspectrum.c
index 5b26be8..a967a41 100644
--- a/libavfilter/avf_showspectrum.c
+++ b/libavfilter/avf_showspectrum.c
@@ -240,7 +240,7 @@ stati
On Sat, Jan 09, 2016 at 09:23:43PM +, Paul B Mahol wrote:
>
> I already set color range.
Fixed and pushed.
Timothy
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On Sun, Jan 10, 2016 at 10:04:34PM +, Ricardo Constantino wrote:
> Either disabling or init'ing secure memory is required after the use
> of gcry_check_version. From a look at the functions rtmpdh uses, I
> noticed none require the use of secure memory, so we disable it [1][2].
>
> This resol
On Wed, Jan 20, 2016 at 09:44:32PM +0100, Clément Bœsch wrote:
> diff --git a/libavutil/thread.h b/libavutil/thread.h
> index 32ddf40..a7b5763 100644
> --- a/libavutil/thread.h
> +++ b/libavutil/thread.h
> @@ -169,4 +169,13 @@ static inline int ff_thread_once(char *control, void
> (*routine)(void)
Hi,
On Wednesday, January 20, 2016, John Pompeii
wrote:
> Hi,
> I am building ffmpeg.exe and ffprobe.exe on 64 bit windows (7) using
> MSYS2/MINGW64. I've resolved all the dependent libraries and got a build
> and it does appear to run just fine as a 64 windows app. This issue that I
> have is
Hi,
On Sat, Jan 23, 2016 at 10:57:06AM +0530, Ganesh Ajjanagadde wrote:
>
> I take it that you are fine with updating the help text accordingly as
> well in ffmpeg.c?
The idea sounds fine. I would love to see the patch though.
Timothy
___
ffmpeg-devel
Hi,
On Fri, Jan 22, 2016 at 11:24:19PM +0530, Ganesh Ajjanagadde wrote:
> +@item h
> +Dump packets/hex; press to cycle through the 3 states.
What are the three states? Packets, hex, emacs-emulation?
> +@item d
> +Accept subsequent entry up to carriage return as debug mode.
What is "subsequent e
On Sat, Jan 23, 2016 at 07:17:00PM +, Mark Thompson wrote:
>
> ---
> configure | 2 +
> libavfilter/Makefile| 1 +
> libavfilter/allfilters.c| 1 +
> libavfilter/vf_vaapi_conv.c | 537
>
> 4 files changed, 541 i
On Sat, Jan 23, 2016 at 07:13:38PM +, Mark Thompson wrote:
> +av_log(0, AV_LOG_ERROR, "Failed to destroy surface: "
> + "%d (%s).\n", vas, vaErrorStr(vas));
Maybe you can consider adding an AVClass just for logging. Either way the “0”
needs to be “NULL.”
Here and below.
On Sat, Jan 23, 2016 at 07:14:29PM +, Mark Thompson wrote:
> diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c
> index 9b341cf..fd41600 100644
> --- a/ffmpeg_opt.c
> +++ b/ffmpeg_opt.c
> @@ -82,6 +82,9 @@ const HWAccel hwaccels[] = {
> #if CONFIG_LIBMFX
> { "qsv", qsv_init, HWACCEL_QSV, AV_P
301 - 400 of 626 matches
Mail list logo
