Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-09 Thread Teresa Johnson
I implemented this change to add a new macro. I tried to find the variables used in MANGLE and change those to use the new DECLARE_ASM_ALIGNED, and the build succeeds with these changes. New changes are in cl/172133815. Teresa On Wed, Nov 1, 2017 at 7:25 AM, Teresa Johnson wrote: > > &g

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-31 Thread Teresa Johnson
quot;, "ff_w" and many more. > > i guess these are all accessed directly, like through MANGLE() > > > > > > > > > Marking all aligned variables as used makes it harder to spot unused > > > variables leading to accumulation of cruft > > > > > > > I see. Maybe we can annotate only

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-01 Thread Teresa Johnson
On Tue, Oct 31, 2017 at 5:42 PM, Michael Niedermayer wrote: > Hi > > On Tue, Oct 31, 2017 at 04:29:18PM +0000, Teresa Johnson wrote: > > It's needed for the same reason the used attribute was already added to > the > > "static const" variables. For t