Re: [FFmpeg-devel] [PATCH v1 1/1] avformat/amr: Return PATCHWELCOME on stereo files

2021-09-26 Thread Sun Zhenliang
在 2021年9月26日 +0800 20:40,myp...@gmail.com ,写道: > On Thu, Sep 16, 2021 at 11:24 AM sunzhenliang > wrote: > > > > Signed-off-by: sunzhenliang > > --- > > libavformat/amr.c | 22 ++ > > 1 file changed, 18 insertions(+), 4 deletions(-) > > > > diff --git a/libavformat/amr.c b/libav

Re: [FFmpeg-devel] [PATCH v1 1/1] avformat/amr: Return PATCHWELCOME on stereo files

2021-09-29 Thread Sun Zhenliang
ping for review. 在 2021年9月27日 +0800 09:48,Sun Zhenliang ,写道: > 在 2021年9月26日 +0800 20:40,myp...@gmail.com ,写道: > > On Thu, Sep 16, 2021 at 11:24 AM sunzhenliang > > wrote: > > > > > > Signed-off-by: sunzhenliang > > > --- > > > libavformat/amr

Re: [FFmpeg-devel] [PATCH v1 1/1] avformat/amr: Return PATCHWELCOME on stereo files

2021-09-30 Thread Sun Zhenliang
在 2021年9月30日 +0800 19:56,Paul B Mahol ,写道: > On Thu, Sep 30, 2021 at 5:05 AM Sun Zhenliang > wrote: > > > ping for review. > > > > have amr-wb mc stereo sample? yes, here are the stereo amr-wb/nb files. https://github.com/HiSunzhenliang/patch/blob/main/ffmpeg/avformat

Re: [FFmpeg-devel] [PATCH v1 1/1] avformat/amr: Return PATCHWELCOME on stereo files

2021-09-30 Thread Sun Zhenliang
2021年10月1日 +0800 03:19 Paul B Mahol ,写道: > On Thu, Sep 30, 2021 at 4:42 PM Sun Zhenliang > wrote: > > > 在 2021年9月30日 +0800 19:56,Paul B Mahol ,写道: > > > On Thu, Sep 30, 2021 at 5:05 AM Sun Zhenliang < > > hisunzhenli...@outlook.com> > &

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/amr*dec: add multichannel support

2021-09-30 Thread Sun Zhenliang
Sent with a Spark 2021年10月1日 +0800 05:01 Paul B Mahol ,写道: > Signed-off-by: Paul B Mahol > --- > libavcodec/amr_parser.c | 39 ++ > libavcodec/amrnbdec.c | 54 +++- > libavcodec/amrwbdec.c | 59 +-- > libavfo

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/amr*dec: add multichannel support

2021-10-01 Thread Sun Zhenliang
2021年10月1日 +0800 14:41 Paul B Mahol ,写道: > On Fri, Oct 1, 2021 at 3:17 AM Sun Zhenliang > wrote: > > > > > Sent with a Spark > > 2021年10月1日 +0800 05:01 Paul B Mahol ,写道: > > > Signed-off-by: Paul B Mahol > > > --- > > > libavcodec/amr_par

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/amr*dec: add multichannel support

2021-10-04 Thread Sun Zhenliang
在 2021年10月1日 +0800 22:11,Paul B Mahol ,写道: > On Fri, Oct 1, 2021 at 4:03 PM Sun Zhenliang > wrote: > > > 2021年10月1日 +0800 14:41 Paul B Mahol ,写道: > > > On Fri, Oct 1, 2021 at 3:17 AM Sun Zhenliang > > > > > wrote: > > > > > > > >

[FFmpeg-devel] 回复: [PATCH] libavformat/movenc: add support for HEVC in .3gp

2020-12-09 Thread Sun Zhenliang
1) 3GPP TS 26.244 V16.1.0 (2020-09) and ISO/IEC 14496-15: "Information technology – Coding of audio-visual objects – Part 15: Carriage of NAL unit structured video in the ISO base media file format" states HEVC's sample entry in 3GPP file format. I think these documentations says we can store

[FFmpeg-devel] 回复: 回复: [PATCH] libavformat/movenc: add support for HEVC in .3gp

2020-12-09 Thread Sun Zhenliang
PATCH] libavformat/movenc: add support for HEVC in .3gp On Wed, Dec 9, 2020 at 4:34 PM Sun Zhenliang wrote: > > 1) 3GPP TS 26.244 V16.1.0 (2020-09) and ISO/IEC 14496-15: "Information > technology – Coding of audio-visual objects – Part 15: Carriage of NAL unit > structured video in t

[FFmpeg-devel] 回复: 回复: [PATCH] libavformat/movenc: add support for HEVC in .3gp

2020-12-09 Thread Sun Zhenliang
MKTAG('a','v','c','1') }, +{ AV_CODEC_ID_HEVC, MKTAG('h','e','v','1') }, { AV_CODEC_ID_MPEG4,MKTAG('m','p','4','v') }, { AV_CODEC_ID_AAC, MKTAG('m','p&#

[FFmpeg-devel] 回复: 回复: 回复: [PATCH] libavformat/movenc: add support for HEVC in .3gp

2020-12-10 Thread Sun Zhenliang
@ffmpeg.org 主题: Re: [FFmpeg-devel] 回复: 回复: [PATCH] libavformat/movenc: add support for HEVC in .3gp Patchwork hasn't picked it up. Send without non-Latin characters, and as plaintext encoding, same as your original patch. Regards, Gyan On 10-12-2020 11:41 am, Sun Zhenliang wrote: >In

[FFmpeg-devel] 回复: [PATCH] libavformat/movenc: add support for HEVC in .3gp

2020-12-10 Thread Sun Zhenliang
ok, I'll fix it and add a new patch shortly. And should i make [FFmpeg-devel,v2] to add the new patch ?and how? I am new to the patchwork, it would be helpful if you could give me some guidances. Regards, SunZhenliang 发件人: ffmpeg-devel 代表 Gyan Doshi 发送时间: 20

[FFmpeg-devel] 回复: [PATCH v2] libavformat/movenc: add support for HEVC in .3gp

2020-12-10 Thread Sun Zhenliang
The modification has been completed and the patch has been submitted. Thanks for your review, Gyan. Regards, SunZhenliang 发件人: ffmpeg-devel 代表 Gyan Doshi 发送时间: 2020年12月11日 12:33 收件人: ffmpeg-devel@ffmpeg.org 主题: Re: [FFmpeg-devel] [PATCH v2] libavformat/movenc:

[FFmpeg-devel] 回复: [PATCH, v3] libavformat/movenc: add support for HEVC in .3gp

2020-12-10 Thread Sun Zhenliang
Emmm, I didn't think carefully. Fixed it now. Sorry for another patch. Regards, Sunzhenliang 发件人: ffmpeg-devel 代表 Gyan Doshi 发送时间: 2020年12月11日 13:20 收件人: ffmpeg-devel@ffmpeg.org 主题: Re: [FFmpeg-devel] [PATCH, v3] libavformat/movenc: add support for HEVC in .3

[FFmpeg-devel] 转发: [PATCH, v4] libavformat/movenc: Add support for HEVC in .3gp

2020-12-11 Thread Sun Zhenliang
>> +if (st->codecpar->codec_id == AV_CODEC_ID_H265){ >pay attention about the code style Sorry, I couldn't see problems in code style. Can you explain it in more detail, it would be helpful. Appreciate and regards, SunZhenliang 发件人: Steven Liu 发送时间: 20

[FFmpeg-devel] 回复: [PATCH, v4] libavformat/movenc: Add support for HEVC in .3gp

2020-12-11 Thread Sun Zhenliang
I think there two files: 3GPP TS 26.244 V16.1.0 (2020-09) and ISO/IEC 14496-15 2019: "Information technology – Coding of audio-visual objects – Part 15: Carriage of NAL unit structured video in the ISO base media file format" states the major brands of HEVC. https://www.etsi.org/deliver/etsi_ts/

[FFmpeg-devel] 回复: 回复: [PATCH, v4] libavformat/movenc: Add support for HEVC in .3gp

2020-12-11 Thread Sun Zhenliang
rks same to HEVC. Regards, SunZhenliang 发件人: ffmpeg-devel 代表 Jan Ekström 发送时间: 2020年12月12日 01:12 收件人: FFmpeg development discussions and patches 主题: Re: [FFmpeg-devel] 回复: [PATCH, v4] libavformat/movenc: Add support for HEVC in .3gp On Fri, Dec 11, 2020 at 3:27 PM Sun Zhenl

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-04 Thread Sun Zhenliang
> > On Sep 4, 2021, at 16:01, Hendrik Leppkes wrote: > > On Sat, Sep 4, 2021 at 9:10 AM sunzhenliang > wrote: >> >> Those comfort noise frames and empty frames should be >> considered the correct frame. And amr.c/amr_read_packet() >> also takes them as correct frames too. >> >> Signed-off-

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-06 Thread Sun Zhenliang
在 2021年9月7日 +0800 00:55,Paul B Mahol ,写道: > On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang > wrote: > > > > > > > > > On Sep 4, 2021, at 16:01, Hendrik Leppkes wrote: > > > > > > On Sat, Sep 4, 2021 at 9:10 AM sunzhenliang > > wrote: &g

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-07 Thread Sun Zhenliang
在 2021年9月7日 +0800 14:16,Paul B Mahol ,写道: > On Tue, Sep 7, 2021 at 7:34 AM Sun Zhenliang > wrote: > > > 在 2021年9月7日 +0800 00:55,Paul B Mahol ,写道: > > > On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang > > > > > wrote: > > > > > > > &

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-07 Thread Sun Zhenliang
在 2021年9月7日 +0800 19:13,Paul B Mahol ,写道: > On Tue, Sep 7, 2021 at 11:36 AM Sun Zhenliang > wrote: > > > 在 2021年9月7日 +0800 14:16,Paul B Mahol ,写道: > > > On Tue, Sep 7, 2021 at 7:34 AM Sun Zhenliang > > > > > wrote: > > > > > > > 在 202

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-07 Thread Sun Zhenliang
在 2021年9月8日 +0800 00:14,Paul B Mahol ,写道: > On Tue, Sep 7, 2021 at 4:48 PM Sun Zhenliang > wrote: > > > 在 2021年9月7日 +0800 19:13,Paul B Mahol ,写道: > > > On Tue, Sep 7, 2021 at 11:36 AM Sun Zhenliang < > > hisunzhenli...@outlook.com> > > > wrote: >

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-08 Thread Sun Zhenliang
在 2021年9月8日 +0800 16:37,Paul B Mahol ,写道: > On Wed, Sep 8, 2021 at 4:23 AM Sun Zhenliang > wrote: > > > 在 2021年9月8日 +0800 00:14,Paul B Mahol ,写道: > > > On Tue, Sep 7, 2021 at 4:48 PM Sun Zhenliang > > > > > wrote: > > > > > > > 在 202

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-08 Thread Sun Zhenliang
在 2021年9月8日 +0800 17:55,Hendrik Leppkes ,写道: > On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang > wrote: > > > > Thanks for reviewing. > > > > Probing is expecting to find “correct” frames, which includes those kinds > > of comfort noise and NO_DATA fra

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-08 Thread Sun Zhenliang
在 2021年9月8日 +0800 17:10,Paul B Mahol ,写道: > On Wed, Sep 8, 2021 at 10:56 AM Sun Zhenliang > wrote: > > > 在 2021年9月8日 +0800 16:37,Paul B Mahol ,写道: > > > On Wed, Sep 8, 2021 at 4:23 AM Sun Zhenliang > > > > > wrote: > > > > > > > 在 202

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-13 Thread Sun Zhenliang
在 2021年9月8日 +0800 22:12,Sun Zhenliang ,写道: > 在 2021年9月8日 +0800 17:10,Paul B Mahol ,写道: > > On Wed, Sep 8, 2021 at 10:56 AM Sun Zhenliang > > wrote: > > > > > 在 2021年9月8日 +0800 16:37,Paul B Mahol ,写道: > > > > On Wed, Sep 8, 2021 at 4:23 AM Sun Zhenliang

Re: [FFmpeg-devel] [PATCH v1 1/1] libavformat/amr.c: remove mode range check

2021-09-13 Thread Sun Zhenliang
在 2021年9月8日 +0800 21:48,Sun Zhenliang ,写道: > 在 2021年9月8日 +0800 17:55,Hendrik Leppkes ,写道: > > On Sat, Sep 4, 2021 at 1:52 PM Sun Zhenliang > > wrote: > > > > > > Thanks for reviewing. > > > > > > Probing is expecting to find “correct” frames,

Re: [FFmpeg-devel] [PATCH v1 1/1] avformat/amr: Return PATCHWELCOME on stereo files

2021-09-16 Thread Sun Zhenliang
Ping. Anyone could review this patch? Thx. 在 2021年9月16日 +0800 11:24,sunzhenliang ,写道: > Signed-off-by: sunzhenliang > --- > libavformat/amr.c | 22 ++ > 1 file changed, 18 insertions(+), 4 deletions(-) > > diff --git a/libavformat/amr.c b/libavformat/amr.c > index 836b276fd5..

Re: [FFmpeg-devel] [PATCH v1 1/1] avformat/amr: Return PATCHWELCOME on stereo files

2021-09-17 Thread Sun Zhenliang
ich followed 3GPP specifications. FFmpeg did not recognize this audio before. With this patch, it will detect correctly and show patches welcome. > > On Fri, Sep 17, 2021 at 4:14 AM Sun Zhenliang > wrote: > > > Ping. > > > > Anyone could review this patch? > >

Re: [FFmpeg-devel] [PATCH v1 1/1] avformat/amr: Return PATCHWELCOME on stereo files

2021-09-18 Thread Sun Zhenliang
Ping. 在 2021年9月17日 +0800 15:28,Sun Zhenliang ,写道: > 在 2021年9月17日 +0800 14:49,Paul B Mahol ,写道: > > Are stereo files available somewhere? Known way to encode? > Here is the stereo file, > https://github.com/HiSunzhenliang/patch/blob/main/ffmpeg/avformat-amr-Return-PATCHWELCOME-

Re: [FFmpeg-devel] [PATCH v1 1/1] avformat/amr: Return PATCHWELCOME on stereo files

2021-09-21 Thread Sun Zhenliang
ping. Anyone could review this ? > On Sep 18, 2021, at 20:40, Sun Zhenliang wrote: > > Ping. > 在 2021年9月17日 +0800 15:28,Sun Zhenliang ,写道: >> 在 2021年9月17日 +0800 14:49,Paul B Mahol ,写道: >>> Are stereo files available somewhere? Known way to encode? >>

Re: [FFmpeg-devel] [PATCH v1 1/1] avformat/amr: Return PATCHWELCOME on stereo files

2021-09-24 Thread Sun Zhenliang
ping. 在 2021年9月21日 +0800 20:08,Sun Zhenliang ,写道: > > ping. Anyone could review this ? > > > On Sep 18, 2021, at 20:40, Sun Zhenliang wrote: > > > > Ping. > > 在 2021年9月17日 +0800 15:28,Sun Zhenliang ,写道: > > > 在 2021年9月17日 +0800 14:49,Paul B Mahol ,写道: &g