Re: [FFmpeg-devel] [PATCH 1/5] fftools/ffprobe: Fix memleak

2023-08-01 Thread Stefano Sabatini
On date Monday 2023-07-31 13:08:37 +0200, Andreas Rheinhardt wrote: > Fixes Coverity issue #1524491. > Regression since e6126abc6997058ca49ee596b70611bbe367163e. > > Signed-off-by: Andreas Rheinhardt > --- > fftools/ffprobe.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > dif

Re: [FFmpeg-devel] [PATCH 45/47] fftools/ffprobe: inline opt_output_file() into its only caller

2023-08-01 Thread Stefano Sabatini
On date Saturday 2023-07-15 12:46:09 +0200, Anton Khirnov wrote: > There is no reason to keep them separate. > > Also, replace exit_program() with returning an error code. > --- > fftools/ffprobe.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/fftools/ffprobe.c

Re: [FFmpeg-devel] [PATCH 46/47] fftools/ffprobe: stop calling exit_program()

2023-08-01 Thread Stefano Sabatini
On date Saturday 2023-07-15 12:46:10 +0200, Anton Khirnov wrote: > Inline the relevant part of ffprobe_cleanup() into main() and drop the > rest. > --- > fftools/ffprobe.c | 22 -- > 1 file changed, 8 insertions(+), 14 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/

Re: [FFmpeg-devel] [PATCH] lavu: add AVVideoHint API

2023-08-01 Thread Stefano Sabatini
On date Friday 2023-07-28 09:44:37 +0200, Stefano Sabatini wrote: > On date Wednesday 2023-07-26 10:52:57 +, Carotti, Elias wrote: > > On Mon, 2023-07-24 at 01:27 +0200, Stefano Sabatini wrote: > > > CAUTION: This email originated from outside of the organization. Do > &

Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: Use proper enum type

2023-08-08 Thread Stefano Sabatini
On date Sunday 2023-08-06 15:28:00 +0200, Andreas Rheinhardt wrote: > This is a bit cleaner as int need not be the underlying type > of an enum if a smaller type can hold all its values. > Also declare the children_ids array as const as it never changes. > > Signed-off-by: Andreas Rheinhardt > --

Re: [FFmpeg-devel] [PATCH 2/2] lavc/libx264: add mb_info option

2023-08-08 Thread Stefano Sabatini
On date Monday 2023-07-03 15:55:40 +, Carotti, Elias wrote: > On Wed, 2023-06-21 at 15:57 +, Carotti, Elias wrote: > > Hi all, > > please find the second part of the patch set. > > Best, > > Elias > > Hi all, > please find the second part of the patch, updating libavcodec/libx264.c > to us

Re: [FFmpeg-devel] [PATCH] lavu: add AVVideoHint API

2023-08-08 Thread Stefano Sabatini
On date Wednesday 2023-08-02 07:36:43 +0200, Stefano Sabatini wrote: > On date Friday 2023-07-28 09:44:37 +0200, Stefano Sabatini wrote: > > On date Wednesday 2023-07-26 10:52:57 +, Carotti, Elias wrote: [...] > > > Agreed. > > > For clarity I am attaching again the

[FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-08-25 Thread Stefano Sabatini
x4->params.analyse.b_fast_pskip should only be forced in case mb_info is set. Fix output change introduced in 418c954e318. --- libavcodec/libx264.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index 1a7dc7bdd5..a2877d7f75 10064

[FFmpeg-devel] [PATCH 3/3] doc/encoders/libx264: clarify meaning of level option

2023-08-25 Thread Stefano Sabatini
Address trac issue: http://trac.ffmpeg.org/ticket/3947 --- doc/encoders.texi | 8 1 file changed, 8 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 947b0c3320..b7fbc25f92 100644 --- a/doc/encoders.texi +++ b/doc/encoders.texi @@ -2452,6 +2452,14 @@ Quantizer curve

[FFmpeg-devel] [PATCH 2/3] lavc: clarify meaning of avctx.level option

2023-08-25 Thread Stefano Sabatini
--- doc/codecs.texi| 5 - libavcodec/avcodec.h | 4 +++- libavcodec/options_table.h | 2 +- 3 files changed, 8 insertions(+), 3 deletions(-) diff --git a/doc/codecs.texi b/doc/codecs.texi index f903dad754..0aa848f62f 100644 --- a/doc/codecs.texi +++ b/doc/codecs.texi @@ -697

[FFmpeg-devel] [PATCH 1/3] doc/encoders/libx264: review and extend option description

2023-08-25 Thread Stefano Sabatini
Also, merge x264opts and x264-opts option docs to avoid duplication and make it even more clearer they provide the same functionality. --- doc/encoders.texi | 66 ++- 1 file changed, 37 insertions(+), 29 deletions(-) diff --git a/doc/encoders.texi b/doc

[FFmpeg-devel] [PATCH] doc/encoders/libxvid: fix references for me_quality option

2023-08-26 Thread Stefano Sabatini
Drop reference to constants removed in 94eed68ace9f2416af8. In particular, rename me_method to me_quality and add description for supported values. Address trac issue: http://trac.ffmpeg.org/ticket/10003 --- doc/encoders.texi | 21 + 1 file changed, 9 insertions(+), 12 deleti

[FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec

2023-08-26 Thread Stefano Sabatini
Use in place of sws_getGaussianVec. The new function enable better log handling, and provide better naming for the variance variable, now named standard_deviation to reflect the meaning of the parameter. --- doc/APIchanges | 3 +++ libswscale/swscale.h | 21 ++-

[FFmpeg-devel] [PATCH 1/2] lsws,lavfi: use sws_get_gaussian_vec

2023-08-26 Thread Stefano Sabatini
Use in place of deprecated sws_getGaussianVec. --- libavfilter/vf_sab.c | 17 + libavfilter/vf_smartblur.c | 8 libswscale/utils.c | 32 ++-- 3 files changed, 31 insertions(+), 26 deletions(-) diff --git a/libavfilter/vf_sab.c b/

[FFmpeg-devel] [PATCH 2/2] doc/filters/smartblur: amend definition of luma_radius and chroma_radius

2023-08-26 Thread Stefano Sabatini
Correctly define the option values as a standard deviation rather than a variance. Address trac issue: http://trac.ffmpeg.org/ticket/9068 --- doc/filters.texi | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 90e6c433c4..

[FFmpeg-devel] [PATCH] doc/encoders/libopus: clarify lowdelay and cutoff options

2023-08-26 Thread Stefano Sabatini
Extend descriptions for the application=lowdelay and cutoff options. Based on notes by Mingye Wang. Address issue: http://trac.ffmpeg.org/ticket/10330 --- doc/encoders.texi | 7 +-- libavcodec/libopusenc.c | 2 +- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/doc/encode

Re: [FFmpeg-devel] [PATCH 1/6] doc/developer: move a sentence to a more appropriate place

2023-08-27 Thread Stefano Sabatini
Il sab 26 ago 2023, 20:08 Anton Khirnov ha scritto: > It's targeted at our users, not developers, so it makes more sense to > group it with other text targeted at our users. > --- > doc/developer.texi | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/doc/developer.

Re: [FFmpeg-devel] [PATCH 2/6] doc/developer: merge the 'contributing code' section into its parent chapter

2023-08-27 Thread Stefano Sabatini
Il sab 26 ago 2023, 20:08 Anton Khirnov ha scritto: > The section consistes of a single short paragraph linking to other > chapters. The enclosing chapter also has no other sections, all other > text is placed in the chapter directly. > Keeping a separate section for this paragraph just adds more

Re: [FFmpeg-devel] [PATCH 3/6] doc/developer: fix a nonsense statement

2023-08-27 Thread Stefano Sabatini
Il sab 26 ago 2023, 20:08 Anton Khirnov ha scritto: > Adding new fields to _functions_ makes no sense, it was supposed to be > structs. > --- > doc/developer.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/doc/developer.texi b/doc/developer.texi > index d27716ab97..

Re: [FFmpeg-devel] [PATCH 4/6] doc/developer: add a code behaviour section to development policy

2023-08-27 Thread Stefano Sabatini
Il sab 26 ago 2023, 20:08 Anton Khirnov ha scritto: > Document our longstanding de facto policies on things like correctness, > thread-safety, UB, etc. > UB? --- > doc/developer.texi | 50 +- > 1 file changed, 36 insertions(+), 14 deletions(-) > > di

Re: [FFmpeg-devel] [PATCH 5/6] doc/developer: drop an outdated item

2023-08-27 Thread Stefano Sabatini
Il sab 26 ago 2023, 20:08 Anton Khirnov ha scritto: > It dates back to pre-2005 days, when people generally tended to commit > their work directly without going through the mailing list. Few > developers do it today, and never outside of their standalone modules. > This item is thus confusing and

Re: [FFmpeg-devel] [PATCH 6/6] doc/developer: deduplicate commit message rules

2023-08-27 Thread Stefano Sabatini
Il sab 26 ago 2023, 20:08 Anton Khirnov ha scritto: > The patches/committing section currently contains several > partially-overlapping rules on commit messages. Merge and simplify them > into one item. > --- > doc/developer.texi | 41 ++--- > 1 file changed,

Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec

2023-08-31 Thread Stefano Sabatini
On date Saturday 2023-08-26 17:15:36 +0200, Anton Khirnov wrote: > Quoting Stefano Sabatini (2023-08-26 14:23:28) > > Use in place of sws_getGaussianVec. > > > > The new function enable better log handling, and provide better naming > > for the variance variable, now

Re: [FFmpeg-devel] [PATCH 4/6] doc/developer: add a code behaviour section to development policy

2023-08-31 Thread Stefano Sabatini
On date Tuesday 2023-08-29 10:34:45 +0200, Anton Khirnov wrote: > Quoting Stefano Sabatini (2023-08-27 14:38:44) > > Il sab 26 ago 2023, 20:08 Anton Khirnov ha scritto: > > > > > Document our longstanding de facto policies on things like correctness, >

Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec

2023-08-31 Thread Stefano Sabatini
On date Saturday 2023-08-26 17:15:27 +0200, Andreas Rheinhardt wrote: > Stefano Sabatini: > > Use in place of sws_getGaussianVec. > > > > The new function enable better log handling, and provide better naming > > Better log handling? Why? > > >

Re: [FFmpeg-devel] [PATCH 1/2] lsws, lavfi: use sws_get_gaussian_vec

2023-08-31 Thread Stefano Sabatini
On date Saturday 2023-08-26 17:13:19 +0200, Andreas Rheinhardt wrote: > Stefano Sabatini: > > Use in place of deprecated sws_getGaussianVec. > > This patchset should have been sent as a reply to the patch actually > adding sws_get_gaussian_vec. Noted. > > --- &

Re: [FFmpeg-devel] [PATCH] Build failed with newer glslang

2023-08-31 Thread Stefano Sabatini
On date Tuesday 2023-08-29 11:33:43 +0200, Luca Bonissi wrote: > Newer glslang does no more provide static libraries libOSDependent.a and > libOGLCompiler.a. > These libraries are only used in configure's test to detect spirv_compiler, > but are no more necessary even with older glslang. > > The f

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-08-31 Thread Stefano Sabatini
; Hi > >> > >> -Original Message- > >> From: ffmpeg-devel On Behalf Of > >> Stefano Sabatini > >> Sent: Friday, August 25, 2023 12:01 PM > >> To: FFmpeg development discussions and patches > >> Cc: Stefano Sabatini > >

Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec

2023-08-31 Thread Stefano Sabatini
On date Thursday 2023-08-31 18:51:52 +0200, Andreas Rheinhardt wrote: > Stefano Sabatini: > > +int sws_get_gaussian_vec(SwsVector **vecp, > > + AVClass *log_ctx, > > + double standard_deviation, double quality); > > >

[FFmpeg-devel] [PATCH] lavu/avstring: fix typo in av_strireplace function doxy

2023-09-01 Thread Stefano Sabatini
--- libavutil/avstring.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/avstring.h b/libavutil/avstring.h index e260263763..9b187e8d92 100644 --- a/libavutil/avstring.h +++ b/libavutil/avstring.h @@ -265,7 +265,7 @@ int av_strncasecmp(const char *a, const char *b, si

[FFmpeg-devel] [PATCH 1/3] ffprobe: factorize side data printing to dedicated function

2023-09-01 Thread Stefano Sabatini
--- fftools/ffprobe.c | 163 -- 1 file changed, 85 insertions(+), 78 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 4fcfe1164b..547e299312 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2578,6 +2578,89 @@ static void s

[FFmpeg-devel] [PATCH 2/3] ffprobe: correct section name for side data piece

2023-09-01 Thread Stefano Sabatini
--- fftools/ffprobe.c | 2 +- tests/ref/fate/hevc-dv-rpu | 80 +++--- 2 files changed, 41 insertions(+), 41 deletions(-) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 547e299312..7eb4d20a17 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c

Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec

2023-09-01 Thread Stefano Sabatini
On date Friday 2023-09-01 17:50:56 +0200, Anton Khirnov wrote: > Quoting Stefano Sabatini (2023-08-31 17:06:06) > > On date Saturday 2023-08-26 17:15:36 +0200, Anton Khirnov wrote: > > > Quoting Stefano Sabatini (2023-08-26 14:23:28) > > > > Use in place of sws_getGau

Re: [FFmpeg-devel] [PATCH 4/6] doc/developer: add a code behaviour section to development policy

2023-09-01 Thread Stefano Sabatini
On date Friday 2023-09-01 20:10:11 +0300, Rémi Denis-Courmont wrote: > Le torstaina 31. elokuuta 2023, 18.28.48 EEST Stefano Sabatini a écrit : > > On date Tuesday 2023-08-29 10:34:45 +0200, Anton Khirnov wrote: > > > Quoting Stefano Sabatini (2023-08-27 14:38:44) > > >

Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec

2023-09-01 Thread Stefano Sabatini
On date Friday 2023-09-01 18:54:40 +0200, Michael Niedermayer wrote: > On Thu, Aug 31, 2023 at 07:16:20PM +0200, Stefano Sabatini wrote: [...] > > +/** > > + * Compute and return a normalized Gaussian vector. > > + * > > + * @param vecp: pointer where the comput

[FFmpeg-devel] [PATCH 1/6] libavcodec/avcodec.h: fix typos in AVCodecContext.pkt_timebase description

2023-09-01 Thread Stefano Sabatini
--- libavcodec/avcodec.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 649411ac79..070e36795d 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -1794,9 +1794,9 @@ typedef struct AVCodecContext { enum A

[FFmpeg-devel] [PATCH 3/6] doc/examples/transcode: factorize codec_type definition

2023-09-01 Thread Stefano Sabatini
--- doc/examples/transcode.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index 9af5674953..1ec4a3c230 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode.c @@ -82,6 +82,7 @@ static int open_input_file

[FFmpeg-devel] [PATCH 4/6] doc/examples/transcode: improve reporting when the encoder is not found

2023-09-01 Thread Stefano Sabatini
Also return EINVAL in place of INVALIDDATA. --- doc/examples/transcode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index 1ec4a3c230..aa6594f4ec 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode.c @@

[FFmpeg-devel] [PATCH 2/6] doc/examples/transcode: apply style fixes

2023-09-01 Thread Stefano Sabatini
--- doc/examples/transcode.c | 95 +--- 1 file changed, 49 insertions(+), 46 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index ed6ac9fa03..9af5674953 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode.c @@ -82,1

[FFmpeg-devel] [PATCH 5/6] doc/examples/transcode: use av_buffersrc_add_frame()

2023-09-01 Thread Stefano Sabatini
Favor it over av_buffersrc_add_frame_flags, simplify. --- doc/examples/transcode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index aa6594f4ec..b4b2d3c4c9 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode

[FFmpeg-devel] [PATCH 6/6] doc/examples/transcode: introduce timestamp logging

2023-09-01 Thread Stefano Sabatini
Aid timestamp debugging. --- doc/examples/transcode.c | 45 1 file changed, 36 insertions(+), 9 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index b4b2d3c4c9..983a8f2845 100644 --- a/doc/examples/transcode.c +++ b/doc/examp

[FFmpeg-devel] Review and fix doc/examples/transcode.c - version 2

2023-09-02 Thread Stefano Sabatini
Apply various fixes to transcode.c, with some bonus patches fixing a typo and adding some debug logs in the aresample filter. In particular fixes: http://trac.ffmpeg.org/ticket/5849 ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.or

[FFmpeg-devel] [PATCH 02/11] lavfi/aresample: show time_base information during setup

2023-09-02 Thread Stefano Sabatini
--- libavfilter/af_aresample.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavfilter/af_aresample.c b/libavfilter/af_aresample.c index f4bcc45616..b71ed5b91c 100644 --- a/libavfilter/af_aresample.c +++ b/libavfilter/af_aresample.c @@ -28,6 +28,7 @@ #include "libav

[FFmpeg-devel] [PATCH 04/11] doc/examples/transcode: factorize codec_type definition

2023-09-02 Thread Stefano Sabatini
--- doc/examples/transcode.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index 81a88dd577..3c57fb36c9 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode.c @@ -82,6 +82,7 @@ static int open_input_file

[FFmpeg-devel] [PATCH 03/11] doc/examples/transcode: apply style fixes

2023-09-02 Thread Stefano Sabatini
--- doc/examples/transcode.c | 97 +--- 1 file changed, 50 insertions(+), 47 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index ed6ac9fa03..81a88dd577 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode.c @@ -82,1

[FFmpeg-devel] [PATCH 01/11] lavc/avcodec.h: fix typos in AVCodecContext.pkt_timebase description

2023-09-02 Thread Stefano Sabatini
--- libavcodec/avcodec.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 649411ac79..070e36795d 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -1794,9 +1794,9 @@ typedef struct AVCodecContext { enum A

[FFmpeg-devel] [PATCH 05/11] doc/examples/transcode: improve reporting when the encoder is not found

2023-09-02 Thread Stefano Sabatini
Also return EINVAL in place of INVALIDDATA. --- doc/examples/transcode.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index 3c57fb36c9..dd64c38f15 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode.c @@

[FFmpeg-devel] [PATCH 09/11] doc/examples/transcode: fix timestamps scaling

2023-09-02 Thread Stefano Sabatini
Set pkt_timebase in the decoder and in the decoded frame, use it for the filterchain source, and rescale the filtered frame to the target encoder time_base. This fixes filtering in case the time base was not set in the decoder, causing the error: [in @ 0x5647fc26ec80] Invalid time base 0/1 --- do

[FFmpeg-devel] [PATCH 10/11] doc/examples/transcode: simplify selection of pix_fmt

2023-09-02 Thread Stefano Sabatini
Use ternary operator. --- doc/examples/transcode.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index 524bb47f50..1d22a4b09e 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode.c @@ -178,11 +178,10 @

[FFmpeg-devel] [PATCH 08/11] doc/examples/transcode: use more meaningful labels for filtergraph sinks and sources

2023-09-02 Thread Stefano Sabatini
--- doc/examples/transcode.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index 5671c6664b..b94fdbede2 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode.c @@ -280,14 +280,14 @@ static int init_filte

[FFmpeg-devel] [PATCH 06/11] doc/examples/transcode: use av_buffersrc_add_frame()

2023-09-02 Thread Stefano Sabatini
Favor it over av_buffersrc_add_frame_flags, simplify. --- doc/examples/transcode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index dd64c38f15..21ea14b614 100644 --- a/doc/examples/transcode.c +++ b/doc/examples/transcode

[FFmpeg-devel] [PATCH 11/11] doc/examples/transcode: fix selection of sample format if not set in encoder

2023-09-02 Thread Stefano Sabatini
Fix crash occurring when the list of sample formats is not defined in the encoder, use the decoder one in that case. Possibly fix issue: http://trac.ffmpeg.org/ticket/5849 --- doc/examples/transcode.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/doc/examples/transcod

[FFmpeg-devel] [PATCH 07/11] doc/examples/transcode: introduce timestamp logging

2023-09-02 Thread Stefano Sabatini
Aid timestamp debugging. --- doc/examples/transcode.c | 43 +++- 1 file changed, 34 insertions(+), 9 deletions(-) diff --git a/doc/examples/transcode.c b/doc/examples/transcode.c index 21ea14b614..5671c6664b 100644 --- a/doc/examples/transcode.c +++ b/doc/examp

Re: [FFmpeg-devel] [PATCH 1/6] libavcodec/avcodec.h: fix typos in AVCodecContext.pkt_timebase description

2023-09-02 Thread Stefano Sabatini
On date Saturday 2023-09-02 01:14:42 +0200, Stefano Sabatini wrote: > --- > libavcodec/avcodec.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Patchset dropped in favor of version 2. ___ ffmpeg-devel mailing list ffmpeg-devel@f

Re: [FFmpeg-devel] [PATCH 1/3] ffprobe: factorize side data printing to dedicated function

2023-09-02 Thread Stefano Sabatini
On date Saturday 2023-09-02 10:33:12 +0200, Andreas Rheinhardt wrote: > Stefano Sabatini: > > +static void print_frame_side_data(WriterContext *w, > > + AVFrame *frame, > > + AVStream *stream) > > I am

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-09-02 Thread Stefano Sabatini
On date Saturday 2023-09-02 09:20:08 +, Carotti, Elias wrote: > On Thu, 2023-08-31 at 19:09 +0200, Stefano Sabatini wrote: > > > > > > > > In particular why are you turning on fast_pskip silently based on a > > > completely different setting? > &g

Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec

2023-09-02 Thread Stefano Sabatini
On date Saturday 2023-09-02 22:07:53 +0200, Michael Niedermayer wrote: > On Fri, Sep 01, 2023 at 08:38:26PM +0200, Stefano Sabatini wrote: > > On date Friday 2023-09-01 18:54:40 +0200, Michael Niedermayer wrote: > > > On Thu, Aug 31, 2023 at 07:16:20PM +0200, Stef

Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec

2023-09-05 Thread Stefano Sabatini
On date Tuesday 2023-09-05 13:19:00 +0200, Anton Khirnov wrote: > Quoting Stefano Sabatini (2023-09-01 20:28:33) > > On date Friday 2023-09-01 17:50:56 +0200, Anton Khirnov wrote: > > > Quoting Stefano Sabatini (2023-08-31 17:06:06) > > > > On date Saturday 2023-08-26

Re: [FFmpeg-devel] [PATCH] lavc/libx264: enable x4->params.analyse.b_fast_pskip if mb_info is set

2023-09-05 Thread Stefano Sabatini
On date Tuesday 2023-09-05 12:43:35 +, ffmpeg-devel Mailing List wrote: [...] > On date Saturday 2023-09-02 09:20:08 +, Carotti, Elias wrote: > > On Thu, 2023-08-31 at 19:09 +0200, Stefano Sabatini wrote: > > > > > > > > > > > > In particul

Re: [FFmpeg-devel] [PATCH 1/3] doc/encoders/libx264: review and extend option description

2023-09-05 Thread Stefano Sabatini
On date Saturday 2023-08-26 03:10:28 +0200, Stefano Sabatini wrote: > Also, merge x264opts and x264-opts option docs to avoid duplication > and make it even more clearer they provide the same functionality. > --- > doc/encoders.texi | 66 ++---

Re: [FFmpeg-devel] [PATCH] doc/encoders/libxvid: fix references for me_quality option

2023-09-05 Thread Stefano Sabatini
On date Saturday 2023-08-26 12:56:10 +0200, Stefano Sabatini wrote: > Drop reference to constants removed in 94eed68ace9f2416af8. > > In particular, rename me_method to me_quality and add description for > supported values. > > Address trac issue: > http://trac.ff

Re: [FFmpeg-devel] [PATCH 3/3] ffprobe: introduce section type, use for the compact output

2023-09-05 Thread Stefano Sabatini
On date Friday 2023-09-01 15:43:36 +0200, Stefano Sabatini wrote: > Also, avoid spurious end-of-line after side data entries, and improve > rendering of compact output, by adding an indication of the side data > type for each entry. > > Also fixes issue: > http://trac.ffmp

Re: [FFmpeg-devel] [PATCH 06/11] doc/examples/transcode: use av_buffersrc_add_frame()

2023-09-05 Thread Stefano Sabatini
On date Sunday 2023-09-03 09:39:02 +0200, Paul B Mahol wrote: > This simplify nothing at all. I don't mind dropping this one. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit li

Re: [FFmpeg-devel] [PATCH 11/11] doc/examples/transcode: fix selection of sample format if not set in encoder

2023-09-05 Thread Stefano Sabatini
On date Sunday 2023-09-03 09:41:49 +0200, Paul B Mahol wrote: > Decoder formats may not relate to encoder formats, thus this one looks too > hackish to me to accept. Agreed, but this is yet another change unrelated to the fix. ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH 11/11] doc/examples/transcode: fix selection of sample format if not set in encoder

2023-09-05 Thread Stefano Sabatini
On date Sunday 2023-09-03 09:41:49 +0200, Paul B Mahol wrote: > Decoder formats may not relate to encoder formats, thus this one looks too > hackish to me to accept. Agreed but this is unrelated to the crash fix. ___ ffmpeg-devel mailing list ffmpeg-deve

Re: [FFmpeg-devel] [REFUND-REQUEST]] VDD'23 Travel

2023-09-28 Thread Stefano Sabatini
On date Monday 2023-09-25 12:44:27 +0200, Niklas Haas wrote: > Hi, > > was a great VDD! Here are my travel costs: > > 316,00 EUR Flight STR <-> DUB > 101,00 EUR Parking at STR > 8,00 EUR Airport Shuttlebus in DUB > > I had planned to use the cheaper (~60 EUR) parking, but it was already > clos

Re: [FFmpeg-devel] [REFUND-REQUEST] VDD23 Travel

2023-09-28 Thread Stefano Sabatini
On date Monday 2023-09-25 14:17:06 +0100, Derek Buitenhuis wrote: > Hello, > > Nice to see you all again after so long. > > My request is for my flights to/from Dublin, which cost 90.58 GBP. Approved on my side, pending Michael's approval. Once this is approved, follow instructions here to gene

Re: [FFmpeg-devel] [PATCH 3/3] doc/ffmpeg: expand -bsf documentation

2023-09-28 Thread Stefano Sabatini
On date Tuesday 2023-09-19 20:15:07 +0200, Anton Khirnov wrote: > Explain how to pass options to filters. > --- > doc/ffmpeg.texi | 15 --- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi > index d2864ff37e..cf47eb68d1 100644 > ---

Re: [FFmpeg-devel] [REFUND-REQUEST] VDD23 Travel

2023-10-05 Thread Stefano Sabatini
In data Sunday 2023-10-01 14:18:22 +0100, Derek Buitenhuis ha scritto: > On 9/29/2023 7:18 AM, Stefano Sabatini wrote: > > Once this is approved, follow instructions here to generate a refund > > request: > > https://www.spi-inc.org/treasurer/reimbursement-form/ > >

Re: [FFmpeg-devel] [PATCH 3/3] ffprobe: introduce section type, use for the compact output

2023-10-05 Thread Stefano Sabatini
On date Wednesday 2023-09-06 01:15:22 +0200, Stefano Sabatini wrote: > On date Friday 2023-09-01 15:43:36 +0200, Stefano Sabatini wrote: > > Also, avoid spurious end-of-line after side data entries, and improve > > rendering of compact output, by adding an indication of the side da

Re: [FFmpeg-devel] [PATCH] doc/encoders/libxvid: fix references for me_quality option

2023-10-06 Thread Stefano Sabatini
On date Wednesday 2023-09-06 10:56:43 +0530, Gyan Doshi wrote: > On 2023-08-26 04:26 pm, Stefano Sabatini wrote: > > Drop reference to constants removed in 94eed68ace9f2416af8. > > > > In particular, rename me_method to me_quality and add description for > > support

Re: [FFmpeg-devel] [PATCH 3/3] doc/encoders/libx264: clarify meaning of level option

2023-10-06 Thread Stefano Sabatini
On date Wednesday 2023-09-06 11:07:23 +0530, Gyan Doshi wrote: > On 2023-08-26 06:40 am, Stefano Sabatini wrote: > > Address trac issue: > > http://trac.ffmpeg.org/ticket/3947 > > --- > > doc/encoders.texi | 8 > > 1 file changed, 8 insertions(+) > &

Re: [FFmpeg-devel] [PATCH] doc/encoders/libopus: clarify lowdelay and cutoff options

2023-10-06 Thread Stefano Sabatini
On date Saturday 2023-08-26 15:48:41 +0200, Stefano Sabatini wrote: > Extend descriptions for the application=lowdelay and cutoff options. > Based on notes by Mingye Wang. > > Address issue: > http://trac.ffmpeg.org/ticket/10330 > --- > doc/encoders.texi | 7

Re: [FFmpeg-devel] [PATCH] lavu: header and documentation for AVWriter

2022-08-31 Thread Stefano Sabatini
On date Wednesday 2022-08-24 17:18:28 +0200, Nicolas George wrote: > The actual implementation, tests and uses in the rest of > FFmpeg code will be committed separately once the API is > settled. > > Signed-off-by: Nicolas George > --- > doc/avwriter_intro.md | 109 ++ > libavutil/writer

Re: [FFmpeg-devel] [PATCH] lavu: header and documentation for AVWriter

2022-09-01 Thread Stefano Sabatini
On date Thursday 2022-09-01 15:01:27 +0200, Nicolas George wrote: [...] > Thanks for the review. I do not think it is necessary to send an updated > patch for these changes, is it? Not needed, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.or

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 10:17:26 +0200, Paul B Mahol wrote: > No need for query function. > This implementation is so blatantly slow and inefficient that is not useful. > Source filters should use .activate instead. > Many more other issues... It was pending reviews for more than two weeks. Ab

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-07-06 Thread Stefano Sabatini
On date Thursday 2024-07-04 17:29:16 +0200, Michael Koch wrote: > Tested and working fine. It would be nice if you could add the default > values to the documentation. Will do, thanks. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.

Re: [FFmpeg-devel] [PATCH] lavfi/perlin: Fix out of bounds stack buffer write

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 20:38:00 +0200, Marvin Scholz wrote: > An incorrect calculation in ff_perlin_init causes a write to the > stack array at index 256, which is out of bounds. > > Fixes: CID1608711 > --- > libavfilter/perlin.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > di

Re: [FFmpeg-devel] [PATCH v4 0/3] s/RUNTIME/POST_INIT_SETTABLE/

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 10:08:37 +0100, Andrew Sayers wrote: > Some notes about this version: > > As previously mentioned, I think this is better with all three patches, > but can live without #2. > > I think I've followed the deprecation instructions, but editing APIchanges > seems to imply

Re: [FFmpeg-devel] [PATCH v3 1/3] lavu/opt: Rename AV_OPT_FLAG_RUNTIME_PARAM to ...POST_INIT_SETTABLE_PARAM

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 11:58:09 +0800, Zhao Zhili wrote: > > > 在 2024年7月2日,上午6:33,Stefano Sabatini 写道: > > > > On date Sunday 2024-06-16 18:08:29 +0100, Andrew Sayers wrote: > >> The old name could be misread as the opposite of "AV_OPT_FLAG_READONL

Re: [FFmpeg-devel] [PATCH v4 1/3] lavu/opt: Rename AV_OPT_FLAG_RUNTIME_PARAM to ...POST_INIT_SETTABLE_PARAM

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 10:08:38 +0100, Andrew Sayers wrote: > The old name could be misread as the opposite of "AV_OPT_FLAG_READONLY" - > some things can be set at runtime, others are read-only. Clarify that > this refers to options that can be set after the struct is initialized. > --- > doc

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-07-06 Thread Stefano Sabatini
On date Saturday 2024-07-06 12:40:55 +0200, Paul B Mahol wrote: > On Sat, Jul 6, 2024 at 11:19 AM Stefano Sabatini wrote: [...] > Not interested in your marginal toys or project. Good, so the next time avoid the rant and save even more time. ___

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: Don't add chapter markers for empty/dummy PTTs

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 00:41:39 -0500, Marth64 wrote: > Some discs (usually same ones with padding cells), also have empty > padding PTTs / chapters to accompany them. This results, for example, > in an extra chapter marker that starts and ends at 0 (no duration). > > Don't add these empty cha

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: Remove redundant ret initializations

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 01:03:29 -0500, Marth64 wrote: > Remove initializing ret = 0, in areas where ret is > only used to hold an error value, immediately returned, > and the function would otherwise return a literal 0. > > Signed-off-by: Marth64 > --- > libavformat/dvdvideodec.c | 12 ++

Re: [FFmpeg-devel] [PATCH v4] avformat/dvdvideodec: Fix incorrect padding cell trim logic

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 01:41:31 -0500, Marth64 wrote: > When -trim option is used (by default), padding cells > at the beginning of the title are supposed to be ignored. > The current implementation does the ignoring after we > have locked on to the PGC navigation event stream, > but does not s

Re: [FFmpeg-devel] Development process for explaining contexts (was Re: [PATCH v6 1/4] doc: Explain what "context" means)

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 10:56:34 +0100, Andrew Sayers wrote: > On Tue, Jul 02, 2024 at 12:16:21AM +0200, Stefano Sabatini wrote: > > On date Sunday 2024-06-16 19:02:51 +0100, Andrew Sayers wrote: > [...] > > > > Andrew, sorry again for the slow reply. Thinking about the

Re: [FFmpeg-devel] [PATCH 8/8] fftools/ffprobe: only print AVStereo3D.view when it's defined

2024-07-06 Thread Stefano Sabatini
On date Saturday 2024-06-22 00:37:01 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > fftools/ffprobe.c | 3 ++- > tests/ref/fate/matroska-spherical-mono | 1 - > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffpr

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-07-06 Thread Stefano Sabatini
On date Tuesday 2024-07-02 10:17:26 +0200, Paul B Mahol wrote: [...] > Source filters should use .activate instead. Can someone elaborate about why .activate is favoured in this case (sorry I missed the activate discussion altogether and I cannot graps it from the docs)? Also, is the direct AVFil

Re: [FFmpeg-devel] [PATCH v4] avformat/dvdvideodec: Fix incorrect padding cell trim logic

2024-07-13 Thread Stefano Sabatini
On Fri, Jul 12, 2024 at 5:31 AM Marth64 wrote: > > Ping to apply on this set of 3, so I can send seeking and additional > cleanup set (as a collection). Thank you! Applied patches: eb07a59 avformat/dvdvideodec: Don't add chapter markers for empty/dummy PTTs f37f86a avformat/dvdvideodec: Remove re

Re: [FFmpeg-devel] [REFUND-REQUEST] BananaPi BPI-F3 SpacemiT K1 RISC-V Devboard

2024-08-04 Thread Stefano Sabatini
On date Thursday 2024-08-01 17:14:52 +0200, Niklas Haas wrote: > Hi all, > > I would like to request reimbursement on the named RISC-V development board. > It will be used to develop and test H.264 RVV routines, and probably more in > the future (e.g. swscale). > > The total cost including tax an

Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: Loop over correct number of streams when flushing decoders

2022-11-06 Thread Stefano Sabatini
On Sun, Nov 6, 2022 at 12:23 PM Derek Buitenhuis wrote: > > On 11/3/2022 3:17 PM, Derek Buitenhuis wrote: > > --- > > fftools/ffprobe.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Ping. >FFprobe does check for this an reallocate anD reallocate LGTM, thanks. ___

Re: [FFmpeg-devel] [REFUND-REQUEST]Travel cost reimbursement request

2022-12-14 Thread Stefano Sabatini
On Tue, Dec 13, 2022 at 8:09 PM Carl Eugen Hoyos wrote: > > Hi! > > I traveled to Barcelona for the development meeting and request a > reimbursement: > Flight Vienna - Barcelona - Vienna: 449,99 > Two nights in a hotel in Barcelona: 161,06 > Bus to Barcelona center: 5,90 > > Thank you, Carl Euge

Re: [FFmpeg-devel] [REFUND-REQUEST] Travel to Developer Meeting

2022-12-14 Thread Stefano Sabatini
On Wed, Dec 14, 2022 at 3:06 PM Derek Buitenhuis wrote: > > Hello, > > I travelled to Barcelona for the developer meeting. > > I am only requesting for my flight, as I chose to stay in non-VideoLAN hotel. > > Flight: £111.98 - receipt available, of course. > > As I am not super active currently, u

Re: [FFmpeg-devel] [REFUND-REQUEST] Dec 2 developer meeting

2022-12-15 Thread Stefano Sabatini
On Thu, Dec 15, 2022 at 8:11 PM Niklas Haas wrote: > > As alluded to by my previous email: > > Flight: 180.32 EUR > Hotel (3 nights + breakfast): 287.40 EUR > Shuttle bus: 5.90 EUR > > I unfortunately can't find receipts for the metro tickets and second bus > ride back to the airport, so I've had

Re: [FFmpeg-devel] AVX512 NUCs for FATE and development

2022-12-18 Thread Stefano Sabatini
On Sat, Dec 17, 2022 at 9:46 PM Michael Niedermayer wrote: > > On Sat, Dec 17, 2022 at 07:57:06PM +, Kieran Kunhya wrote: > > On Sat, 10 Dec 2022 at 18:12, Carl Eugen Hoyos wrote: > > > > > Am Fr., 9. Dez. 2022 um 18:07 Uhr schrieb Michael Niedermayer > > > : > > > > > > > > On Thu, Dec 08, 2

Re: [FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing

2022-12-31 Thread Stefano Sabatini
On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote: > For some samples the pkt->pts is always missing, use the pkt->dts > instead. > > Fix trac issue http://trac.ffmpeg.org/ticket/4427. > --- > fftools/ffprobe.c | 5 +++-- > 1 file changed, 3

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: expose AVAmbientViewingEnvironment side data in AVFrames

2023-01-14 Thread Stefano Sabatini
On date Tuesday 2023-01-10 23:19:48 +0200, Jan Ekström wrote: > --- > fftools/ffprobe.c | 15 +++ > 1 file changed, 15 insertions(+) Missing doc/ffprobe.xsd changes? LGTM otherwise. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH] avfilter/vf_showinfo: add support for Ambient Viewing Environment side data

2023-01-14 Thread Stefano Sabatini
On date Friday 2023-01-13 18:35:36 -0300, James Almer wrote: > Signed-off-by: James Almer > --- > libavfilter/vf_showinfo.c | 15 +++ > 1 file changed, 15 insertions(+) LGTM. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffm

Re: [FFmpeg-devel] [PATCH 3/4] ffprobe: expose AVAmbientViewingEnvironment side data in AVFrames

2023-01-14 Thread Stefano Sabatini
On date Saturday 2023-01-14 22:59:31 +0200, Jan Ekström wrote: > On Sat, Jan 14, 2023 at 10:03 PM Stefano Sabatini wrote: > > > > On date Tuesday 2023-01-10 23:19:48 +0200, Jan Ekström wrote: > > > --- > > > fftools/ffprobe.c | 15 +++ >

Re: [FFmpeg-devel] [PATCH] ffprobe: use pkt->dts to compute interval ts when pts is missing

2023-01-14 Thread Stefano Sabatini
On date Saturday 2022-12-31 20:26:34 +0100, Stefano Sabatini wrote: > On date Wednesday 2022-07-13 02:02:17 +0200, Stefano Sabatini wrote: > > For some samples the pkt->pts is always missing, use the pkt->dts > > instead. > > > > Fix trac issue h

<    2   3   4   5   6   7   8   9   10   11   >