Re: [FFmpeg-devel] [PATCH v4 1/4] doc: Explain what "context" means

2024-05-22 Thread Stefano Sabatini
Sorry for the slow reply. On date Wednesday 2024-05-15 16:54:19 +0100, Andrew Sayers wrote: > Derived from detailed explanations kindly provided by Stefano Sabatini: > https://ffmpeg.org/pipermail/ffmpeg-devel/2024-April/325903.html > --- > doc/cont

Re: [FFmpeg-devel] [PATCH v4 2/4] lavu: Clarify relationship between AVClass, AVOption and context

2024-05-22 Thread Stefano Sabatini
On date Wednesday 2024-05-15 16:54:20 +0100, Andrew Sayers wrote: > --- > libavutil/log.h | 11 --- > libavutil/opt.h | 7 --- > 2 files changed, 12 insertions(+), 6 deletions(-) > > diff --git a/libavutil/log.h b/libavutil/log.h > index ab7ceabe22..cfbf416679 100644 > --- a/libavuti

Re: [FFmpeg-devel] [PATCH v4 4/4] lavf: Add documentation for private "Context" classes

2024-05-22 Thread Stefano Sabatini
On date Wednesday 2024-05-15 16:54:22 +0100, Andrew Sayers wrote: > Doxygen thinks any text like "Context for foo" is a link to a struct called > "Context". > Add a description and a better link, to avoid confusing readers. > --- > libavformat/async.c | 3 +++ > libavformat/cache.c | 3 +++ > 2 f

Re: [FFmpeg-devel] [PATCH v3 1/3] doc: Explain what "context" means

2024-05-22 Thread Stefano Sabatini
On date Sunday 2024-05-05 22:04:36 +0100, Andrew Sayers wrote: > I'm still travelling, so the following thoughts might be a bit > half-formed. But I wanted to get some feedback before sitting down > for a proper think. [...] > > > I've also gone through the code looking for edge cases we haven't c

Re: [FFmpeg-devel] [PATCH v3 1/3] doc: Explain what "context" means

2024-05-25 Thread Stefano Sabatini
On date Wednesday 2024-05-22 13:47:36 +0100, Andrew Sayers wrote: > On Wed, May 22, 2024 at 12:37:37PM +0200, Stefano Sabatini wrote: > > On date Sunday 2024-05-05 22:04:36 +0100, Andrew Sayers wrote: > > > I'm still travelling, so the following thoughts might be a bit &g

Re: [FFmpeg-devel] [PATCH v4 1/4] doc: Explain what "context" means

2024-05-25 Thread Stefano Sabatini
On date Wednesday 2024-05-22 17:07:51 +0100, Andrew Sayers wrote: [...] > > > diff --git a/doc/context.md b/doc/context.md > > > new file mode 100644 > > > index 00..fb85b3f366 > > > --- /dev/null > > > +++ b/doc/context.md > > > @@ -0,0 +1,394 @@ > > > +# Introduction to contexts > > > + >

Re: [FFmpeg-devel] [PATCH v5 2/4] lavu: Clarify relationship between AVClass, AVOption and context

2024-05-25 Thread Stefano Sabatini
On date Thursday 2024-05-23 21:00:41 +0100, Andrew Sayers wrote: > --- > libavutil/log.h | 16 +--- > libavutil/opt.h | 17 ++--- > 2 files changed, 27 insertions(+), 6 deletions(-) > > diff --git a/libavutil/log.h b/libavutil/log.h > index ab7ceabe22..d599ab506e 100644 >

Re: [FFmpeg-devel] [PATCH v5 1/4] doc: Explain what "context" means

2024-05-25 Thread Stefano Sabatini
On date Thursday 2024-05-23 21:00:40 +0100, Andrew Sayers wrote: > Derived from explanations kindly provided by Stefano Sabatini and others: > https://ffmpeg.org/pipermail/ffmpeg-devel/2024-April/325903.html > --- > doc/context.md | 439 +++

[FFmpeg-devel] [POC] lavfi: add perlin noise generator

2024-05-27 Thread Stefano Sabatini
Hi, still missing documentation and might be optimized (and maybe extended to support gray16 - this should be simple), comments are welcome. >From 5018f5b887ef84c19cbf3f76c6607b49a6c99f2a Mon Sep 17 00:00:00 2001 From: Stefano Sabatini Date: Mon, 27 May 2024 11:19:08 +0200 Subject: [PATCH] la

[FFmpeg-devel] lavfi: add perlin noise generator

2024-05-28 Thread Stefano Sabatini
On date Monday 2024-05-27 23:37:33 +0200, Stefano Sabatini wrote: > Hi, > > still missing documentation and might be optimized (and maybe extended > to support gray16 - this should be simple), comments are welcome. Updated with documentation. >From 607459e7a184ab2d111b65f5017fb

Re: [FFmpeg-devel] [PATCH v4 1/4] doc: Explain what "context" means

2024-05-28 Thread Stefano Sabatini
fully that will keep > the big questions contained in one place. > > On Sat, May 25, 2024 at 11:49:48AM +0200, Stefano Sabatini wrote: > > What perplexes me is that "context" is not part of the standard OOP > > jargon, so this is probably adding more to the confusio

Re: [FFmpeg-devel] [PATCH v4 1/4] doc: Explain what "context" means

2024-05-29 Thread Stefano Sabatini
On date Wednesday 2024-05-29 11:50:40 +0100, Andrew Sayers wrote: > Posting this separately, as these are practical "how does FFmpeg work" issues > vaguely inspired by recent discussions. > > > *How do namespaces work in FFmpeg?* > > We've talked a bit about function namespaces recently. One re

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-06-03 Thread Stefano Sabatini
On date Tuesday 2024-05-28 18:58:28 +0200, Stefano Sabatini wrote: > On date Monday 2024-05-27 23:37:33 +0200, Stefano Sabatini wrote: > > Hi, > > > > still missing documentation and might be optimized (and maybe extended > > to support gray16 - this should be si

Re: [FFmpeg-devel] [PATCH] avfilter/trim: flag trim filter as metadata only

2024-06-04 Thread Stefano Sabatini
On date Tuesday 2024-06-04 23:41:05 +0530, Gyan Doshi wrote: > Similar to select filter for video - it can only pass through or drop frames > --- > libavfilter/trim.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/trim.c b/libavfilter/trim.c > index 4c1a2b4f48..4afc4c74bb 10

Re: [FFmpeg-devel] [PATCH v6 2/4] lavu: Clarify relationship between AVClass, AVOption and context

2024-06-05 Thread Stefano Sabatini
On date Tuesday 2024-06-04 15:47:22 +0100, Andrew Sayers wrote: > --- > libavutil/log.h | 16 +--- > libavutil/opt.h | 26 +- > 2 files changed, 34 insertions(+), 8 deletions(-) > > diff --git a/libavutil/log.h b/libavutil/log.h > index ab7ceabe22..88b35897c6 1

Re: [FFmpeg-devel] [PATCH v6] avcodec: add farbfeld encoder

2024-06-05 Thread Stefano Sabatini
On date Wednesday 2024-06-05 12:02:08 +0200, Andreas Rheinhardt wrote: > Stefano Sabatini: > > On date Tuesday 2024-06-04 17:28:35 -0500, Marcus B Spencer wrote: [...] > >> +#define HEADER_SIZE 16 > >> + > >> +static int farbfeld_encode_fram

Re: [FFmpeg-devel] [PATCH v6] avcodec: add farbfeld encoder

2024-06-05 Thread Stefano Sabatini
On date Wednesday 2024-06-05 13:14:01 +0200, Andreas Rheinhardt wrote: > Stefano Sabatini: [...] > >> One does not need two checks as long as int is 32 bits (because then one > >> can just perform the addition in 64bits). > > > > sizeof(int) is not defined by the

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-06-12 Thread Stefano Sabatini
On date Monday 2024-06-03 11:41:59 +0200, Stefano Sabatini wrote: > On date Tuesday 2024-05-28 18:58:28 +0200, Stefano Sabatini wrote: > > On date Monday 2024-05-27 23:37:33 +0200, Stefano Sabatini wrote: > > > Hi, > > > > > > still missing documentation and mi

Re: [FFmpeg-devel] [PATCH] avfilter: add sdlvsink for video display

2024-06-12 Thread Stefano Sabatini
coders and muxers, and about dealing with a variable number of outputs, I'm attaching this very old proof-of-concept patch for reference. This approach would be possibly much more complex, but should provide a single bridge in place of having a different sink for every output devic

Re: [FFmpeg-devel] [PATCH] doc/faq: Provide information about git send-email and gmail

2024-06-12 Thread Stefano Sabatini
On date Wednesday 2024-06-12 19:46:59 +0200, Michael Niedermayer wrote: > The 2 links are the clearest i found. > > Signed-off-by: Michael Niedermayer > --- > doc/faq.texi | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/doc/faq.texi b/doc/faq.texi > index 477cc60533a..d07ed533dd7

Re: [FFmpeg-devel] [PATCH v6 1/4] doc: Explain what "context" means

2024-06-12 Thread Stefano Sabatini
On date Tuesday 2024-06-04 15:47:21 +0100, Andrew Sayers wrote: > Derived from explanations kindly provided by Stefano Sabatini and others: > https://ffmpeg.org/pipermail/ffmpeg-devel/2024-April/325903.html > --- > doc/context.md | 430 +++

Re: [FFmpeg-devel] [PATCH v6 1/4] doc: Explain what "context" means

2024-06-15 Thread Stefano Sabatini
On date Thursday 2024-06-13 15:20:38 +0100, Andrew Sayers wrote: > On Wed, Jun 12, 2024 at 10:52:00PM +0200, Stefano Sabatini wrote: [...] > > > +@section Context_general “Context” as a general concept > [...] > > I'd skip all this part, as we assume the reader is a

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-06-16 Thread Stefano Sabatini
random_seed), AV_OPT_TYPE_UINT, {.i64=0}, 0, UINT_MAX, FLAGS }, > > +{ "seed","set the seed for filling the initial grid randomly", > > OFFSET(random_seed), AV_OPT_TYPE_UINT, {.i64=0}, 0, UINT_MAX, FLAGS }, > > Nit: "set the seed

Re: [FFmpeg-devel] [PATCH v2] lavu/opt: Discuss AV_OPT_FLAG_RUNTIME_PARAM more explicitly

2024-06-16 Thread Stefano Sabatini
On date Thursday 2024-06-06 17:02:06 +0100, Andrew Sayers wrote: > After a struct is initialized, only options with the > AV_OPT_FLAG_RUNTIME_PARAM flag can be modified. > > Make that clearer, for the sake of readers who would otherwise > assume all options can be modified at any time. > --- > li

Re: [FFmpeg-devel] lavfi: add perlin noise generator

2024-07-01 Thread Stefano Sabatini
On date Sunday 2024-06-16 17:37:09 +0200, Stefano Sabatini wrote: > On date Thursday 2024-06-13 16:45:48 +0100, Andrew Sayers wrote: [...] > Applied other fixes as well, thanks. > From 7d9ffbdb8e419ca01e60604038d5534a3ca8ae0e Mon Sep 17 00:00:00 2001 > From: Stefano Sabatini > Da

Re: [FFmpeg-devel] [PATCH 5/5] avfilter/vf_showinfo: don't use sizeof(AVSphericalMapping)

2024-07-01 Thread Stefano Sabatini
On date Wednesday 2024-06-26 11:10:14 -0300, James Almer wrote: > It's not part of the libavutil ABI. > > Signed-off-by: James Almer > --- > libavfilter/vf_showinfo.c | 5 - > 1 file changed, 5 deletions(-) All patches look good to me, thanks. ___

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: Do not EOF on WAIT events

2024-07-01 Thread Stefano Sabatini
On date Wednesday 2024-06-26 20:34:35 -0500, Marth64 wrote: > A DVDNAV_WAIT event by itself should not warrant an > EOF when navigating the program stream. Some discs > have WAIT events in the middle of a title, causing > playback to end prematurely prior to this fix. > > Signed-off-by: Marth64 >

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: Fix duration logic with 1 chapter and validate chapter range

2024-07-01 Thread Stefano Sabatini
On date Wednesday 2024-06-26 22:05:46 -0500, Marth64 wrote: > Chapters and duration are calculated together in dvdvideo demuxer. > Previous chapter calculation logic treated extraction of 1 chapter > using chapter_start and chapter_end switches incorrectly, returning > the duration of the entire ti

Re: [FFmpeg-devel] [PATCH] avformat/dvdvideodec: Fix duration logic with 1 chapter and validate chapter range

2024-07-01 Thread Stefano Sabatini
On date Monday 2024-07-01 22:49:42 +0200, Stefano Sabatini wrote: > On date Wednesday 2024-06-26 22:05:46 -0500, Marth64 wrote: > > Chapters and duration are calculated together in dvdvideo demuxer. > > Previous chapter calculation logic treated extraction of 1 chapter > > us

Re: [FFmpeg-devel] [RFC]] swscale modernization proposal

2024-07-01 Thread Stefano Sabatini
On date Monday 2024-06-24 16:44:33 +0200, Vittorio Giovara wrote: > On Sun, Jun 23, 2024 at 7:57 PM James Almer wrote: > > > On 6/22/2024 7:19 PM, Vittorio Giovara wrote: > > > Needless to say I support the plan of renaming the library so that it can > > > be inline with the other libraries names

Re: [FFmpeg-devel] [PATCH] avfilter/af_afade: fix opt_type for nb_samples/ns

2024-07-01 Thread Stefano Sabatini
On date Saturday 2024-06-22 15:20:52 +0200, Andreas Rheinhardt wrote: > Andrew Sayers: > > The actual value is an int64_t, and is accessed elsewhere as > > AV_OPT_TYPE_INT64. > > > > Accessing it as INT will likely cause bugs on some 32-bit architectures. > > Whether this works or not will depen

Re: [FFmpeg-devel] Development process for explaining contexts (was Re: [PATCH v6 1/4] doc: Explain what "context" means)

2024-07-01 Thread Stefano Sabatini
On date Sunday 2024-06-16 19:02:51 +0100, Andrew Sayers wrote: > Meta note #1: I've replied in this thread but changed the subject line. > That's because it needs to stay focussed on solving this thread's problem, > but may be of more general interest. > > Meta note #2: Stefano, I appreciate your

Re: [FFmpeg-devel] [PATCH v3 0/3] s/RUNTIME/POST_INIT_SETTABLE/

2024-07-01 Thread Stefano Sabatini
On date Sunday 2024-06-16 18:08:28 +0100, Andrew Sayers wrote: > AV_OPT_FLAG_POST_INIT_SETTABLE_PARAM is fine by me, here's a patch. > I've added a "@deprecated" comment for the old name, but would this > need to be queued up for 8.0? Technically this is a backwards-incompatible > change to the e

Re: [FFmpeg-devel] [PATCH v3 1/3] lavu/opt: Rename AV_OPT_FLAG_RUNTIME_PARAM to ...POST_INIT_SETTABLE_PARAM

2024-07-01 Thread Stefano Sabatini
On date Sunday 2024-06-16 18:08:29 +0100, Andrew Sayers wrote: > The old name could be misread as the opposite of "AV_OPT_FLAG_READONLY" - > some things can be set at runtime, others are read-only. Clarify that > this refers to options that can be set after the struct is initialized. > --- > liba

Re: [FFmpeg-devel] [REFUND-REQUEST]] VDD23 Travel

2023-10-09 Thread Stefano Sabatini
On date Sunday 2023-10-08 10:09:03 +0800, Steven Liu wrote: > Nice to see you all after so long. > My request is for my flights, 9750,00 CNY Beijing from/to Abu Dhabi, > Abu Dhabi from/to Dublin Approved on my side, pending Michael's approval. To get the refund, follow instructions here to genera

Re: [FFmpeg-devel] [PATCH 3/3] doc: add spi.txt

2023-10-12 Thread Stefano Sabatini
On date Wednesday 2023-10-11 20:10:15 +0200, Michael Niedermayer wrote: > This explains how to request refunds and what can be funded by SPI > --- > doc/spi.txt | 50 ++ > 1 file changed, 50 insertions(+) > create mode 100644 doc/spi.txt > > diff -

[FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout

2023-10-14 Thread Stefano Sabatini
Fix rendering of int values within a side data element, which was broken since commit d2d3a83ad93, where the side data element was correctly marked as a variable fields element. Logic to render a string variable was implemented already, but it was not implemented for the int fields path, which was

Re: [FFmpeg-devel] SWS cleanup / SPI Funding Suggestion

2023-10-14 Thread Stefano Sabatini
On date Friday 2023-10-13 21:19:34 +0200, Michael Niedermayer wrote: > Hi everyone > > I propose using 15k$ from SPI for funding sws cleanup work. > this is substantially less than what people belive this needs (see IRC logs > from yesterday or so) > So it really is more a small price for a good

Re: [FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout

2023-10-14 Thread Stefano Sabatini
On date Saturday 2023-10-14 19:24:28 +0200, Stefano Sabatini wrote: > Fix rendering of int values within a side data element, which was > broken since commit d2d3a83ad93, where the side data element was > correctly marked as a variable fields element. Logic to render a > string

Re: [FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout

2023-10-14 Thread Stefano Sabatini
On date Sunday 2023-10-15 03:09:14 +0200, Timo Rothenpieler wrote: > On 14.10.2023 19:24, Stefano Sabatini wrote: > > Fix rendering of int values within a side data element, which was > > broken since commit d2d3a83ad93, where the side data element was > > correctly marked

[FFmpeg-devel] [PATCH] ffprobe: add -output_format as an alias of -of

2023-10-15 Thread Stefano Sabatini
Currently we have -of and -print_format, which is a bit confusing. Add -output_format as an alias of -of to match the short name. --- Changelog | 1 + doc/ffprobe.texi | 6 +++--- fftools/ffprobe.c | 17 + 3 files changed, 13 insertions(+), 11 deletions(-) diff --git a/

Re: [FFmpeg-devel] [PATCH v2] doc: add spi.txt

2023-10-17 Thread Stefano Sabatini
On date Monday 2023-10-16 00:49:56 +0200, Michael Niedermayer wrote: > This explains how to request refunds and what can be funded by SPI > > Co-Author: Stefano Sabatini > --- > doc/spi.txt | 73 + > 1 file changed, 73 inser

Re: [FFmpeg-devel] [PATCH v2] doc: add spi.txt

2023-10-17 Thread Stefano Sabatini
On date Monday 2023-10-16 06:34:45 +0200, Lynne wrote: > Oct 16, 2023, 00:50 by mich...@niedermayer.cc: > > > This explains how to request refunds and what can be funded by SPI > > > > Co-Author: Stefano Sabatini >

Re: [FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout

2023-10-18 Thread Stefano Sabatini
On date Tuesday 2023-10-17 11:56:35 +0200, Stefano Sabatini wrote: > On date Sunday 2023-10-15 19:15:16 +0200, Michael Niedermayer wrote: > > On Sat, Oct 14, 2023 at 09:50:24PM +0200, Stefano Sabatini wrote: > > > On date Saturday 2023-10-14 19:24:28 +0200, Stefano Sabatini

Re: [FFmpeg-devel] [PATCH] ffprobe: add -output_format as an alias of -of

2023-10-18 Thread Stefano Sabatini
On date Sunday 2023-10-15 11:29:10 +0200, Stefano Sabatini wrote: > Currently we have -of and -print_format, which is a bit confusing. Add > -output_format as an alias of -of to match the short name. > --- > Changelog | 1 + > doc/ffprobe.texi | 6 +++--- > ffto

Re: [FFmpeg-devel] [PATCH v2] doc: add spi.txt

2023-10-18 Thread Stefano Sabatini
On date Tuesday 2023-10-17 14:41:00 +0200, epira...@gmail.com wrote: > > > On 17 Oct 2023, at 9:29, Stefano Sabatini wrote: > > > On date Monday 2023-10-16 06:34:45 +0200, Lynne wrote: > >> Oct 16, 2023, 00:50 by mich...@niedermayer.cc: > >> > >>&g

Re: [FFmpeg-devel] SWS cleanup / SPI Funding Suggestion

2023-10-18 Thread Stefano Sabatini
On date Tuesday 2023-10-17 16:58:41 +, ffmpeg-devel Mailing List wrote: > > > > On Oct 17, 2023, at 7:36 AM, Michael Niedermayer > > wrote: > > > > On Sat, Oct 14, 2023 at 07:53:04PM +0200, Stefano Sabatini wrote: > >> > >> It would be usef

Re: [FFmpeg-devel] SWS cleanup / SPI Funding Suggestion

2023-10-18 Thread Stefano Sabatini
On date Wednesday 2023-10-18 19:30:11 +0300, Rémi Denis-Courmont wrote: > Le keskiviikkona 18. lokakuuta 2023, 0.57.45 EEST Michael Niedermayer a écrit > : > > On Tue, Oct 17, 2023 at 09:50:41PM +0300, Rémi Denis-Courmont wrote: [...] > > > What happens if more than one credible developer wants to

Re: [FFmpeg-devel] [PATCH v2] doc: add spi.txt

2023-10-18 Thread Stefano Sabatini
On date Wednesday 2023-10-18 23:46:48 +0200, Stefano Sabatini wrote: > On date Tuesday 2023-10-17 14:41:00 +0200, epira...@gmail.com wrote: [...] > > IMO this would be much more discoverable on the website, it would > > never occur to me to look for such information in the FFmpeg

Re: [FFmpeg-devel] [PATCH] ffprobe: fix XML rendering, review XML layout

2023-10-20 Thread Stefano Sabatini
On date Wednesday 2023-10-18 23:44:45 +0200, Stefano Sabatini wrote: > On date Tuesday 2023-10-17 11:56:35 +0200, Stefano Sabatini wrote: > > On date Sunday 2023-10-15 19:15:16 +0200, Michael Niedermayer wrote: > > > On Sat, Oct 14, 2023 at 09:50:24PM +0200, Stefano Sabatini wrot

Re: [FFmpeg-devel] [PATCH] ffprobe: add -output_format as an alias of -of

2023-10-20 Thread Stefano Sabatini
On date Wednesday 2023-10-18 23:45:11 +0200, Stefano Sabatini wrote: > On date Sunday 2023-10-15 11:29:10 +0200, Stefano Sabatini wrote: > > Currently we have -of and -print_format, which is a bit confusing. Add > > -output_format as an alias of -of to match the short name. > &g

Re: [FFmpeg-devel] [REFUND-REQUEST] Travel & Accomodation for LDP 23

2023-10-23 Thread Stefano Sabatini
On date Saturday 2023-10-21 11:39:02 +0200, ffmpeg-devel Mailing List wrote: > Hi, > > I went to Prag for the LinuxDays Prague 23 [1] by Bus and stayed at the > university Dorm/Hotel. > > Bus:54,98 EUR > Hotel: 154,08 EUR (converted from CZK by VISA) > = > Total: 209,06 EUR L

Re: [FFmpeg-devel] [REFUND-REQUEST] VDD23 Travel

2023-10-23 Thread Stefano Sabatini
On date Monday 2023-10-23 22:42:02 +0200, Michael Niedermayer wrote: > On Sat, Oct 21, 2023 at 02:10:13PM +0200, Anton Khirnov wrote: > > Hi, > > requesting refund of travel costs for VDD23: > > * PRG -> DUB: 2789 CZK ≈ 116 € > > * DUB -> PRG: 112.44 € > > * bus DUB <-> Dublin: 12 € > > total: ~240

Re: [FFmpeg-devel] [PATCH 1/3] doc/encoders/libx264: review and extend option description

2023-11-04 Thread Stefano Sabatini
gt; > out.mkv > > @end example > > +To get the complete list of the libx264 options, invoke the command > > +@command{x264 --fullhelp} or consult the libx264 documentation. > > May want to make it clear that x264 refers to the standalone CLI tool. Isn't that cl

Re: [FFmpeg-devel] [PATCH] lsws/swscale.h: introduce sws_get_gaussian_vec

2023-11-04 Thread Stefano Sabatini
On date Wednesday 2023-09-06 13:13:25 +0200, Anton Khirnov wrote: > Quoting Stefano Sabatini (2023-09-06 00:59:44) [...] > A simple rename is a trivial API change. Almost everything else is not. > > > and therefore should not be committed. > > Yes, the baseline for every API

Re: [FFmpeg-devel] [PATCH] doc/t2h: Support texinfo 7.0

2023-11-05 Thread Stefano Sabatini
On date Sunday 2023-11-05 13:53:38 +, p...@frankplowman.com wrote: > From: Frank Plowman > > Texinfo 7.0, released in November 2022, changed the names of various > functions. Compiling docs with Texinfo 7.0 results in warnings and > improperly formatted documentation. More old names appear to

Re: [FFmpeg-devel] [PATCH] doc/t2h: Support texinfo 7.0

2023-11-06 Thread Stefano Sabatini
On date Sunday 2023-11-05 13:53:38 +, p...@frankplowman.com wrote: > From: Frank Plowman > > Texinfo 7.0, released in November 2022, changed the names of various > functions. Compiling docs with Texinfo 7.0 results in warnings and > improperly formatted documentation. More old names appear to

Re: [FFmpeg-devel] [PATCH] doc/t2h: Support texinfo 7.0

2023-11-06 Thread Stefano Sabatini
On date Tuesday 2023-11-07 00:36:14 +0100, Stefano Sabatini wrote: > On date Sunday 2023-11-05 13:53:38 +, p...@frankplowman.com wrote: > > From: Frank Plowman > > > > Texinfo 7.0, released in November 2022, changed the names of various > > functions. Compiling do

Re: [FFmpeg-devel] [PATCH v2 1/1] tools/general_assembly.pl - add options to print names, emails or both

2023-11-06 Thread Stefano Sabatini
On date Monday 2023-11-06 18:41:54 +, ffmpeg-devel Mailing List wrote: > Signed-off-by: Cosmin Stejerean > --- > tools/general_assembly.pl | 43 +-- > 1 file changed, 41 insertions(+), 2 deletions(-) > > diff --git a/tools/general_assembly.pl b/tools/gener

Re: [FFmpeg-devel] [PATCH v2] doc/t2h: Support texinfo 7.0

2023-11-07 Thread Stefano Sabatini
On date Tuesday 2023-11-07 23:32:23 +0100, epira...@gmail.com wrote: > On 7 Nov 2023, at 22:44, Frank Plowman wrote: > > > On 07/11/2023 20:38, epira...@gmail.com wrote: [...] > >> Just had a quick look and was wondering why your patch touches the > >> bootstrap.min.css? > > > > Texinfo 7.0 produ

Re: [FFmpeg-devel] [PATCH v3] doc/html: Support texinfo 7.0

2023-11-08 Thread Stefano Sabatini
On date Wednesday 2023-11-08 16:53:27 +, Frank Plowman wrote: > Patches attached. > > Changes since v2: * Split changes to t2h.pm and bootstrap.min.css into > separate commits. * Add justification for CSS changes to commit message. Thanks, both applied. ___

Re: [FFmpeg-devel] [PATCH v3] doc/html: Support texinfo 7.0

2023-11-08 Thread Stefano Sabatini
On date Wednesday 2023-11-08 23:56:46 +0100, Stefano Sabatini wrote: > On date Wednesday 2023-11-08 16:53:27 +, Frank Plowman wrote: > > Patches attached. > > > > Changes since v2: * Split changes to t2h.pm and bootstrap.min.css into > > separate commits. * Add ju

Re: [FFmpeg-devel] [PATCH] treewide: Spelling fixes

2023-11-18 Thread Stefano Sabatini
On date Friday 2023-11-10 16:41:54 +0100, ffmpeg-devel Mailing List wrote: > Fix spelling issue as reported by Debian's lintian tool: > accomodate -> accommodate > addtional -> additional > auxillary -> auxiliary > bellow -> below > betweeen -> between > Calulate -> Calculate > coefficents -> coeff

Re: [FFmpeg-devel] [PATCH] lavfi/Makefile: fix vf_cropdetect missed edge_common

2023-11-18 Thread Stefano Sabatini
On date Saturday 2023-11-18 10:26:07 +0800, Jun Zhao wrote: > fix #10664 > > vf_cropdetect depends on edge_common, it's missing in Makefile > > Signed-off-by: Jun Zhao > --- > libavfilter/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Applied, thanks.

Re: [FFmpeg-devel] [PATCH 1/3] doc/encoders/libx264: review and extend option description

2023-11-19 Thread Stefano Sabatini
On date Saturday 2023-11-04 22:26:27 +0100, Stefano Sabatini wrote: > On date Wednesday 2023-09-06 11:04:49 +0530, Gyan Doshi wrote: > [...] > > Sorry for the slow reply. > > > > -Argument is a list of @var{key}=@var{value} couples separated by > > > -&qu

[FFmpeg-devel] [POC][PATCHSET] Add qrencodesrc source

2023-11-29 Thread Stefano Sabatini
This is meant to introduce functionality to handle QR codes. This is still in early development stage (missing docs, padding functionality to avoid to insert a pad filter?), plus a filter will be added for adding a QR code on the input reading from metadata, and possibly at some point also a quirc

[FFmpeg-devel] [PATCH 1/2] lavfi: introduce textutils

2023-11-29 Thread Stefano Sabatini
Generalize drawtext utilities to make them usable in other filters. This will be needed to introduce the QR code source and filter without duplicating functionality. --- libavfilter/Makefile | 2 +- libavfilter/textutils.c | 379 +++ libavfilter/textutils.h | 182

[FFmpeg-devel] [PATCH 2/2] lavfi: add qrencodesrc source

2023-11-29 Thread Stefano Sabatini
--- configure | 4 + libavfilter/Makefile| 1 + libavfilter/allfilters.c| 1 + libavfilter/vsrc_qrencode.c | 435 4 files changed, 441 insertions(+) create mode 100644 libavfilter/vsrc_qrencode.c diff --git a/configure b/co

Re: [FFmpeg-devel] [POC][PATCHSET] Add qrencodesrc source

2023-12-02 Thread Stefano Sabatini
On date Thursday 2023-11-30 12:21:16 +0100, Paul B Mahol wrote: > On Thu, Nov 30, 2023 at 12:07 PM Tomas Härdin wrote: > > > tor 2023-11-30 klockan 01:49 +0100 skrev Stefano Sabatini: > > > This is meant to introduce functionality to handle QR codes. > > > &g

Re: [FFmpeg-devel] [POC][PATCHSET] Add qrencodesrc source

2023-12-02 Thread Stefano Sabatini
On date Friday 2023-12-01 16:08:23 +0100, Tomas Härdin wrote: > tor 2023-11-30 klockan 15:39 + skrev Cosmin Stejerean via ffmpeg- > devel: > > > > > On Nov 30, 2023, at 03:07, Tomas Härdin wrote: > > > > > > tor 2023-11-30 klockan 01:49 +0100 skrev

Re: [FFmpeg-devel] [PATCH 1/3] doc/encoders/libx264: review and extend option description

2023-12-03 Thread Stefano Sabatini
On date Sunday 2023-11-19 12:34:09 +0100, Stefano Sabatini wrote: > On date Saturday 2023-11-04 22:26:27 +0100, Stefano Sabatini wrote: [...] > > From a11eafe5a61a572f4e9ab9e4ab9907bba98300e4 Mon Sep 17 00:00:00 2001 > > From: Stefano Sabatini > > Date: Sat, 26 Aug 2023 01:10

Re: [FFmpeg-devel] [PATCH] avfilter: allow floating point formatting in expr_int_format (vf_drawtext.c)

2023-12-03 Thread Stefano Sabatini
On date Saturday 2023-12-02 15:54:34 +0100, Lennart Klebl wrote: > Since I was trying for quite some time to get proper floating point > formatting of positive and negative numbers working with the existing > drawtext/expr_int_format implementation, I added the f format specifier > that is only app

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: introduce textutils

2023-12-03 Thread Stefano Sabatini
On date Thursday 2023-11-30 01:49:13 +0100, Stefano Sabatini wrote: > Generalize drawtext utilities to make them usable in other filters. > This will be needed to introduce the QR code source and filter without > duplicating functionality. > --- > libavfilter/Makefile | 2 +-

Re: [FFmpeg-devel] [PATCH 1/7] avutil/tests/imgutils: factorize basic tests to new function

2023-12-03 Thread Stefano Sabatini
On date Sunday 2023-12-03 01:27:20 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/tests/imgutils.c | 68 ++ > 1 file changed, 39 insertions(+), 29 deletions(-) > > diff --git a/libavutil/tests/imgutils.c b/libavutil/tests/imgutils

Re: [FFmpeg-devel] [PATCH 2/7] avutil/tests/imgutils: add tests for av_image_fill_black()

2023-12-03 Thread Stefano Sabatini
On date Sunday 2023-12-03 01:27:21 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/tests/imgutils.c | 60 -- > tests/ref/fate/imgutils| 217 + > 2 files changed, 268 insertions(+), 9 deletions(-) > > diff --git a/libav

Re: [FFmpeg-devel] [PATCH 3/7] avutil/imgutils: fix av_image_fill_black() for some pixel formats

2023-12-03 Thread Stefano Sabatini
On date Sunday 2023-12-03 01:27:22 +0100, Marton Balint wrote: > - Fixes YA formats, because previous code always assumed alpha as the 4th > component. > - Fixes PAL format (as long as 0 is black, as in a systematic palette), > because > previous code assumed it as limited Y. > - Fixes XYZ for

Re: [FFmpeg-devel] [PATCH 4/7] avutil/imgutils: add support for 32bit pixel format for av_image_fill_black()

2023-12-03 Thread Stefano Sabatini
On date Sunday 2023-12-03 01:27:23 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/imgutils.c| 32 ++-- > tests/ref/fate/imgutils | 24 > 2 files changed, 34 insertions(+), 22 deletions(-) > > diff --git a/liba

Re: [FFmpeg-devel] [PATCH 5/7] avutil/imgutils: factorize a fill color function

2023-12-03 Thread Stefano Sabatini
On date Sunday 2023-12-03 01:27:24 +0100, Marton Balint wrote: > In preparation for making it public. > > Signed-off-by: Marton Balint > --- > libavutil/imgutils.c | 101 +++ > 1 file changed, 63 insertions(+), 38 deletions(-) > > diff --git a/libavutil/i

Re: [FFmpeg-devel] [PATCH 6/7] avutil/imgutils: add new function av_image_fill_color()

2023-12-03 Thread Stefano Sabatini
On date Sunday 2023-12-03 01:27:25 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > doc/APIchanges | 3 +++ > libavutil/imgutils.c | 4 ++-- > libavutil/imgutils.h | 30 ++ > libavutil/version.h | 2 +- > 4 files changed, 36 insertions(+), 3

Re: [FFmpeg-devel] [PATCH] libavfilter/asrc_flite: fixes and improvements

2023-12-04 Thread Stefano Sabatini
On date Sunday 2023-12-03 23:23:48 +0100, Paul B Mahol wrote: > Attached. > From fe1ece70c0ecbe6fb24e0823fe46db57242396e4 Mon Sep 17 00:00:00 2001 > From: Paul B Mahol > Date: Sun, 3 Dec 2023 21:38:08 +0100 > Subject: [PATCH 1/2] avfilter/asrc_flite: switch to activate > > Allows to set EOF time

Re: [FFmpeg-devel] [PATCH v2 1/7] avutil/tests/imgutils: factorize basic tests to new function

2023-12-06 Thread Stefano Sabatini
On date Wednesday 2023-12-06 09:22:14 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/tests/imgutils.c | 68 ++ > 1 file changed, 39 insertions(+), 29 deletions(-) LGTM, thanks. ___ ffmpe

Re: [FFmpeg-devel] [PATCH v2 2/7] avutil/tests/imgutils: add tests for av_image_fill_black()

2023-12-06 Thread Stefano Sabatini
On date Wednesday 2023-12-06 09:22:15 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/tests/imgutils.c | 61 +-- > tests/ref/fate/imgutils| 217 + > 2 files changed, 269 insertions(+), 9 deletions(-) LGTM, thanks.

Re: [FFmpeg-devel] [PATCH v2 3/7] avutil/imgutils: fix av_image_fill_black() for some pixel formats

2023-12-06 Thread Stefano Sabatini
On date Wednesday 2023-12-06 09:22:16 +0100, Marton Balint wrote: > - Fixes YA formats, because previous code always assumed alpha as the 4th > component. > - Fixes PAL format (as long as 0 is black, as in a systematic palette), > because > previous code assumed it as limited Y. > - Fixes XYZ

Re: [FFmpeg-devel] [PATCH v2 4/7] avutil/imgutils: add support for 32bit pixel format for av_image_fill_black()

2023-12-06 Thread Stefano Sabatini
On date Wednesday 2023-12-06 09:22:17 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavutil/imgutils.c| 33 +++-- > tests/ref/fate/imgutils | 24 > 2 files changed, 35 insertions(+), 22 deletions(-) LGTM, thanks. ___

Re: [FFmpeg-devel] [PATCH v2 5/7] avutil/imgutils: factorize a fill color function

2023-12-06 Thread Stefano Sabatini
On date Wednesday 2023-12-06 09:22:18 +0100, Marton Balint wrote: > In preparation for making it public. > > Signed-off-by: Marton Balint > --- > libavutil/imgutils.c | 103 +++ > 1 file changed, 64 insertions(+), 39 deletions(-) LGTM, thanks. ___

Re: [FFmpeg-devel] [PATCH v2 6/7] avutil/imgutils: add new function av_image_fill_color()

2023-12-06 Thread Stefano Sabatini
On date Wednesday 2023-12-06 09:22:19 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > doc/APIchanges | 3 +++ > libavutil/imgutils.c | 4 ++-- > libavutil/imgutils.h | 30 ++ > libavutil/version.h | 2 +- > 4 files changed, 36 insertions(+)

Re: [FFmpeg-devel] [PATCH v2 7/7] avcodec: add AV_CODEC_FLAG_CLEAR

2023-12-06 Thread Stefano Sabatini
On date Wednesday 2023-12-06 09:22:20 +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > doc/APIchanges | 3 +++ > doc/codecs.texi| 14 ++ > libavcodec/avcodec.h | 4 > libavcodec/decode.c| 6 ++ > libavcodec/options_ta

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: introduce textutils

2023-12-09 Thread Stefano Sabatini
On date Sunday 2023-12-03 16:05:40 +0100, Stefano Sabatini wrote: > On date Thursday 2023-11-30 01:49:13 +0100, Stefano Sabatini wrote: > > Generalize drawtext utilities to make them usable in other filters. > > This will be needed to introduce the QR code source and filter without

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: add qrencodesrc source

2023-12-09 Thread Stefano Sabatini
On date Thursday 2023-11-30 01:49:14 +0100, Stefano Sabatini wrote: > --- > configure | 4 + > libavfilter/Makefile| 1 + > libavfilter/allfilters.c| 1 + > libavfilter/vsrc_qrencode.c | 435 > 4

Re: [FFmpeg-devel] [PATCH] doc/filters: expand documentation on libvmaf filter

2023-12-09 Thread Stefano Sabatini
On date Friday 2023-12-08 18:47:28 +, ffmpeg-devel Mailing List wrote: > Attached. > From e2b98c2dec1248f5000a9291bd6f1177de2a4d0f Mon Sep 17 00:00:00 2001 > From: nilfm > Date: Fri, 8 Dec 2023 14:28:12 + > Subject: [PATCH] doc/filters: expand documentation on libvmaf filter > > Signed-o

Re: [FFmpeg-devel] [PATCH] avfilter/select: initialize prev_selected_n to NAN

2023-12-09 Thread Stefano Sabatini
On date Friday 2023-12-08 13:05:43 +0530, Gyan Doshi wrote: > As per the doc, prev_selected_n should be NAN at the start. > However, this was never set. > --- > libavfilter/f_select.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavfilter/f_select.c b/libavfilter/f_select.c > index

Re: [FFmpeg-devel] [PATCH] doc/ffmpeg: AV_FMT_DISCONT typo should be AVFMT_TS_DISCONT

2023-12-09 Thread Stefano Sabatini
On date Saturday 2023-12-09 13:17:55 -0600, Marth64 wrote: > --- > doc/ffmpeg.texi | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi > index 145cbb1032..6bcedd76d5 100644 > --- a/doc/ffmpeg.texi > +++ b/doc/ffmpeg.texi > @@ -1860,7 +186

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add setts example

2023-12-09 Thread Stefano Sabatini
On date Saturday 2023-12-09 13:23:04 -0600, Marth64 wrote: > --- > doc/bitstream_filters.texi | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi > index c63c20370f..145aa8684e 100644 > --- a/doc/bitstream_filters.texi > +++ b/doc/

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-09 Thread Stefano Sabatini
On date Saturday 2023-12-09 13:31:13 -0600, Marth64 wrote: > --- > doc/bitstream_filters.texi | 17 + > 1 file changed, 17 insertions(+) > > diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi > index 145aa8684e..b01ede0c93 100644 > --- a/doc/bitstream_filters.tex

Re: [FFmpeg-devel] [PATCH v3 6/7] avutil/imgutils: add new function av_image_fill_color()

2023-12-11 Thread Stefano Sabatini
On date Saturday 2023-12-09 20:25:07 +0100, Marton Balint wrote: > v3: added flags argument. > > Signed-off-by: Marton Balint > --- > doc/APIchanges | 3 +++ > libavutil/imgutils.c | 6 +++--- > libavutil/imgutils.h | 31 +++ > libavutil/version.h | 2 +- >

Re: [FFmpeg-devel] [PATCH] doc/bitstream_filters: add filter_units practical examples for removing closed captions

2023-12-11 Thread Stefano Sabatini
On date Saturday 2023-12-09 19:35:50 -0600, Marth64 wrote: > --- > doc/bitstream_filters.texi | 18 ++ > 1 file changed, 18 insertions(+) > > diff --git a/doc/bitstream_filters.texi b/doc/bitstream_filters.texi > index c63c20370f..d2ad6e78ff 100644 > --- a/doc/bitstream_filters.te

Re: [FFmpeg-devel] [PATCH 2/2] lavfi: add qrencodesrc source

2023-12-11 Thread Stefano Sabatini
On date Monday 2023-12-11 12:59:39 -0800, Kyle Swanson wrote: > Hi, > > On Sat, Dec 9, 2023 at 10:14 AM Stefano Sabatini wrote: > > > > On date Thursday 2023-11-30 01:49:14 +0100, Stefano Sabatini wrote: > > > --- > > > configure

Re: [FFmpeg-devel] [PATCH] examples/transcode: fix log message

2023-12-11 Thread Stefano Sabatini
On date Thursday 2023-11-30 23:57:31 +0800, Zhao Zhili wrote: > From: Zhao Zhili > > 'encoder' can be audio or video encoder. > --- > doc/examples/transcode.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks good, will apply. ___ ffmpeg-d

Re: [FFmpeg-devel] [PATCH v3] doc/filters: add example for idet filter

2023-12-11 Thread Stefano Sabatini
On date Monday 2023-12-11 14:07:42 -0600, Marth64 wrote: > Clean up the example further. Sorry. > > Signed-off-by: Marth64 > --- > doc/filters.texi | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/doc/filters.texi b/doc/filters.texi > index 6d00ba2c3f..bf59352ba0 100644 > --- a/d

Re: [FFmpeg-devel] [PATCH] doc/ffprobe: add a useful one-liner example to get essential input information as JSON

2023-12-11 Thread Stefano Sabatini
On date Saturday 2023-12-09 20:57:09 -0600, Marth64 wrote: > Signed-off-by: Marth64 > > This could be useful for folks who are just learning ffmpeg or have simple > needs for parsing input information as JSON. > > --- > doc/ffprobe.texi | 6 ++ > 1 file changed, 6 insertions(+) > > diff -

  1   2   3   4   5   6   7   8   9   10   >