Somehow it seems, that this patch never got onto the mailing list. So may I
kindly ask you to review it.
--
Stay hungry, stay foolish
> Am 26.01.2022 um 17:31 schrieb Simone Karin Lehmann :
>
>
> The patch adds an option to the hevc_videotoolbox encoder to prioritize speed
>
rQuality property: %d\n", status);
>>> + return AVERROR_EXTERNAL;
>>> +}
>
> If its called to priotize speed over qual, why not just print a warning and
> continue without this option?
You’re right. A warning seems much better. Changed this too.
since the SDK states that this property
defaults to FALSE for h264 and hevc and to TRUE for ProRes I didn’t add it to
the COMMON_OPTIONS but to each encoder options, because I didn’t want to make a
regression to the ProRes or enabling it by default for h264 and hevc. Hope
that’s ok.
Here’s th
> Am 23.04.2022 um 17:07 schrieb Thilo Borgmann :
>
>
> If that works I'd be happy. Does not apply for me anymore (on HEAD), though?
>
>
hhmm, the patch applies for me on current HEAD. I’ve tested it a few moments
ago on a fresh downloaded git snapshot.
Maybe a former patch from me still t
> Am 23.04.2022 um 21:56 schrieb Thilo Borgmann :
>
> Am 23.04.22 um 17:42 schrieb Simone Karin Lehmann:
>>> Am 23.04.2022 um 17:07 schrieb Thilo Borgmann :
>>>
>>>
>>> If that works I'd be happy. Does not apply for me anymore (on HEAD), thou
> Am 25.04.2022 um 21:14 schrieb Rick Kern :
>
>>
>>{ "a53cc", "Use A53 Closed Captions (if available)", OFFSET(a53_cc),
>> AV_OPT_TYPE_BOOL, {.i64 = 1}, 0, 1, VE },
>> +{ "prio_speed", "prioritize encoding speed", OFFSET(prio_speed),
>> AV_OPT_TYPE_BOOL, { .i64 = 0 }, 0, 1, VE },
>>
>
Hi,
may I kindly ask you to check, if this patch could now be applied?
Regards
Simone
Von meinem iPad gesendet
> Am 25.04.2022 um 22:33 schrieb Simone Karin Lehmann :
>
>
>
>>> Am 25.04.2022 um 21:14 schrieb Rick Kern :
>>>
>>>
>>> {
>> On May 1, 2022, at 1:31 PM, Simone Karin Lehmann wrote:
>>
>> Hi,
>>
>> may I kindly ask you to check, if this patch could now be applied?
> I’ll look at it today.
>
>>
>> Regards
>> Simone
>>
>> Von me
