On 4/10/19 10:05 PM, Michael Niedermayer wrote:
On Tue, Apr 09, 2019 at 11:50:16PM +0530, Shivam Goyal wrote:
lavf/flv: Add XV (Xunlei Video) Support.
Fixes ticket #3720.
Changelog|1
libavformat/Makefile |1
libavformat/allformats.c |1
libavformat
~150 data
elements for image data).
I have uploaded some samples of dicom files with explicit value
representation here (in case needed).
https://drive.google.com/drive/folders/1V8HUNeX3EYiPLj_dcFt8C68tAh7C7v4X?usp=sharing
Please comment,
Thank you ,
Shivam Go
On 6/25/19 2:12 AM, Michael Niedermayer wrote:
On Mon, Jun 24, 2019 at 09:18:13PM +0530, Shivam wrote:
Hi!
The code is to add DICOM Support. The patch is only for uncompressed
dicom files using explicit value representation. I would extend it, once i
clarify some doubts. As dicom
On 6/26/19 4:37 PM, Michael Niedermayer wrote:
On Wed, Jun 26, 2019 at 09:54:56AM +0200, Paul B Mahol wrote:
On 6/26/19, Michael Niedermayer wrote:
On Tue, Jun 25, 2019 at 01:52:09PM +0530, Shivam wrote:
On 6/25/19 2:12 AM, Michael Niedermayer wrote:
On Mon, Jun 24, 2019 at 09:18:13PM
On 6/27/19 9:21 PM, Michael Niedermayer wrote:
On Wed, Jun 26, 2019 at 11:33:05PM +0530, Shivam wrote:
On 6/26/19 4:37 PM, Michael Niedermayer wrote:
On Wed, Jun 26, 2019 at 09:54:56AM +0200, Paul B Mahol wrote:
On 6/26/19, Michael Niedermayer wrote:
On Tue, Jun 25, 2019 at 01:52:09PM
On 6/29/19 3:35 AM, Michael Niedermayer wrote:
On Fri, Jun 28, 2019 at 02:02:29PM +0530, Shivam wrote:
On 6/27/19 9:21 PM, Michael Niedermayer wrote:
On Wed, Jun 26, 2019 at 11:33:05PM +0530, Shivam wrote:
On 6/26/19 4:37 PM, Michael Niedermayer wrote:
On Wed, Jun 26, 2019 at 09:54:56AM
On 6/29/19 3:39 AM, Paul B Mahol wrote:
On 6/29/19, Michael Niedermayer wrote:
On Fri, Jun 28, 2019 at 02:02:29PM +0530, Shivam wrote:
On 6/27/19 9:21 PM, Michael Niedermayer wrote:
On Wed, Jun 26, 2019 at 11:33:05PM +0530, Shivam wrote:
On 6/26/19 4:37 PM, Michael Niedermayer wrote:
On
adata." (The tags present in Dicom dictionary would be demuxed).
I have also uploaded DICOM samples here.
https://1drv.ms/u/s!AosJ9_SrP4Tsh2WoPfQAI8cSsqUs?e=ZMd5fR
Please review,
Thank you,
Shivam Goyal
___
ffmpeg-devel mailing list
ffmpeg-devel@
the procedure, I have added an
option "-metadata." (The tags present in Dicom dictionary would be demuxed).
I have also uploaded DICOM samples here.
https://1drv.ms/u/s!AosJ9_SrP4Tsh2WoPfQAI8cSsqUs?e=ZMd5fR
Please review,
Thank you,
Shivam Goyal
>From cd7ebe834278b29b0429b3f5b37
Forwarded Message
Subject: Re: [FFmpeg-devel] [PATCH] lavf: Add DICOM demuxer, lavc: Add
DICOM decoder
Date: Thu, 22 Aug 2019 00:27:55 +0530
From: Shivam
To: Michael Niedermayer
On 8/21/19 2:00 AM, Michael Niedermayer wrote:
On Tue, Aug 20, 2019 at 08:53
On 8/21/19 7:27 PM, Moritz Barsnick wrote:
On Tue, Aug 20, 2019 at 20:53:43 +0530, Shivam wrote:
Please review,
(Untested, just visual code inspection.)
+- DICOM decoder and demxer
Typo -> demuxer. Also, when splitting the commits, also split the
changes to the Changelog. (Can still be
The patch contains DICOM decoder. I have improved the code as suggested.
Please, push it as soon as possible, as i have to share the commit in
GSoC final evaluation. if anything remain i would add it after that.
Thank you,
Shivam Goyal
>From 29f25f6650822ed8de8e51fa0510cf4ac91288aa Mon
The patch contains DICOM demuxer. I have improved the code as suggested.
Please, push it as soon as possible, as i have to share the commit in
GSoC final evaluation. if anything remain i would add it after that.
Thank you,
Shivam Goyal
>From e76ce45b2f7c0e6ce9706cbcb62da147e56e3e61 Mon
On 8/25/19 1:47 PM, Paul B Mahol wrote:
On Sat, Aug 24, 2019 at 11:53 PM Shivam wrote:
The patch contains DICOM decoder. I have improved the code as suggested.
Please, push it as soon as possible, as i have to share the commit in
GSoC final evaluation. if anything remain i would add it
On 8/27/19 2:04 AM, Moritz Barsnick wrote:
On Sun, Aug 25, 2019 at 03:20:13 +0530, Shivam wrote:
The patch contains DICOM decoder. I have improved the code as suggested.
Hi Shivan,
nice job.
First of all, all your samples now appear to demux and decode properly.
I didn't get a chance to
On 8/27/19 2:05 AM, Moritz Barsnick wrote:
On Sun, Aug 25, 2019 at 03:22:02 +0530, Shivam wrote:
The patch contains DICOM demuxer. I have improved the code as suggested.
Second part of my review:
From: Shivam Goyal <1998.goyal.shi...@gmail.com>
Date: Sun, 25 Aug 2019 02:57:35 +0530
S
This time i modified the initial buffer at the time of reading header
instead of changing the IO layer.
Suggest any changes required.
>From 277a4267f8cbb68c5fa57a0bddd215e04ca662bd Mon Sep 17 00:00:00 2001
From: Shivam Goyal
Date: Sun, 7 Apr 2019 12:13:21 +0530
Subject: [PATCH] Added
Updated patch for ticket #3720 .
I have tried to improve the patch as suggested.
>From 8c4cd8cfc2b7b07cebbfefb96fc9bb9e92668385 Mon Sep 17 00:00:00 2001
From: Shivam Goyal
Date: Tue, 9 Apr 2019 02:01:17 +0530
Subject: [PATCH] Added XV Support v3
---
libavformat/Makefile |
flv: Add XV (Xunlie Video) Support.
Updated patch for ticket #3720.
>From 4e976186059b0fc41de7b65f538c352d264477d4 Mon Sep 17 00:00:00 2001
From: Shivam Goyal
Date: Tue, 9 Apr 2019 15:00:49 +0530
Subject: [PATCH] Updated patch for ticket #3720. flv: Add XV (Xunlei Video)
supp
On 4/9/19 5:10 PM, Carl Eugen Hoyos wrote:
2019-04-09 11:36 GMT+02:00, Shivam Goyal :
flv: Add XV (Xunlie Video) Support.
Updated patch for ticket #3720.
Above is an acceptable commit message, slightly
better would be:
"
lavf/flv: Add XV (Xunlie Video) Support.
Fixes ticket #3720
lavf/flv: Add XV (Xunlei Video) Support.
Fixes ticket #3720
I have fixed the minor mistakes in the patch. I have also checked the
patch with patcheck.
>From a64698a11c10ec62968a5d853d7db0fed956c0d3 Mon Sep 17 00:00:00 2001
From: Shivam Goyal
Date: Tue, 9 Apr 2019 19:25:23 +0530
Subj
On 09-04-2019 08:32 PM, Moritz Barsnick wrote:
Some minor nitpicking remarks from me:
Subject: [PATCH] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720.
Basically, the second sentence belongs into the body of the commit
message, after a single empty line separator. (It may not matt
lavf/flv: Add XV (Xunlei Video) Support.
Fixes ticket #3720.
>From 605dc262abf948813c26d58f51d5e2d7f498d9cd Mon Sep 17 00:00:00 2001
From: Shivam Goyal
Date: Tue, 9 Apr 2019 23:36:27 +0530
Subject: [PATCH] lavf/flv: Add XV (Xunlei Video) Support. Fixes ticket #3720.
---
Change
ON_MINOR 27
>> +#define LIBAVFORMAT_VERSION_MINOR 28
>> #define LIBAVFORMAT_VERSION_MICRO 103
>
> When bumping MINOR, you need to reset MICRO to 100.
Would reset it to 100. Sending another patch with the documentation too.
Thank you
Shivam Goyal
The patch fixes ticket #3720. Add Xunlei video support.
Suggestions are appreciated.
Thank you
Shivam GoyalFrom 0f0d87b499c1e91bf2b6265a61e964c1a16da8de Mon Sep 17 00:00:00 2001
From: Shivam Goyal
Date: Thu, 2 May 2019 23:27:24 +0530
Subject: [PATCH] lavf/flv: Add XV (Xunlei Video) Support
The patch is for ticket #5154. https://trac.ffmpeg.org/ticket/5154
Suggest any changes required.
Shivam GoyalFrom 8416b130d461da117ca2d0b64e805c8e9cbe675c Mon Sep 17 00:00:00 2001
From: Shivam Goyal
Date: Sat, 4 May 2019 12:46:39 +0530
Subject: [PATCH] lavf/h264: Add support for raw h264
The improved patch is for ticket #5154.
Support for Raw h264 stream from Arecont Camera.
Suggest any changes required.
Shivam GoyalFrom c9e03c2460630686c6942b2078c64f82143d76f8 Mon Sep 17 00:00:00 2001
From: Shivam Goyal
Date: Sat, 4 May 2019 14:04:36 +0530
Subject: [PATCH] lavf/h264: Add
On 04-05-2019 15:15, Hendrik Leppkes wrote:
> On Sat, May 4, 2019 at 10:52 AM Shivam Goyal wrote:
>
>> The improved patch is for ticket #5154.
>>
>> Support for Raw h264 stream from Arecont Camera.
>>
>> Suggest any changes required.
The patch is for ticket #5154.
I have improved the patch as suggested.
Please review.
Thank you,
Shivam GoyalFrom 2aa843626f939218179d3ec252f76f9991c33ed6 Mon Sep 17 00:00:00 2001
From: Shivam Goyal
Date: Tue, 7 May 2019 10:01:15 +0530
Subject: [PATCH] lavf/h264: Add support for h264
On 07-05-2019 10:05, Shivam Goyal wrote:
> The patch is for ticket #5154.
>
> I have improved the patch as suggested.
>
> Please review.
>
> Thank you,
>
> Shivam Goyal
Ping, Please review.
Thank you
Shivam Goyal
_
On 09-05-2019 01:15, Reimar Döffinger wrote:
> On Tue, May 07, 2019 at 10:05:12AM +0530, Shivam Goyal wrote:
>
>> +static int arecont_h264_probe(const AVProbeData *p)
>> +{
>> +int i, j, k, o = 0;
>> +int ret = h264_probe(p);
>> +const uint8_t
On 09-05-2019 02:16, Michael Niedermayer wrote:
> On Tue, May 07, 2019 at 10:05:12AM +0530, Shivam Goyal wrote:
>
>> The patch is for ticket #5154.
>>
>> I have improved the patch as suggested.
>>
>> Please review.
>>
>>
On 09-05-2019 02:16, Michael Niedermayer wrote:
> On Tue, May 07, 2019 at 10:05:12AM +0530, Shivam Goyal wrote:
>
>> The patch is for ticket #5154.
>>
>> I have improved the patch as suggested.
>>
>> Please review.
>>
>>
On 09-05-2019 15:00, Moritz Barsnick wrote:
> On Thu, May 09, 2019 at 07:28:20 +0530, Shivam Goyal wrote: +//Extra to
> find the http header
> +size = 2 * ARECONT_H264_MIME_SIZE + RAW_PACKET_SIZE;
> +data = av_malloc(size);
> +
> +if (av_new_pac
s. also as the packet can
contain partial header at the beginning and end of the pkt, i took extra
size to read from the input stream
Please review
Thank You
Shivam GoyalFrom deb859ff488c500b7e6005e350f04c200f2853a4 Mon Sep 17 00:00:00 2001
From: Shivam Goyal
Date: Thu, 9 May 2019 23:18:13 +053
there can be another approach ( i know
this is an easy task but just due to those 0x400 bytes it is tricky ).
Thank you,
Shivam GoyalFrom b9dde21af273c8137df370399ade79c0c59a4046 Mon Sep 17 00:00:00 2001
From: Shivam Goyal
Date: Fri, 10 May 2019 17:53:26 +0530
Subject: [PATCH] lavf/flv:
On 11-05-2019 03:21, Reimar Döffinger wrote:
> On 10.05.2019, at 15:10, Shivam Goyal wrote:
>
>> -> Making two avio contexts and one calling the other ( I am not sure if
>> i implemented it in the right way, but still i reached low level ).
>
> Can't you at
On 11-05-2019 04:27, Reimar Döffinger wrote:
> On Thu, May 09, 2019 at 11:45:59PM +0530, Shivam Goyal wrote:
>
>> @@ -117,4 +120,128 @@ static int h264_probe(const AVProbeData *p)
>> return 0;
>> }
>>
>> +static const uint8_t arecont_sign[] = {0x2D, 0x2D, 0x
p 17 00:00:00 2001
From: Shivam Goyal
Date: Sun, 24 Mar 2019 16:19:05 +0530
Subject: [PATCH] Added XV file support
---
libavformat/Makefile |1 +
libavformat/allformats.c |1 +
libavformat/xvdec.c | 1395 ++
libavformat/xvtools.h| 95
On 3/24/19 6:09 PM, Moritz Barsnick wrote:
On Sun, Mar 24, 2019 at 16:35:40 +0530, Shivam Goyal wrote:
libavformat/xvdec.c | 1395 ++
libavformat/xvtools.h| 95 +++
This looks like a 90% copy of flvdec, with some modifications. I
believe it
On 3/25/19 4:47 AM, Moritz Barsnick wrote:
On Sun, Mar 24, 2019 at 13:39:09 +0100, Moritz Barsnick wrote:
Another thing:
On Sun, Mar 24, 2019 at 16:35:40 +0530, Shivam Goyal wrote:
libavformat/xvdec.c | 1395 ++
libavformat/xvtools.h| 95
On 3/25/19 3:59 PM, Michael Niedermayer wrote:
On Sun, Mar 24, 2019 at 04:35:40PM +0530, Shivam Goyal wrote:
The attached patch is for ticket #3720
https://trac.ffmpeg.org/ticket/3720
I have tested this demuxer on the files 1.xv and 5.xv attached with the
ticket
http
Hi Dev-Community,
I am Shivam Saboo from India. I am pursuing B.Tech in Computer Science and
Engineering at Indian Institute of Information Technology, Vadodara. I am
new to FFmpeg and wish to contribute as a GSoC applicant this year.
I am very interested in Deep Learning especially in the field
43 matches
Mail list logo