Re: [FFmpeg-devel] Fwd: [PATCH] libavformat: add librist protocol

2020-12-28 Thread Sergio M. Ammirata, Ph.D.
Hello Nicolas, We already had a file descriptor signaling method on a private branch. Here is the link: https://code.videolan.org/rist/librist/-/commits/descriptor_method/ I assume this would work? Is the idea to add our file handle to a larger array on a master select loop inside ffmpeg? Afte

Re: [FFmpeg-devel] Fwd: [PATCH] libavformat: add librist protocol

2020-12-30 Thread Sergio M. Ammirata, Ph.D.
Understood ... thanks for the advice. Is there else blocking the integration of the library based module into ffmpeg? We would prefer not to have it in "experimental mode". Regards, Sergio On Tue, 2020-12-29 at 23:03 +0100, Nicolas George wrote: > Sergio M. Ammirata, Ph.D.

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-01-19 Thread Sergio M. Ammirata, Ph.D.
Hello Paul, In the librist_read function, you must call the new API called rist_receiver_data_block_free to free the buffer when you are done using it. I am not sure if ffmpeg supports a custom callback for freeing a buffer. If it does, you could actually use the rist buffer as a reference as lon

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-01-31 Thread Sergio M. Ammirata, Ph.D.
librist has an internal buffer limit of 1 bytes (the protocol has none). For writing, the data you give librist, will go out "as is" to the network with some added protocol overhead bytes (28 bytes without encryption enabled and 36 bytes with encryption enabled). To avoid your data being fra

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-02-01 Thread Sergio M. Ammirata, Ph.D.
otocol. In your example above, the reader will get three reads of 20, 30 and 40 Sergio On Mon, 2021-02-01 at 15:22 +0100, Nicolas George wrote: > Sergio M. Ammirata, Ph.D. (12021-01-31): > For writing, the data you give librist, will go out "as > is"to the network with some added

Re: [FFmpeg-devel] [PATCH] libavformat: add librist protocol

2021-02-01 Thread Sergio M. Ammirata, Ph.D.
On Mon, 2021-02-01 at 16:25 +0100, Nicolas George wrote: > Sergio M. Ammirata, Ph.D. (12021-02-01): > This is a packet protocol. In your example above, > thereader will get three reads of 20, 30 and 40 > Thank you for the clarification. I looked a little in the > code

[FFmpeg-devel] Fix for PES packets with too much padding

2021-08-03 Thread Sergio M. Ammirata, Ph.D.
PES packet with too much padding trigger unlimited error messages "PES packet size mismatch" because the code that corrects the length is wrong. Here is a sample file: http://99.93.62.129/smpte2038.ts PID 300 is the one triggering the errors. I am attaching a patch that fixes the problem. From 3a2

Re: [FFmpeg-devel] Fix for PES packets with too much padding

2021-08-05 Thread Sergio M. Ammirata, Ph.D.
You are right ... the if statement would have to change as well. On Tue, 2021-08-03 at 14:20 +, ffmpegandmahanstreamer@e.email wrote: > August 3, 2021 10:07 AM, "Sergio M. Ammirata, Ph.D." < > ser...@ammirata.net> wrote: > PES packet with too much padding trigger

Re: [FFmpeg-devel] Fix for PES packets with too much padding

2021-08-05 Thread Sergio M. Ammirata, Ph.D.
Can you share the video file you are using to get the segfault? On Thu, 2021-08-05 at 23:10 +0200, Michael Niedermayer wrote: > On Thu, Aug 05, 2021 at 11:08:30PM +0200, Michael > Niedermayer wrote: > On Tue, Aug 03, 2021 at 10:07:34AM -0400, Sergio M. > Ammirata, Ph.D. wrote: >