Re: [FFmpeg-devel] [PATCH v11 07/14] avcodec/vaapi_encode: extract the init and close function to base layer

2024-05-25 Thread Sean McGovern
kes FFHWBaseEncodeContext as an > argument, rather than AVCodecContext (apart from where the function > absolutely must read some data from it)? > Might this suggestion involve having to do some ugly down-casting? -- Sean McGovern > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] Empty arch/ directories

2024-05-29 Thread Sean McGovern
Hi, It is not likely we will get anyone to step up to do DSP work for arguably dead architectures like SPARC, Blackfin, etc. Maybe is it time to remove those directories that just contain a README now? Sean McGovern ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH 1/2] libavcodec: various: remove empty directories originally for legacy DSP code

2024-05-30 Thread Sean McGovern
--- libavcodec/bfin/README | 6 -- libavcodec/sh4/README | 6 -- libavcodec/sparc/README | 6 -- 3 files changed, 18 deletions(-) delete mode 100644 libavcodec/bfin/README delete mode 100644 libavcodec/sh4/README delete mode 100644 libavcodec/sparc/README diff --git a/libavcodec

[FFmpeg-devel] [PATCH 2/2] [RFC] libavcodec: remove DSP acceleration code for DEC Alpha

2024-05-30 Thread Sean McGovern
--- Changelog| 1 + libavcodec/alpha/Makefile| 10 - libavcodec/alpha/asm.h | 153 -- libavcodec/alpha/blockdsp_alpha.c| 49 - libavcodec/alpha/hpeldsp_alpha.c | 213 --- libavcodec/alpha/hpeldsp_alph

Re: [FFmpeg-devel] [PATCH] libavcodec/libxvid: code cleanup (replace magic numbers)

2024-05-30 Thread Sean McGovern
On Thu, May 30, 2024 at 5:20 PM Ramiro Polla wrote: > > --- > libavcodec/libxvid.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c > index b9ac39429d..a490f16b3f 100644 > --- a/libavcodec/libxvid.c > +++ b/libavcodec/libxvid

[FFmpeg-devel] [PATCH] [RFC] libavutil: remove AVR32 assembly

2024-05-30 Thread Sean McGovern
--- libavutil/avr32/bswap.h| 44 libavutil/avr32/intreadwrite.h | 182 - 2 files changed, 226 deletions(-) delete mode 100644 libavutil/avr32/bswap.h delete mode 100644 libavutil/avr32/intreadwrite.h diff --git a/libavutil/avr32/bswap.h b/libavu

Re: [FFmpeg-devel] [PATCH 1/2] libavcodec: various: remove empty directories originally for legacy DSP code

2024-06-01 Thread Sean McGovern
On Thu, May 30, 2024 at 5:21 PM Sean McGovern wrote: > > --- > libavcodec/bfin/README | 6 -- > libavcodec/sh4/README | 6 -- > libavcodec/sparc/README | 6 -- > 3 files changed, 18 deletions(-) > delete mode 100644 libavcodec/bfin/README > delete mo

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-06-03 Thread Sean McGovern
On Mon, Jun 3, 2024, 17:32 Michael Niedermayer wrote: > On Sun, Jun 02, 2024 at 03:49:42PM +0200, Sebastian Ramacher wrote: > > On 2024-03-03 09:55:15 +0100, Sebastian Ramacher wrote: > > > On 2024-03-02 20:39:08 -0500, Sean McGovern wrote: > > > > On Sat, Mar 2, 2

[FFmpeg-devel] [RFC] flac_wasted32 vector implementation for VSX on ppc64le

2024-06-06 Thread Sean McGovern
egister vec_s32 shifted; for (int i = 0; i < len; i += VSX_STRIDE) { vec1 = vec_vsx_ld(i, decoded); shifted = vec_sl(vec1, vec2); vec_vsx_st(shifted, i, decoded); } } Anyone with experience with AltiVec or VSX see something obvious I am missing? -- Sean M

Re: [FFmpeg-devel] [RFC] flac_wasted32 vector implementation for VSX on ppc64le

2024-06-06 Thread Sean McGovern
On Thu, Jun 6, 2024, 05:53 Rémi Denis-Courmont wrote: > > > Le 6 juin 2024 10:43:05 GMT+03:00, Sean McGovern a > écrit : > >Hi, > > > >Attached inline is a _non-working_ implementation of flac_wasted32 for > >VSX developed on a POWER9 in little-endian mo

Re: [FFmpeg-devel] [PATCH] lavu/arm: remove GCC 4.6- stuff

2024-06-07 Thread Sean McGovern
On Fri, Jun 7, 2024 at 12:49 PM Rémi Denis-Courmont wrote: > > Since the C11 support is required, those GCC versions can no longer be > supported anyhow. > --- > libavutil/arm/bswap.h| 20 > libavutil/arm/intreadwrite.h | 91 > libavutil/intre

Re: [FFmpeg-devel] [PATCH 1/2] lavu/bswap: remove some inline assembler

2024-06-07 Thread Sean McGovern
On Fri, Jun 7, 2024 at 2:20 PM Rémi Denis-Courmont wrote: > > C code or compiler built-ins are preferable over inline assembler for > byte-swaps as it allows for better optimisations (e.g. instruction > scheduling) which would otherwise be impossible. > > As with f64c2e710fa1a7b59753224e717f57c484

Re: [FFmpeg-devel] [PATCH 2/2] sh4: remove architecture

2024-06-07 Thread Sean McGovern
On Fri, Jun 7, 2024 at 2:20 PM Rémi Denis-Courmont wrote: > > Support for SuperH was dropped over a decade ago. There no longer is any > architecture-specific code to be found, so just remove the corresponding > test. Technically it is still possible to compile FFmpeg as the > "generic" (pure C) a

[FFmpeg-devel] remove DEC Alpha DSP & support code

2024-06-09 Thread Sean McGovern
Hi, Attached is a patch to do proper removal of support for the DEC Alpha. I hope it is not mangled. Side note: it seems GMail now prevents sending patches directly with git send-email -- I really wish we could move to a CI platform like GitLab or Gitea. -- Sean McGovern From

Re: [FFmpeg-devel] remove DEC Alpha DSP & support code

2024-06-10 Thread Sean McGovern
Hi, On Mon, Jun 10, 2024 at 8:17 PM Michael Niedermayer wrote: > > On Mon, Jun 10, 2024 at 02:42:16PM +0200, Vittorio Giovara wrote: > > On Mon, Jun 10, 2024 at 2:29 PM Michael Niedermayer > > wrote: > > > > > On Sun, Jun 09, 2024 at 04:08:48PM -0400, Sean McGov

Re: [FFmpeg-devel] [PATCH] configure: detect 64-bit generic platforms

2024-06-11 Thread Sean McGovern
___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > +1 for this. L

[FFmpeg-devel] Reset password on Patchwork

2024-06-11 Thread Sean McGovern
Hi, Can someone help me reset my password on Patchwork? I've used the 'Forgot password ' link several times and never received an email. -- Sean McGovern ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/

Re: [FFmpeg-devel] remove DEC Alpha DSP & support code

2024-06-13 Thread Sean McGovern
1 juin 2024 12:59:23 GMT+03:00, Michael Niedermayer < > > mich...@niedermayer.cc> a écrit : > > > >On Mon, Jun 10, 2024 at 08:52:08PM -0400, Sean McGovern wrote: > > > >[...] > > > >> Are there any real concerns about the Alpha removal itself? > &g

Re: [FFmpeg-devel] [PATCH 2/2] sh4: remove architecture

2024-06-13 Thread Sean McGovern
On Fri, Jun 7, 2024, 17:18 Sean McGovern wrote: > On Fri, Jun 7, 2024 at 2:20 PM Rémi Denis-Courmont > wrote: > > > > Support for SuperH was dropped over a decade ago. There no longer is any > > architecture-specific code to be found, so just remove the corresponding >

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/j2kenc: Merge dwt_norm into lambda

2024-06-23 Thread Sean McGovern
cblk->layers[0].cum_passes = cblk->ninclpasses; > > cblk->layers[0].npasses = cblk->ninclpasses; > > Does this also fix the UB in the vsynth*-jpeg2000-yuva444p16 tests? > > - Andreas > >

Re: [FFmpeg-devel] [RFC] flac_wasted32 vector implementation for VSX on ppc64le

2024-06-26 Thread Sean McGovern
Hi, On Thu, Jun 6, 2024, 12:51 Sean McGovern wrote: > > > On Thu, Jun 6, 2024, 05:53 Rémi Denis-Courmont wrote: > >> >> >> Le 6 juin 2024 10:43:05 GMT+03:00, Sean McGovern a >> écrit : >> >Hi, >> > >> >Attached inline is a _non

Re: [FFmpeg-devel] [PATCH 5/6] checkasm: add tests for yuv2rgb

2024-06-29 Thread Sean McGovern
gt; > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > It looks like this exposed an issue in the AltiVec acceleration in libswscale. libswscale/ppc/yuv2rgb.c looks a bit too complex for

[FFmpeg-devel] [PATCH] libavutil/ppc/cpu.c: check that AT_HWCAP2 is defined

2023-10-14 Thread Sean McGovern
It was not introduced until glibc 2.18. --- This should fix the ppc32 FATE node. --- libavutil/ppc/cpu.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavutil/ppc/cpu.c b/libavutil/ppc/cpu.c index 96b491c716..bc8bb5f47c 100644 --- a/libavutil/ppc/cpu.c +++ b/libavutil/p

Re: [FFmpeg-devel] [PATCH] libavutil/ppc/cpu.c: check that AT_HWCAP2 is defined

2023-10-18 Thread Sean McGovern
On Sat, Oct 14, 2023, 23:27 Sean McGovern wrote: > It was not introduced until glibc 2.18. > --- > This should fix the ppc32 FATE node. > --- > libavutil/ppc/cpu.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavutil/ppc/cpu.c b/lib

Re: [FFmpeg-devel] [PATCH 1/2] aarch64: Simplify the linux runtime cpu detection code

2023-10-24 Thread Sean McGovern
; > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". >

Re: [FFmpeg-devel] [PATCH] lavu/riscv: fix typo

2023-10-26 Thread Sean McGovern
mail > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > Looks OK to me. -- Sean McGovern > ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 1/2] aarch64: Simplify the linux runtime cpu detection code

2023-10-26 Thread Sean McGovern
On Tue, Oct 24, 2023 at 8:40 AM Sean McGovern wrote: > > > > On Tue, Oct 24, 2023, 08:23 Martin Storsjö wrote: >> >> Skip doing the whole getauxval(AT_HWCAP) if HWCAP_CPUID isn't >> defined. >> --- >> libavutil/aarch64/cpu.c | 6 +-

Re: [FFmpeg-devel] [PATCH 1/2] aarch64: Simplify the linux runtime cpu detection code

2023-10-26 Thread Sean McGovern
On Thu, Oct 26, 2023 at 5:40 PM Sean McGovern wrote: > > On Tue, Oct 24, 2023 at 8:40 AM Sean McGovern wrote: > > > > > > > > On Tue, Oct 24, 2023, 08:23 Martin Storsjö wrote: > >> > >> Skip doing the whole getauxval(AT_HWCAP) if HWCAP_CPUID isn&

Re: [FFmpeg-devel] [PATCH 2/4] avfilter/buffersink: cuddle () closer around =

2023-11-02 Thread Sean McGovern
s://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > This and 1/2 seem a bit frivolous, but providing they don't violate the project style guide, LGTM. -- Sean McGove

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/flicvideo: consider width in copy loops

2023-11-02 Thread Sean McGovern
y_ptr += s->frame->linesize[0]) { > > bytestream2_get_buffer(&g2, pixels + y_ptr, > 3*s->avctx->width); > -- > 2.17.1 > > ___ > ffmpeg-devel ma

Re: [FFmpeg-devel] [PATCH 4/4] avformat/lafdec: Check for 0 parameters

2023-11-02 Thread Sean McGovern
if (!s->data) > -- > 2.17.1 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffm

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: switch to activate

2023-11-07 Thread Sean McGovern
org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > This is really unfair to Paul to let this drag on for so long. If you are genuinely this b

Re: [FFmpeg-devel] [PATCH] avfilter/buffersrc: switch to activate

2023-11-13 Thread Sean McGovern
per, > In the kingdom of code, you're the top-drawer. > > To Paul's Patch, a toast we raise, > In the realm of software, you set ablaze. > For every bug quivered, and every glitch shivered, > Thanks to Paul's Patch, we code delivered! > > thx > > [...] > --

Re: [FFmpeg-devel] Need to reduce ffmpeg.exe size in n6.0

2023-11-14 Thread Sean McGovern
with subject "unsubscribe". > Saying it doesn't work is decidedly nebulous. Also, ffmpeg-devel is a development-centered list and not the correct forum for CLI usage help. -- Sean McGovern > ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] mips/ac3dsp_mips: add missing stddef.h header include

2023-11-25 Thread Sean McGovern
> ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > Tangential to the change, but I would be super curious to know if anyone is using m

[FFmpeg-devel] RISC-V dev kit recommendations

2023-12-01 Thread Sean McGovern
Hi, If I wanted to purchase a RISC-V developer kit, does anyone have suggestions of what to buy? Or even what to steer clear of? Thanks, Sean McGovern ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH] fate: fix sub2video_{basic, time_limited} on big-endian targets

2024-03-25 Thread Sean McGovern
Hi, On Fri, Mar 8, 2024, 10:11 Sean McGovern wrote: > On Wed, Mar 6, 2024, 18:48 Sean McGovern wrote: > >> The reference file uses BGRA pixel format, so request it here. >> --- >> tests/fate/ffmpeg.mak | 2 ++ >> 1 file changed, 2 insertions(+) >> >>

Re: [FFmpeg-devel] [PATCH 2/5] fate/ffmpeg: Explicitly set pix fmt for sub2video tests

2024-03-29 Thread Sean McGovern
__ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > I already submitted this change a f

Re: [FFmpeg-devel] [PATCH 06/18] postproc/postprocess: Don't generally include arch-specific headers

2024-03-29 Thread Sean McGovern
uint8_t src[], int stride, PPContext *c) > { > -#if HAVE_7REGS && TEMPLATE_PP_MMXEXT > +#if TEMPLATE_PP_MMXEXT && HAVE_7REGS > DECLARE_ALIGNED(8, uint64_t, tmp)[3]; > __asm__ volatile( > "pxor %%mm6, %%mm6 \n\t" > -- &g

Re: [FFmpeg-devel] [PATCH 07/18] swscale/swscale_internal: Only include altivec header iff HAVE_ALTIVEC

2024-03-29 Thread Sean McGovern
t > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". This also looks good to me. -- Sean McGovern

Re: [FFmpeg-devel] [PATCH 6/6] fate/image: Fix EXR tests on big endian

2024-03-30 Thread Sean McGovern
-large: CMD = framecrc -i > $(TARGET_SAMPLES)/exr/rgb_tile_half_piz_dw_large.exr -vf scale -pix_fmt > gbrpf32le > > FATE_EXR += fate-exr-rgb-tile-uint32-piz-dw-large > -fate-exr-rgb-tile-uint32-piz-dw-large: CMD = framecrc -i > $(TARGET_SAMPLES)/exr/rgb_tile_uint32_piz_dw_large.

Re: [FFmpeg-devel] 7.0 Name

2024-04-01 Thread Sean McGovern
gt; ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > Not sure if I am allowed to pick, my choice is D

Re: [FFmpeg-devel] [PATCH] avcodec/libsvt1: check return value of sned/receive functions

2024-04-09 Thread Sean McGovern
.0 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe&qu

Re: [FFmpeg-devel] [PATCH] avcodec/libx264: bump minimum required version to 160

2024-04-11 Thread Sean McGovern
exhausted all other alternatives. > -- Abba Eban > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmp

Re: [FFmpeg-devel] [PATCH v2] configure: support msvc build inside WSL

2024-04-27 Thread Sean McGovern
> (!match($$0, / /)) print "$@:", $$0 }'\'' > $(@:.o=.d)' > +fi > _DEPFLAGS='$(CPPFLAGS) $(CFLAGS) -showIncludes -Zs' > _cflags_speed="-O2" > _cflags_size="-O1" > -- > 2.43.2 >

Re: [FFmpeg-devel] [REFUND-REQUEST] Vulkan F2F travel

2024-04-29 Thread Sean McGovern
them. > > > > 95 GBP: Eurostar to Bruxelle-Midi > > 95 GBP: Eurostar from Bruxelle-Midi > > Total: 190 GBP > > LGTM > > PS: maybe we should make a page on trac that links to all talks from all > FFmpeg developers > Is there video/audio from this talk? I

Re: [FFmpeg-devel] [PATCH] avutil/ppc/cpu: Also use the machdep.altivec sysctl on NetBSD

2024-05-06 Thread Sean McGovern
= {CTL_MACHDEP, CPU_ALTIVEC}; > #else > int sels[2] = {CTL_HW, HW_VECTORUNIT}; > -- > 2.44.0 > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe,

Re: [FFmpeg-devel] [PATCH] tools: Add target_sws_fuzzer.c

2024-02-17 Thread Sean McGovern
uot;, "none", 0); > + > +ret = sws_init_context(sws, NULL, NULL); > +if (ret < 0) > +goto end; > + > +fprintf(stderr, "%d x %d %s -> %d x %d %s\n", srcW, srcH, > desc_src->name, dstW, dstH, desc_dst->name); > +//TODO Sli

Re: [FFmpeg-devel] [PATCH] fate/mxf: fix mxf-probe-j2k on big endian systems

2024-02-22 Thread Sean McGovern
vel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". Confirming this fixes #10868 for me. Thanks, Sean McGovern ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH 0/1] fate-aac-encode-pred UBsan fix

2024-02-25 Thread Sean McGovern
From: Sean McGovern Hi FFmpeg-devel, I've started looking into the results posted by the UBsan FATE node -- http://fate.ffmpeg.org/history.cgi?slot=x86_64-archlinux-gcc-ubsan Here is the error reported by FATE (snipped for brevity) for 'fate-aac-encode-pred': [aist#0:0/pcm_s1

[FFmpeg-devel] [PATCH 1/1] aacenc_pred: prevent UB in ff_aac_adjust_common_pred()

2024-02-25 Thread Sean McGovern
--- libavcodec/aacenc_pred.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/aacenc_pred.c b/libavcodec/aacenc_pred.c index f87fcd5a00..d3efade85e 100644 --- a/libavcodec/aacenc_pred.c +++ b/libavcodec/aacenc_pred.c @@ -162,9 +162,11 @@ void ff_aac_adjust_common_p

Re: [FFmpeg-devel] [PATCH 0/1] fate-aac-encode-pred UBsan fix

2024-02-25 Thread Sean McGovern
On Sun, Feb 25, 2024 at 1:44 PM Sean McGovern wrote: > > > Here is the error reported by FATE (snipped for brevity) for > 'fate-aac-encode-pred': > Ooops! I should copy-paste more often -- that should be 'fate-aac-pre

Re: [FFmpeg-devel] [PATCH 1/1] aacenc_pred: prevent UB in ff_aac_adjust_common_pred()

2024-02-27 Thread Sean McGovern
Hi Andreas, First off all, thanks for having a look! :) On Tue, Feb 27, 2024 at 1:37 PM Andreas Rheinhardt wrote: > > Sean McGovern: > > --- > > libavcodec/aacenc_pred.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/l

Re: [FFmpeg-devel] [PATCH] avcodec/dxvenc: Use proper alignment, write endian-independent output

2024-02-27 Thread Sean McGovern
rev_pos, state = 16, pos > = 2, op = 0; > > ht_init(ctx->color_lookback_ht); Confirming that this does fix the failing test on a big-endian PowerPC + Altivec virtual machine. Thanks, Sean McGovern ___ ffmpeg-devel mailing list ffmpeg-d

Re: [FFmpeg-devel] FFmpeg 7.0 blocking issues

2024-03-02 Thread Sean McGovern
eople want me to wait or ignore them and branch ? > > > Iam not sure when the exact deadline is but if we keep waiting > > > we will not get into ubuntu 24.04 LTS > > > > 24.04 is past feature freeze, so it's too late for that. > > we should aim earlier i

[FFmpeg-devel] [PATCH] aacenc_pred: prevent UB in ff_aac_adjust_common_pred()

2024-03-04 Thread Sean McGovern
Iterate over 'pmax' instead of 'num_swb'. --- libavcodec/aacenc_pred.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aacenc_pred.c b/libavcodec/aacenc_pred.c index a486c44d42..c5b8aa9665 100644 --- a/libavcodec/aacenc_pred.c +++ b/libavcodec/aacenc_pred.c @@ -164,7

[FFmpeg-devel] [PATCH] fate: fix sub2video_{basic, time_limited} on big-endian targets

2024-03-06 Thread Sean McGovern
The reference file uses BGRA pixel format, so request it here. --- tests/fate/ffmpeg.mak | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak index 669c878c7f..77e93693b9 100644 --- a/tests/fate/ffmpeg.mak +++ b/tests/fate/ffmpeg.mak @@ -62,6 +62,7 @@

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Sean McGovern
peg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > Everybody can we *please* keep the responses civil/professional on the ML. -- Se

Re: [FFmpeg-devel] [PATCH] fate: fix sub2video_{basic, time_limited} on big-endian targets

2024-03-08 Thread Sean McGovern
On Wed, Mar 6, 2024, 18:48 Sean McGovern wrote: > The reference file uses BGRA pixel format, so request it here. > --- > tests/fate/ffmpeg.mak | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/fate/ffmpeg.mak b/tests/fate/ffmpeg.mak > index 669c878c7f..77e9

[FFmpeg-devel] Did FATE have an unhappy accident?

2024-03-08 Thread Sean McGovern
It's been unreachable since yesterday. -- Sean McGovern ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with su

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Sean McGovern
On Fri, Mar 8, 2024, 10:19 Nicolas George wrote: > Sean McGovern (12024-03-08): > > Everybody can we *please* keep the responses civil/professional on the > ML. > > Civil, certainly, provided others are civil to me. > > Professional, not a chance. This is L

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Sean McGovern
On Fri, Mar 8, 2024, 10:31 Paul B Mahol wrote: > On Fri, Mar 8, 2024 at 4:21 PM Vittorio Giovara < > vittorio.giov...@gmail.com> > wrote: > > > On Fri, Mar 8, 2024 at 4:10 PM Sean McGovern wrote: > > > > > On Fri, Mar 8, 2024, 08:20 Nicolas George wrote:

Re: [FFmpeg-devel] [PATCH 2/3] lavc: replace ff_thread_get_buffer() with ff_get_buffer()

2024-03-08 Thread Sean McGovern
On Fri, Mar 8, 2024, 10:37 Vittorio Giovara wrote: > On Fri, Mar 8, 2024 at 4:34 PM Sean McGovern wrote: > > > On Fri, Mar 8, 2024, 10:31 Paul B Mahol wrote: > > > > > On Fri, Mar 8, 2024 at 4:21 PM Vittorio Giovara < > > > vittorio.giov...@gmail.com>

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec: Don't include libavcodec/x86/vvc/Makefile on any architecture

2024-03-09 Thread Sean McGovern
gt; -include $(SRC_PATH)/libavcodec/x86/vvc/Makefile > +-include $(SRC_PATH)/libavcodec/$(ARCH)/vvc/Makefile > OBJS-$(CONFIG_AANDCTTABLES)+= aandcttab.o > OBJS-$(CONFIG_AC3DSP) += ac3dsp.o ac3.o ac3tab.o > OBJS-$(CONFIG_ADTS_HEADER) += adts_

Re: [FFmpeg-devel] [PATCH 1/2] makefile: Clean up missed object files with "make clean"

2024-03-09 Thread Sean McGovern
) $(CLEANSUFFIXES:%=libavfilter/dnn/%) > $(CLEANSUFFIXES:%=libavfilter/opencl/%) \ > + $(CLEANSUFFIXES:%=libavfilter/metal/%) \ >$(CLEANSUFFIXES:%=libavfilter/vulkan/%) > > OPENCL = $(subst $(SRC_PATH)/,,$(wildcard > $(SRC_PATH)/libavfilter/opencl/

Re: [FFmpeg-devel] [PATCH v2] avcodec/ppc/h264dsp: Fix unaligned stores

2024-03-14 Thread Sean McGovern
th subject "unsubscribe". First of all, thank you for looking into this. Second, do we feel that this change covers the FIXME immediately above it that exclaims "there has to be a better way"? If so, we can remove the comment. I did not perform a full FATE run as it is

Re: [FFmpeg-devel] [PATCH] avformat/avidec: Fix integer overflow iff ULONG_MAX < INT64_MAX

2024-03-14 Thread Sean McGovern
/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". Confirming that this fixes fate-v210 (and probably many more) on my PowerPC QEMU setup -- it

Re: [FFmpeg-devel] [PATCH] avcodec/lossless_videoencdsp: Fix unaligned access

2024-03-14 Thread Sean McGovern
__ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". Confirming that this fixes

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Align idct-block appropriately

2024-03-14 Thread Sean McGovern
or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". Confirming that this fixes fate-mpeg4-simple-studio-profile on PowerPC QEMU with GCC UBsan as noted. It was not failing on POWER7 (ppc64) or POWER9 (ppc64le). Thanks, Sean McGovern ___

Re: [FFmpeg-devel] [PATCH] avcodec/ppc/vp8dsp_altivec: Fix out-of-bounds access

2024-03-14 Thread Sean McGovern
__ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". Confirming this patch fixes

Re: [FFmpeg-devel] [PATCH] avcodec/tests/snowenc: Fix mixed declaration and code

2024-03-15 Thread Sean McGovern
> ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > OK, looks good to me. Thanks, Sean

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pngenc: fix mDCv typo

2024-07-02 Thread Sean McGovern
x27;, 'C', 'v'), > s->buf, 24); > } > } > > -- > 2.45.2 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubs

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/pngenc: fix mDCv typo

2024-07-02 Thread Sean McGovern
Hi Andreas, On Tue, Jul 2, 2024, 11:48 Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Sean McGovern: > > Hi Leo, > > > > > > On Tue, Jul 2, 2024, 09:44 Leo Izen wrote: > > > >> When mDCv support was added, there was a typo in bo

Re: [FFmpeg-devel] [PATCH v12 15/15] avcodec/hw_base_encode: add avctx pointer for FFHWBaseEncodeContext

2024-07-02 Thread Sean McGovern
int > >>> vaapi_encode_create_recon_frames(AVCodecContext *avctx) > >>>>} > >>>>hwconfig->config_id = ctx->va_config; > >>>> > >>>> -err = ff_hw_base_get_recon_format(avctx, (const void*)hwconfig

Re: [FFmpeg-devel] [PATCH] avcodec/hw_base_encode: Add missing include

2024-07-02 Thread Sean McGovern
> > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > I did not test but visually this looks OK. As an aside, I wonder if the check headers config should be one of the runs on Patchwork. -- Sean McGovern > ___

[FFmpeg-devel] [RFC] fix UB in fate-checkasm-sw_yuv2rgb

2024-07-03 Thread Sean McGovern
Hi, Attached is an RFC patch to address the undefined behaviour from the new `fate-checkasm-sw_yuv2rgb` test seen on both the x86 and ppc UBSan FATE nodes. -- Sean McGovern From 7b7c5fe69443085250ce8fc35110cfa2d756 Mon Sep 17 00:00:00 2001 From: Sean McGovern Date: Tue, 2 Jul 2024 23:07:54

Re: [FFmpeg-devel] [RFC] fix UB in fate-checkasm-sw_yuv2rgb

2024-07-03 Thread Sean McGovern
Hi Rémi, On Wed, Jul 3, 2024 at 4:34 PM Rémi Denis-Courmont wrote: > > Le keskiviikkona 3. heinäkuuta 2024, 22.07.42 EEST Sean McGovern a écrit : > > Hi, > > > > Attached is an RFC patch to address the undefined behaviour from the > > new `fate-checkasm-sw_yuv2rgb`

[FFmpeg-devel] [PATCH 1/2] configure: permit POWER9 cpu flags

2024-07-03 Thread Sean McGovern
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index b28221f258..bbda7a02cb 100755 --- a/configure +++ b/configure @@ -5493,7 +5493,7 @@ elif enabled ppc; then cpuflags="-mcpu=$cpu" disable vsx ;; -

[FFmpeg-devel] [PATCH 2/2] lavc/flacdsp: implement wasted32 DSP function for VSX on POWER

2024-07-03 Thread Sean McGovern
@@ +/* + * Copyright (c) 2024 Sean McGovern + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the

Re: [FFmpeg-devel] [PATCH 2/2] lavc/flacdsp: implement wasted32 DSP function for VSX on POWER

2024-07-04 Thread Sean McGovern
Hi Rémi, First of all, thanks for the review. On Thu, Jul 4, 2024, 07:15 Rémi Denis-Courmont wrote: > > > Le 4 juillet 2024 04:23:30 GMT+03:00, Sean McGovern > a écrit : > >RaptorCS POWER9 (8c4t) @ 2.2GHz: > >flac_wasted_32_c: 50.1 > >flac_wasted_32_vsx: 17.3 &

Re: [FFmpeg-devel] [PATCH 1/2] configure: permit POWER9 cpu flags

2024-07-06 Thread Sean McGovern
Hi, On Wed, Jul 3, 2024, 21:24 Sean McGovern wrote: > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index b28221f258..bbda7a02cb 100755 > --- a/configure > +++ b/configure > @@ -5493,7 +5493,

Re: [FFmpeg-devel] [PATCH 2/2] lavc/flacdsp: implement wasted32 DSP function for VSX on POWER

2024-07-06 Thread Sean McGovern
Hi, On Thu, Jul 4, 2024, 13:54 Rémi Denis-Courmont wrote: > Le torstaina 4. heinäkuuta 2024, 19.26.19 EEST Sean McGovern a écrit : > > Is that correlated with the comment above re: len? Or is it more general > > that I should unroll until I've exhausted the available vecto

Re: [FFmpeg-devel] [PATCH 2/2] lavc/flacdsp: implement wasted32 DSP function for VSX on POWER

2024-07-07 Thread Sean McGovern
Hi, On Sat, Jul 6, 2024, 16:18 Rémi Denis-Courmont wrote: > Le lauantaina 6. heinäkuuta 2024, 23.00.47 EEST Sean McGovern a écrit : > > Does wasted32 (and I guess wasted33 by proxy) not have to worry about > loops > > tails? I noticed the other vectorized versions don't d

[FFmpeg-devel] [PATCH] lavc/flacdsp: implement wasted32 DSP function for VSX on POWER

2024-07-07 Thread Sean McGovern
@@ +/* + * Copyright (c) 2024 Sean McGovern + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License

[FFmpeg-devel] [PATCHv2] swscale: prevent undefined behaviour in the PUTRGBA macro

2024-07-07 Thread Sean McGovern
--- libswscale/yuv2rgb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c index 977eb3a7dd..ac0b811f61 100644 --- a/libswscale/yuv2rgb.c +++ b/libswscale/yuv2rgb.c @@ -100,9 +100,9 @@ const int *sws_getCoefficients(int colorspace)

[FFmpeg-devel] [PATCHv3] swscale: prevent undefined behaviour in the PUTRGBA macro

2024-07-09 Thread Sean McGovern
For even small values of 'asrc', shifting them by 24 bits or more will cause arithmetic overflow and be caught by GCC's undefined behaviour sanitizer. Ensure the values do not overflow by up-casting the bracketed expressions involving 'asrc' to int32_t. --- libswscale/yuv2rgb.c | 4 ++-- 1 file c

Re: [FFmpeg-devel] Reset password on Patchwork

2024-07-09 Thread Sean McGovern
Hi Andriy, Any luck with this? I'm still locked out. On Wed, Jun 12, 2024 at 6:59 PM Michael Niedermayer wrote: > > Hi > > adding Andriy to CC, to make sure its not missed > > On Tue, Jun 11, 2024 at 07:45:21PM -0400, Sean McGovern wrote: > > Hi, > > > >

[FFmpeg-devel] [PATCHv4] swscale: prevent undefined behaviour in the PUTRGBA macro

2024-07-09 Thread Sean McGovern
For even small values of 'asrc[x]', shifting them by 24 bits or more will cause arithmetic overflow and be caught by GCC's undefined behaviour sanitizer. Ensure the values do not overflow by up-casting the bracketed expressions involving 'asrc' to uint32_t. --- libswscale/yuv2rgb.c | 4 ++-- 1 fi

Re: [FFmpeg-devel] [PATCH 1/2] configure: permit POWER9 cpu flags

2024-07-12 Thread Sean McGovern
Hi, On Wed, Jul 3, 2024, 21:24 Sean McGovern wrote: > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index b28221f258..bbda7a02cb 100755 > --- a/configure > +++ b/configure > @@ -5493,7 +5493,

[FFmpeg-devel] [PATCH] configure: remove TILE-Gx and TILE-Pro due to lack of compiler support

2024-07-15 Thread Sean McGovern
GCC removed support for them in versions >= 13.0, and there was never any acceleration or compat code generated for these targets. --- configure | 5 - 1 file changed, 5 deletions(-) diff --git a/configure b/configure index f84fefeaab..6777fc038f 100755 --- a/configure +++ b/configure @@ -214

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_videotoolbox: Fix build with older SDKs

2024-07-21 Thread Sean McGovern
if (colorspace) { > CVBufferSetAttachment(pixbuf, kCVImageBufferCGColorSpaceKey, > > base-commit: 9fb8d13d56f20728141fd7070d8a325720727d57 > -- > 2.39.3 (Apple Git-146) > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg

Re: [FFmpeg-devel] [PATCH 2/7] avformat/dvdvideodec: Implement seeking

2024-07-28 Thread Sean McGovern
gle number", >OFFSET(opt_angle), AV_OPT_TYPE_INT,{ .i64=1 }, 1, > 9, AV_OPT_FLAG_DECODING_PARAM }, > @@ -1718,11 +1788,12 @@ const FFInputFormat ff_dvdvideo_demuxer = { > .p.name = "dvdvideo",

Re: [FFmpeg-devel] FATE RISC-V planned maintenance

2023-12-22 Thread Sean McGovern
ove, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > Do we get to see the cute outfit when it is done? :) -- Sean McGovern ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinf

Re: [FFmpeg-devel] [PATCH] libavutil/ppc/cpu.c: check that AT_HWCAP2 is defined

2024-01-01 Thread Sean McGovern
Hi, On Thu, Oct 19, 2023, 07:44 Michael Niedermayer wrote: > On Wed, Oct 18, 2023 at 01:18:54PM -0400, Sean McGovern wrote: > > On Sat, Oct 14, 2023, 23:27 Sean McGovern wrote: > > > > > It was not introduced until glibc 2.18. > > > --- > >

Re: [FFmpeg-devel] Meeting at FOSDEM

2024-01-31 Thread Sean McGovern
Hi everybody, Sorry I can't be at FOSDEM to meet you all again. Unfortunately it always falls on a weekend I have to be available at home for work. -- Sean McGovern ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/ma

Re: [FFmpeg-devel] [PATCH 2/2] Require compilers to support C17.

2024-02-08 Thread Sean McGovern
mmend C17 compilers modes > - move to C17 at this mid-year when 7.1 is branched (LTS if we follow our > plans) > I like this approach. It's a shame we can't get metrics on who might be genuinely affected by a direct move to C17. I&

[FFmpeg-devel] [PATCH v2] aacenc_pred: prevent UB in ff_aac_adjust_common_pred()

2024-10-05 Thread Sean McGovern
--- libavcodec/aacenc_pred.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/aacenc_pred.c b/libavcodec/aacenc_pred.c index a486c44d42..a6dfaa25fb 100644 --- a/libavcodec/aacenc_pred.c +++ b/libavcodec/aacenc_pred.c @@ -153,9 +153,7 @@ void ff_aac_adjust_common

Re: [FFmpeg-devel] [PATCH 09/12] swscale/internal: constify SwsFunc

2024-10-07 Thread Sean McGovern
Hi, On Sun, Oct 6, 2024 at 6:31 PM Michael Niedermayer wrote: > > On Sat, Oct 05, 2024 at 09:24:00PM +0200, Niklas Haas wrote: > > From: Niklas Haas > > > > I want to move away from having random leaf processing functions mutate > > plane pointers, and while we're at it, we might as well make th

Re: [FFmpeg-devel] [PATCH 3/3] fate/vcodec: add a test for v410 pixel format raw video

2024-10-17 Thread Sean McGovern
el > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". These tests now fail on ppc64, even with the recent addition of the missing reference files. Please have a look at this FATE instance: http://fate.ffmpeg.org/report.cgi?slot=p

Re: [FFmpeg-devel] [PATCH 09/12] swscale/internal: constify SwsFunc

2024-10-07 Thread Sean McGovern
Hi, On Mon, Oct 7, 2024 at 8:22 PM Niklas Haas wrote: > > On Mon, 07 Oct 2024 16:53:41 -0400 Sean McGovern wrote: > > Hi, > > > > On Sun, Oct 6, 2024 at 6:31 PM Michael Niedermayer > > wrote: > > > > > > On Sat, Oct 05, 2024 at 09:24:00PM +02

  1   2   >