Re: [FFmpeg-devel] [PATCH] avformat/mov: set AVFMT_SEEK_TO_PTS flag

Looks good to me. We were already doing PTS based seeking in MOV demuxer (although it's not perfect). On Thu, May 2, 2019 at 3:23 AM Gyan wrote: > > FATE passes. Checked that transcoded output remains the same whereas in > copy mode, seek to a video KF using ffmpeg cli returns the desired KF > a

[FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

Fixes t/6421 Signed-off-by: Sasi Inguva --- libavformat/mov.c| 57 -- tests/ref/fate/h264-twofields-packet | 60 ++-- 2 files changed, 70 insertions(+), 47 deletions(-) diff --git a/libavformat/mov.c b

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

ot dropped when being decoded and remuxed to the framecrc before, and now it is not being dropped but I dont understand why. On Sat, Jun 3, 2017 at 5:40 AM, wm4 wrote: > On Fri, 2 Jun 2017 18:17:22 -0700 > Sasi Inguva wrote: > > > Fixes t/6421 > > > &g

[FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

/twofields_packet.mp4 is a similar file starting with 2 Bframes. Before this change the PTS of first two B-frames was -6006 and -3003, and I am guessing one of them got dropped when being decoded and remuxed to the framecrc before, and now it is not being dropped. Signed-off-by: Sasi Inguva

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

Got it. Added to the description. On Tue, Jun 6, 2017 at 6:51 AM, wm4 wrote: > On Sat, 3 Jun 2017 19:31:37 -0700 > Sasi Inguva wrote: > > > > -// Offset the DTS by ctts[0] to make the PTS of the first frame 0 > > > -if (ctts_dat

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

Ping! On Jun 6, 2017 11:17 AM, "Sasi Inguva" wrote: > Got it. Added to the description. > > On Tue, Jun 6, 2017 at 6:51 AM, wm4 wrote: > >> On Sat, 3 Jun 2017 19:31:37 -0700 >> Sasi Inguva wrote: >> >> > > -// Offset the DTS by ctts[0]

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Offset index timestamps by the minimum pts to make first pts zero.

That's great. Thanks. On Jun 9, 2017 9:24 AM, "wm4" wrote: > On Tue, 6 Jun 2017 11:16:01 -0700 > Sasi Inguva wrote: > > > Fixes t/6421. If the videos starts with B frame, then the minimum > composition time as computed by stts + ctts will be non-zero. Hence we

Re: [FFmpeg-devel] Why the tag “DURATION” is a necessity in Matroska files?

Hi, I was the one who made that change. We needed a way to obtain individual stream durations from a Matroska file without reading the entire file. I don't think it adds to the file size greatly (< 50 bytes) compared to the size of video and audio data, hence I didn't hide it under an option. How

[FFmpeg-devel] [PATCH] lavf/mov.c: Refine edit list start seek, based on PTS computed from CTTS.

Partially fixes t/6699. --- libavformat/mov.c| 129 +++ tests/fate/mov.mak | 8 +++ tests/ref/fate/mov-ibi-elst-starts-b | 33 + 3 files changed, 127 insertions(+), 43 deletions(-) create mode 100644 tests/ref/fate/m

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Refine edit list start seek, based on PTS computed from CTTS.

Modified the comment for find_prev_index function. Thx. On Thu, Nov 2, 2017 at 4:22 PM, Michael Niedermayer wrote: > On Tue, Oct 31, 2017 at 04:45:00PM -0700, Sasi Inguva wrote: > > Attaching the fate sample. > > uploaded > > [...] > > -- >

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

Updated the fate test after http://git.videolan.org/?p=ffmpeg.git;a=commit;h=c2a8f0fcbe57ea9ccaa864130f078af10516c3c1 . Sending the updated patch. On Thu, Nov 2, 2017 at 4:23 PM, Michael Niedermayer wrote: > On Wed, Nov 01, 2017 at 02:27:50PM -0700, Sasi Inguva wrote: > > Pls find atta

[FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

Partially fixes t/6699. --- libavformat/mov.c | 32 --- tests/fate/mov.mak| 4 tests/ref/fate/mov-elst-ends-betn-b-and-i | 31 ++ 3 files changed, 56 insertions(+), 11 deletions(-) create

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

Sorry, about this. i had uncommitted changes. Attaching the patch. On Thu, Nov 9, 2017 at 12:22 PM, Michael Niedermayer wrote: > On Wed, Nov 08, 2017 at 04:13:46PM -0800, Sasi Inguva wrote: > > Partially fixes t/6699. > > --- > > libavformat/mov.c

[FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

Partially fixes t/6699. --- libavformat/mov.c | 32 +++--- tests/fate/mov.mak| 4 tests/ref/fate/mov-elst-ends-betn-b-and-i | 33 +++ 3 files changed, 58 insertions(+), 11 deletions(-) create

[FFmpeg-devel] [PATCH] lavf/mov.c: Don't correct edit list start to zero, when we can't find a frame before edit list start. After c2a8f0fcbe57ea9ccaa864130f078af10516c3c1 this can happen on normal ed

Signed-off-by: Sasi Inguva --- libavformat/mov.c | 4 +--- tests/fate/mov.mak | 6 ++ 2 files changed, 7 insertions(+), 3 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index fd170baa57..79023ef369 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -3380,13 +3380,11

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Don't correct edit list start to zero, when we can't find a frame before edit list start. After c2a8f0fcbe57ea9ccaa864130f078af10516c3c1 this can happen on norma

Forgot the fate REF file. Sending the full patch again. On Mon, Nov 13, 2017 at 4:15 PM, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavformat/mov.c | 4 +--- > tests/fate/mov.mak | 6 ++ > 2 files changed, 7 insertions(+), 3 deletions(-) > > diff --gi

[FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

Signed-off-by: Sasi Inguva --- libavformat/mov.c| 48 tests/fate/mov.mak | 5 + tests/ref/fate/mov-guess-delay-1 | 3 +++ tests/ref/fate/mov-guess-delay-2 | 3 +++ 4 files changed, 59 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH] lavf/mov.c: Don't correct edit list start to zero, when we can't find a frame before edit list start. After c2a8f0fcbe57ea9ccaa864130f078af10516c3c1 this can happen on normal ed

Signed-off-by: Sasi Inguva --- libavformat/mov.c| 4 +- tests/fate/mov.mak | 6 + tests/ref/fate/mov-bbi-elst-starts-b | 391 +++ 3 files changed, 398 insertions(+), 3 deletions(-) create mode 100644 tests/ref/fate/mov

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

derek.buitenh...@gmail.com> wrote: > On 11/14/2017 2:15 AM, Sasi Inguva wrote: > > Signed-off-by: Sasi Inguva > > --- > > libavformat/mov.c| 48 ++ > ++ > > tests/fate/mov.mak | 5 + > > test

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

.buitenh...@gmail.com> wrote: > On 11/14/2017 8:28 PM, Sasi Inguva wrote: > > For H264 files with no bitstream restriction flag, we aren't able to > guess > > the delay correctly. Especially if it's MOV container, because for MOV > > container we just probe the 1st

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

017 at 3:23 PM, Derek Buitenhuis < > > derek.buitenh...@gmail.com> wrote: > > > > > On 11/14/2017 10:11 PM, Sasi Inguva wrote: > > > > I don't know if the patch can be made more generic to work for all > > > > demuxers, because this patch requires

[FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

Signed-off-by: Sasi Inguva --- libavformat/mov.c| 52 tests/fate/mov.mak | 5 tests/ref/fate/mov-guess-delay-1 | 3 +++ tests/ref/fate/mov-guess-delay-2 | 3 +++ 4 files changed, 63 insertions(+) create mode 100644

Re: [FFmpeg-devel] [mov] Fix leak of frame_duration_buffer in mov_fix_index().

LGTM. Thanks for the fix. On Sat, Nov 18, 2017 at 4:24 AM, Dale Curtis wrote: > Should be unconditionally freed at the end of mov_fix_index() in case it > hasn't been used during the fix up. > > Signed-off-by: Dale Curtis > ___ ffmpeg-devel mailing li

[FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

Done. is there a better way to identify codecs that might need Signed-off-by: Sasi Inguva --- libavformat/mov.c| 52 tests/fate/mov.mak | 5 tests/ref/fate/mov-guess-delay-1 | 3 +++ tests/ref/fate/mov-guess-delay-2

[FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

Signed-off-by: Sasi Inguva --- libavformat/mov.c| 54 tests/fate/mov.mak | 5 tests/ref/fate/mov-guess-delay-1 | 3 +++ tests/ref/fate/mov-guess-delay-2 | 3 +++ 4 files changed, 65 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

On Sun, Nov 19, 2017 at 1:17 AM, Michael Niedermayer wrote: > On Sat, Nov 18, 2017 at 11:12:17AM -0800, Sasi Inguva wrote: > > Signed-off-by: Sasi Inguva > > --- > > libavformat/mov.c| 54 ++ > ++ > > tests/f

[FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

Signed-off-by: Sasi Inguva --- libavformat/mov.c| 55 tests/fate/mov.mak | 7 + tests/ref/fate/mov-guess-delay-1 | 3 +++ tests/ref/fate/mov-guess-delay-2 | 3 +++ tests/ref/fate/mov-guess-delay-3 | 3 +++ 5 files

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

Attaching the fate sample On Mon, Nov 20, 2017 at 8:28 AM, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavformat/mov.c| 55 ++ > ++ > tests/fate/mov.mak | 7 + > tests/ref/fate/mov-

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

Ok. Just restricting this to H264 . On Tue, Nov 21, 2017 at 3:56 AM, Hendrik Leppkes wrote: > On Mon, Nov 20, 2017 at 11:06 PM, Michael Niedermayer > wrote: > > On Mon, Nov 20, 2017 at 09:58:05PM +0530, Sasi Inguva wrote: > >> On Sun, Nov 19, 2017 at 1:17 AM, Michael Nied

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

Reattaching Fate sample. On Tue, Nov 21, 2017 at 9:57 AM, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavformat/mov.c| 50 ++ > ++ > tests/fate/mov.mak | 7 ++ > tests/ref/fate/mov-

[FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

Signed-off-by: Sasi Inguva --- libavformat/mov.c| 50 tests/fate/mov.mak | 7 ++ tests/ref/fate/mov-guess-delay-1 | 3 +++ tests/ref/fate/mov-guess-delay-2 | 3 +++ tests/ref/fate/mov-guess-delay-3 | 3 +++ 5 files

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

mputed will be 2 (because 2 frames between 0 and 1 ) but we need a buffer size of 3 . On Wed, Nov 22, 2017 at 8:29 AM, Michael Niedermayer wrote: > On Mon, Nov 20, 2017 at 08:27:05PM -0800, Sasi Inguva wrote: > > Signed-off-by: Sasi Inguva > > --- > >

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

Pmin. > However > > that will still fail for this example, > > 0, 3, 5, 1, 4, 2 . The delay computed will be 2 (because 2 frames > between > > 0 and 1 ) but we need a buffer size of 3 . > > > > On Wed, Nov 22, 2017 at 8:29 AM, Michael Niedermayer > > > wro

[FFmpeg-devel] [PATCH] lavf/mov.c: Guess video codec delay based on PTS while parsing MOV header.

Signed-off-by: Sasi Inguva --- libavformat/mov.c| 56 tests/fate/mov.mak | 7 + tests/ref/fate/mov-guess-delay-1 | 3 +++ tests/ref/fate/mov-guess-delay-2 | 3 +++ tests/ref/fate/mov-guess-delay-3 | 3 +++ 5 files

Re: [FFmpeg-devel] [PATCH] tests/fate/mov: Disable fate-mov-invalid-elst-entry-count, the test does not work reliable currently

i was on vacation so I missed this. sorry for the trouble and thanks for fixing the test. This test was fixed once before http://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=4ccc1ef2a3b1a22d849861423df830e110c9a4ab . I've no idea why only this test needs to have the "-flags +bitexact -idct simple

[FFmpeg-devel] [PATCH] lavfi/avfilter.c: Correct guess_status_pts to account for differing link timebases.

Signed-off-by: Sasi Inguva --- libavfilter/avfilter.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 58917ed445..ec7dfc0bd3 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -427,19

Re: [FFmpeg-devel] [PATCH 5/5] ffmpeg: send EOF pts to filters.

I've encountered the same problem, and tracked it to guess_status_pts function which tries to take the end timestamp from the input links however without converting it to correct time base. Sent a patch, PTAL. On Tue, Oct 3, 2017 at 5:36 PM, Thomas Mundt wrote: > Hi Nicolas, > > 2017-09-07 10:59

[FFmpeg-devel] [PATCH] lavfi/avfilter.c: Correct guess_status_pts to account for differing link timebases.

Signed-off-by: Sasi Inguva --- libavfilter/avfilter.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 58917ed445..f0f849b326 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -427,19 +427,19

[FFmpeg-devel] [PATCH] ffmpeg.c: Fallback to duration_dts, when duration_pts can't be determined.

This is required for FLV files, for which duration_pts comes out to be zero. Signed-off-by: Sasi Inguva --- fftools/ffmpeg.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 6d64bc1043..5f373db847 100644 --- a/fftools/ffmpeg.c +++ b/fftools

[FFmpeg-devel] [PATCH] ffmpeg.c: Fallback to duration_dts, when duration_pts can't be determined.

This is required for FLV files, for which duration_pts comes out to be zero. Signed-off-by: Sasi Inguva --- fftools/ffmpeg.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg.c b/fftools/ffmpeg.c index 6d64bc1043..3ee31473dc 100644 --- a/fftools

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: Fallback to duration_dts, when duration_pts can't be determined.

True. Thanks! Sending the corrected patch. On Tue, Oct 10, 2017 at 5:40 AM, Thomas Mundt wrote: > 2017-10-10 3:27 GMT+02:00 Sasi Inguva : > >> This is required for FLV files, for which duration_pts comes out to be >> zero. >> >> Signed-off-by: Sasi Inguva &

Re: [FFmpeg-devel] [PATCH] ffmpeg.c: Fallback to duration_dts, when duration_pts can't be determined.

dt wrote: > > > 2017-10-10 19:36 GMT+02:00 Sasi Inguva >: > > > > > > > This is required for FLV files, for which duration_pts comes out to > be > > > > zero. > > > > > > > > Signed-off-by: Sasi Inguva > >

Re: [FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

Thanks for the patch. The bug is because mov_fix_index updates skip_samples correctly, but not start_pad. Can you instead of taking the max, just update the mov_fix_index function so that start_pad = skip_samples always. Something like this diff --git a/libavformat/mov.c b/libavformat/mov.c index 8

Re: [FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

Patch LGTM. Thanks. On Wed, Oct 18, 2017 at 4:14 PM, Dale Curtis wrote: > On Wed, Oct 18, 2017 at 4:00 PM, Sasi Inguva wrote: > >> Thanks for the patch. The bug is because mov_fix_index updates >> skip_samples correctly, but not start_pad. Can you instead of taking the >&

[FFmpeg-devel] [PATCH] lavf/mov.c: Fix parsing of edit list atoms with invalid elst entry count.

Signed-off-by: Sasi Inguva --- libavformat/mov.c | 16 +++- tests/fate/mov.mak | 6 ++- tests/ref/fate/mov-invalid-elst-entry-count | 57 + 3 files changed, 76 insertions(+), 3 deletions(-) create mode 100644

[FFmpeg-devel] [PATCH] lavf/mov.c: Fix parsing of edit list atoms with invalid elst entry count.

Signed-off-by: Sasi Inguva --- libavformat/mov.c | 15 +++- tests/fate/mov.mak | 4 ++ tests/ref/fate/mov-invalid-elst-entry-count | 57 + 3 files changed, 75 insertions(+), 1 deletion(-) create mode 100644

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fix parsing of edit list atoms with invalid elst entry count.

On Fri, Oct 20, 2017 at 4:26 PM, Michael Niedermayer wrote: > On Wed, Oct 18, 2017 at 08:12:50PM -0700, Sasi Inguva wrote: > > Signed-off-by: Sasi Inguva > > --- > > libavformat/mov.c | 16 +++- > > tests/fate/mov.mak

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fix parsing of edit list atoms with invalid elst entry count.

On Tue, Oct 24, 2017 at 2:48 PM, Michael Niedermayer wrote: > On Mon, Oct 23, 2017 at 04:18:28PM -0700, Sasi Inguva wrote: > > Signed-off-by: Sasi Inguva > > --- > > libavformat/mov.c | 15 +++- > > tests/fate/mov.mak

Re: [FFmpeg-devel] [PATCH]fate: Add bitexact and idct simple to the mov-invalid-edst test

looks good to me. Thanks for the fix. On Sun, Oct 29, 2017 at 2:11 PM, Carl Eugen Hoyos wrote: > 2017-10-29 22:03 GMT+01:00 Carl Eugen Hoyos : > > Hi! > > > > Attached patch fixes a fate test here on a ppc system. > > The following is sufficient: -flags +bitexact > The idct option is not necessa

[FFmpeg-devel] [PATCH] lavf/mov.c: Refine edit list start seek, based on PTS computed from CTTS.

Partially fixes t/6699. --- libavformat/mov.c | 125 +++-- tests/fate/mov.mak | 8 2 files changed, 90 insertions(+), 43 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 60f0228e2d..a295445651 100644 --- a/libavformat/mo

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Refine edit list start seek, based on PTS computed from CTTS.

Attaching the fate sample. On Tue, Oct 31, 2017 at 4:42 PM, Sasi Inguva wrote: > Partially fixes t/6699. > --- > libavformat/mov.c | 125 ++ > +-- > tests/fate/mov.mak | 8 > 2 files changed, 90 insertions(+), 43 del

[FFmpeg-devel] (no subject)

Added the fate ref file to the commit. Thx. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] lavf/mov.c: Refine edit list start seek, based on PTS computed from CTTS.

Partially fixes t/6699. --- libavformat/mov.c| 125 +++ tests/fate/mov.mak | 8 +++ tests/ref/fate/mov-ibi-elst-starts-b | 33 + 3 files changed, 123 insertions(+), 43 deletions(-) create mode 100644 tests/ref/fate/m

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Refine edit list start seek, based on PTS computed from CTTS.

Thanks. Sent the corrected patch. On Tue, Oct 31, 2017 at 7:14 PM, Michael Niedermayer wrote: > On Tue, Oct 31, 2017 at 04:42:56PM -0700, Sasi Inguva wrote: > > Partially fixes t/6699. > > --- > > libavformat/mov.c | 125 ++ > +--

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

Forgot to attach the FATE ref file. sending the patch again. On Wed, Nov 1, 2017 at 2:23 PM, Sasi Inguva wrote: > Partially fixes t/6699. > --- > libavformat/mov.c | 32 +--- > tests/fate/mov.mak | 4 > 2 files changed, 25 insertions(+

[FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

Partially fixes t/6699. --- libavformat/mov.c | 32 --- tests/fate/mov.mak| 4 tests/ref/fate/mov-elst-ends-betn-b-and-i | 31 ++ 3 files changed, 56 insertions(+), 11 deletions(-) create

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

Pls find attached, the FATE sample. On Wed, Nov 1, 2017 at 2:26 PM, Sasi Inguva wrote: > Partially fixes t/6699. > --- > libavformat/mov.c | 32 > --- > tests/fate/mov.mak| 4 > tests/ref/fate/

[FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

Partially fixes t/6699. --- libavformat/mov.c | 32 +--- tests/fate/mov.mak | 4 2 files changed, 25 insertions(+), 11 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 60f0228e2d..e716e5ba9e 100644 --- a/libavformat/mov.c +++ b/libavformat/m

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Parse upto 2 keyframes after the edit list end in mov_fix_index.

This patch is not an alternative. Both patches are required to fix t/6699 . Once one of the patches is submitted, i will update the fate tests in the other patch. On Wed, Nov 1, 2017 at 5:11 PM, Michael Niedermayer wrote: > On Wed, Nov 01, 2017 at 02:26:45PM -0700, Sasi Inguva wr

Re: [FFmpeg-devel] [PATCH] lavf/mov: Add support for edit list parsing.

wrote: > On Fri, 5 Aug 2016 17:18:39 -0700 > Sasi Inguva wrote: > > > In YouTube we have long been receiving MOV files from users, which have > non-trivial edit lists (Those edit lists which are not just used to offset > video start from audio start) and multiple edit lists.

Re: [FFmpeg-devel] [PATCH] lavf/mov: Add support for edit list parsing.

I am also happy to fix any breaking files, if they don't fall under the above category. On Tue, Oct 18, 2016 at 1:08 PM, Sasi Inguva wrote: > With the current state of code, we will only encounterdemuxer > outputting non-monotonic DTS when there are multiple edit lists . Avo

Re: [FFmpeg-devel] [PATCH] lavf/mov: Add support for edit list parsing.

On Fri, Oct 21, 2016 at 8:32 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > > In YouTube we have long been receiving MOV files from users, which have > non-trivial edit lists (Those edit lists which are not just used to offset > video start from audio start) and multiple edit lists. R

[FFmpeg-devel] [PATCH] lavf/mov.c: Use the correct timescale when seeking for audio.

Signed-off-by: Sasi Inguva --- libavformat/mov.c | 2 +- tests/fate/mov.mak | 6 +- tests/ref/fate/mov-aac-2048-priming | 217 3 files changed, 223 insertions(+), 2 deletions(-) create mode 100644 tests/ref/fate/mov-aac

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Use the correct timescale when seeking for audio.

Attaching the fate sample. 2016-10-23 22:37 GMT-07:00 Sasi Inguva : > Signed-off-by: Sasi Inguva > --- > libavformat/mov.c | 2 +- > tests/fate/mov.mak | 6 +- > tests/ref/fate/mov-aac-2048-priming | 217 ++ >

Re: [FFmpeg-devel] [PATCH] lavf/mov: Add support for edit list parsing.

Just sent a patch, correcting a bug in the edit list code. PTAL. On Fri, Oct 21, 2016 at 11:08 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 10/21/2016 6:47 PM, Sasi Inguva wrote: > > * Audio packets. Especially audio packets with a large numb

[FFmpeg-devel] [PATCH] lavf/mov.c: Use the first sidx for tracks without sidx.

r any non‐indexed media stream." Signed-off-by: Sasi Inguva --- libavformat/isom.h | 1 + libavformat/mov.c | 26 +++--- 2 files changed, 24 insertions(+), 3 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index 9038057..d684502 100644 --- a/libavfor

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Use the first sidx for tracks without sidx.

sorry. forgot to remove the debug printf. sending the corrected patch. On Wed, Oct 26, 2016 at 7:47 AM, Michael Niedermayer wrote: > On Tue, Oct 25, 2016 at 11:07:58PM -0700, Sasi Inguva wrote: > > According to spec ISO_IEC_15444_12 "For any media stream for which no > segment

[FFmpeg-devel] [PATCH] lavf/mov.c: Use the first sidx for tracks without sidx.

r any non‐indexed media stream." Signed-off-by: Sasi Inguva --- libavformat/isom.h | 1 + libavformat/mov.c | 25 ++--- 2 files changed, 23 insertions(+), 3 deletions(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index 9038057..d684502 100644 --- a/libavfor

[FFmpeg-devel] [PATCH] lavf/mov.c: Set duration to zero if the duration is UINT_MAX

Fixes some MP4F files which have duration in mdhd set to UINT_MAX instead of zero. Signed-off-by: Sasi Inguva --- libavformat/mov.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 357d800..245e424 100644 --- a/libavformat/mov.c +++ b

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Use the correct timescale when seeking for audio.

gentle ping. Thanks! On Mon, Oct 24, 2016 at 4:20 PM, Michael Niedermayer wrote: > On Sun, Oct 23, 2016 at 10:41:52PM -0700, Sasi Inguva wrote: > > Attaching the fate sample. > > uploaded > > thx > > [...] > > -- > Michael GnuPG fingerprint: 9FF2128B147

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Use the first sidx for tracks without sidx.

ping. Thanks! On Wed, Oct 26, 2016 at 11:31 AM, Sasi Inguva wrote: > According to spec ISO_IEC_15444_12 "For any media stream for which no > segment index is present, referred to as non‐indexed stream, the media > stream associated with the first Segment Index box in the segment

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Set duration to zero if the duration is UINT_MAX

ping. Thanks! On Wed, Oct 26, 2016 at 12:42 PM, Sasi Inguva wrote: > Attaching the file that it fixes. > > > On Wed, Oct 26, 2016 at 12:40 PM, Sasi Inguva wrote: > >> Fixes some MP4F files which have duration in mdhd set to UINT_MAX instead >> of zero. >&

Re: [FFmpeg-devel] [PATCH] mov: only read e_old if there were any old streams

First of all, if nb_old == 0 i.e. there are no entries in AVIndex, then there is no point in calling mov_fix_index function at all. So instead of doing the above , you can directly check for st->nb_index_entries > 0 at the top of mov_fix_index and return otherwise. Also, I don't understand how nb_

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Set duration to zero if the duration is UINT_MAX

0, so this is ok. But some MP4F files have it set to UINT_MAX , like the example I have uploaded. On Mon, Oct 31, 2016 at 5:16 PM, Yusuke Nakamura < muken.the.vfrman...@gmail.com> wrote: > 2016-10-27 4:40 GMT+09:00 Sasi Inguva : > > > Fixes some MP4F files which have duration

Re: [FFmpeg-devel] [PATCH] mov: only read e_old if there were any old streams

patch looks good to me. Thanks for the fix. On Mon, Oct 31, 2016 at 5:17 PM, Andreas Cadhalpun < andreas.cadhal...@googlemail.com> wrote: > On 31.10.2016 19:20, Sasi Inguva wrote: > > First of all, if nb_old == 0 i.e. there are no entries in AVIndex, then > > there i

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Use the correct timescale when seeking for audio.

Yes. This is expected. The audio has an edit list with duration 7294805 which at a timescale of 600 means 1324.675 . Entry[0].SegmentDuration 794805 Entry[0].MediaTime 2048 ~/ffmpeg_new/ffprobe -show_frames -print_format compact -select_streams 1 ~/Downloads/edit_list_sample.mp4 When we add up

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Use the first sidx for tracks without sidx.

Ping. Sorry for the urgency on this, but this is blocking us internally. Thanks On Mon, Oct 31, 2016 at 10:23 AM, Sasi Inguva wrote: > ping. > > Thanks! > > On Wed, Oct 26, 2016 at 11:31 AM, Sasi Inguva wrote: > >> According to spec ISO_IEC_15444_12 "For

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Use the first sidx for tracks without sidx.

On Wed, Nov 2, 2016 at 3:50 PM, Derek Buitenhuis wrote: > On 10/26/2016 7:31 PM, Sasi Inguva wrote: > > According to spec ISO_IEC_15444_12 "For any media stream for which no > segment index is present, referred to as non‐indexed stream, the media > stream associated with the

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Set duration to zero if the duration is UINT_MAX

ping. Thanks! On Mon, Oct 31, 2016 at 10:25 PM, Sasi Inguva wrote: > For MP4F files , stream duration is updated by the sum of duration of > moof's http://git.videolan.org/?p=ffmpeg.git;a=blob;f=libavformat/mov.c;h= > 414007e7aa128aa66e07395b42c0cd4b369b3146;hb=HEAD#l4193

[FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

Signed-off-by: Sasi Inguva --- libavformat/mov.c | 30 -- tests/fate/mov.mak | 6 +- 2 files changed, 25 insertions(+), 11 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 4222088..f5b2035 100644 --- a/libavformat/mov.c +++ b/libavformat

[FFmpeg-devel] [PATCH] lavc/utils.c: Make sure skip_samples never goes negative.

Signed-off-by: Sasi Inguva --- libavcodec/utils.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 87de15f..a33afaa 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -2391,7 +2391,9 @@ int attribute_align_arg

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

Sorry, forgot to add the fate test reference file. Sending it again. On Thu, Nov 3, 2016 at 12:41 PM, Sasi Inguva wrote: > Attaching the fate sample. > > On Thu, Nov 3, 2016 at 12:39 PM, Sasi Inguva wrote: > >> Signed-off-by: Sasi Inguva >> --- >

[FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

Signed-off-by: Sasi Inguva --- libavformat/mov.c | 30 ++--- tests/fate/mov.mak | 6 +- tests/ref/fate/mp4-init-nonkeyframe | 120 3 files changed, 145 insertions(+), 11 deletions(-) create mode 100644 tests/ref/fate

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

2PM -0700, Sasi Inguva wrote: > > Signed-off-by: Sasi Inguva > > --- > > libavformat/mov.c | 30 ++--- > > tests/fate/mov.mak | 6 +- > > > tests/ref/fate/mp4-init-nonkeyframe | 120 >

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

itenhuis < derek.buitenh...@gmail.com> wrote: > On 11/3/2016 10:36 PM, Sasi Inguva wrote: > > +if (index == -1) { > > +av_log(mov->fc, AV_LOG_ERROR, > > + "st: %d edit list %"PRId64" Canno

Re: [FFmpeg-devel] [PATCH] lavc/utils.c: Make sure skip_samples never goes negative.

yeah. that is better. On Thu, Nov 3, 2016 at 3:41 PM, Hendrik Leppkes wrote: > On Thu, Nov 3, 2016 at 11:31 PM, Sasi Inguva > wrote: > > Signed-off-by: Sasi Inguva > > --- > > libavcodec/utils.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) &

[FFmpeg-devel] [PATCH] lavc/utils.c: Make sure skip_samples never goes negative.

Signed-off-by: Sasi Inguva --- libavcodec/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 87de15f..d6dca18 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -2391,7 +2391,7 @@ int attribute_align_arg

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

, 2016 at 10:25 PM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 11/4/2016 9:53 PM, Sasi Inguva wrote: > > So, if I am not wrong, the only case when that would happen is, if edit > > list media time was < 0 . And that would be a corrupt MOV file, unless > edit

[FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

Signed-off-by: Sasi Inguva --- libavformat/mov.c | 41 tests/fate/mov.mak | 6 +- tests/ref/fate/mp4-init-nonkeyframe | 120 3 files changed, 155 insertions(+), 12 deletions(-) create mode 100644 tests/ref

Re: [FFmpeg-devel] [PATCH] lavf/mov.c: Fallback to finding non-keyframe in fix_index, if keyframe search fails.

I've modified the patch to fallback to rounding edit list media time to zero when it is negative, and added a strict_std_compliance check for edit lists. PTAL. Thanks. On Sun, Nov 6, 2016 at 7:07 PM, Derek Buitenhuis wrote: > On 11/6/2016 12:40 PM, Michael Niedermayer wrote: > > IMO we should su

Re: [FFmpeg-devel] [PATCH] lavc/utils.c: Make sure skip_samples never goes negative.

ping. On Sat, Nov 5, 2016 at 4:01 AM, Sasi Inguva wrote: > Signed-off-by: Sasi Inguva > --- > libavcodec/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index 87de15f..d6dca18 100644 > --- a/li

Re: [FFmpeg-devel] [PATCH] lavf/mov: Add support for edit list parsing.

6 at 11:08 PM, wm4 wrote: > On Fri, 5 Aug 2016 17:18:39 -0700 > Sasi Inguva wrote: > > > In YouTube we have long been receiving MOV files from users, which have > non-trivial edit lists (Those edit > > Found a file that does not show video at all with edit lists enabled

[FFmpeg-devel] [PATCH] lavf/mov.c: Set skip_samples according to first edit list, when -ignore_editlist is set.

Signed-off-by: Sasi Inguva --- libavformat/isom.h | 2 ++ libavformat/mov.c | 22 +- 2 files changed, 23 insertions(+), 1 deletion(-) diff --git a/libavformat/isom.h b/libavformat/isom.h index d684502..6a8a4e3 100644 --- a/libavformat/isom.h +++ b/libavformat/isom.h

[FFmpeg-devel] [PATCH] libx264: Increase x264 opts character limit to 4096

Signed-off-by: Sasi Inguva --- libavcodec/libx264.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index c8f2380..b730c91 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -777,8 +777,8

[FFmpeg-devel] [PATCH] lavf/mov: Add support for edit list parsing.

In YouTube we have long been receiving MOV files from users, which have non-trivial edit lists (Those edit lists which are not just used to offset video start from audio start) and multiple edit lists. Recently the uploads of such files has increased with the introduction of apps that allow vide

[FFmpeg-devel] [PATCH] lavf/mov: Add support for edit list parsing.

Signed-off-by: Sasi Inguva --- libavcodec/avcodec.h | 6 + libavcodec/utils.c | 6 + libavformat/avformat.h | 3 + libavformat/mov.c | 305 - libavutil/frame.h

[FFmpeg-devel] [PATCH 3/4] lavc: Add a flag in AVPacket to discard packet after decoding. Discard frames after decoding based on the flag.

Signed-off-by: Sasi Inguva --- libavcodec/avcodec.h | 6 ++ libavcodec/utils.c | 14 +- libavcodec/version.h | 2 +- 3 files changed, 20 insertions(+), 2 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 3b21537..d68da01 100644 --- a/libavcodec

[FFmpeg-devel] (no subject)

Sorry that I hadn't started a discussion on the patch before sending it for review. However this patch has been there for years in our ffmpeg version. I simply made some cosmetic changes to prepare it to send for review, hence I haven't wasted much work/time on it. That said, I think that the co

[FFmpeg-devel] [PATCH 4/4] lavf/mov: Add support for edit list parsing.

Signed-off-by: Sasi Inguva --- libavformat/mov.c| 323 - tests/Makefile |1 + tests/fate/mov.mak | 28 + tests/ref/fate/filter-fps-cfr|1 - tests/ref/fate/gaplessenc-itunes-to

[FFmpeg-devel] [PATCH 2/4] avformat/avframe.h: Add a flag in AVIndexEntry to discard frame after decoding.

Signed-off-by: Sasi Inguva --- libavformat/avformat.h | 3 +++ libavformat/version.h | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index d8a6cf3..8cf1401 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h

  1   2   3   >