Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-18 Thread Sanchit Sinha
ambisonic_class, > > .inputs = inputs, > > .outputs = outputs, > > }; > > Align such that all equal signs are in the same column, look at how other > filters do it. > > > > On 13 March 2017 at 03:12, Sanchit Sinha wrote: > > > On Mon, Mar 13, 2017 at 2:

[FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-10 Thread Sanchit Sinha
libavfilter/af_ambisonic.c | 139 + 1 file changed, 139 insertions(+) create mode 100644 libavfilter/af_ambisonic.c diff --git a/libavfilter/af_ambisonic.c b/libavfilter/af_ambisonic.c new file mode 100644 index 000..98b0e44 --- /dev/null +++ b/liba

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-10 Thread Sanchit Sinha
Okay made some changes, From c0c1a1e7d4ad1fcbd96827725a47af20145c7621 Mon Sep 17 00:00:00 2001 From: Sanchit Sinha Date: Sat, 11 Mar 2017 01:27:38 +0530 Subject: [PATCH] Changes to af_ambisonic.c, makefile and allfilters.c --- libavfilter/af_ambisonic.c | 136

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-10 Thread Sanchit Sinha
, Mar 11, 2017 at 1:50 AM, Paul B Mahol wrote: > On 3/10/17, Sanchit Sinha wrote: > > Okay made some changes, > > > > Do all changes, not just some. > Also this must be full patch. > > You are missing Makefile, Changelog and so on... > _

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-10 Thread Sanchit Sinha
Hi, I specific changes we talked about. Also updated apart from af_ambisonic.c : allfilters.c, Makefile and Changelog. From b74755ae0ea6741f01d2c1b2c79056984674c331 Mon Sep 17 00:00:00 2001 From: Sanchit Sinha Date: Sat, 11 Mar 2017 03:31:51 +0530 Subject: [PATCH] Changes to af_ambisonic

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-11 Thread Sanchit Sinha
Apologies I will update it asap On Mar 11, 2017 3:07 PM, "Paul B Mahol" wrote: > On 3/10/17, Sanchit Sinha wrote: > > Hi, > > I specific changes we talked about. Also updated apart from > af_ambisonic.c > > : allfilters.c, Ma

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-11 Thread Sanchit Sinha
Thanks Andy for the valuable info! It would be good to talk and learn from these guys, especially for an amateur like me. :) On Sat, Mar 11, 2017 at 4:23 PM, Andy Furniss wrote: > Paul B Mahol wrote: > >> On 3/11/17, Andy Furniss wrote: >> >>> Sanchit Sinha

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-11 Thread Sanchit Sinha
Patch details: File added avfilter/af_ambisonic.c Entries made in avfilter/Makefile and avfilter/allfilters.c Entry made in Changelog On Sat, Mar 11, 2017 at 4:29 PM, Sanchit Sinha wrote: > > Thanks Andy for the valuable info! It would be good to talk and learn from > these guys, e

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-11 Thread Sanchit Sinha
On Sat, Mar 11, 2017 at 5:57 PM, Paul B Mahol wrote: > On 3/11/17, Sanchit Sinha wrote: > > Patch details: > > File added avfilter/af_ambisonic.c > > Entries made in avfilter/Makefile and avfilter/allfilters.c > > Entry made in Changelog > >

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-11 Thread Sanchit Sinha
On Sat, Mar 11, 2017 at 9:18 PM, Paul B Mahol wrote: > On 3/11/17, Sanchit Sinha wrote: > > On Sat, Mar 11, 2017 at 5:57 PM, Paul B Mahol wrote: > > > > Please do not post diff of patch but full patch, diff from master branch. > __

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-11 Thread Sanchit Sinha
On Sat, Mar 11, 2017 at 9:46 PM, Sanchit Sinha wrote: > > > > > > On Sat, Mar 11, 2017 at 9:18 PM, Paul B Mahol wrote: > >> On 3/11/17, Sanchit Sinha wrote: >> > On Sat, Mar 11, 2017 at 5:57 PM, Paul B Mahol wrote: >> > >> >> Please d

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-11 Thread Sanchit Sinha
On Sat, Mar 11, 2017 at 10:38 PM, Paul B Mahol wrote: > On 3/11/17, Sanchit Sinha wrote: > > On Sat, Mar 11, 2017 at 9:46 PM, Sanchit Sinha > > > wrote: > > > > tabs are forbidden use 4 spaces for identation, remove commented out code. > ___

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-12 Thread Sanchit Sinha
Any changes required in this one? On Mar 11, 2017 10:53 PM, "Sanchit Sinha" wrote: > > > > > > On Sat, Mar 11, 2017 at 10:38 PM, Paul B Mahol wrote: > >> On 3/11/17, Sanchit Sinha wrote: >> > On Sat, Mar 11, 2017 at 9:46 PM, Sanchit S

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-12 Thread Sanchit Sinha
On Mon, Mar 13, 2017 at 2:36 AM, Paul B Mahol wrote: > On 3/12/17, Sanchit Sinha wrote: > > Any changes required in this one? > > Please do not top post. > > Expect vertical alignment, no changes are needed. > ___ > ffmpeg-

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-03-13 Thread Sanchit Sinha
Sir, I cannot find any tabs in the code. Can you point out where exactly? Thank You On Mon, Mar 13, 2017 at 2:20 PM, Paul B Mahol wrote: > On 3/13/17, Sanchit Sinha wrote: > > On Mon, Mar 13, 2017 at 2:36 AM, Paul B Mahol wrote: > > > >> On 3/12/17, Sanchit Sinha w

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-08-14 Thread Sanchit Sinha
On Mon, Mar 20, 2017 at 2:16 PM, Carl Eugen Hoyos wrote: > 2017-03-13 10:15 GMT+01:00 Sanchit Sinha : > > Sir, I cannot find any tabs in the code. > > For the future: > There is a script in tools/patcheck that helps you with some basic > i

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-08-15 Thread Sanchit Sinha
ling list > ffmpeg-devel@ffmpeg.org > http://ffmpeg.org/mailman/listinfo/ffmpeg-devel > -- Sanchit Sinha B.Tech- CSE IIIT-Delhi Roll-2015083 https://sinhaaftersanchit.com/ From c802c29bd9d6b141cf0d273d480f00fef97d617f Mon Sep 17 00:00:00 2001 From: Sanchit Sinha Date: Tue, 15 Aug 20

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-08-16 Thread Sanchit Sinha
On Thu, Aug 17, 2017 at 1:32 AM, Michael Niedermayer wrote: > On Tue, Aug 15, 2017 at 11:57:18PM +0530, Sanchit Sinha wrote: > > On Tue, Aug 15, 2017 at 4:46 PM, Paul B Mahol wrote: > > > > > Hi, > > > > > > subject of patch file is wrong. > >

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-08-17 Thread Sanchit Sinha
On Thu, Aug 17, 2017 at 7:31 AM, Michael Niedermayer wrote: > On Thu, Aug 17, 2017 at 04:35:13AM +0530, Sanchit Sinha wrote: > > On Thu, Aug 17, 2017 at 1:32 AM, Michael Niedermayer > > > wrote: > > > > > On Tue, Aug 15, 2017 at 11:57:18PM +0530, Sanchit Si

Re: [FFmpeg-devel] [PATCH] libavfilter/af_ambisonic.c Added File for Ambisonic Filter

2017-08-19 Thread Sanchit Sinha
;https://mailtrack.io/reauth?url=https%3A%2F%2Fmailtrack.io%2Freminder%2Fdisable%3Fid%3De39725b884cf2b0ba3c4c2b7098ac344d73c1937&login_hint=sanchit15083%40iiitd.ac.in>) > > -- Sanchit Sinha B.Tech- CSE IIIT-Delhi Roll-2015083 https://sinhaaftersanchit.com/ From 93d709a6c04af3749cd12e