[FFmpeg-devel] [PATCH 1/6] lavf: rename tls_securetransport to tls_apple

2019-06-11 Thread Rodger Combs
--- libavformat/Makefile | 2 +- libavformat/{tls_securetransport.c => tls_apple.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename libavformat/{tls_securetransport.c => tls_apple.c} (100%) diff --git a/libavformat/Makefile b/libavformat/Makefile index df

[FFmpeg-devel] [PATCH 4/6] lavf/tls_apple: link to SecIdentityCreate weakly

2019-06-11 Thread Rodger Combs
This is a private API, so it might go away in a future macOS version. Linking to it weakly means that if it does, we won't crash during symbol lookup. --- libavformat/tls_apple.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/tls_apple.c b/libavformat/tls_app

[FFmpeg-devel] [PATCH 6/6] lavf/tls_apple: add support for the new Network framework

2019-06-11 Thread Rodger Combs
Network.framework was added in macOS 10.14/iOS 12, replacing Secure Transport. Its TLS functionality is (currently) implemented on top of BoringSSL. Secure Transport is deprecated as of macOS 10.15/iOS 13. It'll likely remain available for the forseeable future, but it's considered "legacy" and won

[FFmpeg-devel] [PATCH 3/6] lavf/tls_apple: fix crash on unexpected PEM types

2019-06-11 Thread Rodger Combs
--- libavformat/tls_apple.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/tls_apple.c b/libavformat/tls_apple.c index 2ff6622565..37d63f3b27 100644 --- a/libavformat/tls_apple.c +++ b/libavformat/tls_apple.c @@ -165,6 +165,12 @@ static int load_identity(URLContext *h, SecId

[FFmpeg-devel] [PATCH 5/6] lavf/tls: factor ff_tls_process_underlying into its own function

2019-06-11 Thread Rodger Combs
--- libavformat/tls.c | 45 +++-- libavformat/tls.h | 1 + 2 files changed, 28 insertions(+), 18 deletions(-) diff --git a/libavformat/tls.c b/libavformat/tls.c index 10e0792e29..ccd551061d 100644 --- a/libavformat/tls.c +++ b/libavformat/tls.c @@ -51,6 +5

[FFmpeg-devel] [PATCH 2/6] lavf/tls_apple: factor loading SecItemIdentity into its own (Mac-only) function

2019-06-11 Thread Rodger Combs
This allows us to easily reuse this function with NWF --- libavformat/tls_apple.c | 34 +- 1 file changed, 25 insertions(+), 9 deletions(-) diff --git a/libavformat/tls_apple.c b/libavformat/tls_apple.c index 37380541b1..2ff6622565 100644 --- a/libavformat/tls_appl

[FFmpeg-devel] [PATCH 2/2] lavfi/vf_thumbnail_cuda: fix operator precedence bug

2019-07-30 Thread Rodger Combs
Discovered via a warning when building with clang --- libavfilter/vf_thumbnail_cuda.cu | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_thumbnail_cuda.cu b/libavfilter/vf_thumbnail_cuda.cu index c73e49fbc6..d4d4d791f6 100644 --- a/libavfilter/vf_thumbnail_cuda.cu

[FFmpeg-devel] [PATCH 1/2] build: add support for building CUDA files with clang

2019-07-30 Thread Rodger Combs
h new file mode 100644 index 00..dbe50f8711 --- /dev/null +++ b/compat/cuda/cuda_runtime.h @@ -0,0 +1,131 @@ +/* + * Minimum CUDA compatibility definitions header + * + * Copyright (c) 2019 Rodger Combs + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute

[FFmpeg-devel] [PATCH] lavf/mpegts: improve read error handling

2018-08-23 Thread Rodger Combs
We previously could fail to check errors entirely, or misinterpret read errors as normal EOFs. --- libavformat/mpegts.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 37a6aa8bff..1350213d39 100644 --- a/libavform

[FFmpeg-devel] [PATCH 2/2] lavc/hevc_mp4toannexb_bsf: warn if a NAL size would overflow the buffer

2018-08-23 Thread Rodger Combs
This didn't actually cause a buffer overread previously, but it could result in the end of a NAL being filled with zeros silently. --- libavcodec/hevc_mp4toannexb_bsf.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/hevc_mp4toannexb_bsf.c b/libavcodec/hevc_mp4toannexb_bsf.c i

[FFmpeg-devel] [PATCH 1/2] lavc/hevc_mp4toannexb_bsf: don't fail on extradata with too few arrays

2018-08-23 Thread Rodger Combs
I've been given a sample that does this. Not sure exactly why, but the decoder ignores it and plays normally. --- libavcodec/hevc_mp4toannexb_bsf.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/hevc_mp4toannexb_bsf.c b/libavcodec/hevc_mp4toannexb_bsf.c index 09bce5b34c..fb4e

Re: [FFmpeg-devel] [PATCH] lavf/mpegts: improve read error handling

2018-08-24 Thread Rodger Combs
> On Aug 24, 2018, at 03:44, Hendrik Leppkes wrote: > > On Fri, Aug 24, 2018 at 5:01 AM myp...@gmail.com <mailto:myp...@gmail.com> > mailto:myp...@gmail.com>> wrote: >> >> On Fri, Aug 24, 2018 at 5:38 AM Rodger Combs wrote: >>> >>>

[FFmpeg-devel] [PATCH] lavf/mpegtsdec: fix AVPacket.pos when FEC/DVHS/BDAV data is present

2018-08-30 Thread Rodger Combs
We previously set pos to several bytes before the actual packet sync byte, which meant that seeking to pos relied on resync working, which can fail if there are 0x47 bytes in the additional data. The resync issue should probably also be fixed separately. --- libavformat/mpegts.c | 3 +-- 1 file c

[FFmpeg-devel] [PATCH] lavf/isom: add "dvhe" fourCC for HEVC

2018-11-05 Thread Rodger Combs
This refers to "Dolby Vision", which can have some additional extensions, but (usually?) is also valid HEVC. --- libavformat/isom.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/isom.c b/libavformat/isom.c index ca9d22e4f7..fbfa0dc057 100644 --- a/libavformat/isom.c +++ b/libavfo

[FFmpeg-devel] [PATCH 2/3] lavf/avidec: don't treat I/O errors as EOF

2018-11-27 Thread Rodger Combs
--- libavformat/avidec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/avidec.c b/libavformat/avidec.c index 3f074795a7..1d131b299c 100644 --- a/libavformat/avidec.c +++ b/libavformat/avidec.c @@ -1383,8 +1383,8 @@ static int ni_prepare_read(AVFormatContext *s

[FFmpeg-devel] [PATCH 1/3] lavf/matroskadec: don't treat I/O errors as EOF

2018-11-27 Thread Rodger Combs
pb->eof_reached is set on error, so we need to check pb->error, even after checking pb->eof_reached or avio_feof(pb), or else we can end up returning AVERROR_EOF instead of the actual error code. --- libavformat/matroskadec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

[FFmpeg-devel] [PATCH 3/3] lavf/movdec: don't treat I/O errors as EOF

2018-11-27 Thread Rodger Combs
--- libavformat/mov.c | 42 +- 1 file changed, 21 insertions(+), 21 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 542e92ec00..607ce30178 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -645,7 +645,7 @@ static int mov_read_d

Re: [FFmpeg-devel] [PATCH 1/3] lavf/matroskadec: don't treat I/O errors as EOF

2018-11-28 Thread Rodger Combs
> On Nov 28, 2018, at 13:19, Marton Balint wrote: > > > > On Wed, 28 Nov 2018, Rodger Combs wrote: > >> pb->eof_reached is set on error, so we need to check pb->error, >> even after checking pb->eof_reached or avio_feof(pb), or else we >> ca

[FFmpeg-devel] [PATCH] lavc/samidec: don't error on empty packets

2018-11-30 Thread Rodger Combs
No change to output; just prevents error spam --- libavcodec/samidec.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/libavcodec/samidec.c b/libavcodec/samidec.c index e32f238c62..7ea67b5597 100644 --- a/libavcodec/samidec.c +++ b/libavcodec/samidec.c @@ -38,6

[FFmpeg-devel] [PATCH] lavc/videotoolboxdec: fix crop handling when multithreaded

2019-09-06 Thread Rodger Combs
This was partially fixed by 233cd89, but it made changes to AVFrame fields from within end_frame, which doesn't work consistently when multithreading is enabled. This is what the post_process function is for. --- libavcodec/videotoolbox.c | 10 +- 1 file changed, 5 insertions(+), 5 deletio

[FFmpeg-devel] [PATCH] lavu/hwcontext_qsv: update crop width/height when mapping frames

2019-09-11 Thread Rodger Combs
This fixes an issue where the context could be configured with one resolution, but incoming frames could have another, and our output AVFrames wouldn't match the underlying surfaces' resolution, which is usually the value that MFX code uses. In particular, this would happen when mapping from DXVA2

Re: [FFmpeg-devel] [PATCH] lavu/hwcontext_qsv: update crop width/height when mapping frames

2019-09-12 Thread Rodger Combs
mplex '[0:0]hwmap=derive_device=qsv[0];[0]scale_qsv=format=nv12[1]' -map[1] -codec:0 h264_qsv output.mkv > On Sep 12, 2019, at 07:59, Li, Zhong wrote: > >> From: ffmpeg-devel On Behalf Of Rodger >> Combs >> Sent: Thursday, September 12, 2019 11:59 AM &g

[FFmpeg-devel] [PATCH] lavf/movdec: add position_order option

2019-09-21 Thread Rodger Combs
This allows reading packets linearly, which prevents large numbers of unnecessary seeks in poorly-interleaved files with consumer software that handles those cases well on its own. --- libavformat/isom.h| 1 + libavformat/mov.c | 11 +++ libavformat/version.h | 2 +- 3 files chan

[FFmpeg-devel] [PATCH] lavf/tcp: add resolve_hosts option

2019-09-21 Thread Rodger Combs
This can be used to resolve particular hosts offline without affecting HTTP headers, TLS SNI, or cross-domain redirects. It works similarly to curl's --resolve option, but without port-specific handling. --- libavformat/tcp.c | 27 +++ libavformat/version.h | 2 +- 2 f

[FFmpeg-devel] [PATCH] lavf/mp3dec: increase probe score of buffers entirely composed of valid packets

2019-09-21 Thread Rodger Combs
Fixes some files misdetecting as MPEG PS --- libavformat/mp3dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index 258f19174b..d9aaee50b9 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -100,13 +100,13 @@ stat

Re: [FFmpeg-devel] [PATCH] lavf/movdec: add position_order option

2019-09-22 Thread Rodger Combs
> On Sep 22, 2019, at 03:19, Andreas Rheinhardt > wrote: > > Rodger Combs: >> This allows reading packets linearly, which prevents large numbers of >> unnecessary seeks in poorly-interleaved files with consumer software that >> handles those cases well on its

[FFmpeg-devel] [PATCH] lavc: vt_hevc: fix crash if vps_list[0] or sps_list[0] are null

2019-01-09 Thread Rodger Combs
Instead of assuming id 0 is used, use the same logic as used for PPS, where all available entries in the list are emitted. --- libavcodec/videotoolbox.c | 86 ++- 1 file changed, 40 insertions(+), 46 deletions(-) diff --git a/libavcodec/videotoolbox.c b/libavco

[FFmpeg-devel] [PATCH 3/4] lavf/tls_openssl: on 1.1 or later, verify the server's hostname

2019-01-17 Thread Rodger Combs
--- libavformat/tls_openssl.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 493f43e610..bdc4985bad 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -35,6 +35,7 @@ #in

[FFmpeg-devel] [PATCH 2/4] lavf/tls_openssl: if no CA path is set, use the system default

2019-01-17 Thread Rodger Combs
This is consistent with the other TLS wrappers --- libavformat/tls_openssl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index faa5b8636e..493f43e610 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -253,6 +2

[FFmpeg-devel] [PATCH 4/4] lavf/tls: enable server verification by default when not on mbedtls

2019-01-17 Thread Rodger Combs
All other TLS wrappers now have a mechanism to load a system trust store by default, without setting the cafile option. For Secure Transport and Secure Channel, it's the OS. For OpenSSL and libtls, it's a path set at compile-time. For GNUTLS, it's either a path set at compile-time, or the OS trust

[FFmpeg-devel] [PATCH 1/4] lavf/tls_openssl: silence warning on OpenSSL 1.1 and later

2019-01-17 Thread Rodger Combs
--- libavformat/tls_openssl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 7ae71bdaf3..faa5b8636e 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -102,7 +102,7 @@ void ff_openssl_deinit(voi

Re: [FFmpeg-devel] [PATCH 1/4] lavf/tls_openssl: silence warning on OpenSSL 1.1 and later

2019-01-17 Thread Rodger Combs
> On Jan 17, 2019, at 03:12, Nicolas George wrote: > > Signed PGP part > Rodger Combs (12019-01-17): >> --- >> libavformat/tls_openssl.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/tls_openssl.c b/lib

Re: [FFmpeg-devel] [PATCH 3/4] lavf/tls_openssl: on 1.1 or later, verify the server's hostname

2019-01-17 Thread Rodger Combs
> On Jan 17, 2019, at 03:09, Nicolas George wrote: > > Signed PGP part > Rodger Combs (12019-01-17): >> --- >> libavformat/tls_openssl.c | 22 ++ >> 1 file changed, 18 insertions(+), 4 deletions(-) >> >> diff --git a/libavformat

[FFmpeg-devel] [PATCH 1/5] lavf/tls_openssl: disable obsolete locking code on OpenSSL 1.1 and later

2019-01-18 Thread Rodger Combs
These functions are now all no-ops and locking is handled internally. This fixes a small memory leak on init. --- libavformat/tls_openssl.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 7ae71bdaf3..9dd53c6fc0 1

[FFmpeg-devel] [PATCH 2/5] lavf/tls_openssl: if no CA path is set, use the system default

2019-01-18 Thread Rodger Combs
This is consistent with the other TLS wrappers --- libavformat/tls_openssl.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 9dd53c6fc0..ae3fd6e236 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -253,6 +2

[FFmpeg-devel] [PATCH 3/5] lavf/tls_openssl: on 1.1 or later, verify the server's hostname

2019-01-18 Thread Rodger Combs
--- libavformat/tls_openssl.c | 22 ++ 1 file changed, 18 insertions(+), 4 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index ae3fd6e236..ba233c0229 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -35,6 +35,7 @@ #in

[FFmpeg-devel] [PATCH 5/5] lavf/tls: enable server verification by default when not on mbedtls

2019-01-18 Thread Rodger Combs
All other TLS wrappers now have a mechanism to load a system trust store by default, without setting the cafile option. For Secure Transport and Secure Channel, it's the OS. For OpenSSL and libtls, it's a path set at compile-time. For GNUTLS, it's either a path set at compile-time, or the OS trust

[FFmpeg-devel] [PATCH 4/5] lavf/tls: apply numerichost check to verifyhost

2019-01-18 Thread Rodger Combs
--- libavformat/tls.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/tls.c b/libavformat/tls.c index 10e0792e29..a6dcd3cc96 100644 --- a/libavformat/tls.c +++ b/libavformat/tls.c @@ -80,15 +80,15 @@ int ff_tls_open_underlying(TLSShared *c, URLContext *pare

Re: [FFmpeg-devel] [PATCH 5/5] lavf/tls: enable server verification by default when not on mbedtls

2019-01-18 Thread Rodger Combs
> On Jan 18, 2019, at 05:41, Carl Eugen Hoyos wrote: > > 2019-01-18 9:46 GMT+01:00, Rodger Combs : >> All other TLS wrappers now have a mechanism to load a system trust store >> by default, without setting the cafile option. For Secure Transport and >> Secure Channe

[FFmpeg-devel] [PATCH 1/3] lavu/x86util: make imprecise PMINSD implementation opt-in

2019-01-22 Thread Rodger Combs
This caused rounding errors when values that can't be expressed exactly as 32-bit floats were passed in, which could happen in 16-bit yadif swscale's call is opted in, under the assumption that it never uses values large enough to run into this (i.e. within 2^24) --- libavutil/x86/x86util.asm | 4

[FFmpeg-devel] [PATCH 2/3] FATE/filter-video: fix high-bit-depth yadif tests

2019-01-22 Thread Rodger Combs
These previously upconverted the video _after_ applying the filter, so they didn't actually test the high-bit-depth code paths at all, which is why the PMINSD issue in the previous commit wasn't caught. I also added variants with the spatial check enabled and disabled, so both of those paths are te

[FFmpeg-devel] [PATCH 3/3] tests/checkasm: add vf_yadif tests

2019-01-22 Thread Rodger Combs
--- libavfilter/vf_yadif.c| 23 --- libavfilter/yadif.h | 2 + tests/checkasm/Makefile | 1 + tests/checkasm/checkasm.c | 3 + tests/checkasm/checkasm.h | 1 + tests/checkasm/vf_yadif.c | 137 ++ 6 files changed, 158 insertions(+), 9 del

[FFmpeg-devel] [PATCH] lavf/hlsdec: fix support for large initialization segments

2019-02-28 Thread Rodger Combs
--- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index fc9110356d..c56ead507b 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1553,7 +1553,7 @@ reload: if (v->init_sec_buf_read_offset < v->init_sec_data_

[FFmpeg-devel] [PATCH 1/2] lavf/movdec: fix demuxing files with 0-entry trun atoms

2019-03-16 Thread Rodger Combs
Regressed in 4a9d32baca3af0d1831f9556a922c7ab5b426b10 --- libavformat/mov.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index a7d444b0ee..0dfee2e7c4 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4739,6 +4739,8 @@ static int mov_read_trun

[FFmpeg-devel] [PATCH 2/2] lavf/movdec: use a more appropriate error code for bad trun atoms

2019-03-16 Thread Rodger Combs
--- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 0dfee2e7c4..9ed109962f 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -4785,7 +4785,7 @@ static int mov_read_trun(MOVContext *c, AVIOContext *pb, MOVAto

[FFmpeg-devel] [PATCH] lavf/mp3dec: increase probe score of buffers entirely composed of valid packets

2019-03-16 Thread Rodger Combs
Fixes some files misdetecting as MPEG PS --- libavformat/mp3dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mp3dec.c b/libavformat/mp3dec.c index ef884934e1..81da0c6090 100644 --- a/libavformat/mp3dec.c +++ b/libavformat/mp3dec.c @@ -100,13 +100,13 @@ stat

[FFmpeg-devel] [PATCH 3/3] lavf/movdec: request probing for an ambiguous codec tag

2017-03-18 Thread Rodger Combs
--- libavformat/isom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/isom.c b/libavformat/isom.c index 7da2700842..9589f42741 100644 --- a/libavformat/isom.c +++ b/libavformat/isom.c @@ -514,6 +514,8 @@ FF_ENABLE_DEPRECATION_WARNINGS codec_id= ff_codec_get_id(ff_mp4_obj_ty

[FFmpeg-devel] [PATCH 2/3] lavf/utils: add MP2 to the probing list

2017-03-18 Thread Rodger Combs
--- libavformat/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 84acb9c795..8bf34e8f6f 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -329,6 +329,7 @@ static int set_codec_from_probe_data(AVFormatContext *s, AVStream *st,

[FFmpeg-devel] [PATCH 1/3] lavf: identify MP1 and MP2 as distinct containers from MP3

2017-03-18 Thread Rodger Combs
This allows us to report the correct codec ID here --- libavformat/allformats.c | 3 ++- libavformat/mp3dec.c | 66 +++- libavformat/rawenc.c | 13 ++ libavformat/utils.c | 4 +-- libavformat/version.h| 4 +-- 5 files changed,

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: add dash demuxer base version

2017-03-19 Thread Rodger Combs
A few initial comments inline: > On Mar 19, 2017, at 04:05, Steven Liu wrote: > > ffmpeg need a dash demuxer for demux the dash formats > base on > https://github.com/samsamsam-iptvplayer/exteplayer3/blob/master/tmp/ffmpeg/patches/3.2.2/01_add_dash_demux.patch > > Signed-off-by: Steven Liu

Re: [FFmpeg-devel] [PATCH v6] avformat/dashdec: add dash demuxer base version

2017-03-22 Thread Rodger Combs
_free > > Reviewed-by: Clément Bœsch > Reviewed-by: Michael Niedermayer > Reviewed-by: Carl Eugen Hoyos > Reviewed-by: Rodger Combs > Reviewed-by: Moritz Barsnick > Reviewed-by: Nicolas George > Reviewed-by: Ricardo Constantino > Signed-off-by: Steven Liu >

Re: [FFmpeg-devel] [PATCH v6] avformat/dashdec: add dash demuxer base version

2017-03-22 Thread Rodger Combs
> On Mar 22, 2017, at 09:31, Steven Liu wrote: > > 2017-03-22 22:01 GMT+08:00 Rodger Combs <mailto:rodger.co...@gmail.com>>: > >> >>> On Mar 21, 2017, at 08:16, Steven Liu wrote: >>> >>> v2 fixed: >>> 1. from autodetect to

Re: [FFmpeg-devel] [PATCH v9] avformat/dashdec: add dash demuxer base version

2017-03-26 Thread Rodger Combs
o av_free > > v7 fixed: > 1. remove the -lxml2 from configure when require_pkg_config > > v8 fixed: > 1. fix replace filename template by av_asprintf secure problem > > v9 modified: > 1. make manifest parser clearly > > Reviewed-by: Clément Bœsch > Reviewed-by: Mi

Re: [FFmpeg-devel] [PATCH v9] avformat/dashdec: add dash demuxer base version

2017-03-27 Thread Rodger Combs
> On Mar 27, 2017, at 01:52, Steven Liu wrote: > > 2017-03-27 8:39 GMT+08:00 Rodger Combs <mailto:rodger.co...@gmail.com>>: > >> >>> On Mar 26, 2017, at 19:10, Steven Liu wrote: >>> >>> v2 fixed: >>> 1. from autodetect to disab

Re: [FFmpeg-devel] [PATCH v14] avformat/dashdec: add dash demuxer base version

2017-04-11 Thread Rodger Combs
ce > > v13 fixed: > 1. fix bug: cannot play: > http://dash.edgesuite.net/akamai/bbb_30fps/bbb_30fps.mpd > > v14 fixed: > 1. fix bug: TLS connection was non-properly terminated > 2. fix bug: No trailing CRLF found in HTTP header > > Reviewed-by: Clément Bœsch >

[FFmpeg-devel] [PATCH 1/5] lavu/bprint: reorder cases to match enum order

2017-04-12 Thread Rodger Combs
--- libavutil/bprint.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/libavutil/bprint.c b/libavutil/bprint.c index 2f059c5ba6..652775bef9 100644 --- a/libavutil/bprint.c +++ b/libavutil/bprint.c @@ -271,19 +271,8 @@ void av_bprint_escape(AVBPrint *

[FFmpeg-devel] [PATCH 2/5] lavu/bprint: add XML escaping

2017-04-12 Thread Rodger Combs
--- libavutil/avstring.h | 28 libavutil/bprint.c | 43 +++ 2 files changed, 71 insertions(+) diff --git a/libavutil/avstring.h b/libavutil/avstring.h index 04d2695640..68b753a569 100644 --- a/libavutil/avstring.h +++ b/libavu

[FFmpeg-devel] [PATCH 1/5] lavu/bprint: reorder cases to match enum order

2017-04-12 Thread Rodger Combs
--- libavutil/bprint.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/libavutil/bprint.c b/libavutil/bprint.c index 2f059c5ba6..652775bef9 100644 --- a/libavutil/bprint.c +++ b/libavutil/bprint.c @@ -271,19 +271,8 @@ void av_bprint_escape(AVBPrint *

[FFmpeg-devel] [PATCH 4/5] lavc/webvttenc: XML-escape text output

2017-04-12 Thread Rodger Combs
The test output was previously incorrect, so the reference is updated. --- libavcodec/webvttenc.c | 7 ++- tests/ref/fate/sub-webvttenc | 20 ++-- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/libavcodec/webvttenc.c b/libavcodec/webvttenc.c index c84bb

[FFmpeg-devel] [PATCH 3/5] ffprobe: switch xml_escape_str to use av_bprint_escape

2017-04-12 Thread Rodger Combs
This now escapes single-quotes, so the test reference is updated. --- ffprobe.c | 25 ++--- tests/ref/fate/ffprobe_xml | 2 +- 2 files changed, 7 insertions(+), 20 deletions(-) diff --git a/ffprobe.c b/ffprobe.c index 0a9ba14d8d..5c5bdaf3b1 100644 --- a/ffpro

[FFmpeg-devel] [PATCH 5/5] lavu/bprint: add URL escaping

2017-04-12 Thread Rodger Combs
--- libavutil/avstring.h | 1 + libavutil/bprint.c | 11 +++ libavutil/version.h | 2 +- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/libavutil/avstring.h b/libavutil/avstring.h index 68b753a569..cce210 100644 --- a/libavutil/avstring.h +++ b/libavutil/avstring.h

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix CID 1405135

2017-04-25 Thread Rodger Combs
> On Apr 25, 2017, at 18:47, Steven Liu wrote: > > CID: 1405135 I have no idea what this message is supposed to mean. > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hl

[FFmpeg-devel] [PATCH 1/2] ffmpeg: treat audio streams with no parsed packets like unknown streams

2017-05-01 Thread Rodger Combs
--- ffmpeg_opt.c | 8 1 file changed, 8 insertions(+) diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c index d1fe8742ff..5ed29d717e 100644 --- a/ffmpeg_opt.c +++ b/ffmpeg_opt.c @@ -2255,6 +2255,14 @@ loop_end: if(o->data_disable && ist->st->codecpar->codec_type == AVMEDIA_T

[FFmpeg-devel] [PATCH 2/2] lavf/utils: bail early if we don't see any packets in an MPEGTS stream

2017-05-01 Thread Rodger Combs
--- libavformat/utils.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index ba82a766dc..4028d8dbcb 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -3505,6 +3505,8 @@ int avformat_find_stream_info(AVFor

Re: [FFmpeg-devel] [PATCH 2/2] lavf/utils: bail early if we don't see any packets in an MPEGTS stream

2017-05-02 Thread Rodger Combs
> On May 2, 2017, at 03:59, Matthias Hunstock wrote: > > Am 02.05.2017 um 03:42 schrieb Rodger Combs: >> +max_empty_analyze_duration = max_analyze_duration; >> if (!max_analyze_duration) { >> +max_empty_analyze_duration = >>

[FFmpeg-devel] [PATCH] lavf/utils: bail early if we don't see any packets in an MPEGTS stream

2017-05-02 Thread Rodger Combs
--- libavformat/utils.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index ba82a766dc..80895b31f0 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -3505,6 +3505,8 @@ int avformat_find_stream_info(

[FFmpeg-devel] [PATCH 2/7] lavf/segment: add option to segment by chapter

2017-05-07 Thread Rodger Combs
--- doc/muxers.texi | 6 + libavformat/segment.c | 65 +++ libavformat/version.h | 2 +- 3 files changed, 67 insertions(+), 6 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 0866142..b80bc68 100644 --- a/doc/muxers.texi

[FFmpeg-devel] [PATCH 5/7] lavf/flacenc: support writing attached pictures

2017-05-07 Thread Rodger Combs
--- libavformat/flacenc.c | 271 +++--- 1 file changed, 236 insertions(+), 35 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index b894f9e..9bb4947 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -21,10 +21,13

[FFmpeg-devel] [PATCH 4/7] lavf/segment: write attached pictures to all segments by default

2017-05-07 Thread Rodger Combs
--- doc/muxers.texi | 4 libavformat/segment.c | 24 libavformat/version.h | 2 +- 3 files changed, 29 insertions(+), 1 deletion(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index b80bc68..3707d05 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -15

[FFmpeg-devel] [PATCH 3/7] lavf/segment: copy stream dispositions in output

2017-05-07 Thread Rodger Combs
--- libavformat/segment.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index 8575d32..9c6ce73 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -184,6 +184,7 @@ static int segment_mux_init(AVFormatContext *s) }

[FFmpeg-devel] [PATCH 6/7] lavf/flacenc: avoid buffer overread with unexpected extradata sizes

2017-05-07 Thread Rodger Combs
--- libavformat/flacenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index 9bb4947..b8800cc 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -315,7 +315,7 @@ static int flac_write_trailer(struct AVFormatContext

[FFmpeg-devel] [PATCH 1/7] lavf: add cue sheet demuxer

2017-05-07 Thread Rodger Combs
, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +/** + * @file + * Cue sheet demuxer + * @author Rodger Combs + */ + +#include "avformat.h" +#include "internal.h" +#include "subtitles.h" +#include "url.h" +#include "libavutil/in

[FFmpeg-devel] [PATCH 7/7] lavf/flacenc: generate timestamps internally

2017-05-07 Thread Rodger Combs
--- libavformat/flacenc.c | 88 +-- 1 file changed, 85 insertions(+), 3 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index b8800cc..0e948ac 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -30,6 +30,7 @@

Re: [FFmpeg-devel] [PATCH v4 14/14] avcodec/videotoolbox: fix whitespace

2017-11-10 Thread Rodger Combs
Patchset LGTM. > On Nov 10, 2017, at 15:40, Aman Gupta wrote: > > From: Aman Gupta > > --- > libavcodec/videotoolbox.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c > index 9eb06e619f..04c558935d 100644 > ---

Re: [FFmpeg-devel] [PATCH 6/7] lavf/flacenc: avoid buffer overread with unexpected extradata sizes

2017-11-21 Thread Rodger Combs
> On Nov 21, 2017, at 19:03, Rostislav Pehlivanov wrote: > > On 2 August 2017 at 00:35, Rodger Combs <mailto:rodger.co...@gmail.com>> wrote: > >> >>> On Aug 1, 2017, at 18:25, James Almer wrote: >>> >>> On 8/1/2017 3:33 AM, Rodge

[FFmpeg-devel] [PATCH] lavu/hwcontext_opencl.h: fix build on macOS

2017-11-27 Thread Rodger Combs
--- libavutil/hwcontext_opencl.h | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/hwcontext_opencl.h b/libavutil/hwcontext_opencl.h index 8e34df44cd..ef54486c95 100644 --- a/libavutil/hwcontext_opencl.h +++ b/libavutil/hwcontext_opencl.h @@ -19,7 +19,11 @@ #ifndef AVUTIL_HWCONTEX

[FFmpeg-devel] [PATCH] build: fix build with OpenCL

2017-12-07 Thread Rodger Combs
--- fftools/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fftools/Makefile b/fftools/Makefile index 094f6d6265..9b211aa4d5 100644 --- a/fftools/Makefile +++ b/fftools/Makefile @@ -21,7 +21,7 @@ OBJS-ffserver += fftools/ffserver_config.o defin

[FFmpeg-devel] [PATCH] lavc/libopenjpeg: support version 2.3.0 and later

2017-12-07 Thread Rodger Combs
--- configure | 2 ++ libavcodec/libopenjpegdec.c | 29 +++-- libavcodec/libopenjpegenc.c | 29 +++-- 3 files changed, 48 insertions(+), 12 deletions(-) diff --git a/configure b/configure index ae0eddac6c..27bed3a20d 100755 --- a/

[FFmpeg-devel] [PATCH 2/2] lavf/utils: add flag to discard timestamps on corrupted frames

2017-12-07 Thread Rodger Combs
--- libavformat/avformat.h | 1 + libavformat/internal.h | 5 + libavformat/options_table.h | 1 + libavformat/utils.c | 12 4 files changed, 19 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 4f2798a871..e2d88280a8 100644 ---

[FFmpeg-devel] [PATCH 1/2] lavf/mpegts: mark packets with TEI flag as corrupted

2017-12-07 Thread Rodger Combs
--- libavformat/mpegts.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 53cbcfb543..0a3ad05726 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -2296,6 +2296,14 @@ static int handle_packet(MpegTSContext *ts, const uint8

Re: [FFmpeg-devel] [PATCH] lavc/libopenjpeg: support version 2.3.0 and later

2017-12-07 Thread Rodger Combs
Yup, I did. > On Dec 7, 2017, at 08:04, James Almer wrote: > > On 12/7/2017 6:17 AM, Rodger Combs wrote: >> --- >> configure | 2 ++ >> libavcodec/libopenjpegdec.c | 29 +++-- >> libavcodec/libopenjpegenc.c | 29 +++

Re: [FFmpeg-devel] [PATCH 2/2] lavf/utils: add flag to discard timestamps on corrupted frames

2017-12-07 Thread Rodger Combs
> On Dec 7, 2017, at 16:53, Hendrik Leppkes wrote: > > On Thu, Dec 7, 2017 at 9:46 PM, Michael Niedermayer > mailto:mich...@niedermayer.cc>> wrote: >> On Thu, Dec 07, 2017 at 03:37:38AM -0600, Rodger Combs wrote: >>> --- >>> libavformat/avforma

[FFmpeg-devel] [PATCH 2/3] lavf/utils: add flag to discard timestamps on corrupted frames

2017-12-07 Thread Rodger Combs
--- libavformat/avformat.h | 1 + libavformat/options_table.h | 1 + libavformat/utils.c | 8 3 files changed, 10 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 4f2798a871..d10d583dff 100644 --- a/libavformat/avformat.h +++ b/libavformat/avf

[FFmpeg-devel] [PATCH 1/3] lavf/mpegts: mark packets with TEI flag as corrupted

2017-12-07 Thread Rodger Combs
--- libavformat/mpegts.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 53cbcfb543..0a3ad05726 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -2296,6 +2296,14 @@ static int handle_packet(MpegTSContext *ts, const uint8

[FFmpeg-devel] [PATCH 3/3] lavf/utils: add flag to fill unset timestamps from wallclock offset

2017-12-07 Thread Rodger Combs
--- libavformat/avformat.h | 1 + libavformat/internal.h | 5 + libavformat/options_table.h | 1 + libavformat/utils.c | 12 4 files changed, 19 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index d10d583dff..a039a2764d 100644 ---

[FFmpeg-devel] [PATCH 1/3] lavf/matroskadec: resync if cluster parsing fails while seeking

2017-12-08 Thread Rodger Combs
--- libavformat/matroskadec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 496499b553..93a3ec4a07 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -3528,9 +3528,12 @@ static int matro

[FFmpeg-devel] [PATCH 2/3] lavf/matroskadec: fallback to generic seeking if resyncing fails while seeking

2017-12-08 Thread Rodger Combs
--- libavformat/matroskadec.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 93a3ec4a07..2d23f2ee84 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -3531,8 +3531,10 @@ static int matroska_

[FFmpeg-devel] [PATCH 3/3] lavf/matroskadec: log when falling back to generic seeking

2017-12-08 Thread Rodger Combs
--- libavformat/matroskadec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 2d23f2ee84..f023e94e70 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -3567,6 +3567,7 @@ static int matroska_read_seek(AVFormatCo

[FFmpeg-devel] [PATCH 3/3] lavf/matroskadec: log when falling back to generic seeking

2017-12-08 Thread Rodger Combs
--- libavformat/matroskadec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 944ed795d5..fb1a27f4a8 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -3570,6 +3570,7 @@ static int matroska_read_seek(AVFormatCo

[FFmpeg-devel] [PATCH 2/3] lavf/matroskadec: fallback to generic seeking if resyncing fails while seeking

2017-12-08 Thread Rodger Combs
--- libavformat/matroskadec.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index b51f67af00..944ed795d5 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -3532,8 +3532,12 @@ static int matrosk

[FFmpeg-devel] [PATCH 1/3] lavf/matroskadec: resync if cluster parsing fails while seeking

2017-12-08 Thread Rodger Combs
--- libavformat/matroskadec.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index 496499b553..b51f67af00 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -3528,9 +3528,13 @@ static int matr

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: add flag to discard timestamps on corrupted frames

2017-12-08 Thread Rodger Combs
> On Dec 8, 2017, at 11:06, Michael Niedermayer wrote: > > On Thu, Dec 07, 2017 at 10:23:15PM -0600, Rodger Combs wrote: >> --- >> libavformat/avformat.h | 1 + >> libavformat/options_table.h | 1 + >> libavformat/utils.c | 8 >> 3 file

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: add flag to discard timestamps on corrupted frames

2017-12-10 Thread Rodger Combs
> On Dec 9, 2017, at 12:19, Michael Niedermayer wrote: > > On Fri, Dec 08, 2017 at 10:34:39PM -0600, Rodger Combs wrote: >> >> >>> On Dec 8, 2017, at 11:06, Michael Niedermayer >>> wrote: >>> >>> On Thu, Dec 07, 2017 at 10:23:

Re: [FFmpeg-devel] [PATCH 3/3] lavf/utils: add flag to fill unset timestamps from wallclock offset

2017-12-10 Thread Rodger Combs
> On Dec 10, 2017, at 05:07, Nicolas George wrote: > > Rodger Combs (2017-12-07): >> --- >> libavformat/avformat.h | 1 + >> libavformat/internal.h | 5 + >> libavformat/options_table.h | 1 + >> libavformat/utils.c | 12 +++

Re: [FFmpeg-devel] [PATCH 3/3] lavf/utils: add flag to fill unset timestamps from wallclock offset

2017-12-10 Thread Rodger Combs
> On Dec 10, 2017, at 05:40, Nicolas George wrote: > > Rodger Combs (2017-12-10): >> The goal is to use this in conjunction with the previous patches in >> the set to deal with live broadcast streams coming off a tuner. The >> first patch sets the CORRUPT flag when

Re: [FFmpeg-devel] [PATCH 1/3] lavf/matroskadec: resync if cluster parsing fails while seeking

2017-12-10 Thread Rodger Combs
> On Dec 10, 2017, at 08:08, Nicolas George wrote: > > Rodger Combs (2017-12-08): >> --- >> libavformat/matroskadec.c | 8 ++-- >> 1 file changed, 6 insertions(+), 2 deletions(-) >> >> diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c

Re: [FFmpeg-devel] [PATCH 2/3] lavf/utils: add flag to discard timestamps on corrupted frames

2017-12-13 Thread Rodger Combs
> On Dec 10, 2017, at 09:27, Michael Niedermayer wrote: > > On Sun, Dec 10, 2017 at 05:17:44AM -0600, Rodger Combs wrote: >> >> >>> On Dec 9, 2017, at 12:19, Michael Niedermayer >>> wrote: >>> >>> On Fri, Dec 08, 2017 at 10:34:3

Re: [FFmpeg-devel] [PATCH] avcodec: add properties for lossless to AVCodecParameters

2017-12-13 Thread Rodger Combs
> On May 9, 2016, at 08:28, Hendrik Leppkes wrote: > > On Mon, May 9, 2016 at 3:26 PM, Derek Buitenhuis > wrote: >> On 5/9/2016 2:22 PM, Paul B Mahol wrote: >>> Once st->codec is gone, how would this lossless info be gathered back? >> >> As myself and others have said above: decode a frame. >

[FFmpeg-devel] [PATCH 1/4] lavf/mpegts: mark packets with TEI flag as corrupted

2017-12-13 Thread Rodger Combs
--- libavformat/mpegts.c | 8 1 file changed, 8 insertions(+) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 53cbcfb543..0a3ad05726 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c @@ -2296,6 +2296,14 @@ static int handle_packet(MpegTSContext *ts, const uint8

[FFmpeg-devel] [PATCH 4/4] lavf/utils: add flag to fill unset timestamps from wallclock offset

2017-12-13 Thread Rodger Combs
--- libavformat/avformat.h | 1 + libavformat/internal.h | 5 + libavformat/options_table.h | 1 + libavformat/utils.c | 12 4 files changed, 19 insertions(+) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index d10d583dff..a039a2764d 100644 ---

  1   2   3   4   5   6   7   8   >