It seems like some software can insert an additional ID3v2 tag instead
of appending a frame to an existing one. One could argue that that is
somewhat broken, but I agree it's better to handle it instead of
returning an error. The changes in aacdec.c look ok to me.
The fate sample you provided has
On Mon, Apr 2, 2018 at 8:31 PM, Steven Liu wrote:
>
>
>> On 3 Apr 2018, at 09:12, rshaf...@tunein.com wrote:
>>
>> From: Richard Shaffer
>>
>> The rw_timeout option is currently not applied when opening media playlist,
>> segment, or encryption key URL
On Mon, Apr 2, 2018 at 10:15 PM, Steven Liu wrote:
>
>
>> On 3 Apr 2018, at 12:33, Richard Shaffer wrote:
>>
>> On Mon, Apr 2, 2018 at 8:31 PM, Steven Liu wrote:
>>>
>>>
>>>> On 3 Apr 2018, at 09:12, rshaf...@tunein.com wrote:
>>>&
On Tue, Apr 3, 2018 at 12:13 AM, Steven Liu wrote:
>
>
> > On 3 Apr 2018, at 14:06, Richard Shaffer wrote:
> >
> > On Mon, Apr 2, 2018 at 10:15 PM, Steven Liu wrote:
> >>
> >>
> >>> On 3 Apr 2018, at 12:33, Richard Shaffer wrote:
> &g
On Tue, Apr 3, 2018 at 5:11 PM, Steven Liu wrote:
> 2018-04-04 7:53 GMT+08:00 Steven Liu :
> >>>
> >>> Look at the code:
> >>>
> >>> 205 char *referer; ///< holds HTTP referer
> set
> >>> as an AVOption to the HTTP protocol context
> >>> 206 char *user_agent;
On Tue, Apr 10, 2018 at 4:00 PM, Liu Steven wrote:
>
> > 在 2018年4月11日，上午3:14，Richard Shaffer 写道：
> >
> > On Tue, Apr 3, 2018 at 5:11 PM, Steven Liu
> wrote:
> >
> >> 2018-04-04 7:53 GMT+08:00 Steven Liu :
> >>>>>
> &
On Mon, Apr 9, 2018 at 1:05 AM, Mattias Amnefelt wrote:
> On 2018-04-05 01:00, Mattias Amnefelt wrote:
>
>> On 2018-04-04 09:22, Mattias Amnefelt wrote:
>>
>>> On 2018-04-04 03:42, James Almer wrote:
>>>
On 4/3/2018 10:40 PM, Carl Eugen Hoyos wrote:
> 2018-04-04 3:38 GMT+02:00, Jame
On Fri, Apr 13, 2018 at 5:14 PM, wrote:
> From: Richard Shaffer
>
> The HLSContext struct contains fields which duplicate the data stored in
> the
> avio_opts field. This change removes those fields in favor of avio_opts,
> and
> updates the code accordingly.
> ---
>
On Fri, Apr 13, 2018 at 4:42 PM, wrote:
> From: Richard Shaffer
>
> ---
> libavformat/http.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/libavformat/http.c b/libavformat/http.c
> index 983034f083..b4a1919f24 100644
> --- a/libavformat/http.c
> +++ b/l
On Tue, Apr 17, 2018 at 1:04 PM, wm4 wrote:
> On Tue, 17 Apr 2018 10:48:16 -0700
> Richard Shaffer wrote:
>
> > On Fri, Apr 13, 2018 at 4:42 PM, wrote:
> >
> > > From: Richard Shaffer
> > >
> > > ---
> > > libavformat/http.c | 1 +
>
On Mon, Apr 16, 2018 at 10:24 PM, Steven Liu wrote:
>
>
> > On 16 Apr 2018, at 08:37, Jun Zhao wrote:
> >
> >
> >
> > On 2018/4/13 20:29, Steven Liu wrote:
> >> 2018-04-13 16:19 GMT+08:00 Jun Zhao :
> >>>
> >>> On 2018/4/12 16:48, Steven Liu wrote:
> Signed-off-by: Steven Liu
> ---
>
On Tue, Apr 17, 2018 at 4:37 PM, wrote:
> From: Richard Shaffer
>
> This refactors get_cookies to simplify some code paths, specifically for
> skipping logic in the while loop or exiting it. It also simplifies the
> logic
> for appending additional values to *cookies by
On Thu, Apr 19, 2018 at 1:04 PM, wm4 wrote:
> On Thu, 19 Apr 2018 12:55:00 -0700
> rshaf...@tunein.com wrote:
>
> > From: Richard Shaffer
> >
> > This refactors get_cookies to simplify some code paths, specifically for
> > skipping logic in the while loop or e
On Thu, Jan 11, 2018 at 2:49 PM, Moritz Barsnick wrote:
> On Thu, Jan 11, 2018 at 14:28:52 -0800, rshaf...@tunein.com wrote:
>
> > [PATCH 3/3] http: fix memory leak in parse_cookie.g
>
> > This is my first time contributing.
>
> Where are the other two of the three ("3/3") patches then? (Not
> im
x27;t useful to anyone else, that would also be good to know. Any
feedback at all would be appreciated if anyone is willing.
Much thanks,
-Richard
On Fri, Jan 12, 2018 at 1:13 PM, wrote:
> From: Richard Shaffer
>
> Enables getting access to ID3 PRIV tags from the command-line or metada
Thanks for reviewing; it's much appreciated. I responded to one of the
comments in-line. I'll work on updating the patch to address your comments.
On Wed, Jan 17, 2018 at 10:21 AM, wm4 wrote:
> On Fri, 12 Jan 2018 13:13:05 -0800
> rshaf...@tunein.com wrote:
>
> &
On Wed, Jan 17, 2018 at 11:38 AM, wm4 wrote:
> On Wed, 17 Jan 2018 11:10:26 -0800
> Richard Shaffer wrote:
>
> > [...]
> > I'm also not sure if an option for compatibility is needed. It's
> > > probably fine to prefix the name with something (maybe &qu
or to have some additional comments if more changes are needed.
On the other hand, I don't want to be a squeaky wheel. If there is no
response or interest, I won't have any hard feelings.
Thanks again,
-Richard
On Wed, Jan 17, 2018 at 4:34 PM, wrote:
> From: Richard Shaffer
&
On Mon, Jan 22, 2018 at 3:18 PM, wm4 wrote:
> On Wed, 17 Jan 2018 16:34:39 -0800
> rshaf...@tunein.com wrote:
>
> > From: Richard Shaffer
> >
> > Enables getting access to ID3 PRIV tags from the command-line or
> metadata API
> > when demuxing. The PRIV
On Tue, Jan 23, 2018 at 2:32 PM, wm4 wrote:
>
> I think this test program is pretty nice, though usually we try to get
> by with running the "ffmpeg" utility to test the libs. Having a
> relatively big program to test some obscure functionality might have a
> maintenance burden. I'm not sure how
On Tue, Jan 23, 2018 at 6:15 PM, James Almer wrote:
>
>
> ffprobe -show_format is probably best for an id3v2 tag. Add a new
> probeformat() function to fate-run.sh like
>
> probeformat(){
> run ffprobe${PROGSUF} -show_format -v 0 "$@"
> }
>
> Then call it with the sample in question a argument
>From f7398407c1f5822e1536ce03d46c885b2ad00c38 Mon Sep 17 00:00:00 2001
From: Richard Shaffer
Date: Thu, 25 Jan 2018 19:54:59 -0800
Subject: [PATCH] fate: add id3v2 test
Adds basic unit test for parsing ID3v2 tags.
---
This follows the suggestion to use the ffprobe utility instead of a
t
Maybe a result of my mail client. Let me send from git send-email.
-Richard
On Thu, Jan 25, 2018 at 11:03 PM, Richard Shaffer wrote:
> From f7398407c1f5822e1536ce03d46c885b2ad00c38 Mon Sep 17 00:00:00 2001
> From: Richard Shaffer
> Date: Thu, 25 Jan 2018 19:54:59 -0800
> Subject:
LGTM, for whatever my opinion is worth.
Also easier to follow than the old code.
-Richard
On Tue, Jan 30, 2018 at 4:47 AM, wm4 wrote:
> On Tue, 30 Jan 2018 13:43:25 +0100
> wm4 wrote:
>
>> The ID3v2 "unsynchronization scheme" requires replacing any 0xFF 0x00
>> sequences with 0xFF. This has to
On Thu, Feb 1, 2018 at 10:18 PM, wm4 wrote:
> On Thu, 1 Feb 2018 18:44:34 -0800
> rshaf...@tunein.com wrote:
>
>> From: Richard Shaffer
>>
>> If a subdemuxer has the updated metadata event flag set, the metadata is
>> copied
>> to the corresponding stream
On Thu, Feb 1, 2018 at 10:02 PM, wm4 wrote:
> On Thu, 1 Feb 2018 18:37:45 -0800
> rshaf...@tunein.com wrote:
>
>> From: Richard Shaffer
>>
>> While rare, ID3 tags may be inserted between ADTS frames. This change enables
>> parsing them and setting the approp
On Fri, Feb 2, 2018 at 5:52 AM, James Almer wrote:
> On 2/1/2018 11:37 PM, rshaf...@tunein.com wrote:
>> From: Richard Shaffer
>>
>> While rare, ID3 tags may be inserted between ADTS frames. This change enables
>> parsing them and setting the appropriate metadata upda
On Saturday, February 3, 2018, wm4 wrote:
> On Fri, 2 Feb 2018 12:59:45 -0800
> rshaf...@tunein.com wrote:
>
> > From: Richard Shaffer
> >
> > If a subdemuxer has the updated metadata event flag set, the metadata is
> copied
> > to the correspondin
Attaching sample file for the test.
-Richard
On Sat, Feb 3, 2018 at 11:24 PM, wrote:
> From: Richard Shaffer
>
> A basic test for demuxing raw AAC (ADTS) with ID3v2 tags.
> ---
> This is related to the patch 'libavformat/aac: Parse ID3 tags between ADTS
> frames
I did send the sample file and a unit test for this. If there are no
issues or other comments, would you guys be willing to merge it?
-Richard
On Fri, Feb 2, 2018 at 11:15 AM, Richard Shaffer wrote:
> On Fri, Feb 2, 2018 at 5:52 AM, James Almer wrote:
>> On 2/1/2018 11:37
don't want to be annoying
or overly persistent. However, if anyone has a little time to review
this and provide feedback or accept the changes, I'd appreciate it.
Thanks,
-Richard
On Wed, Feb 7, 2018 at 9:40 AM, Richard Shaffer wrote:
> I did send the sample file and a unit test
On Fri, Feb 9, 2018 at 1:21 PM, wm4 wrote:
> On Fri, 9 Feb 2018 12:54:29 -0800
> Richard Shaffer wrote:
>
>> I just wanted to send a final ping about this patch. While most
>> streams will not encounter the case that it addresses, those that do
>> will have a pretty ba
There was only one version of this one. Thanks for applying.
On Mon, Feb 12, 2018 at 1:17 PM, wm4 wrote:
> On Thu, 1 Feb 2018 18:37:45 -0800
> rshaf...@tunein.com wrote:
>
>> From: Richard Shaffer
>>
>> While rare, ID3 tags may be inserted between ADTS frames. Thi
On Fri, May 18, 2018 at 2:54 AM, wm4 wrote:
> On Thu, 17 May 2018 20:49:42 -0700
> rshaf...@tunein.com wrote:
>
> > From: Richard Shaffer
> >
> > The HLS demuxer will process any ID3 tags at the beginning of a segment
> in
> > order to obtain timestamp data
gt; From: Richard Shaffer
>
> The HLS demuxer will process any ID3 tags at the beginning of a segment in
> order to obtain timestamp data. However, when this data was parsed on a
> second
> or subsequent segment, the updated metadata would be discarded. This change
> preserves
On Fri, May 18, 2018 at 4:09 PM, wrote:
> From: Richard Shaffer
>
> The HLS demuxer will process any ID3 tags at the beginning of a segment in
> order to obtain timestamp data. However, when this data was parsed on a
> second
> or subsequent segment, the updated metadata
36 matches
Mail list logo
