Re: [FFmpeg-devel] [PATCH] avutil: Rename RSHIFT macro to ROUNDED_RSHIFT

2019-01-26 Thread Peter Ross
On Sat, Jan 26, 2019 at 02:46:59PM -0500, FeRD wrote: > On Tue, Jan 22, 2019 at 8:15 AM Moritz Barsnick wrote: > > > On Mon, Jan 21, 2019 at 21:32:46 -0500, FeRD wrote: > > > Well... not *purely* cosmetic. See [1] for an example of one issue. > > Ruby's > > > > > `ruby/config.h` header also defin

Re: [FFmpeg-devel] fate/proresenc_aw : Add fate test for interlace and 444 encoding

2019-03-08 Thread Peter Ross
On Fri, Mar 08, 2019 at 12:11:47AM +0100, Martin Vignali wrote: > >> Can you check that and fix it? > >> > >> > > > Patch in attach fix for me vsynth3 interlace prores test : > make fate-vsynth3-prores_int;make fate-vsynth3-prores_444_int > > Pass fate test for me (os x X86_64) with and without >

Re: [FFmpeg-devel] [PATCH 3/7] electronicarts: prevent overflow during block alignment calculation

2016-12-15 Thread Peter Ross
looks good. On Fri, Dec 16, 2016 at 03:33:26AM +0100, Andreas Cadhalpun wrote: > Signed-off-by: Andreas Cadhalpun > --- > libavformat/electronicarts.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c > index 30eb723..9088fe1 10

Re: [FFmpeg-devel] [Vote] Code of Conduct

2016-05-22 Thread Peter Ross
On Sat, May 21, 2016 at 04:10:39PM +0200, Michael Niedermayer wrote: > On Wed, May 18, 2016 at 08:40:07PM +0200, Michael Niedermayer wrote: > > This is the version i had in my pending branch and should be the last > > version of the Code of Conduct from march, IIRC there where no further > > comm

[FFmpeg-devel] [PATCH] avformat/wtvdec: seek over broken chunks

2014-08-28 Thread Peter Ross
Fixes ticket #3898 Signed-off-by: Peter Ross --- libavformat/wtvdec.c | 29 +++-- 1 file changed, 27 insertions(+), 2 deletions(-) diff --git a/libavformat/wtvdec.c b/libavformat/wtvdec.c index c70057c..4cb3295 100644 --- a/libavformat/wtvdec.c +++ b/libavformat

Re: [FFmpeg-devel] [PATCH] added synchronous KLV codec ID and mpegts PAT and PMT descriptors as specified in stanag4609 annex C

2014-08-30 Thread Peter Ross
On Fri, Aug 29, 2014 at 02:24:21PM +0200, paolovergori wrote: > --- > libavcodec/avcodec.h| 17 + > libavcodec/codec_desc.c | 6 ++ > libavformat/mpegts.c| 2 ++ > libavformat/mpegts.h| 1 + > libavformat/mpegtsenc.c | 27 +++ > 5 files ch

[FFmpeg-devel] [PATCH] libavformat/iff: print error message when DSDIFF compression type is not supported

2014-09-25 Thread Peter Ross
Signed-off-by: Peter Ross --- libavformat/iff.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/libavformat/iff.c b/libavformat/iff.c index 8e20303..e7c240c 100644 --- a/libavformat/iff.c +++ b/libavformat/iff.c @@ -285,7 +285,13 @@ static int parse_dsd_prop

Re: [FFmpeg-devel] Please help update tasks and mentor/backups for OPW

2014-09-26 Thread Peter Ross
On Thu, Sep 25, 2014 at 02:20:21PM -0300, Reynaldo H. Verdejo Pinochet wrote: > If you were listed as a mentor please update your availability > and/or willingness status on the wiki. If you were listed as a > backup mentor for a mentorless project, please consider becoming > a full fledged mentor

[FFmpeg-devel] [RFC] Direct Stream Transfer (DST) decoder

2014-09-30 Thread Peter Ross
Signed-off-by: Peter Ross --- DST (described in 14496 Part 3 Subpart 10) is the lossless compression standard for DSD samples. My implementation is ~45% faster than the reference decoder. Even so, single threaded decoding is still very demanding and there does not appear to much scope for SIMD

Re: [FFmpeg-devel] [PATCH]Stop demuxing wtv on eof

2014-10-01 Thread Peter Ross
On Wed, Oct 01, 2014 at 06:18:56PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes the wtv regression described in tickets #3991 and #3995 > for me. > > Please review, Carl Eugen > diff --git a/libavformat/wtvdec.c b/libavformat/wtvdec.c > index 4cb3295..674ff6e 100644 > --- a/lib

Re: [FFmpeg-devel] [RFC] Direct Stream Transfer (DST) decoder

2014-10-06 Thread Peter Ross
Thanks for the review (also thanks compn). I will address all your comments -- some further questions below: On Tue, Sep 30, 2014 at 09:00:12PM +0200, Reimar Döffinger wrote: > On Tue, Sep 30, 2014 at 11:42:20PM +1000, Peter Ross wrote: > > +/** > > + * Calculate FS44 ratio > &

Re: [FFmpeg-devel] FFmpeg IRC meeting October 4th 2014, UTC 16

2014-10-07 Thread Peter Ross
On Mon, Oct 06, 2014 at 03:47:00PM +0200, Stefano Sabatini wrote: > On date Saturday 2014-10-04 17:45:32 +0200, Stefano Sabatini encoded: > [...] > > The meeting will happen in a few minutes, 16 UTC, on the freenode IRC > > channel #ffmpeg-meeting. Please join if interested. > > > > Topics of the

Re: [FFmpeg-devel] [PATCH 5/7] avcodec/dsddec: Fix decoding LSBF samples

2024-04-02 Thread Peter Ross
On Tue, Apr 02, 2024 at 03:37:06AM +0200, Andreas Rheinhardt wrote: > ff_dsd2pcm_translate() works internally by converting LSBF input > to MSBF upon reading; its buffer is therefore always MSBF > and should therefore be initialized with MSBF silence; > but this is not true since e3d8963c3cb5b8cd31

[FFmpeg-devel] [PATCH] av_tx_init: accept NULL scale for RDFT

2024-02-14 Thread Peter Ross
Make av_tx_init() agree with documentation: * Real to complex and complex to real DFTs. * For the float and int32 variants, the scale type is 'float', while for * the double variant, it's a 'double'. If scale is NULL, 1.0 will be used * as a default. --- libavutil/tx.c | 4 ++-

Re: [FFmpeg-devel] [PATCH] lead: support unaligned blocks

2024-02-15 Thread Peter Ross
On Sun, Nov 12, 2023 at 11:40:26AM +1100, Peter Ross wrote: > Fixed ticket #10656. > --- > libavcodec/leaddec.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/leaddec.c b/libavcodec/leaddec.c > index ede52fba5a..fd2018256d 1006

Re: [FFmpeg-devel] [PATCH] lead: support format 0x0

2024-02-15 Thread Peter Ross
On Sun, Nov 12, 2023 at 11:41:23AM +1100, Peter Ross wrote: > Fixes ticket #10660. > --- > > thanks to the mysterious 'ami_stuff'. > > libavcodec/leaddec.c | 38 ++ > 1 file changed, 26 insertions(+), 12 deletions(-) > >

Re: [FFmpeg-devel] [PATCH] avutil/tx: Use proper default scale for double MDCT/RDFT

2024-02-17 Thread Peter Ross
On Sat, Feb 17, 2024 at 08:44:47PM +0100, Andreas Rheinhardt wrote: > Fixes a bug and a Clang warning: > "use of logical '||' with constant operand [-Wconstant-logical-operand]" > > Signed-off-by: Andreas Rheinhardt > --- > libavutil/tx.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-)

[FFmpeg-devel] [PATCH 1/3] avformat/rmdec: support RMHD file format

2024-03-02 Thread Peter Ross
Signed-off-by: Peter Ross --- libavformat/rmdec.c | 43 ++- 1 file changed, 30 insertions(+), 13 deletions(-) diff --git a/libavformat/rmdec.c b/libavformat/rmdec.c index 0f1534b582..e7f2480464 100644 --- a/libavformat/rmdec.c +++ b/libavformat/rmdec.c

[FFmpeg-devel] [PATCH 3/3] fate: rv60 test cases

2024-03-02 Thread Peter Ross
--- samples: https://pross.sdf.org/sandpit/test72x72.rmhd (32 KiB) https://pross.sdf.org/sandpit/test512x512.rmhd (64 KiB) tests/fate/video.mak| 8 tests/ref/fate/rv60-512x512 | 9 + tests/ref/fate/rv60-72x72 | 40 + 3 files chang

Re: [FFmpeg-devel] [PATCH 1/2] avradio/sdr: add Airband frequencies

2023-08-14 Thread Peter Ross
On Mon, Aug 14, 2023 at 03:42:53PM +0200, Michael Niedermayer wrote: > On Sat, Jul 29, 2023 at 11:46:56AM +1000, Peter Ross wrote: > > --- > > libavradio/sdrdemux.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/libavradio/sdrdemux.c b/libavradi

Re: [FFmpeg-devel] Question about ffmpeg support of sph files with embedded-shorten-v2.00 coding

2023-08-29 Thread Peter Ross
On Tue, Aug 29, 2023 at 12:45:57PM -0400, Don Resnik wrote: > ffmpeg, > > I have a sph file that ffmpeg will not process. I am using ffmpeg 6.0, > which I believe is the latest version. I am actually running ffprobe on > the file. > > Here is the file header: ... > and here is the output: >

Re: [FFmpeg-devel] [PATCH 1/5] avformat/wtvdec: Don't truncate GUIDs

2023-09-12 Thread Peter Ross
On Tue, Sep 12, 2023 at 02:27:17PM +0200, Andreas Rheinhardt wrote: > Each of the 16 bytes of a GUID is written as a two-character > hex value and three hyphens, leading to a length of 35. > GCC 13 emits a -Wformat-truncation= warning because of this. > > Signed-off-by: Andreas Rheinhardt > --- >

[FFmpeg-devel] [PATCH] avradio/avdevice/sdrindev: -sdr_ant option

2023-09-21 Thread Peter Ross
Signed-off-by: Peter Ross --- For use with uhd device with run-time selectable antenna jack. libavdevice/sdrindev.c | 3 +++ libavformat/sdr.h | 1 + libavformat/sdrdemux.c | 1 + 3 files changed, 5 insertions(+) diff --git a/libavdevice/sdrindev.c b/libavdevice/sdrindev.c index

Re: [FFmpeg-devel] [PATCH 1/2] avformat/iff: Check data_size not overflowing int64

2020-09-27 Thread Peter Ross
On Sun, Sep 27, 2020 at 10:20:52PM +0200, Michael Niedermayer wrote: > Fixes: Infinite loop > Fixes: > 25844/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5660803318153216 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-of

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: do not abort decoding if strips are available

2020-10-03 Thread Peter Ross
On Fri, Oct 02, 2020 at 12:18:49PM +0200, Paul B Mahol wrote: > Even if such files are invalid, they can be decoded just fine. > Also stored tiles may have bigger dimensions than displayed ones, > so do not abort decoding in such cases. > > Signed-off-by: Paul B Mahol > --- > libavcodec/tiff.c |

[FFmpeg-devel] [PATCH] FATE/dnn: only run unit test when CONFIG_DNN enabled

2020-10-08 Thread Peter Ross
Signed-off-by: Peter Ross --- tests/fate/dnn.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/dnn.mak b/tests/fate/dnn.mak index 90a1bb3cac..c5e458708e 100644 --- a/tests/fate/dnn.mak +++ b/tests/fate/dnn.mak @@ -33,6 +33,6 @@ fate-dnn-layer-avgpool

[FFmpeg-devel] [PATCH 1/3] avformat/mspdec: Microsoft Paint (MSP) demuxer

2020-10-08 Thread Peter Ross
Signed-off-by: Peter Ross --- Week nine or so of lockdown... Changelog | 1 + doc/general_contents.texi | 2 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/mspdec.c | 95 +++ 5 files changed, 100

[FFmpeg-devel] [PATCH 2/3] avcodec/msp2dec: Microsoft Paint (MSP) version 2 decoder

2020-10-08 Thread Peter Ross
Signed-off-by: Peter Ross --- Changelog | 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + libavcodec/msp2dec.c| 100 libavformat/mspdec.c

[FFmpeg-devel] [PATCH 3/3] fate: add Microsoft Paint (MSP) test cases

2020-10-08 Thread Peter Ross
--- tests/fate/video.mak| 6 ++ tests/ref/fate/msp-msp1 | 6 ++ tests/ref/fate/msp-msp2 | 6 ++ 3 files changed, 18 insertions(+) create mode 100644 tests/ref/fate/msp-msp1 create mode 100644 tests/ref/fate/msp-msp2 diff --git a/tests/fate/video.mak b/tests/fate/video.mak index

Re: [FFmpeg-devel] [PATCH] avformat/isom: add support for RAW ASC Bayer BGGR in mov

2020-10-08 Thread Peter Ross
On Thu, Oct 08, 2020 at 07:25:33PM +0200, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavcodec/raw.c | 1 + > libavformat/isom.c | 2 ++ > 2 files changed, 3 insertions(+) > > diff --git a/libavcodec/raw.c b/libavcodec/raw.c > index b6fb91c1c6..079d5c5d10 100644 > --- a/libavco

Re: [FFmpeg-devel] [PATCH 4/5] avformat/icodec: Change order of operations to avoid NULL dereference

2020-10-16 Thread Peter Ross
On Fri, Oct 16, 2020 at 07:35:29PM +0200, Michael Niedermayer wrote: > Fixes: SEGV on unknown address 0x > Fixes: > 26379/clusterfuzz-testcase-minimized-ffmpeg_dem_ICO_fuzzer-5709011753893888 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/pr

Re: [FFmpeg-devel] [PATCH 2/4] avformat/wtvdec: Check dir_length

2020-10-19 Thread Peter Ross
On Mon, Oct 19, 2020 at 05:59:53PM +0200, Michael Niedermayer wrote: > Fixes: Infinite loop > Fixes: > 26445/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-5125558331244544 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-of

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/vp3: Fix memleak upon init failure

2020-10-20 Thread Peter Ross
On Tue, Oct 20, 2020 at 09:53:52AM +0200, Andreas Rheinhardt wrote: > Up until now, there was no cleanup in case initializing the Theora VLC > tables failed, leading to memleaks. This commit gets rid of them by > setting the FF_CODEC_CAP_INIT_CLEANUP flag for all decoders in vp3.c; > this also allo

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/vp3: Check allocations of VLCs

2020-10-20 Thread Peter Ross
On Tue, Oct 20, 2020 at 09:53:53AM +0200, Andreas Rheinhardt wrote: > It would lead to crashs lateron if they failed. did you find these automatically? have previously used this tool tool to find such errors: https://github.com/ralight/mallocfail > > Signed-off-by: Andreas Rheinhardt > --- >

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/vp3: Unify initializing and freeing VLC tables

2020-10-20 Thread Peter Ross
On Tue, Oct 20, 2020 at 09:53:54AM +0200, Andreas Rheinhardt wrote: > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vp3.c | 163 --- > libavcodec/vp3data.h | 22 ++ > libavcodec/vp4data.h | 22 ++ > 3 files changed, 55 insertions(+), 15

[FFmpeg-devel] [PATCHv2 1/2] avcodec/msp2dec: Microsoft Paint (MSP) version 2 decoder

2020-10-22 Thread Peter Ross
Signed-off-by: Peter Ross --- Changelog | 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 +++ libavcodec/codec_id.h | 1 + libavcodec/msp2dec.c| 102 6 files changed, 113

[FFmpeg-devel] [PATCHv2 2/2] avformat/mspdec: Microsoft Paint (MSP) demuxer

2020-10-22 Thread Peter Ross
Signed-off-by: Peter Ross --- Changelog | 1 + doc/general_contents.texi | 2 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/mspdec.c | 117 ++ 5 files changed, 122 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH 2/8] avformat/electronicarts: Check for EOF in each iteration of the loop in ea_read_packet()

2020-10-24 Thread Peter Ross
On Sun, Oct 25, 2020 at 12:23:06AM +0200, Michael Niedermayer wrote: > Fixes: timeout(>20sec -> 1ms) > Fixes: > 26526/clusterfuzz-testcase-minimized-ffmpeg_dem_EA_fuzzer-567232806912 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > S

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/vp3: Make parsing Theora Huffman tables more spec-compliant

2020-10-25 Thread Peter Ross
On Sun, Oct 25, 2020 at 09:02:25AM +0100, Andreas Rheinhardt wrote: > Andreas Rheinhardt: > > Theora allows to use custom Huffman tables which are coded in the > > bitstream as a tree: Whether the next node is a leaf or not is coded > > in a bit; each node itself contains a five bit token. Each tre

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/utils: Check sample rate before use for AV_CODEC_ID_BINKAUDIO_DCT in get_audio_frame_duration()

2020-10-27 Thread Peter Ross
On Tue, Oct 27, 2020 at 05:21:19PM +0100, Michael Niedermayer wrote: > Fixes: shift exponent 95 is too large for 32-bit type 'int' > Fixes: > 26590/clusterfuzz-testcase-minimized-ffmpeg_dem_SMACKER_fuzzer-5120609937522688 > > Signed-off-by: Michael Niedermayer > --- > libavcodec/utils.c | 5 +++

Re: [FFmpeg-devel] [PATCH 3/7] avformat/icodec: Factor failure code out in read_header()

2020-11-12 Thread Peter Ross
On Wed, Nov 04, 2020 at 01:06:45AM +0100, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/icodec.c | 12 ++-- > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/libavformat/icodec.c b/libavformat/icodec.c > index c061f3ec42..cf1e60815e

Re: [FFmpeg-devel] [PATCH 4/7] avformat/icodec: Check for zero streams and stream creation failure

2020-11-12 Thread Peter Ross
On Wed, Nov 04, 2020 at 01:06:46AM +0100, Michael Niedermayer wrote: > Fixes: NULL pointer dereference > Fixes: > 26814/clusterfuzz-testcase-minimized-ffmpeg_dem_ICO_fuzzer-5758487797432320 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 2/7] avcodec/vp3dsp: Use unsigned constant to avoid undefined integer overflow in ff_vp3dsp_set_bounding_values()

2020-11-12 Thread Peter Ross
On Tue, Nov 10, 2020 at 12:04:51AM +0100, Michael Niedermayer wrote: > Fixes: signed integer overflow: 64 * 33686018 cannot be represented in type > 'int' > Fixes: > 26911/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_THEORA_fuzzer-4904975073017856 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 100/114] avcodec/vp3: Use symbols table for VP3 motion vectors

2020-11-14 Thread Peter Ross
On Tue, Nov 10, 2020 at 11:58:22AM +0100, Andreas Rheinhardt wrote: > Expressions like array[get_vlc2()] can be optimized by using a symbols > table if the array is always the same for a given VLC. This requirement > is fulfilled for the VLC used for VP3 motion vectors. The reason it > hasn't been

Re: [FFmpeg-devel] [PATCH 100/114] avcodec/vp3: Use symbols table for VP3 motion vectors

2020-11-15 Thread Peter Ross
On Sun, Nov 15, 2020 at 06:37:25AM +0100, Andreas Rheinhardt wrote: > Peter Ross: > > On Tue, Nov 10, 2020 at 11:58:22AM +0100, Andreas Rheinhardt wrote: > >> Expressions like array[get_vlc2()] can be optimized by using a symbols > >> table if the array is always the

Re: [FFmpeg-devel] [PATCHv2 2/2] avformat/mspdec: Microsoft Paint (MSP) demuxer

2020-11-20 Thread Peter Ross
On Fri, Oct 23, 2020 at 11:53:03AM +1100, Peter Ross wrote: > Signed-off-by: Peter Ross > --- > Changelog | 1 + > doc/general_contents.texi | 2 + > libavformat/Makefile | 1 + > libavformat/allformats.c | 1 + > libavforma

Re: [FFmpeg-devel] [PATCH 02/18] avcodec/vp8: Disable lf_delta for VP7

2022-09-10 Thread Peter Ross
On Sat, Sep 10, 2022 at 03:07:13AM +0200, Andreas Rheinhardt wrote: > It is a VP8-only feature. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vp8.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c > index c00c5c975e..04a21

Re: [FFmpeg-devel] [PATCH 02/18] avcodec/vp8: Disable lf_delta for VP7

2022-09-11 Thread Peter Ross
On Sun, Sep 11, 2022 at 06:38:39AM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > On Sat, Sep 10, 2022 at 03:07:13AM +0200, Andreas Rheinhardt wrote: > >> It is a VP8-only feature. > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > >

Re: [FFmpeg-devel] [PATCH 8/9] avformat/icodec: Check nb_pal

2022-09-17 Thread Peter Ross
On Sat, Sep 17, 2022 at 11:15:56PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: 538976288 * 4 cannot be represented in type > 'int' > Fixes: > 50993/clusterfuzz-testcase-minimized-ffmpeg_dem_ICO_fuzzer-6690068904935424 > > Found-by: continuous fuzzing process > https://gi

[FFmpeg-devel] [PATCH] avcodec: ViewQuest VQC decoder

2022-10-06 Thread Peter Ross
1387d --- /dev/null +++ b/libavcodec/vqcdec.c @@ -0,0 +1,443 @@ +/* + * ViewQuest VQC decoder + * Copyright (C) 2022 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + *

[FFmpeg-devel] [PATCHv2] avcodec: ViewQuest VQC decoder

2022-10-08 Thread Peter Ross
c/vqcdec.c b/libavcodec/vqcdec.c new file mode 100644 index 00..5d1a03158c --- /dev/null +++ b/libavcodec/vqcdec.c @@ -0,0 +1,430 @@ +/* + * ViewQuest VQC decoder + * Copyright (C) 2022 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it a

[FFmpeg-devel] [PATCH] fate: vqc testcase

2022-10-08 Thread Peter Ross
--- please copy https://trac.ffmpeg.org/attachment/ticket/5601/samp1.avi to $FATE_SAMPLES/vqc/ tests/fate/video.mak | 3 +++ tests/ref/fate/vqc | 6 ++ 2 files changed, 9 insertions(+) create mode 100644 tests/ref/fate/vqc diff --git a/tests/fate/video.mak b/tests/fate/video.mak index

[FFmpeg-devel] [PATCH 1/2] avcodec/jpegtables: remove duplicate luma and chroma quantization tables

2022-10-13 Thread Peter Ross
Duplicates of the standard JPEG quantization tables were found in the AGM, MSS34(dsp), NUV and VP31 codecs. This patch elimates those duplicates, placing a single copy in jpegtables. --- configure | 6 -- libavcodec/agm.c| 27 +-- libavcodec/jpegt

[FFmpeg-devel] [PATCH 2/2] avcodec/vp3data: rectify comment

2022-10-13 Thread Peter Ross
--- they're actually one byte different. libavcodec/vp3data.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp3data.h b/libavcodec/vp3data.h index 317797a697..a347f492ad 100644 --- a/libavcodec/vp3data.h +++ b/libavcodec/vp3data.h @@ -25,7 +25,7 @@ #include

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/jpegtables: remove duplicate luma and chroma quantization tables

2022-10-14 Thread Peter Ross
On Fri, Oct 14, 2022 at 05:19:44PM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > Duplicates of the standard JPEG quantization tables were found in the > > AGM, MSS34(dsp), NUV and VP31 codecs. This patch elimates those duplicates, > > placing a single copy in jpe

[FFmpeg-devel] [PATCHv2] avcodec/jpegtables: remove duplicate luma and chroma quantization tables

2022-10-14 Thread Peter Ross
Duplicates of the standard JPEG quantization tables were found in the AGM, MSS34(dsp), NUV and VP31 codecs. This patch elimates those duplicates, placing a single copy in jpegquanttables.c. --- libavcodec/Makefile | 8 ++--- libavcodec/agm.c | 27 - libavcodec

Re: [FFmpeg-devel] [PATCHv2] avcodec: ViewQuest VQC decoder

2022-10-16 Thread Peter Ross
On Sun, Oct 09, 2022 at 11:36:09AM +1100, Peter Ross wrote: > Reviewed-by: Andreas Rheinhardt > Reviewed-by: Tomas Härdin > --- > > Thanks for reviews. All suggestions implemented. > > Changelog | 1 + > doc/general_contents.texi | 1 + > liba

[FFmpeg-devel] [PATCH] avcodec/svq1: fix interframe mean VLC symbols

2022-10-16 Thread Peter Ross
Fixes ticket #128. The SVQ1 interframe mean VLC symbols -128 and 128 are incorrectly swapped in our SVQ1 implementation, resulting in visible artifacts for some videos. This patch unswaps the order of these two symbols. The most noticable example of the artiacts caused by this error can be observ

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: fix interframe mean VLC symbols

2022-10-17 Thread Peter Ross
On Mon, Oct 17, 2022 at 05:04:29AM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > Fixes ticket #128. > > > > The SVQ1 interframe mean VLC symbols -128 and 128 are incorrectly swapped > > in our SVQ1 implementation, resulting in visible artifacts for some videos.

Re: [FFmpeg-devel] [PATCH] avcodec/svq1: fix interframe mean VLC symbols

2022-10-17 Thread Peter Ross
On Mon, Oct 17, 2022 at 10:38:53PM +0200, Michael Niedermayer wrote: > On Mon, Oct 17, 2022 at 08:33:28PM +1100, Peter Ross wrote: > > On Mon, Oct 17, 2022 at 05:04:29AM +0200, Andreas Rheinhardt wrote: > > > Peter Ross: > > > > Fixes ticket #128. > > >

[FFmpeg-devel] [PATCHv3] avcodec/jpegtables: remove duplicate luma and chroma quantization tables

2022-10-18 Thread Peter Ross
Duplicates of the standard JPEG quantization tables were found in the AGM, MSS34(dsp), NUV and VP31 codecs. This patch elimates those duplicates, placing a single copy in jpegquanttables.c. --- added FF_VISIBILITY_xxx_HIDDEN statements and removed suplus copyright text. libavcodec/Makefile

Re: [FFmpeg-devel] [PATCHv2] avcodec: ViewQuest VQC decoder

2022-10-18 Thread Peter Ross
On Tue, Oct 18, 2022 at 12:05:05PM +0200, Tomas Härdin wrote: > sön 2022-10-09 klockan 11:36 +1100 skrev Peter Ross: > > > > +    gamma = buf[0] >> 4; > > +    contrast = AV_RL16(buf + 2) >> 1; > > +    if (gamma || contrast) > > +    avpriv_reque

[FFmpeg-devel] [PATCHv2 1/4] avcodec/svq1: fix interframe mean VLC symbols

2022-10-19 Thread Peter Ross
Fixes ticket #128. The SVQ1 interframe mean VLC symbols -128 and 128 are incorrectly swapped in our SVQ1 implementation, resulting in visible artifacts for some videos. This patch unswaps the order of these two symbols. The most noticable example of the artiacts caused by this error can be observ

[FFmpeg-devel] [PATCHv2 2/4] avcodec/svq1enc: do not use ambiguous interframe mean symbols

2022-10-19 Thread Peter Ross
Don't emit interframe mean symbols -128 and 128 to maintain compatibility with older versions of FFmpeg that incorrectly interpret these symbols. --- libavcodec/svq1enc.c | 5 + tests/ref/seek/vsynth_lena-svq1 | 28 ++-- tests/ref/vsynth/vsynth1-svq1

[FFmpeg-devel] [PATCHv2 3/4] avcodec/svq1enc: output ident string in extradata field

2022-10-19 Thread Peter Ross
This will enable the acurate identification of FFmpeg produced SVQ1 streams, should there be new bugs found in the encoder. --- libavcodec/svq1enc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c index 9bd5a04368..6aacaef88d 100644 --- a/li

[FFmpeg-devel] [PATCHv2 4/4] avcodec/svq1dec: detect buggy FFmpeg encoder and apply correction to interframe mean symbols

2022-10-19 Thread Peter Ross
--- libavcodec/svq1dec.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/libavcodec/svq1dec.c b/libavcodec/svq1dec.c index 828b38b93d..c7269456e2 100644 --- a/libavcodec/svq1dec.c +++ b/libavcodec/svq1dec.c @@ -73,6 +73,8 @@ typedef struct SVQ1

Re: [FFmpeg-devel] [PATCHv2 3/4] avcodec/svq1enc: output ident string in extradata field

2022-10-20 Thread Peter Ross
On Wed, Oct 19, 2022 at 10:42:39PM -0300, James Almer wrote: > On 10/19/2022 10:30 PM, Peter Ross wrote: > > This will enable the acurate identification of FFmpeg produced > > SVQ1 streams, should there be new bugs found in the encoder. > > --- > > libavcodec/svq1enc.c

[FFmpeg-devel] [PATCH] avcodec/mss2: calculate draw region and revise split position

2022-10-20 Thread Peter Ross
for videos with wmv9 rectangles, the region drawn by ff_mss12_decode_rect may be less than the entire video area. the wmv9 rectangles are used to calculate the ff_mss12_decode_rect draw region. Fixes tickets #3255 and #4043 --- (will also fix identation as seperate commit on push) libavcodec/ms

Re: [FFmpeg-devel] [PATCH v2 02/24] avcodec/eamad: Don't use IDCTDSP-API unnecessarily

2022-10-21 Thread Peter Ross
On Fri, Oct 21, 2022 at 10:12:38PM +0200, Andreas Rheinhardt wrote: > The eamad decoder uses a custom IDCT and actually does not > use the IDCTDSP API at all. Somehow it was nevertheless > used to simply apply the identity permutation on ff_zigzag_direct. > This commit stops doing so. i think this

Re: [FFmpeg-devel] [PATCHv3] avcodec/jpegtables: remove duplicate luma and chroma quantization tables

2022-10-24 Thread Peter Ross
On Tue, Oct 18, 2022 at 08:06:02PM +1100, Peter Ross wrote: > Duplicates of the standard JPEG quantization tables were found in the > AGM, MSS34(dsp), NUV and VP31 codecs. This patch elimates those duplicates, > placing a single copy in jpegquanttables.c. > --- > added FF_VISIBI

Re: [FFmpeg-devel] [PATCH] avcodec/mss2: calculate draw region and revise split position

2022-10-24 Thread Peter Ross
On Thu, Oct 20, 2022 at 07:59:25PM +1100, Peter Ross wrote: > for videos with wmv9 rectangles, the region drawn by ff_mss12_decode_rect > may be less than the entire video area. the wmv9 rectangles are used to > calculate the ff_mss12_decode_rect draw region. > > Fixes tickets

[FFmpeg-devel] [PATCHv3 1/4] avcodec/svq1enc: do not use ambiguous interframe mean symbols

2022-10-25 Thread Peter Ross
Don't emit interframe mean symbols -128 and 128. --- v3 patch set changes: - reordered patchset - add stds fields around extradata codec ident - use Lavc codec ident when operating in bitexact mode libavcodec/svq1enc.c | 5 + tests/ref/seek/vsynth_lena-svq1 | 28 +

[FFmpeg-devel] [PATCHv3 2/4] avcodec/svq1enc: output ident string in extradata field

2022-10-25 Thread Peter Ross
This will enable the acurate identification of FFmpeg produced SVQ1 streams, should there be new bugs found in the encoder. --- libavcodec/svq1enc.c | 16 +++- tests/ref/vsynth/vsynth1-svq1 | 4 ++-- tests/ref/vsynth/vsynth2-svq1 | 4 ++-- tests/ref/vsynth/vsynth

[FFmpeg-devel] [PATCHv3 3/4] avcodec/svq1: fix interframe mean VLC symbols

2022-10-25 Thread Peter Ross
Fixes ticket #128. The SVQ1 interframe mean VLC symbols -128 and 128 are incorrectly swapped in our SVQ1 implementation, resulting in visible artifacts for some videos. This patch unswaps the order of these two symbols. The most noticable example of the artiacts caused by this error can be observ

[FFmpeg-devel] [PATCHv3 4/4] avcodec/svq1dec: detect buggy FFmpeg encoder and apply correction to interframe mean symbols

2022-10-25 Thread Peter Ross
--- libavcodec/svq1dec.c | 32 +++- 1 file changed, 23 insertions(+), 9 deletions(-) diff --git a/libavcodec/svq1dec.c b/libavcodec/svq1dec.c index 828b38b93d..c7269456e2 100644 --- a/libavcodec/svq1dec.c +++ b/libavcodec/svq1dec.c @@ -73,6 +73,8 @@ typedef struct SVQ1

[FFmpeg-devel] [PATCH] fate/microsoft: add mss2 region test case

2022-10-25 Thread Peter Ross
--- please copy https://trac.ffmpeg.org/raw-attachment/ticket/4043/fail.wmv to $FATE_SAMPLES/mss2 tests/fate/microsoft.mak | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/fate/microsoft.mak b/tests/fate/microsoft.mak index ee1a062425..edd42df8b3 100644 --- a/tests

Re: [FFmpeg-devel] Mono ADPCM for EA WVE Files / Fix Framerate

2024-07-19 Thread Peter Ross
On Fri, Jul 19, 2024 at 07:34:18AM -0400, redacted redacted wrote: > Hello there, > > The Sims 1: Unleashed makes use of WVE files for its intro videos. > Two of the files for the game use Mono ADPCM audio instead of Stereo. > However, FFmpeg's ADPCM_EA codec always expects the files to be in Ster

Re: [FFmpeg-devel] Mono ADPCM for EA WVE Files / Fix Framerate

2024-07-22 Thread Peter Ross
On Sat, Jul 20, 2024 at 10:19:18AM -0400, Aaron wrote: > On Fri, Jul 19, 2024 at 07:54:37PM -0400, Peter Ross wrote: > > > can you post a sample file somewhere > > Of course. Here are some you can try out: > > gm_us.wve: (Stereo - 15 FPS) https://0x0.st/X97A.wve >

[FFmpeg-devel] [PATCH] avcodec/adpcm: only process right samples when decoding stereo

2024-07-23 Thread Peter Ross
Fixes Coverity issue #1610760. --- libavcodec/adpcm.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c index afdbeaa15e..58f2ef0dfb 100644 --- a/libavcodec/adpcm.c +++ b/libavcodec/adpcm.c @@ -1684,22 +1684,24 @@ static int

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/adpcm: Remove setting min_channel to value it is already set to

2024-07-27 Thread Peter Ross
On Fri, Jul 26, 2024 at 11:08:32PM +0200, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/adpcm.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/libavcodec/adpcm.c b/libavcodec/adpcm.c > index 8f9a8a8c8e2..6c53d0bcf39 100644 > --- a/libavcodec/adpc

Re: [FFmpeg-devel] [PATCH 4/6] avformat/wtvdec: clear sectors

2024-08-06 Thread Peter Ross
On Wed, Aug 07, 2024 at 12:18:51AM +0200, Michael Niedermayer wrote: > The code can leave uninitialized holes in the array. > Fixes: use of uninitialized values > Fixes: > 70883/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-6698694567591936 > > Found-by: continuous fuzzing process > https

Re: [FFmpeg-devel] [PATCH 6/6] avformat/wtvdec: Check length of read mpeg2_descriptor

2024-08-06 Thread Peter Ross
On Wed, Aug 07, 2024 at 12:18:53AM +0200, Michael Niedermayer wrote: > Fixes: Use of uninitialized value > Fixes: > 70900/clusterfuzz-testcase-minimized-ffmpeg_dem_WTV_fuzzer-6286909377150976 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpe

[FFmpeg-devel] [PATCH] avcodec/eatgq: prevent out of bounds memory access and endless loop

2022-10-26 Thread Peter Ross
--- libavcodec/eatgq.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavcodec/eatgq.c b/libavcodec/eatgq.c index 89e9f20880..fdda8286ef 100644 --- a/libavcodec/eatgq.c +++ b/libavcodec/eatgq.c @@ -56,7 +56,7 @@ static av_cold int tgq_decode_init(AVCodecContext *a

[FFmpeg-devel] [PATCHv2] fate/microsoft: add mss2 region test case

2022-10-26 Thread Peter Ross
--- test file: https://trac.ffmpeg.org/attachment/ticket/3255/mss2_2.wmv (30 KiB) tests/fate/microsoft.mak | 3 ++- tests/ref/fate/mss2-region | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 tests/ref/fate/mss2-region diff --git a/tests/fate/microsoft.mak b/te

Re: [FFmpeg-devel] [PATCH] avcodec/eatgq: prevent out of bounds memory access and endless loop

2022-10-26 Thread Peter Ross
On Wed, Oct 26, 2022 at 01:41:57PM +0200, Andreas Rheinhardt wrote: > Peter Ross: > > --- > > libavcodec/eatgq.c | 10 +++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/libavcodec/eatgq.c b/libavcodec/eatgq.c > > index

[FFmpeg-devel] [PATCH] avcodec/mss2: initialise wmv9_mask variable

2022-10-27 Thread Peter Ross
initialised to -1 which indicates wmv9 codec not present --- libavcodec/mss2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mss2.c b/libavcodec/mss2.c index 69494d8c44..14746505f4 100644 --- a/libavcodec/mss2.c +++ b/libavcodec/mss2.c @@ -519,7 +519,7 @@ static in

[FFmpeg-devel] [PATCH] avcodec/svq3: perform residual slice copy before xor'ing watermark key

2022-10-27 Thread Peter Ross
Fixes ticket #5387 --- libavcodec/svq3.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavcodec/svq3.c b/libavcodec/svq3.c index 7e8f16cc72..b96c4f61f6 100644 --- a/libavcodec/svq3.c +++ b/libavcodec/svq3.c @@ -1037,15 +1037,16 @@ static int svq3_decode_slice_header(

Re: [FFmpeg-devel] [PATCHv3 1/4] avcodec/svq1enc: do not use ambiguous interframe mean symbols

2022-10-30 Thread Peter Ross
On Tue, Oct 25, 2022 at 08:17:04PM +1100, Peter Ross wrote: > Don't emit interframe mean symbols -128 and 128. > --- > > v3 patch set changes: > - reordered patchset > - add stds fields around extradata codec ident > - use Lavc codec ident when operating in bite

[FFmpeg-devel] [PATCH 2/3] fate/audio: msnsiren test case

2022-11-05 Thread Peter Ross
--- tests/fate/audio.mak | 5 + 1 file changed, 5 insertions(+) diff --git a/tests/fate/audio.mak b/tests/fate/audio.mak index 9d39eeace3..c733d8b7f4 100644 --- a/tests/fate/audio.mak +++ b/tests/fate/audio.mak @@ -45,6 +45,11 @@ fate-imc: CMD = pcm -i $(TARGET_SAMPLES)/imc/imc.avi fate-imc:

[FFmpeg-devel] [PATCH 3/3] fate/video: vqc testcase

2022-11-05 Thread Peter Ross
--- tests/fate/video.mak | 3 +++ tests/ref/fate/vqc | 6 ++ 2 files changed, 9 insertions(+) create mode 100644 tests/ref/fate/vqc diff --git a/tests/fate/video.mak b/tests/fate/video.mak index 40cdd9e3b6..af7e77e814 100644 --- a/tests/fate/video.mak +++ b/tests/fate/video.mak @@ -374,6 +

[FFmpeg-devel] [PATCH 1/3] fate/microsoft: add mss2 region test case

2022-11-05 Thread Peter Ross
--- posting here to test against patchwork tests/fate/microsoft.mak | 3 ++- tests/ref/fate/mss2-region | 7 +++ 2 files changed, 9 insertions(+), 1 deletion(-) create mode 100644 tests/ref/fate/mss2-region diff --git a/tests/fate/microsoft.mak b/tests/fate/microsoft.mak index ee1a062425

[FFmpeg-devel] [PATCH] avcodec: LEAD MCMP decoder

2022-11-11 Thread Peter Ross
Partially fixes ticket #798 --- sample: https://trac.ffmpeg.org/raw-attachment/ticket/798/DaDa_CMP.avi configure | 1 + doc/general_contents.texi | 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 1 + libavcodec/codec_desc.c | 7 + libavcodec/codec_i

Re: [FFmpeg-devel] [PATCH 1/3] avformat/electronicarts: fix EOF check

2022-11-16 Thread Peter Ross
On Sun, Nov 13, 2022 at 07:44:39PM +0100, Marton Balint wrote: > Similar to feof(), avio_feof() is only true after an actual overread. > > Signed-off-by: Marton Balint > --- > libavformat/electronicarts.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/elect

Re: [FFmpeg-devel] [PATCH 2/3] avformat/electronicarts: set packet_read in one place

2022-11-16 Thread Peter Ross
On Sun, Nov 13, 2022 at 07:44:40PM +0100, Marton Balint wrote: > Signed-off-by: Marton Balint > --- > libavformat/electronicarts.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/electronicarts.c b/libavformat/electronicarts.c > index 0a0d6249e8..0532264f

Re: [FFmpeg-devel] [PATCH 3/3] avformat/electronicarts: add option to return alpha channel in the main video stream in VP6A codec

2022-11-16 Thread Peter Ross
On Mon, Nov 14, 2022 at 11:05:44PM +0100, Marton Balint wrote: > > > On Mon, 14 Nov 2022, Anton Khirnov wrote: > > > Quoting Marton Balint (2022-11-13 19:44:41) > > > Signed-off-by: Marton Balint > > > --- > > > doc/demuxers.texi| 18 > > > libavformat/electronicar

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/vqcdec: Check for end of input in decode_vectors()

2022-11-18 Thread Peter Ross
On Fri, Nov 18, 2022 at 10:09:18PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 52695/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VQC_fuzzer-4882310386548736 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/pictordec: Check that the image fits in the input

2022-11-24 Thread Peter Ross
On Tue, Nov 22, 2022 at 11:56:51PM +0100, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 53438/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_PICTOR_fuzzer-5458939919859712 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpe > Signe

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/pictordec: Check that the image fits in the input

2022-11-25 Thread Peter Ross
On Fri, Nov 25, 2022 at 03:11:32PM +0100, Anton Khirnov wrote: > Quoting Michael Niedermayer (2022-11-25 14:38:46) > > t On Fri, Nov 25, 2022 at 05:45:29PM +1100, Peter Ross wrote: > > > On Tue, Nov 22, 2022 at 11:56:51PM +0100, Michael Niedermayer wrote: > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/pictordec: Remove mid exit branch

2022-11-25 Thread Peter Ross
On Fri, Nov 25, 2022 at 09:18:33PM +0100, Michael Niedermayer wrote: > This causes the RLE decoder to exit before applying the last RLE run > All images i tested with are unchanged, this makes the special case > for handling the last run unused for non truncated images. > > Signed-off-by: Michael

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/vqcdec: Check width & 15

2022-12-07 Thread Peter Ross
On Sun, Nov 27, 2022 at 11:34:34PM +0100, Michael Niedermayer wrote: > Various parts of the code assume that width can be divided by various powers > of 2 > without rounding > > Fixes: out of array access > Fixes: > 53623/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VQC_fuzzer-6209269924233

<    1   2   3   4   5   6   >