Re: [FFmpeg-devel] [PATCH] avformat/jvdec: Make sizeof(JVFrame) smaller to save memory

2021-09-23 Thread Peter Ross
*< palette size (bytes) */ > -int video_type;/**< per-frame video compression type */ > +uint16_t palette_size; /**< palette size (bytes) */ > +uint8_t video_type; /**< per-frame video compression type */ > } JVFrame; ok -- Peter (A907 E02F A6E5 0CD2 3

[FFmpeg-devel] [PATCH] avformat/img2dec: fix logic error in GEM Raster file probe

2022-01-20 Thread Peter Ross
Use correct logic to express limits of the planes and pattern_size fields. Fix ticket# 9605 Signed-off-by: Peter Ross --- libavformat/img2dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index 4d5ac51b53..2583ca2465

Re: [FFmpeg-devel] [PATCH 2/2] avformat/img2dec: add GEM Raster image demuxer

2022-01-22 Thread Peter Ross
On Sun, Jan 23, 2022 at 01:01:58AM +0100, Carl Eugen Hoyos wrote: > Am Fr., 17. Sept. 2021 um 10:39 Uhr schrieb Peter Ross : > > > +static int gem_probe(const AVProbeData *p) > > +{ > > +const uint8_t *b = p->buf; > > +int ret = 0; > > +if ( AV_R

[FFmpeg-devel] [PATCH] avformat/img2dec: increase probe score for fourcc variants

2022-01-24 Thread Peter Ross
Signed-off-by: Peter Ross --- libavformat/img2dec.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c index 2583ca2465..8608252d83 100644 --- a/libavformat/img2dec.c +++ b/libavformat/img2dec.c @@ -1112,7 +1112,6 @@ static

[FFmpeg-devel] [PATCH] avformat/utils: fix logic error in ff_mkdir_p

2022-01-24 Thread Peter Ross
Fix ticket# 9605 Signed-off-by: Peter Ross --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index e643821fc9..1164cebe68 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -1135,7 +1135,7 @@ int

Re: [FFmpeg-devel] [PATCH] avformat/img2dec: fix logic error in GEM Raster file probe

2022-02-01 Thread Peter Ross
On Fri, Jan 21, 2022 at 09:14:05AM +1100, Peter Ross wrote: > Use correct logic to express limits of the planes and pattern_size fields. > > Fix ticket# 9605 > > Signed-off-by: Peter Ross > --- > libavformat/img2dec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 dele

Re: [FFmpeg-devel] [PATCH] avformat/img2dec: increase probe score for fourcc variants

2022-02-01 Thread Peter Ross
On Tue, Jan 25, 2022 at 06:26:23PM +1100, Peter Ross wrote: > Signed-off-by: Peter Ross > --- > libavformat/img2dec.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/libavformat/img2dec.c b/libavformat/img2dec.c > index 2583ca2465..8608

Re: [FFmpeg-devel] [PATCH] avcodec/vp8: Remove always-false check

2022-02-08 Thread Peter Ross
FF_ARRAY_ELEMS(s->frames); i++) > av_frame_free(&s->frames[i].tf.f); looks good to me. please apply. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH] avcodec/vp6: return value check for av_mallocz

2022-02-08 Thread Peter Ross
memory leak, same as the av_frame_alloc() in > ff_vp56_init(). > > Fixes: 39a3894ad5 ("lavc/vp6: Implement "slice" threading for VP6A decode") > Signed-off-by: Jiasheng Jiang > --- > libavcodec/vp6.c | 4 > 1 file changed, 4 insertions(+) looks goo

Re: [FFmpeg-devel] [PATCH 1/6] avcodec/vp6: Check initializing VP6A context

2022-02-12 Thread Peter Ross
@@ const AVCodec ff_vp6a_decoder = { > .close = vp6_decode_free, > .decode = ff_vp56_decode_frame, > .capabilities = AV_CODEC_CAP_DR1 | AV_CODEC_CAP_SLICE_THREADS, > +.caps_internal = FF_CODEC_CAP_INIT_CLEANUP, > }; > -- > 2.32.0

Re: [FFmpeg-devel] [PATCH] avformat/utils: fix logic error in ff_mkdir_p

2022-02-12 Thread Peter Ross
On Tue, Jan 25, 2022 at 06:30:03PM +1100, Peter Ross wrote: > Fix ticket# 9605 > > Signed-off-by: Peter Ross > --- > libavformat/utils.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index e6

Re: [FFmpeg-devel] [PATCH] avcodec/vp3: Add missing check for av_malloc

2022-02-15 Thread Peter Ross
buffer) { > s->edge_emu_buffer = av_malloc(9 * > FFABS(s->current_frame.f->linesize[0])); > +if (!s->edge_emu_buffer) { > +ret = AVERROR(ENOMEM); > +goto error; > +} > +} > looks good to me. i wil

Re: [FFmpeg-devel] [PATCH] avcodec/binkaudio: add support for >2 channels dct codec

2022-03-19 Thread Peter Ross
ame, 0)) < 0) > >> -return ret; > >> +if (s->ch_offset == 0) { > >> +frame->nb_samples = s->frame_len; > >> +if ((ret = ff_get_buffer(avctx, frame, 0)) < 0) > >> +return ret; > >> +} >

[FFmpeg-devel] [PATCH] avcodec/binkaudio: fix indentation to match previous line

2022-03-22 Thread Peter Ross
/ count; + out[ch + ch_offset][i] * j) / count; } memcpy(s->previous[ch + ch_offset], &out[ch + ch_offset][s->frame_len - s->overlap_len], s->overlap_len * sizeof(*s->previous[ch + ch_off

[FFmpeg-devel] [PATCH] avformat/codec2: remove surplus include 'memory.h' statement

2022-03-22 Thread Peter Ross
..400c5acbdb 100644 --- a/libavformat/codec2.c +++ b/libavformat/codec2.c @@ -21,7 +21,6 @@ #include "config_components.h" -#include #include "libavcodec/codec2utils.h" #include "libavutil/channel_layout.h" #include "libavutil/intreadwrite.h" -- 2.35.1

Re: [FFmpeg-devel] [WIP] [PATCH v5 0/1] add Software Defined Radio support

2023-06-26 Thread Peter Ross
ce it with ff_kbd_window_init, observe FF_KBD_WINDOW_MAX assert in kbd_window_init. cheers, -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

[FFmpeg-devel] [PATCH] Adapted to the latest JPEG XL library version 0.9.0

2023-07-01 Thread Peter Kovář
Signed-off-by: Peter Kovář --- libavcodec/libjxldec.c | 17 + 1 file changed, 17 insertions(+) diff --git a/libavcodec/libjxldec.c b/libavcodec/libjxldec.c index 50417bcb02..bfff60769c 100644 --- a/libavcodec/libjxldec.c +++ b/libavcodec/libjxldec.c @@ -210,14 +210,23 @@ static

Re: [FFmpeg-devel] [PATCH] libavcodec/ansi: fix ECMA-48 SGR parameter 49

2023-07-11 Thread Peter Ross
i += 2; > } else if (m == 49) { > -s->fg = ansi_to_cga[DEFAULT_BG_COLOR]; > +s->bg = ansi_to_cga[DEFAULT_BG_COLOR]; Well spotted. Applied. -- Peter (A907 E02F A6E5 0CD2 34CD 20

[FFmpeg-devel] [PATCH 1/2] avradio/sdr: add Airband frequencies

2023-07-28 Thread Peter Ross
band" , "MW", 52, 160}, {"Shortwave band" , "SW", 600, 1800}, {"FM broadcast band", "FM", 8800, 10800}, +{"Aircraft band", "Airband", 10800, 13700}, }; ModulationDescrip

[FFmpeg-devel] [PATCH 2/2] avradio/sdr: ident band_descs

2023-07-28 Thread Peter Ross
000, 10800}, +{"Mediumwave band" , "MW", 52, 160}, +{"Shortwave band" , "SW",600, 1800}, +{"FM broadcast band", "FM", 8800, 10800}, {"Aircraft band", "Airband", 1080

[FFmpeg-devel] [PATCH] doc: describe QOI image format

2022-06-15 Thread Peter Ross
: @tab Photoshop @item PTX @tab @tab X @tab V.Flash PTX format +@item QOI @tab X @tab X +@tab Quite OK Image format @item SGI @tab X @tab X @tab SGI RGB image format @item Sun Rasterfile @tab X @tab X -- 2.35.1 -- Peter (A907 E02F A6E5 0CD2 34CD

[FFmpeg-devel] PowerPC e500v2: Build system patch needs to be reapplied

2022-06-30 Thread Peter Krefting
fixes it for me, so I would appreciate if the patch was re-applied. The alternative version that came in from libav in commit 54f7881615a5ce2f89283e7ac2015b8ef141537c does not seem to have any effect. -- \\// Peter - http://www.softwolves.pp.se

Re: [FFmpeg-devel] [PATCH 3/6] tools/target_dec_fuzzer: Adjust threshold for MMVIDEO

2022-07-20 Thread Peter Ross
ODEC_ID_LSCR:maxpixels /= 16;break; > +case AV_CODEC_ID_MMVIDEO: maxpixels /= 256; break; > case AV_CODEC_ID_MOTIONPIXELS:maxpixels /= 256; break; > case AV_CODEC_ID_MP4ALS: maxsamples /= 65536; break; > case AV_CODEC_ID_MSA1:maxpixels /= 16384; break

[FFmpeg-devel] [PATCH] WBMP (Wireless Application Protocol Bitmap) image format

2022-07-26 Thread Peter Ross
call LAVF_IMAGES,TIFF) += tiff FATE_LAVF_IMAGES-$(call LAVF_IMAGES, QOI) += qoi +FATE_LAVF_IMAGES-$(call LAVF_IMAGES,WBMP) += wbmp FATE_LAVF_IMAGES-$(call LAVF_IMAGES, XBM) += xbm FATE_LAVF_IMAGES-$(call LAVF_IMAGES, XWD) += xwd FATE_LAVF_IMAGES-$(cal

[FFmpeg-devel] [PATCHv2] avcodec: WBMP (Wireless Application Protocol Bitmap) image format

2022-07-29 Thread Peter Ross
TIFF) += tiff FATE_LAVF_IMAGES-$(call LAVF_IMAGES, QOI) += qoi +FATE_LAVF_IMAGES-$(call LAVF_IMAGES,WBMP) += wbmp FATE_LAVF_IMAGES-$(call LAVF_IMAGES, XBM) += xbm FATE_LAVF_IMAGES-$(call LAVF_IMAGES, XWD) += xwd FATE_LAVF_IMAGES-$(c

[FFmpeg-devel] [PATCHv3] avcodec: WBMP (Wireless Application Protocol Bitmap) image format

2022-08-07 Thread Peter Ross
Reviewed-by: Andreas Rheinhardt Signed-off-by: Peter Ross --- flipped fate ref file order, due to 4fb8741c4670965eaf1f78d6122c6bdfdf1f3358 submitting to patchwork before push Changelog | 1 + doc/general_contents.texi | 2 + libavcodec/Makefile | 2 + libavcodec

[FFmpeg-devel] [PATCH 1/2] avformat/ildadec: ILDA Image Data Transfer Format demuxer

2022-08-22 Thread Peter Ross
Signed-off-by: Peter Ross --- sample: 'ftp://ftp.photonlexicon.com/public/Laser Shows/ILDA Frames/wim.ild' doc/general_contents.texi | 1 + libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/ildadec.c | 137 +

[FFmpeg-devel] [PATCH 2/2] avcodec/ildadec: ILDA Image Data Transfer Format decoder

2022-08-22 Thread Peter Ross
Signed-off-by: Peter Ross --- libavcodec/Makefile | 1 + libavcodec/allcodecs.c | 1 + libavcodec/codec_desc.c | 7 + libavcodec/codec_id.h | 1 + libavcodec/ildadec.c| 297 5 files changed, 307 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/utils: use 32pixel alignment for bink

2023-01-26 Thread Peter Ross
acroblock > h_align = 16 * 2; // interlaced needs 2 macroblocks height > +if (s->codec_id == AV_CODEC_ID_BINKVIDEO) > +w_align = 16*2; > break; > case AV_PIX_FMT_YUV411P: > case AV_PIX_FMT_YUVJ411P: please apply. -- Peter (A907 E02F A6

[FFmpeg-devel] [PATCH] fate: Add test for wav Peak Envelope Chunk encoder (levl, chunk).

2014-07-18 Thread Peter B.
s possible. Regards, Pb >From bec0905cc5b896a287d8e0953c9931e41a62972d Mon Sep 17 00:00:00 2001 From: Peter B Date: Thu, 17 Jul 2014 18:51:38 +0200 Subject: [PATCH] fate: Add test for wav Peak Envelope Chunk encoder (levl chunk). --- tests/fate/avformat.mak |2 ++ tests/lavf-regression.

Re: [FFmpeg-devel] [PATCH] fate: Add test for wav Peak Envelope Chunk encoder (levl, chunk).

2014-07-18 Thread Peter B.
On 07/18/2014 07:40 PM, Michael Niedermayer wrote: > applied Thanks! Pb ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 01/16] web: Modernize with Bower, Bootstrap, LESS

2014-07-25 Thread Peter Ross
on the screen?) Looks great otherwise. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: Digital signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] avcodec/vp56: decode interlace content

2024-10-08 Thread Peter Ross
, 11, +12, 12, 13, 13, 14, 12, 11, 9, + 7, 9, 11, 12, 14, 14, 14, 15, + 13, 11, 13, 15, 15, 15, 15, 15, +}; + static const uint8_t vp6_def_runv_coeff_model[2][14] = { { 198, 197, 196, 146, 198, 204, 169, 142, 130, 136, 149, 149, 191, 249 }, { 135, 201, 181, 154, 98, 117, 132, 12

[FFmpeg-devel] [PATCHv2 2/2] fate/vp60-interlace: add test

2024-10-18 Thread Peter Ross
, 3072, 0x6612f4d1 +0,147,147,1, 3072, 0x9874c583 +0,148,148,1, 3072, 0xcde3c709 +0,149,149,1, 3072, 0x275dcc64 +0,150,150,1, 3072, 0x4261d055 -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD

[FFmpeg-devel] [PATCHv2 1/2] avcodec/vp56: decode interlace content

2024-10-18 Thread Peter Ross
er[] = { 14, 14, 15, 15, 15, 15, 15, 15, }; +static const uint8_t vp6_il_coeff_reorder[] = { + 0, 1, 0, 1, 1, 2, 5, 3, + 2, 2, 2, 2, 4, 7, 8, 10, + 9, 7, 5, 4, 2, 3, 5, 6, + 8, 9, 11, 12, 13, 12, 11, 10, + 9, 7, 5, 4, 6, 7, 9, 11, +12, 12, 13, 13, 14,

[FFmpeg-devel] [PATCH] avcodec/eatgq: decode motion vector macroblocks

2024-10-20 Thread Peter Ross
x->priv_data; +av_frame_free(&s->last_frame); +return 0; +} + const FFCodec ff_eatgq_decoder = { .p.name = "eatgq", CODEC_LONG_NAME("Electronic Arts TGQ video"), @@ -255,6 +296,7 @@ const FFCodec ff_eatgq_decoder = {

[FFmpeg-devel] [PATCH 2/2] avcodec/rv60: check init_get_bits8 return value

2024-11-05 Thread Peter Ross
_frame_header(s, &gb, &width, &height)) < 0) return ret; -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://

[FFmpeg-devel] [PATCH 1/2] avcodec/rv60: negative qp guard

2024-11-05 Thread Peter Ross
qp); memset(thread.coded_blk, 0, sizeof(thread.coded_blk)); -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmp

[FFmpeg-devel] [PATCHv2] avcodec/eatgq: decode motion vector macroblocks

2024-11-05 Thread Peter Ross
Signed-off-by: Peter Ross --- added missing reference frame check. will apply soon. libavcodec/codec_desc.c | 2 +- libavcodec/eatgq.c | 54 ++--- 2 files changed, 51 insertions(+), 5 deletions(-) diff --git a/libavcodec/codec_desc.c b/libavcodec

Re: [FFmpeg-devel] [PATCHv2 1/2] avcodec/vp56: decode interlace content

2024-10-25 Thread Peter Ross
On Fri, Oct 18, 2024 at 07:53:55PM +1100, Peter Ross wrote: > Modification of patch submitted by Aurelien Jacobs (November 2007). > > Fixes ticket #5581. > --- > v2: vp56_mc() modified to reproduce behaviour of reference VP6 decoder > > libavcodec/vp5.c | 5 +---

Re: [FFmpeg-devel] [PATCHv3] avcodec/rv60: RealVideo 6.0 decoder

2024-10-25 Thread Peter Ross
On Tue, Oct 01, 2024 at 12:59:30PM +1000, Peter Ross wrote: > Reviewed-by: Anton Khirnov > Reviewed-by: Andreas Rheinhardt > Signed-off-by: Peter Ross > --- > > Have addressed all comments from earlier post (March 2024) > (https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2

[FFmpeg-devel] [PATCH 2/2] avcodec/rv60: simplify fill_mv_skip_cand

2024-11-10 Thread Peter Ross
mp;s->blk_info[cu->blk_pos + s->blk_stride * mv_size - 1].mv); +if (cu->xpos) +add_if_valid(skip_cand, &s->blk_info[cu->blk_pos + s->blk_stride * (mv_size - 1) - 1].mv); +if (cu->ypos) +add_if_valid(skip_cand, &s->blk_info[cu->blk_pos - s->

[FFmpeg-devel] [PATCH 1/2] avcodec/rv60: loosen fill_mv_skip_cand top right and bottom left criteria

2024-11-10 Thread Peter Ross
mp; cu->ypos + size < s->aheight) { const MVInfo * mv = &s->blk_info[cu->blk_pos + s->blk_stride * mv_size - 1].mv; if (mvinfo_valid(mv)) unique_list_mvinfo_add(skip_cand, *mv); -- 2.45.2 -- Peter (A907 E02F

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/rv60: prevent decode_cu_r segfault

2024-11-06 Thread Peter Ross
return AVERROR_INVALIDDATA; s->slice[i].data = avpkt->data + header_size + ofs; s->slice[i].data_size = FFMIN(s->slice[i].size, avpkt->size - header_size - ofs); ofs += s->slice[i].size; -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/rv60: prevent decode_cu_r deadlock

2024-11-06 Thread Peter Ross
,7 +2295,7 @@ static int decode_slice(AVCodecContext *avctx, void *tdata, int cu_y, int thread if (s->avctx->active_thread_type & FF_THREAD_SLICE) ff_thread_progress_report(&s->progress[cu_y], INT_MAX); -return 0; +return ret; } static int rv60_decode_frame(AV

[FFmpeg-devel] [PATCH] avcodec/rv60: align calc_sel_qp with reference decoder

2024-11-06 Thread Peter Ross
osvquant, int qp) { switch (osvquant) { case 0: return qp; -case 1: return qp < 25 ? qp + 5 : qp; +case 1: return qp <= 25 ? qp + 5 : qp; default: if (qp <= 18) return qp + 10; -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5

[FFmpeg-devel] [PATCH] configure: add rv60 decoder golomb dependency

2024-11-13 Thread Peter Ross
presso_decoder_deps="zlib" shorten_decoder_select="bswapdsp" sipr_decoder_select="lsp" -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 01/11] avformat/spdifenc: parse headers for audio codecs

2024-11-17 Thread Peter Ross
> tests/ref/fate/spdif-dca-master-core-remux | 2344 ++-- > 3 files changed, 1181 insertions(+), 1179 deletions(-) > > diff --git a/libavformat/spdifdec.c b/libavformat/spdifdec.c -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc De

[FFmpeg-devel] [PATCH 3/3] fate/qmage: add tests

2024-11-20 Thread Peter Ross
-w2_pass new file mode 100644 index 00..2fd7eed456 --- /dev/null +++ b/tests/ref/fate/qmage-w2_pass @@ -0,0 +1,6 @@ +#tb 0: 1/15 +#media_type 0: video +#codec_id 0: rawvideo +#dimensions 0: 32x32 +#sar 0: 0/1 +0, 0, 0,1, 2048, 0xb9fddd43 -- 2.45.2 -- Peter

[FFmpeg-devel] [PATCH 2/3] avformat/qmagedec: Quram Qmage demuxer

2024-11-20 Thread Peter Ross
+++ b/libavformat/qmagedec.c @@ -0,0 +1,244 @@ +/* + * Quram Qmage image format demuxer + * Copyright (c) 2024 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as

[FFmpeg-devel] [PATCH 1/3] avcodec/qmagedec: Quram Qmage decoder

2024-11-20 Thread Peter Ross
0644 index 00..8c3d6cbc60 --- /dev/null +++ b/libavcodec/qmagedec.c @@ -0,0 +1,836 @@ +/* + * Quram Qmage image format decoder + * Copyright (c) 2024 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the

Re: [FFmpeg-devel] [PATCH 2/2] libavcodec/sanm: fix XPAL handling

2024-11-20 Thread Peter Ross
tested this with few Outlaws SAN files. looks great. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-d

Re: [FFmpeg-devel] [PATCH] avformat/icodec: fix integer overflow with nb_pal

2024-11-24 Thread Peter Ross
+ 32, image->nb_pal); > > } > > > > -if (image->nb_pal > INT_MAX / 4 - 14 - 40) > > +if (image->nb_pal > INT_MAX / 4 - 14 - 40U) > > return AVERROR_INVALIDDATA; > > > > AV_WL32(buf - 4, 14 + 40 + im

[FFmpeg-devel] [PATCH] avcodec/ac4dec: process immersive stereo

2024-11-26 Thread Peter Ross
) +if (s->pinfo[i].presentation_version == 2) { +ssi->channel_mode = 1; /* immersive stereo */ +break; +} + if (ssi->channel_mode == 11 || ssi->channel_mode == 12 || ssi->channel_mode == 13 || -- 2.45.2 -- P

Re: [FFmpeg-devel] [PATCHv2 1/4] avcodec/mm: set audio pts proportionally to audio offset

2024-11-16 Thread Peter Ross
On Thu, Jun 27, 2024 at 08:08:14AM +1000, Peter Ross wrote: > --- > libavformat/mm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/mm.c b/libavformat/mm.c > index 23c025d852..a40b5c44bb 100644 > --- a/libavformat/mm.c > +++ b/liba

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/rv60dec: Check qp for intra

2024-12-01 Thread Peter Ross
is_intra = cu.cu_type == CU_INTRA; > +if (is_intra && qp >= 32) > +return AVERROR_INVALIDDATA; > cu_pos = ((xpos & 63) >> 3) + ((ypos & 63) >> 3) * 8; nice find by clusterfuzz. please appl

[FFmpeg-devel] [PATCH] avformat/mm: fix packets pts generation and add seek support

2024-12-01 Thread Peter Ross
Signed-off-by: Peter Ross --- Author: Paul B Mahol Date: Wed Jun 26 09:07:29 2024 +0200 libavformat/mm.c | 31 ++ tests/ref/fate/alg-mm | 62 +-- 2 files changed, 45 insertions(+), 48 deletions(-) diff --git a/libavformat/mm.c

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/rv60dec: Use get_bits_long()

2024-12-07 Thread Peter Ross
+int diff = get_bits_long(gb, nbits); > if (s->slice[i].sign) > last_size += diff; > else please apply -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffm

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/rv60dec: Check NEXT/LAST availability

2024-12-07 Thread Peter Ross
(s, frame->data, frame->linesize, s->last_frame[NEXT_PIC], > bx, by, bw, bh, mv.f_mv, 0); > break; > case MVREF_BREF: suggest also setting enum MVREF_NONE = 0 higher up in the file, so it is clear to readers these enums are ordered deliberately.

[FFmpeg-devel] [PATCH] avformat/iff: SndAnim decoding

2024-12-07 Thread Peter Ross
if (sta->codecpar->codec_tag == ID_DSD || iff->form_tag == ID_MAUD) { +ret = av_get_packet(pb, pkt, FFMIN(iff->body_end - pos, 1024 * sta->codecpar->block_align)); +} else if (sta->codecpar->codec_tag == ID_DST) { return read_dst_fr

Re: [FFmpeg-devel] [PATCH v2] Add SRV3 decoder/demuxer

2024-12-27 Thread Peter Ross
// TODO: Handle window styles > > > > use avpriv_report_missing_feature()? > > > > I can do that but it'll trigger on many subtitle files as it's > pretty commonly used, just doesn't usually change all that much > which is why it

[FFmpeg-devel] [PATCH] avformat/iff: ignore FVER tag when not processing DSD/DST files

2024-12-28 Thread Peter Ross
%d.%d.%d.%d\n",version >> 24, (version >> 16) & 0xFF, (version >> 8) & 0xFF, version & 0xFF); +if (!new_stream(s, &sta, &iff->audio_stream_index, AVMEDIA_TYPE_AUDIO)) +return AVERROR(ENOMEM); +sta->codecp

Re: [FFmpeg-devel] [PATCH 4/4] avformat/mlvdec: Check avio_read()

2024-12-25 Thread Peter Ross
gt; +int ret; > + > if (!value) { > avio_skip(pb, size); > return; > } > > -avio_read(pb, value, size); > -if (!value[0]) { > +ret = avio_read(pb, value, size); > +if (ret != size || !value[0]) { > av_free(v

Re: [FFmpeg-devel] [PATCH] configure: update copyright year

2025-01-01 Thread Peter Ross
ATADIR "$(eval c_escape $datadir)" > #define AVCONV_DATADIR "$(eval c_escape $datadir)" > #define CC_IDENT "$(c_escape ${cc_ident:-Unknown compiler})" FFmpeg turns 25 this year. please apply :) -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signa

[FFmpeg-devel] [PATCH] avformat/wtvenc: do not output negative 'third timestamp' field

2024-12-24 Thread Peter Ross
== AV_NOPTS_VALUE ? 0 : pkt->pts); avio_wl64(pb, 0); avio_wl64(pb, par->codec_type == AVMEDIA_TYPE_VIDEO && (pkt->flags & AV_PKT_FLAG_KEY) ? 1 : 0); avio_wl64(pb, 0); -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B)

Re: [FFmpeg-devel] [PATCH 5/6] avformat/iff: Check that we have a stream in read_dst_frame()

2025-02-08 Thread Peter Ross
vio_feof(pb)) { > chunk_pos = avio_tell(pb); > if (chunk_pos >= iff->body_end) > -- > 2.48.1 please apply, thanks. -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 6/6] avcodec/rv60dec: Initialize slice gb with actually allocated size

2025-02-08 Thread Peter Ross
].data, > s->slice[cu_y].size)) < 0) > +if ((ret = init_get_bits8(&gb, s->slice[cu_y].data, > s->slice[cu_y].data_size)) < 0) > return ret; > > for (int cu_x = 0; cu_x < s->cu_width; cu_x++) { nice find. please apply,

Re: [FFmpeg-devel] [PATCHv2] avcodec/leaddec: support format 0x1006

2025-02-05 Thread Peter Ross
On Sun, Jan 19, 2025 at 08:49:50PM +1100, Peter Ross wrote: > Fixes ticket #10658. > --- > > Tested with some different vertical resolution alignments. > > When the vertical resolution is not aligned to macroblock height, the > reference encoder & decoder performs buggy

[FFmpeg-devel] [PATCHv2] avcodec/g728dec: G.728 decoder

2025-02-05 Thread Peter Ross
00..f932a50f6c --- /dev/null +++ b/libavcodec/g728dec.c @@ -0,0 +1,220 @@ +/* + * G.728 decoder + * Copyright (c) 2025 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public +

[FFmpeg-devel] [PATCH 2/2] avformat/riff: map 0069 twocc to ADPCM IMA XBOX decoder

2024-12-11 Thread Peter Ross
c_id 1: adpcm_ima_xbox #sample_rate 1: 44100 #channel_layout_name 1: stereo 0, 0, 0,0, 1508, 0xefceba48 -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___

[FFmpeg-devel] [PATCH 1/2] avcodec: add ADPCM IMA XBOX decoder

2024-12-11 Thread Peter Ross
ID_ADPCM_IMA_XBOX: +if (bps != 4) +return 0; + tmp = blocks * ((ba - 4 * ch) / (bps * ch) * 8); +break; case AV_CODEC_ID_ADPCM_IMA_WAV: if (bps < 2 || bps > 5) return 0;

[FFmpeg-devel] [PATCHv2 1/2] avformat/iff: SndAnim decoding

2024-12-10 Thread Peter Ross
sta = s->streams[iff->audio_stream_index]; +if (sta->codecpar->codec_tag == ID_DSD || iff->form_tag == ID_MAUD) { +ret = av_get_packet(pb, pkt, FFMIN(iff->body_end - pos, 1024 * sta->codecpar->block_align)); +} else if (sta->codecpar->codec_t

[FFmpeg-devel] [PATCHv2 2/2] tests/fate/demux: IFF test case

2024-12-10 Thread Peter Ross
, 1586, 0xbee30464, F=0x0 -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

[FFmpeg-devel] [PATCH] configure: add iso_writer golomb dependency

2024-12-16 Thread Peter Ross
atsc_a53 golomb" +iso_writer_select="golomb" frame_thread_encoder_deps="encoders threads" iamfdec_deps="iamf" iamfdec_select="iso_media mpeg4audio" -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP sig

[FFmpeg-devel] [PATCH] avformat/Makefile: add iso_writer golomb_tab from shared library dependency

2024-12-18 Thread Peter Ross
)+= mpeg4audio_sample_rates.o SHLIBOBJS-$(CONFIG_HLS_DEMUXER) += ac3_channel_layout_tab.o SHLIBOBJS-$(CONFIG_IMAGE_JPEGXL_PIPE_DEMUXER)+= jpegxl_parse.o -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] configure: add iso_writer golomb dependency

2024-12-17 Thread Peter Ross
On Wed, Dec 18, 2024 at 02:28:26PM +0900, Lynne via ffmpeg-devel wrote: > > > On 16/12/2024 20:00, Peter Ross wrote: > > since commit fce0622d0b1f69a85fe8ce61e1189dd57a8b0fcc, libavformat/hevc.c > > depends on golomb vlc tables. > > --- > > i often build with -

[FFmpeg-devel] [PATCH 1/2] avformat/Makefile: include object files for image_vbn_pipe demuxer

2024-12-18 Thread Peter Ross
)+= img2dec.o img2.o +OBJS-$(CONFIG_IMAGE_VBN_PIPE_DEMUXER) += img2dec.o img2.o OBJS-$(CONFIG_IMAGE_WEBP_PIPE_DEMUXER)+= img2dec.o img2.o OBJS-$(CONFIG_IMAGE_XBM_PIPE_DEMUXER) += img2dec.o img2.o OBJS-$(CONFIG_IMAGE_XPM_PIPE_DEMUXER) += img2dec.o img2.o -- 2.45.2 -- Peter (A907 E02F

[FFmpeg-devel] [PATCH 2/2] avcodec/Makefile: include aom_film_grain.o file for h264_sei component

2024-12-18 Thread Peter Ross
)+= h2645_sei.o aom_film_grain.o \ dynamic_hdr_vivid.o -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/Makefile: add iso_writer golomb_tab from shared library dependency

2024-12-18 Thread Peter Ross
On Wed, Dec 18, 2024 at 05:21:33PM -0300, James Almer wrote: > On 12/18/2024 5:17 PM, Peter Ross wrote: > > --- > > libavformat/Makefile | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/Makefile b/libavformat/Makefile

[FFmpeg-devel] [PATCH 1/3] avformat/mlvdec: demux LJ92 huffman comressed frames

2024-12-12 Thread Peter Ross
, pkt, (st->codecpar->width * st->codecpar->height * st->codecpar->bits_per_coded_sample + 7) >> 3); } else { // AVMEDIA_TYPE_AUDIO if (space > UINT_MAX - 24 || size < (24 + space)) return AVERROR_INVALIDDATA; -- 2.45.2 -- Peter (A907 E02F

[FFmpeg-devel] [PATCH 2/3] avformat/mlvdec: process VERS block

2024-12-12 Thread Peter Ross
','U','L','L')) { } else if (type == MKTAG('M','L','V','I')) { /* occurs when MLV and Mnn files are concatenated */ -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description:

[FFmpeg-devel] [PATCH 3/3] avformat/mlvdec: skip over some other known block types

2024-12-12 Thread Peter Ross
'L','V','I')) { /* occurs when MLV and Mnn files are concatenated */ + } else if (type == MKTAG('R','A','W','C')) { } else { av_log(avctx, AV_LOG_INFO, "unsupported tag %s, size %u\n",

Re: [FFmpeg-devel] [PATCHv2 1/2] avformat/iff: SndAnim decoding

2024-12-19 Thread Peter Ross
On Wed, Dec 11, 2024 at 09:27:51AM +1100, Peter Ross wrote: > Fixes ticket #5553. > --- > Additional hardening thanks to target_dem_fuzzer.c > > libavformat/iff.c | 311 +++--- > 1 file changed, 210 insertions(+), 101 deletions(-) >

Re: [FFmpeg-devel] [PATCH 2/2] avformat/riff: map 0069 twocc to ADPCM IMA XBOX decoder

2024-12-20 Thread Peter Ross
On Thu, Dec 12, 2024 at 09:25:55AM +1100, Peter Ross wrote: > --- > Using AV_CODEC_ID_ADPCM_IMA_WAV for twocc 0x0069 causes subtle artefacts > during > playback. The correct decoder is AV_CODEC_ID_ADPCM_IMA_XBOX. > > Sample .wav and ref flac file: > <https://github.com/v

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/Makefile: include aom_film_grain.o file for h264_sei component

2024-12-20 Thread Peter Ross
On Sat, Dec 21, 2024 at 12:02:06AM +0200, Jan Ekström wrote: > On Thu, Dec 19, 2024 at 4:34 AM Peter Ross wrote: > > > > h264_sei depends on h2645_sei, which in turn depends on aom_film_grain for > > ff_aom_uninit_film_grain_params() > > Set LGTM. > > Thanks f

[FFmpeg-devel] [PATCH 0/3] Quram Qmage image decoder

2024-11-21 Thread Peter Ross
. Samples: https://www.mediafire.com/folder/sa1r8iprkckm7/Bootanimations Peter Ross (3): avcodec/qmagedec: Quram Qmage decoder avformat/qmagedec: Quram Qmage demuxer fate/qmage: add tests libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec

[FFmpeg-devel] [PATCH] avformat/mm: add fallthrough comment

2024-11-21 Thread Peter Ross
: av_log(s, AV_LOG_INFO, "unknown chunk type 0x%x\n", type); +/* fallthrough */ case MM_TYPE_AUDIO2 : avio_skip(pb, length); } -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP

[FFmpeg-devel] [PATCH 1/2] avcodec/leaddec: support format 0x6

2024-12-04 Thread Peter Ross
*avctx, AVFrame * frame, zero = 1; avctx->pix_fmt = AV_PIX_FMT_YUV420P; break; +case 0x6: case 0x8000: yuv20p_half = 1; // fall-through -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description:

[FFmpeg-devel] [PATCH 2/2] configure: add leaddec blockdsp dependency

2024-12-04 Thread Peter Ross
der_select="blockdsp" lagarith_decoder_select="llviddsp" -lead_decoder_select="idctdsp jpegtables" +lead_decoder_select="blockdsp idctdsp jpegtables" ljpeg_encoder_select="jpegtables" lscr_decoder_select="inflate_wrapper" magicyuv_decoder

[FFmpeg-devel] [PATCH 4/8] avcodec/g728dec: G.728 decoder

2025-01-11 Thread Peter Ross
dev/null +++ b/libavcodec/g728dec.c @@ -0,0 +1,213 @@ +/* + * G.728 decoder + * Copyright (c) 2025 Peter Ross + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as publis

[FFmpeg-devel] [PATCH 5/8] avformat/g728dec: raw G.728 demuxer

2025-01-11 Thread Peter Ross
0; +return ret; +} + +const FFInputFormat ff_g728_demuxer = { +.p.name = "g728", +.p.long_name= NULL_IF_CONFIG_SMALL("raw G.728"), +.p.extensions = "g728", +.p.flags= AVFMT_GENERIC_INDEX, +.read_header = g728_read_header, +

[FFmpeg-devel] [PATCH 8/8] avformat/rtp: G.728 muxing and demuxing

2025-01-11 Thread Peter Ross
V_CODEC_ID_RAWVIDEO: case AV_CODEC_ID_BITPACKED: +case AV_CODEC_ID_G728: return 1; default: return 0; -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature ___ ffmpeg-devel

[FFmpeg-devel] [PATCH 6/8] avformat/riff: G.728 muxing and demuxing

2025-01-11 Thread Peter Ross
par->codec_id == AV_CODEC_ID_G728 || par->codec_id == AV_CODEC_ID_MP2|| par->codec_id == AV_CODEC_ID_MP3|| par->codec_id == AV_CODEC_ID_GSM_MS) { -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Descr

[FFmpeg-devel] [PATCH 7/8] avformat/aiff: G.728 muxing and demuxing

2025-01-11 Thread Peter Ross
ormatContext *s, int64_t size, case AV_CODEC_ID_GSM: par->block_align = 33; break; +case AV_CODEC_ID_G728: +par->block_align = 5; +break; default: aiff->block_duration = 1; break; -- 2.45.2

[FFmpeg-devel] [PATCH 1/8] avcodec/g728_template: do_hybrid_window() template

2025-01-11 Thread Peter Ross
-do_hybrid_window(ractx, order, n, non_rec, temp, hist, rec, window); +do_hybrid_window(ractx->vector_fmul, order, n, non_rec, temp, hist, rec, window); if (!compute_lpc_coefs(temp, order, lpc, 0, 1, 1)) ractx->vector_fmul(lpc, lpc, tab, FFALIGN(order, 16)); -- 2.45.2

[FFmpeg-devel] [PATCH 0/8] G.728 decoding

2025-01-11 Thread Peter Ross
Sample: https://pross.sdf.org/sandpit/CW5.g728 Peter Ross (8): avcodec/g728_template: do_hybrid_window() template avcodec/g728_template: make hist parameter constant avcodec/lpc_functions: compute_lpc_coefs: add starting lpc order and err cache parameters avcodec/g728dec: G.728

[FFmpeg-devel] [PATCH 3/8] avcodec/lpc_functions: compute_lpc_coefs: add starting lpc order and err cache parameters

2025-01-11 Thread Peter Ross
, temp, hist, rec, window); -if (!compute_lpc_coefs(temp, order, lpc, 0, 1, 1)) +if (!compute_lpc_coefs(temp, 0, order, lpc, 0, 1, 1, NULL)) ractx->vector_fmul(lpc, lpc, tab, FFALIGN(order, 16)); memmove(hist, hist + n, move_size*sizeof(*hist)); -- 2.45.2 -- Peter (A907 E02

[FFmpeg-devel] [PATCH 2/8] avcodec/g728_template: make hist parameter constant

2025-01-11 Thread Peter Ross
float *window) + const float *hist, float *out2, const float *window) { int i; float buffer1[MAX_BACKWARD_FILTER_ORDER + 1]; -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Description: PGP signature

[FFmpeg-devel] [PATCHv2] avcodec/leaddec: support format 0x1006

2025-01-19 Thread Peter Ross
t;linesize[plane] + x, +(yuv20p_half && b < 2 ? 2 : 1) * fields * frame->linesize[plane]); if (ret < 0) return ret; -- 2.45.2 -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B) signature.asc Descr

Re: [FFmpeg-devel] [FFmpeg-cvslog] avformat/wtvdec: Initialize buf

2025-01-22 Thread Peter Ross
e understand why this is needed... the avio_read() call fills buf, and the call to ff_parse_mpeg2_descriptor specifies an "end" pointer (desc_list_end point) to prevent overreading. where is the uninitialised memory coming from? -- Peter (A907 E02F A6E5 0CD2 34CD 20D2 6760 79C5 AC40 DD6B

<    1   2   3   4   5   6   7   >