Re: [FFmpeg-devel] [PATCH] Avoid sending packets to network when multicast ttl is 0 in udp

2016-07-13 Thread Omid Ghaffarinia
AM, Moritz Barsnick wrote: > On Tue, Jul 12, 2016 at 18:31:36 +0430, Omid Ghaffarinia wrote: > > Your mailer has broken the patch by inserting line breaks. You should > try attaching the patch as a file, or directly using "git send-email". > >> Bug is due to kernel

Re: [FFmpeg-devel] [PATCH] Avoid sending packets to network when multicast ttl is 0 in udp

2016-07-19 Thread Omid Ghaffarinia
Is the patch approved or does it need more explanation? On Wed, Jul 13, 2016 at 3:09 PM, Omid Ghaffarinia wrote: > I attached the patch. > > The actual bug is, when creating a local multicast stream (i.e. giving > "rtp://224.1.1.1:1?ttl=0" to avio_open), then you can se

Re: [FFmpeg-devel] [PATCH] Avoid sending packets to network when multicast ttl is 0 in udp

2016-07-20 Thread Omid Ghaffarinia
Thanks for testing in mingw New patch attached, which should work now. On Wed, Jul 20, 2016 at 1:25 PM, Michael Niedermayer wrote: > On Wed, Jul 13, 2016 at 03:09:28PM +0430, Omid Ghaffarinia wrote: >> I attached the patch. >> >> The actual bug is, when creating a local

Re: [FFmpeg-devel] [PATCH] Avoid sending packets to network when multicast ttl is 0 in udp

2016-07-22 Thread Omid Ghaffarinia
I'm sorry for that, it failed because it was prepared for release/2.8, this one should work on master. On Thu, Jul 21, 2016 at 3:48 AM, Michael Niedermayer wrote: > On Wed, Jul 20, 2016 at 05:38:10PM +0430, Omid Ghaffarinia wrote: >> Thanks for testing in mingw >> New p

Re: [FFmpeg-devel] [PATCH] Avoid sending packets to network when multicast ttl is 0 in udp

2016-08-03 Thread Omid Ghaffarinia
Does it still fail? Thanks in advance. On Sat, Jul 23, 2016 at 10:36 AM, Omid Ghaffarinia wrote: > I'm sorry for that, it failed because it was prepared for release/2.8, > this one should work on master. > > > On Thu, Jul 21, 2016 at 3:48 AM, Michael Niedermayer > w

Re: [FFmpeg-devel] [PATCH] Avoid sending packets to network when multicast ttl is 0 in udp

2016-08-04 Thread Omid Ghaffarinia
ny further changes and then do the rest, but first patch would be redundant and does not actually fix anything. On Wed, Aug 3, 2016 at 10:04 PM, Michael Niedermayer wrote: > On Wed, Aug 03, 2016 at 12:29:17PM +0430, Omid Ghaffarinia wrote: >> Does it still fail? > > no failure >

Re: [FFmpeg-devel] [PATCH] Avoid sending packets to network when multicast ttl is 0 in udp

2016-08-07 Thread Omid Ghaffarinia
I made it into two patches, the first one only moves udp_set_multicast_ttl and second one does the fix. On Fri, Aug 5, 2016 at 3:19 AM, Michael Niedermayer wrote: > On Fri, Aug 05, 2016 at 01:20:12AM +0430, Omid Ghaffarinia wrote: >> Thanks for your comment, actually 'code move&#x

[FFmpeg-devel] [PATCH] Avoid sending packets to network when multicast ttl is 0 in udp

2016-07-12 Thread Omid Ghaffarinia
this host and route is valid). Luckily, this hack is good workaround. */ Signed-off-by: Omid Ghaffarinia --- libavformat/sdp.c |2 +- libavformat/udp.c | 28 2 files changed, 29 insertions(+), 1 deletion(-) diff --git a/libavformat/sdp.c b