[FFmpeg-devel] [PATCH] x11grab: fix vertical repositioning

2019-03-27 Thread Octavio Alvarez
There is a calculation error in xcbgrab_reposition() that breaks vertical repositioning on follow_mouse. It made the bottom reposition occur when moving the mouse lower than N pixels after the capture bottom edge, instead of before. This commit fixes the calculation to match the documentation. fo

Re: [FFmpeg-devel] [PATCH] x11grab: fix vertical repositioning

2019-04-01 Thread Octavio Alvarez
On 4/1/19 7:41 AM, Carl Eugen Hoyos wrote: >> The patch is untested, but it looks fairly straightforward. > > How can this patch be tested? ffmpeg -y -r 30 -f x11grab -show_region 1 -draw_mouse 0 -s 350x614 -follow_mouse 10 -i :0.0+0,0 -r 30 -preset ultrafast followcapture-test-.mkv A dotted fra

Re: [FFmpeg-devel] [PATCH] x11grab: fix vertical repositioning

2019-04-04 Thread Octavio Alvarez
On 4/1/19 11:17 AM, Octavio Alvarez wrote: > On 4/1/19 7:41 AM, Carl Eugen Hoyos wrote: >>> The patch is untested, but it looks fairly straightforward. >> >> How can this patch be tested? > > ffmpeg -y -r 30 -f x11grab -show_region 1 -draw_mouse 0 -s 350x614 > -