[FFmpeg-devel] [PATCH v8 07/13] vvcdec: add inv transform 1d

transform + * + * Copyright (C) 2023 Nuo Mi + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the

[FFmpeg-devel] [PATCH v8 06/13] vvcdec: add inter prediction

) 2022 Nuo Mi + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or (at your option) any

[FFmpeg-devel] [PATCH v8 10/13] vvcdec: add dsp init and inv transform

\ vvc/vvc_filter.o\ diff --git a/libavcodec/vvc/vvcdsp.c b/libavcodec/vvc/vvcdsp.c new file mode 100644 index 00..c82ea7be30 --- /dev/null +++ b/libavcodec/vvc/vvcdsp.c @@ -0,0 +1,141 @@ +/* + * VVC DSP + * + * Copyright (C) 2021 Nuo Mi

[FFmpeg-devel] [PATCH v8 08/13] vvcdec: add intra prediction

*lc, int x0, int y0, int w, int h); +void ff_vvc_decode_neighbour(VVCLocalContext *lc, int x_ctb, int y_ctb, int rx, int ry, int rs); +void ff_vvc_ctu_free_cus(CTU *ctu); void ff_vvc_ep_init_stat_coeff(EntryPoint *ep, int bit_depth, int persistent_rice_adaptation_enabled_flag); #endif // AVCODEC_

[FFmpeg-devel] [PATCH v8 12/13] vvcdec: add CTU thread logical

+ * + * Copyright (C) 2023 Nuo Mi + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or

[FFmpeg-devel] [PATCH v8 13/13] vvcdec: add vvc decoder

RitualDance_1920x1080_60_10_420_37_RA.266 133.0 Tango2_3840x2160_60_10_420_27_LD.26621.7 Asm optimizations still working in progress. please check https://github.com/ffvvc/FFmpeg/wiki#performance-data for the latest Contributors(based on code merge order): Nuo Mi Xu Mu frankplow Shaun

[FFmpeg-devel] [PATCH v8 11/13] vvcdec: add CTU parser

--- libavcodec/vvc/vvc_ctu.c | 2393 +- libavcodec/vvc/vvc_ctu.h | 11 + 2 files changed, 2403 insertions(+), 1 deletion(-) diff --git a/libavcodec/vvc/vvc_ctu.c b/libavcodec/vvc/vvc_ctu.c index 6138d2fc9f..dd3c8884cb 100644 --- a/libavcodec/vvc/vvc_ctu.c +++

[FFmpeg-devel] [PATCH v8 04/13] vvcdec: add reference management

..bf503e429e --- /dev/null +++ b/libavcodec/vvc/vvc_refs.c @@ -0,0 +1,559 @@ +/* + * VVC reference management + * + * Copyright (C) 2023 Nuo Mi + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General

[FFmpeg-devel] [PATCH v8 00/13] Add vvc decoder

an to push these changes in 3 days unless there are strong objections Thank you. Nuo Mi (13): vvcdec: add vvc_data vvcdec: add parameter parser for sps, pps, ph, sh vvcdec: add cabac decoder vvcdec: add reference management vvcdec: add motion vector decoder vvcdec: add inter predictio

Re: [FFmpeg-devel] [PATCH v8 13/13] vvcdec: add vvc decoder

Hi Martin and jb, Thank you for the review. On Sun, Dec 31, 2023 at 8:19 PM Jean-Baptiste Kempf wrote: > > > On Sun, 31 Dec 2023, at 12:07, Martin Storsjö wrote: > > On Sun, 31 Dec 2023, Nuo Mi wrote: > > > >> vvc decoder plug-in to avcodec. > >> split fr

Re: [FFmpeg-devel] [PATCH v8 01/13] vvcdec: add vvc_data

Hi Micheal, Thanks for your response. I can check the CI log, but I'm looking for ways to trigger the CI test before sending patches to the mailing list, aiming to prevent future issues." On Mon, Jan 1, 2024 at 5:43 AM Michael Niedermayer wrote: > On Sun, Dec 31, 2023 at 04:18:46

Re: [FFmpeg-devel] [PATCH v8 01/13] vvcdec: add vvc_data

On Mon, Jan 1, 2024 at 10:28 AM Nuo Mi wrote: > Hi Micheal, > Thanks for your response. > I can check the CI log, but I'm looking for ways to trigger the CI test > before sending patches to the mailing list, aiming to prevent future > issues." > I will check with An

[FFmpeg-devel] [PATCH v9 00/13] Add vvc decoder

Changes since v8: Fixed 'make clean' Used Frank's full name, as Martin suggested Added Co-authors, as jb suggested Included thanks to reviewers and issue reporters Nuo Mi (13): vvcdec: add vvc_data vvcdec: add parameter parser for sps, pps, ph, sh vvcdec: add cabac d

[FFmpeg-devel] [PATCH v9 02/13] vvcdec: add parameter parser for sps, pps, ph, sh

/vvc_ps.c new file mode 100644 index 00..ac96ed9f43 --- /dev/null +++ b/libavcodec/vvc/vvc_ps.c @@ -0,0 +1,1150 @@ +/* + * VVC parameter set parser + * + * Copyright (C) 2023 Nuo Mi + * Copyright (C) 2022 Xu Mu + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can

[FFmpeg-devel] [PATCH v9 03/13] vvcdec: add cabac decoder

\ vvc/vvc_ps.o\ diff --git a/libavcodec/vvc/vvc_cabac.c b/libavcodec/vvc/vvc_cabac.c new file mode 100644 index 00..4342dfc342 --- /dev/null +++ b/libavcodec/vvc/vvc_cabac.c @@ -0,0 +1,2478 @@ +/* + * VVC CABAC decoder + * + * Copyright (C) 2021 Nuo

[FFmpeg-devel] [PATCH v9 05/13] vvcdec: add motion vector decoder

nt h); void ff_vvc_ep_init_stat_coeff(EntryPoint *ep, int bit_depth, int persistent_rice_adaptation_enabled_flag); #endif // AVCODEC_VVC_VVC_CTU_H diff --git a/libavcodec/vvc/vvc_mvs.c b/libavcodec/vvc/vvc_mvs.c new file mode 100644 index 00..81e73fe746 --- /dev/null +++ b/libavcodec/vvc

[FFmpeg-devel] [PATCH v9 06/13] vvcdec: add inter prediction

@@ -0,0 +1,923 @@ +/* + * VVC inter prediction + * + * Copyright (C) 2022 Nuo Mi + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation

[FFmpeg-devel] [PATCH v9 04/13] vvcdec: add reference management

\ diff --git a/libavcodec/vvc/vvc_refs.c b/libavcodec/vvc/vvc_refs.c new file mode 100644 index 00..bf503e429e --- /dev/null +++ b/libavcodec/vvc/vvc_refs.c @@ -0,0 +1,559 @@ +/* + * VVC reference management + * + * Copyright (C) 2023 Nuo Mi + * + * This file is part of FFmpeg. + * + * FFmpeg

[FFmpeg-devel] [PATCH v9 08/13] vvcdec: add intra prediction

libavcodec/vvc/vvc_ctu.h @@ -461,6 +461,8 @@ typedef struct ALFParams { //utils void ff_vvc_set_neighbour_available(VVCLocalContext *lc, int x0, int y0, int w, int h); +void ff_vvc_decode_neighbour(VVCLocalContext *lc, int x_ctb, int y_ctb, int rx, int ry, int rs); +void ff_vvc_ctu_free_cus(CTU *ctu); void ff_vvc_ep_

[FFmpeg-devel] [PATCH v9 10/13] vvcdec: add dsp init and inv transform

--- /dev/null +++ b/libavcodec/vvc/vvcdsp.c @@ -0,0 +1,141 @@ +/* + * VVC DSP + * + * Copyright (C) 2021 Nuo Mi + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by

[FFmpeg-devel] [PATCH v9 11/13] vvcdec: add CTU parser

Co-authored-by: Xu Mu Co-authored-by: Frank Plowman Co-authored-by: Shaun Loo Co-authored-by: Wu Jianhua --- libavcodec/vvc/vvc_ctu.c | 2393 +- libavcodec/vvc/vvc_ctu.h | 11 + 2 files changed, 2403 insertions(+), 1 deletion(-) diff --git a/libavcodec/vv

[FFmpeg-devel] [PATCH v9 07/13] vvcdec: add inv transform 1d

index 00..01a50aad25 --- /dev/null +++ b/libavcodec/vvc/vvc_itx_1d.c @@ -0,0 +1,708 @@ +/* + * VVC 1D transform + * + * Copyright (C) 2023 Nuo Mi + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU

[FFmpeg-devel] [PATCH v9 13/13] vvcdec: add vvc decoder

o \ diff --git a/libavcodec/vvc/vvcdec.c b/libavcodec/vvc/vvcdec.c new file mode 100644 index 00..608d497cb7 --- /dev/null +++ b/libavcodec/vvc/vvcdec.c @@ -0,0 +1,1017 @@ +/* + * VVC video decoder + * + * Copyright (C) 2021 Nuo Mi + * Copyright (C) 2022 Xu Mu + * + * This file is par

[FFmpeg-devel] [PATCH v9 12/13] vvcdec: add CTU thread logical

00..db901585a4 --- /dev/null +++ b/libavcodec/vvc/vvc_thread.c @@ -0,0 +1,828 @@ +/* + * VVC thread logic + * + * Copyright (C) 2023 Nuo Mi + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser

Re: [FFmpeg-devel] [PATCH v9 00/13] Add vvc decoder

On Mon, Jan 1, 2024 at 11:50 PM Lynne wrote: > Jan 1, 2024, 16:26 by jamr...@gmail.com: > > > On 1/1/2024 12:16 PM, Lynne wrote: > > > >> Jan 1, 2024, 15:13 by nuomi2...@gmail.com: > >> > >>> libavcodec/vvc/Makefile | 16 + > >>> libavcodec/vvc/vvc_cabac.c | 2478

Re: [FFmpeg-devel] [PATCH v9 13/13] vvcdec: add vvc decoder

On Mon, Jan 1, 2024 at 11:22 PM Lynne wrote: > Jan 1, 2024, 16:14 by h.lepp...@gmail.com: > > > On Mon, Jan 1, 2024 at 3:54 PM Lynne wrote: > > > >> > >> Jan 1, 2024, 15:16 by nuomi2...@gmail.com: > >> > >> > vvc decoder plug-in to avcodec. > >> > split frames into slices/tiles and send them to

Re: [FFmpeg-devel] [PATCH v9 09/13] vvcdec: add LMCS, Deblocking, SAO, and ALF filters

On Mon, Jan 1, 2024 at 11:18 PM Lynne wrote: > Jan 1, 2024, 15:15 by nuomi2...@gmail.com: > > > Co-authored-by: Xu Mu > > Co-authored-by: Frank Plowman > > Co-authored-by: Shaun Loo > > Co-authored-by: Wu Jianhua > > --- > > libavcodec/vvc/Makefile |1 + > > libavcodec/vvc/v

Re: [FFmpeg-devel] [PATCH v9 07/13] vvcdec: add inv transform 1d

On Mon, Jan 1, 2024 at 10:50 PM Lynne wrote: > Jan 1, 2024, 15:16 by nuomi2...@gmail.com: > > > + */ > > +void ff_vvc_inv_dct2_4(int *coeffs, const ptrdiff_t stride, const > size_t nz) > > +{ > > +const int a = 64, b = 83, c = 36; > > +const int x0 = coeffs[0 * stride], x1 = coeffs[1 * st

Re: [FFmpeg-devel] [PATCH v9 03/13] vvcdec: add cabac decoder

On Mon, Jan 1, 2024 at 11:13 PM Lynne wrote: > > > > Jan 1, 2024, 15:14 by nuomi2...@gmail.com: > > > + > > +//fixme > > +static void vvc_refill2(CABACContext* c) { > > > > Fix what? > Also, wrong coding style. > The function is a copy of refill2 in cabac_functions.h, including the style. The ref

Re: [FFmpeg-devel] [PATCH v9 03/13] vvcdec: add cabac decoder

On Tue, Jan 2, 2024 at 1:35 AM Michael Niedermayer wrote: > On Mon, Jan 01, 2024 at 10:12:29PM +0800, Nuo Mi wrote: > > add Context-based Adaptive Binary Arithmetic Coding (CABAC) decoder > > > > Co-authored-by: Xu Mu > > Co-authored-by: Frank Plowman > >

Re: [FFmpeg-devel] [PATCH v9 06/13] vvcdec: add inter prediction

On Mon, Jan 1, 2024 at 11:04 PM Lynne wrote: > Jan 1, 2024, 15:15 by nuomi2...@gmail.com: > > > + > > > + > > +// > > > + > > > > What's

Re: [FFmpeg-devel] [PATCH v9 09/13] vvcdec: add LMCS, Deblocking, SAO, and ALF filters

On Tue, Jan 2, 2024 at 11:51 PM Lynne wrote: > Jan 2, 2024, 10:48 by nuomi2...@gmail.com: > > > On Mon, Jan 1, 2024 at 11:18 PM Lynne wrote: > > > >> Jan 1, 2024, 15:15 by nuomi2...@gmail.com: > >> > >> > Co-authored-by: Xu Mu > >> > Co-authored-by: Frank Plowman > >> > Co-authored-by: Shaun L

Re: [FFmpeg-devel] [PATCH v9 03/13] vvcdec: add cabac decoder

On Tue, Jan 2, 2024 at 11:57 PM Lynne wrote: > Jan 2, 2024, 14:22 by nuomi2...@gmail.com: > > > On Mon, Jan 1, 2024 at 11:13 PM Lynne wrote: > > > >> > >> > >> > >> Jan 1, 2024, 15:14 by nuomi2...@gmail.com: > >> > >> > + > >> > +//fixme > >> > +static void vvc_refill2(CABACContext* c) { > >> >

Re: [FFmpeg-devel] [PATCH v9 07/13] vvcdec: add inv transform 1d

On Tue, Jan 2, 2024 at 11:55 PM Lynne wrote: > Jan 2, 2024, 14:01 by nuomi2...@gmail.com: > > > On Mon, Jan 1, 2024 at 10:50 PM Lynne wrote: > > > >> Jan 1, 2024, 15:16 by nuomi2...@gmail.com: > >> > >> > + */ > >> > +void ff_vvc_inv_dct2_4(int *coeffs, const ptrdiff_t stride, const > >> size_t

[FFmpeg-devel] [PATCH 0/4] vvcdec: reuse filter template from hevc

SAO is 100% reusable deblock is partial reusable Nuo Mi (4): hevcdec: move sao template to xvc_sao_template.c vvcdec: reuse xvc_sao_template.c hevcdec: move deblock template to xvc_deblock_template.c vvcdec: reuse xvc_deblock_template.c libavcodec/hevcdsp_template.c| 292

[FFmpeg-devel] [PATCH 1/4] hevcdec: move sao template to xvc_sao_template.c

dst[stride_dst*(height-1)] = src[stride_src*(height-1)]; - -} -} - -#undef CMP - // //////// diff --git a/libavcodec/xv

[FFmpeg-devel] [PATCH 2/4] vvcdec: reuse xvc_sao_template.c

--- libavcodec/vvc/vvc_filter_template.c | 193 +-- 1 file changed, 2 insertions(+), 191 deletions(-) diff --git a/libavcodec/vvc/vvc_filter_template.c b/libavcodec/vvc/vvc_filter_template.c index a4f1792ec4..04eb9702dc 100644 --- a/libavcodec/vvc/vvc_filter_template.c ++

[FFmpeg-devel] [PATCH 3/4] hevcdec: move deblock template to xvc_deblock_template.c

[j]; + +FUNC(loop_filter_chroma_weak)(pix, xstride, ystride, size, tc, no_p, no_q); } } } diff --git a/libavcodec/xvc_deblock_template.c b/libavcodec/xvc_deblock_template.c new file mode 100644 index 00..8ed95e754d --- /dev/null +++ b/libavcodec/xvc_deblock_temp

[FFmpeg-devel] [PATCH 4/4] vvcdec: reuse xvc_deblock_template.c

--- libavcodec/vvc/vvc_filter_template.c | 82 +--- 1 file changed, 3 insertions(+), 79 deletions(-) diff --git a/libavcodec/vvc/vvc_filter_template.c b/libavcodec/vvc/vvc_filter_template.c index 04eb9702dc..98a9005674 100644 --- a/libavcodec/vvc/vvc_filter_template.c +++

[FFmpeg-devel] [PATCH] vvcdec: add TODO for combining transform, lmcs_scale_chroma, and add_residual

Thanks for the suggestion from Lynne. --- libavcodec/vvc/vvc_intra.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/vvc/vvc_intra.c b/libavcodec/vvc/vvc_intra.c index 43de312a71..214ad38c8c 100644 --- a/libavcodec/vvc/vvc_intra.c +++ b/libavcodec/vvc/vvc_intra.c @@ -552,6 +552,8

Re: [FFmpeg-devel] [PATCH] fate: add VVC decoder tests

On Thu, Jan 4, 2024 at 8:20 AM James Almer wrote: > Signed-off-by: James Almer > --- > tests/Makefile| 1 + > tests/fate/vvc.mak| 50 +++ > tests/ref/fate/vvc-conformance-APSALF_A_2 | 13 ++ > tests/ref/fate/vvc-conformance

Re: [FFmpeg-devel] [PATCH v9 09/13] vvcdec: add LMCS, Deblocking, SAO, and ALF filters

On Thu, Jan 4, 2024 at 2:38 AM Michael Niedermayer wrote: > On Tue, Jan 02, 2024 at 05:47:53PM +0800, Nuo Mi wrote: > [...] > > maintainer, and any HEVC code change requires a very long review time. > > I think changes that just move code around or rename functions would be

Re: [FFmpeg-devel] [PATCH v9 09/13] vvcdec: add LMCS, Deblocking, SAO, and ALF filters

On Thu, Jan 4, 2024 at 8:07 PM Martin Storsjö wrote: > On Thu, 4 Jan 2024, Nuo Mi wrote: > > > On Thu, Jan 4, 2024 at 2:38 AM Michael Niedermayer < > mich...@niedermayer.cc> > > wrote: > > > >> On Tue, Jan 02, 2024 at 05:47:53PM +0800, Nuo Mi wrote:

Re: [FFmpeg-devel] [PATCH v9 09/13] vvcdec: add LMCS, Deblocking, SAO, and ALF filters

On Thu, Jan 4, 2024 at 10:53 PM James Almer wrote: > On 1/4/2024 10:57 AM, Nuo Mi wrote: > > On Thu, Jan 4, 2024 at 8:07 PM Martin Storsjö wrote: > > > >> On Thu, 4 Jan 2024, Nuo Mi wrote: > >> > >>> On Thu, Jan 4, 2024 at 2:38 AM Michael Niedermay

Re: [FFmpeg-devel] [PATCH v1 2/5] avformat: add muxer support for H266/VVC

On Fri, Nov 3, 2023 at 5:58 PM Thomas Siedel wrote: > Add muxer for vvcc byte stream format. > Add AV_CODEC_ID_VVC to ff_mp4_obj_type. > Add AV_CODEC_ID_VVC to ISO Media codec (VvcConfigurationBox vvi1, > vvc1 defined in ISO/IEC 14496-15:2021). > Add VvcConfigurationBox vvcC which extends FullBox

Re: [FFmpeg-devel] [PATCH] fate: add VVC decoder tests

On Sat, Jan 6, 2024 at 5:09 AM James Almer wrote: > On 1/3/2024 9:19 PM, James Almer wrote: > > Signed-off-by: James Almer > > --- > > tests/Makefile| 1 + > > tests/fate/vvc.mak| 50 +++ > > tests/ref/fate/vvc-conformance-AP

Re: [FFmpeg-devel] [PATCH 2/2] web: add a news entry for VVC

+ decoder, supporting a large subset of the codec's features. Further > > optimizations and > > + support for more features are coming soon. The code was written by Nuo > > Mi, Xu Mu, > > + Frank Plowman, Shaun Loo, and Wu Jianhua. > > + > >

[FFmpeg-devel] [PATCH] avcodec/vvcdec: decode extradata to support container formats

For example: wget https://www.elecard.com/storage/video/NovosobornayaSquare_1920x1080.mp4 ./ffplay NovosobornayaSquare_1920x1080.mp4 --- libavcodec/vvc/vvcdec.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/vvc/vvcdec.c b/libavcodec/vvc/vvcdec.c index 608d497cb7..54ada28124

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: decode extradata to support container formats

On Sat, Jan 6, 2024 at 9:25 AM Nuo Mi wrote: > For example: > wget > https://www.elecard.com/storage/video/NovosobornayaSquare_1920x1080.mp4 > ./ffplay NovosobornayaSquare_1920x1080.mp4 > --- > libavcodec/vvc/vvcdec.c | 6 ++ > 1 file changed, 6 insertions(+) > >

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: decode extradata to support container formats

On Sat, Jan 6, 2024 at 9:32 AM James Almer wrote: > On 1/5/2024 10:27 PM, Nuo Mi wrote: > > On Sat, Jan 6, 2024 at 9:25 AM Nuo Mi wrote: > > > >> For example: > >> wget > >> https://www.elecard.com/storage/video/NovosobornayaSquare_1920x1080.mp4 >

Re: [FFmpeg-devel] [PATCH] fate: add VVC decoder tests

On Sat, Jan 6, 2024 at 9:13 AM James Almer wrote: > On 1/5/2024 10:09 PM, Nuo Mi wrote: > > On Sat, Jan 6, 2024 at 5:09 AM James Almer wrote: > > > >> On 1/3/2024 9:19 PM, James Almer wrote: > >>> Signed-off-by: James Almer > >>> --- > >>

[FFmpeg-devel] [PATCH v2 1/4] hevcdec: move sao template to h26x/h2656_sao_template.c

/h2656_sao_template.c b/libavcodec/h26x/h2656_sao_template.c new file mode 100644 index 00..b3eb8a3deb --- /dev/null +++ b/libavcodec/h26x/h2656_sao_template.c @@ -0,0 +1,217 @@ +/* + * HEVC/VVC SAO template + * + * Copyright (C) 2024 Nuo Mi + * Copyright (C) 2012 - 2013 Guillaume Martres + * + * This

[FFmpeg-devel] [PATCH v2 2/4] vvcdec: reuse h26x/h2656_sao_template.c

--- libavcodec/vvc/vvc_filter_template.c | 193 +-- 1 file changed, 2 insertions(+), 191 deletions(-) diff --git a/libavcodec/vvc/vvc_filter_template.c b/libavcodec/vvc/vvc_filter_template.c index a4f1792ec4..9418980c33 100644 --- a/libavcodec/vvc/vvc_filter_template.c ++

[FFmpeg-devel] [PATCH v2 3/4] hevcdec: move deblock template to h26x/h2656_deblock_template.c

/h2656_deblock_template.c b/libavcodec/h26x/h2656_deblock_template.c new file mode 100644 index 00..8ed95e754d --- /dev/null +++ b/libavcodec/h26x/h2656_deblock_template.c @@ -0,0 +1,99 @@ + +/* + * HEVC/VVC deblocking dsp template + * + * Copyright (C) 2024 Nuo Mi + * Copyright (C) 2012 - 2013

[FFmpeg-devel] [PATCH v2 4/4] vvcdec: reuse h26x/h2656_deblock_template.c

--- libavcodec/vvc/vvc_filter_template.c | 82 +--- 1 file changed, 3 insertions(+), 79 deletions(-) diff --git a/libavcodec/vvc/vvc_filter_template.c b/libavcodec/vvc/vvc_filter_template.c index 9418980c33..671ed7de4e 100644 --- a/libavcodec/vvc/vvc_filter_template.c +++

Re: [FFmpeg-devel] [PATCH] vvcdec: add TODO for combining transform, lmcs_scale_chroma, and add_residual

On Sun, Jan 7, 2024 at 4:03 AM Lynne wrote: > Jan 3, 2024, 16:53 by nuomi2...@gmail.com: > > > Thanks for the suggestion from Lynne. > > --- > > libavcodec/vvc/vvc_intra.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libavcodec/vvc/vvc_intra.c b/libavcodec/vvc/vvc_intra.c > >

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: decode extradata to support container formats

On Sat, Jan 6, 2024 at 10:10 AM Nuo Mi wrote: > > > On Sat, Jan 6, 2024 at 9:32 AM James Almer wrote: > >> On 1/5/2024 10:27 PM, Nuo Mi wrote: >> > On Sat, Jan 6, 2024 at 9:25 AM Nuo Mi wrote: >> > >> >> For example: >>

Re: [FFmpeg-devel] [PATCH] avcodec/vvc_thread: don't use an anonymous union

On Sun, Jan 7, 2024 at 3:38 AM James Almer wrote: > Should fix compilation with old GCC. > > Signed-off-by: James Almer > LGTM > --- > libavcodec/vvc/vvc_thread.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/vvc/vvc_thread.c b/libavcodec/vvc/vvc_threa

[FFmpeg-devel] [PATCH 1/2] avcodec/vvcdec: deblock, fix uninitialized values

see https://fate.ffmpeg.org/report.cgi?slot=x86_64-archlinux-gcc-valgrind&time=20240105201935 If tc is zero, the max_len_q, max_len_p are uninitialized. Reported-by: James Almer --- libavcodec/vvc/vvc_filter_template.c | 231 +-- 1 file changed, 114 insertions(+), 117 d

[FFmpeg-devel] [PATCH 2/2] avcodec/vvcdec: misc, constify hor_ctu_edge

--- libavcodec/vvc/vvc_filter_template.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vvc/vvc_filter_template.c b/libavcodec/vvc/vvc_filter_template.c index e30deaac96..8687d5b24d 100644 --- a/libavcodec/vvc/vvc_filter_template.c +++ b/libavcodec/vvc/vvc_fi

Re: [FFmpeg-devel] [PATCH v9 13/13] vvcdec: add vvc decoder

On Sun, Jan 7, 2024 at 1:47 AM James Almer wrote: > On 1/1/2024 11:12 AM, Nuo Mi wrote: > > vvc decoder plug-in to avcodec. > > split frames into slices/tiles and send them to vvc_thread for further > decoding > > reorder and wait for the frame decoding to be d

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vvcdec: deblock, fix uninitialized values

On Sun, Jan 7, 2024 at 12:43 PM Nuo Mi wrote: > see > https://fate.ffmpeg.org/report.cgi?slot=x86_64-archlinux-gcc-valgrind&time=20240105201935 > > If tc is zero, the max_len_q, max_len_p are uninitialized. > > Reported-by: James Almer > Hi James, Could you help try a

Re: [FFmpeg-devel] [PATCH v2 4/4] vvcdec: reuse h26x/h2656_deblock_template.c

On Sat, Jan 6, 2024 at 6:52 PM Nuo Mi wrote: > --- > libavcodec/vvc/vvc_filter_template.c | 82 +--- > 1 file changed, 3 insertions(+), 79 deletions(-) > > diff --git a/libavcodec/vvc/vvc_filter_template.c > b/libavcodec/vvc/vvc_filter_template.c

Re: [FFmpeg-devel] [PATCH v2 4/4] vvcdec: reuse h26x/h2656_deblock_template.c

On Tue, Jan 9, 2024 at 9:23 AM Ronald S. Bultje wrote: > Hi, > > On Mon, Jan 8, 2024 at 8:03 PM Nuo Mi wrote: > > > On Sat, Jan 6, 2024 at 6:52 PM Nuo Mi wrote: > > > > > --- > > > libavcodec/vvc/vvc_filter_template.c | 82 +-

Re: [FFmpeg-devel] [PATCH v2 4/4] vvcdec: reuse h26x/h2656_deblock_template.c

> > > > > Yes. After we merge this, we will send out the mc x86 asm code for > review. > > It will share the same binary with HEVC. > > For SAO/Deblock, we will follow a similar approach, but it needs to be a > > little later than mc. > > For C code, we can share the binary as well, but it involves

[FFmpeg-devel] [PATCH v2 2/2] avcodec/vvcdec: misc, constify hor_ctu_edge

--- libavcodec/vvc/vvc_filter_template.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vvc/vvc_filter_template.c b/libavcodec/vvc/vvc_filter_template.c index 845c8a4181..b7eaef5125 100644 --- a/libavcodec/vvc/vvc_filter_template.c +++ b/libavcodec/vvc/vvc_fi

[FFmpeg-devel] [PATCH v2 1/2] avcodec/vvcdec: deblock, fix uninitialized values

see https://fate.ffmpeg.org/report.cgi?slot=x86_64-archlinux-gcc-valgrind&time=20240105201935 If tc is zero, the max_len_q, max_len_p are uninitialized. Reported-by: James Almer --- libavcodec/vvc/vvc_filter_template.c | 236 ++- 1 file changed, 119 insertions(+), 117 de

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vvcdec: deblock, fix uninitialized values

On Tue, Jan 16, 2024 at 10:38 PM James Almer wrote: > On 1/8/2024 10:00 PM, Nuo Mi wrote: > > > > > > On Sun, Jan 7, 2024 at 12:43 PM Nuo Mi > <mailto:nuomi2...@gmail.com>> wrote: > > > > see > > > https://fate.ffmpeg.org/report.cgi?

[FFmpeg-devel] [PATCH v2 0/2] avcodec/vvcdec: fix valgrind issue for deblock

change since v1: Rebased on top of master. Nuo Mi (2): avcodec/vvcdec: deblock, fix uninitialized values avcodec/vvcdec: misc, constify hor_ctu_edge libavcodec/vvc/vvc_filter_template.c | 242 ++- 1 file changed, 122 insertions(+), 120 deletions(-) -- 2.25.1

Re: [FFmpeg-devel] [PATCH] avcodec/vvcdec: allocate and store structs on their own within the table list

On Thu, Jan 18, 2024 at 11:10 PM James Almer wrote: > Fixes "runtime error: member access within misaligned address 0xf00 for > type > 'struct bar', which requires # byte alignment" errors under GCC ubsan. > LGTM Thank you, James > > Signed-off-by: James Almer > --- > libavcodec/vvc/vvcdec.c

Re: [FFmpeg-devel] [PATCH v3 5/8] avcodec/vvcdec: reuse h26x/2656_inter.asm to enable x86 optimizations

On Tue, Jan 23, 2024 at 1:47 AM wrote: > From: Wu Jianhua > > + > +#define FW_PUT(name, depth, opt) \ > +static void ff_vvc_put_ ## name ## _ ## depth ## _##opt(int16_t *dst, > const uint8_t *src, ptrdiff_t srcstride, \ > + int height, const int8_t

[FFmpeg-devel] [PATCH v2 0/2] Add mp4 and ts support for vvc

Based on https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=9992 Major changes since v1: * Fix fate test * Fix "fmpeg -i input.mp4 -c:v copy output.ts && ffmpeg -i output.ts -f md5 -" and "fmpeg -i input.mp4 -c:v copy output.mp4 && ffmpeg -i output.mp4 -f md5 -" * Fix unused or uniniti

[FFmpeg-devel] [PATCH v2 2/2] avformat: add ts stream types for H266/VVC

-f null - ffmpeg -i NovosobornayaSquare_1920x1080.mp4 -c:v copy test.ts && ffmpeg -i test.ts -f md5 - Signed-off-by: Thomas Siedel Co-Authored-By: Nuo Mi --- configure | 2 +- libavformat/mpeg.c | 3 ++ libavformat/mpeg.h | 1 + libavformat/

[FFmpeg-devel] [PATCH v2 1/2] avformat: add muxer support for H266/VVC

ff_vvc_muxer to RAW muxers. Tested with: ffmpeg -i NovosobornayaSquare_1920x1080.mp4 -c:v libvvenc test.mp4 && ffmpeg -i test.mp4 -f null - ffmpeg -i NovosobornayaSquare_1920x1080.mp4 -c:v copy test.mp4 && ffmpeg -i test.mp4 -f md5 - Signed-off-by: Thomas Siedel Co-Aut

Re: [FFmpeg-devel] [PATCH v3 5/8] avcodec/vvcdec: reuse h26x/2656_inter.asm to enable x86 optimizations

On Tue, Jan 23, 2024 at 9:01 PM Nuo Mi wrote: > > > > On Tue, Jan 23, 2024 at 1:47 AM wrote: > >> From: Wu Jianhua >> >> + >> +#define FW_PUT(name, depth, opt) \ >> +static void ff_vvc_put_ ## name ## _ ## depth ## _##opt(int16_t *ds

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Use av_log2 when destination is integer

LGTM On Fri, Jan 26, 2024 at 1:05 AM wrote: > From: Frank Plowman > > Signed-off-by: Frank Plowman > --- > libavcodec/vvc/vvc_ctu.c | 4 ++-- > libavcodec/vvc/vvc_ps.c | 2 +- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/vvc/vvc_ctu.c b/libavcodec/vvc/vvc_ctu

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: add muxer support for H266/VVC

On Fri, Jan 26, 2024 at 10:04 PM Thomas Siedel wrote: > Thanks for picking up the patch set! > > On Thu, 25 Jan 2024 at 13:26, Nuo Mi wrote: > >> From: Thomas Siedel >> >> Add muxer for vvcc byte stream format. >> Add AV_CODEC_ID_VVC to ff_mp4_obj_type.

Re: [FFmpeg-devel] [PATCH v1 2/5] avformat: add muxer support for H266/VVC

On Fri, Jan 26, 2024 at 11:18 PM Thomas Siedel wrote: > On Fri, 5 Jan 2024 at 01:21, Nuo Mi wrote: > > > On Fri, Nov 3, 2023 at 5:58 PM Thomas Siedel > > > wrote: > > > > > Add muxer for vvcc byte stream format. > > > Add AV_CODEC_ID_VVC to ff_m

[FFmpeg-devel] [PATCH v3 0/6] Add mp4 and ts support for vvc

Major changes for mpegtsenc since v2: Remove VVC from get_m2ts_stream_type (Marton) Refact check_h26x_startcode to remove duplicate code (Marton) Refact mpegts_check_bitstream to remove duplicate code (Marton) Refact out h26x_prefix_aud Remove h264, hevc magic numbers to improve readability Nuo

[FFmpeg-devel] [PATCH v3 1/6] avformat: add muxer support for H266/VVC

with: ffmpeg -i NovosobornayaSquare_1920x1080.mp4 -c:v libvvenc test.mp4 && ffmpeg -i test.mp4 -f null - ffmpeg -i NovosobornayaSquare_1920x1080.mp4 -c:v copy test.mp4 && ffmpeg -i test.mp4 -f md5 - Signed-off-by: Thomas Siedel Co-Authored-By: Nuo Mi --- liba

[FFmpeg-devel] [PATCH v3 2/6] avformat/mpegtsenc: refact mpegts_check_bitstream to loop up table

--- libavformat/mpegtsenc.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 84edd418f0..418fa08ad5 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -2257,23 +2257,26

[FFmpeg-devel] [PATCH v3 3/6] avformat/mpegtsenc: refact, move h264, hevc startcode checking to check_h26x_startcode

--- libavformat/mpegtsenc.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 418fa08ad5..01b8c8d87a 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -1759,16 +1759,16 @@ stat

[FFmpeg-devel] [PATCH v3 4/6] avformat/mpegtsenc: refact, remove h264, hevc magic numbers for nal_type

--- libavformat/mpegtsenc.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 01b8c8d87a..0843516ee6 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -31,6 +31,7 @@ #i

[FFmpeg-devel] [PATCH v3 5/6] avformat/mpegtsenc: refact out h26x_prefix_aud

--- libavformat/mpegtsenc.c | 45 + 1 file changed, 28 insertions(+), 17 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 0843516ee6..ff1c4de640 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -1834,6 +

[FFmpeg-devel] [PATCH v3 6/6] avformat: add ts stream types for H266/VVC

-f null - ffmpeg -i NovosobornayaSquare_1920x1080.mp4 -c:v copy test.ts && ffmpeg -i test.ts -f md5 - Signed-off-by: Thomas Siedel Co-Authored-By: Nuo Mi --- configure | 2 +- libavformat/mpeg.c | 6 ++ libavformat/mpeg.h | 1 + libavformat/

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Fix emulation prevention byte handling

On Sat, Jan 27, 2024 at 12:21 AM wrote: > From: Frank Plowman > > nal->skipped_bytes_pos contains the positions of errors relative to the > start of the slice header, whereas the position they were tested against > is relative to the start of the slice data, i.e. one byte after the end > of the

Re: [FFmpeg-devel] [PATCH] x86: Remove inline MMX assembly that clobbers the FPU state

On Fri, Jan 26, 2024 at 9:45 PM Martin Storsjö wrote: > On Fri, 26 Jan 2024, Martin Storsjö wrote: > > > These inline implementations of AV_COPY64, AV_SWAP64 and AV_ZERO64 > > are known to clobber the FPU state - which has to be restored > > with the 'emms' instruction afterwards. > > > > This wa

Re: [FFmpeg-devel] [PATCH v3 2/6] avformat/mpegtsenc: refact mpegts_check_bitstream to loop up table

Hi Andreas, thank you for the review On Sat, Jan 27, 2024 at 10:44 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Nuo Mi: > > --- > > libavformat/mpegtsenc.c | 33 ++--- > > 1 file changed, 18 insertions(+), 15 deleti

Re: [FFmpeg-devel] [PATCH v3 1/6] avformat: add muxer support for H266/VVC

On Sat, Jan 27, 2024 at 10:38 PM James Almer wrote: > On 1/27/2024 1:15 AM, Nuo Mi wrote: > > diff --git a/libavformat/isom_tags.c b/libavformat/isom_tags.c > > index a575b7c160..705811e950 100644 > > --- a/libavformat/isom_tags.c > > +++ b/libavformat/isom_tags.c &g

[FFmpeg-devel] [PATCH v4 0/6] Add mp4 and ts support for vvc

enc: mpegps_read_packet, remove duplicate vvc entry (Marton) Nuo Mi (4): avformat/mpegtsenc: refact mpegts_check_bitstream to loop up table avformat/mpegtsenc: refact, move h264, hevc startcode checking to check_h26x_startcode avformat/mpegtsenc: refact, remove h264, hevc magic numbers for nal_t

[FFmpeg-devel] [PATCH v4 2/6] avformat/mpegtsenc: refact mpegts_check_bitstream to loop up table

--- libavformat/mpegtsenc.c | 33 ++--- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 84edd418f0..4e5c264d2a 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -2257,23 +2257,26

[FFmpeg-devel] [PATCH v4 1/6] avformat/mp4: add muxer support for H266/VVC

with: ffmpeg -i NovosobornayaSquare_1920x1080.mp4 -c:v libvvenc test.mp4 && ffmpeg -i test.mp4 -f null - ffmpeg -i NovosobornayaSquare_1920x1080.mp4 -c:v copy test.mp4 && ffmpeg -i test.mp4 -f md5 - Signed-off-by: Thomas Siedel Co-Authored-By: Nuo Mi --- libavforma

[FFmpeg-devel] [PATCH v4 3/6] avformat/mpegtsenc: refact, move h264, hevc startcode checking to check_h26x_startcode

--- libavformat/mpegtsenc.c | 26 -- 1 file changed, 8 insertions(+), 18 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 4e5c264d2a..5e089f2866 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -1759,16 +1759,16 @@ stat

[FFmpeg-devel] [PATCH v4 4/6] avformat/mpegtsenc: refact, remove h264, hevc magic numbers for nal_type

--- libavformat/mpegtsenc.c | 32 +++- 1 file changed, 19 insertions(+), 13 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 5e089f2866..3872be0f46 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -31,6 +31,7 @@ #i

[FFmpeg-devel] [PATCH v4 6/6] avformat: add ts stream types for H266/VVC

-f null - ffmpeg -i NovosobornayaSquare_1920x1080.mp4 -c:v copy test.ts && ffmpeg -i test.ts -f md5 - Signed-off-by: Thomas Siedel Co-Authored-By: Nuo Mi --- configure | 2 +- libavformat/mpeg.c | 3 +++ libavformat/mpeg.h | 1 + libavformat/

[FFmpeg-devel] [PATCH v4 5/6] avformat/mpegtsenc: refact out h26x_prefix_aud

--- libavformat/mpegtsenc.c | 45 + 1 file changed, 28 insertions(+), 17 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 3872be0f46..7bc3feaef1 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegtsenc.c @@ -1834,6 +

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat: add muxer support for H266/VVC

On Mon, Jan 29, 2024 at 11:35 PM Thomas Siedel wrote: > On Fri, 26 Jan 2024 at 16:22, Nuo Mi wrote: > >> >> >> On Fri, Jan 26, 2024 at 10:04 PM Thomas Siedel < >> thomas...@spin-digital.com> wrote: >> >>> Thanks for picking up the patch set!

Re: [FFmpeg-devel] [PATCH v3 1/6] avformat: add muxer support for H266/VVC

On Sat, Jan 27, 2024 at 10:38 PM James Almer wrote: > On 1/27/2024 1:15 AM, Nuo Mi wrote: > > diff --git a/libavformat/isom_tags.c b/libavformat/isom_tags.c > > index a575b7c160..705811e950 100644 > > --- a/libavformat/isom_tags.c > > +++ b/libavformat/isom_tags.c &g

Re: [FFmpeg-devel] [PATCH] lavc/vvc: Add check to num_multi_layer_olss

On Tue, Jan 30, 2024 at 5:41 PM wrote: > From: Frank Plowman > > Check that vps_each_layer_is_an_ols_flag, which indicates that "at > least one OLS specified by the VPS contains more than one layer," is > set if num_multi_layer_olss is non-zero. > > Fixes: > 65160/clusterfuzz-testcase-minimized-

[FFmpeg-devel] [PATCH v5 0/6] Add mp4 and ts support for vvc

Changes since v4: mp4: return patch welcome for CENC nal units (Thomas) mp4: reintroduce vvc back into ff_codec_movvideo_tags since the mp4 demuxer relies on it. (James) Nuo Mi (4): avformat/mpegtsenc: refact mpegts_check_bitstream to loop up table avformat/mpegtsenc: refact, move h264, hevc

<    2   3   4   5   6   7   8   9   10   >