this argument is here.
> Whether you like it or not, there is value in designing separate tools and
> implementing separate tools and libraries for different use cases: even
> though the ffmpeg suite of library is closed together because they pertain
> the same subject (multimedia)
the size of this structure is not part of
the ABI". Hundreds of dynamic allocations, and therefore hundreds of
extra lines of code for failure check. What a waste!
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmp
Paul B Mahol (12020-03-12):
> I changed my mind, I will not follow Nicolas advice at all.
> Will apply this filter ASAP.
>
> I kindly ask Nicolas to stay away from my code for ever.
This is not how it works. Re-send the patch for consideration by the
whole project.
--
Ni
> case which Michael mentioned.
Sorry, I intented to review this series, but things were a little
hectic. I'll get on with it soon.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-de
: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael Niedermayer
> ---
> libavcodec/ffwavesynth.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
No objecti
ATE
samples.
Thanks, and sorry for the delay.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above,
Anton Khirnov (12020-03-16):
> I'd think any decent compiler will already make that transformation.
Profile, don't speculate. gcc doesn't make that optimization for
printf().
And no compiler could do it for av_log() anyway.
Regards,
--
Nicolas George
signature.as
easonable stance by itself.
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Steven Liu (12020-03-16):
> No this is used for fix some problem about full specification support,
> you can fix the memleak but I don’t think remove them is a good way.
How can they fix a problem if they are unused?
Regards,
--
Nicolas George
signature.asc
Description: PGP sig
not fully baked. Let's revert it. And
if you can contribute a commit that actually does something, with proper
lifetime for the variables, we can bring it back.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel
riable to get parsed immediately. I suggest you
make a helper function to parse integer attributes.
Reverting is the way to go.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
.
This code is bad: it stores values that are not needed. It should have
never gone in in the first place.
Write code that works, and it will be reviewed. Feel free to ping me
about it.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
Steven Liu (12020-03-16):
> Patch welcome for rewrite dashdec.
Irrelevant. This particular commit is bad in and by itself. That's what
happens when you push without review.
Regards,
--
Nicolas George
signature.asc
Description: PGP s
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org wit
t's the best solution.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
-2148,6 +2220,10 @@ static int dash_read_header(AVFormatContext *s)
> av_dict_set_int(&rep->assoc_stream->metadata,
> "variant_bitrate", rep->bandwidth, 0);
> if (rep->id[0])
> av_dict_set(&rep->assoc_stream->metadata, &quo
an commit
all of it together.
In short: don't build half a bridge, either build the whole bridge or
keep the materials for later.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpe
Steven Liu (12020-03-20):
> Do you mean,
I mean you should only propose code that actually does something. That
should be easy to understand: if you store into a variable without using
the value, remove it; then iterate.
Regards,
--
Nicolas George
signature.asc
Description: PGP signat
Steven Liu (12020-03-20):
> These member will be used for get more correct information of the MPD
>
> Suggested-by: Andreas Rheinhardt
> Suggested-by: Nicolas George
> Signed-off-by: Steven Liu
> ---
> libavformat/dashdec.c | 180 +++
> Just tell the user this value is incorrect in mpd, the result maybe does not
> accord with the expected result.
> User should check the mpd file content is correct.
Which user knows about the mpd?
Regards,
--
Nicolas George
signature.asc
Descri
Steven Liu (12020-03-20):
> To: Nicolas George
Please heed reply-to headers.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffm
blem is that av_strtok() does
not tell you the semantic of saveptr, you can therefore only use it as
an argument to another call to av_strtok().
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
mselves, they should
> be marked as such.
I had the same idea, and I checked: the problem is that the subtitle
encoding API returns just a buffer of data, not a packet. With that
crappy API, this change is the best we can do.
Regards,
--
Nicolas George
signature.as
Paul B Mahol (12020-03-21):
> I'm not gonna remove those tables, no matter how "valid" your comments are.
Then you're not gonna apply this patch either. That's how a collective
project works.
--
Nicolas George
signature.as
Ashutosh Pradhan (12020-03-26):
> Use cellular automata and fluidsynth sequencer to generate tones in major
> pentatonic scale
Can you explain the use cases for this filter?
Regards,
--
Nicolas George
signature.asc
Description: PGP sig
.
> On Thu, Mar 26, 2020 at 2:41 PM Nicolas George wrote:
Please remember not to top post on this mailing-list.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpe
for
this filter?
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg
our users
would get from this filter. In what case a user would want to use this
filter.
If you cannot answer this question, then there is no reason to adopt it.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-deve
was meant for testing, because it is similar to an
old proposal of mine which was exactly meant for testing. This
implementation is 100% unsuited for testing since it uses an external
library.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
_
ation is suited for testing, preferably bit-exact.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above,
Paul B Mahol (12020-03-26):
> Apparently you are talking about completely different and irrelevant stuff
> for this task.
Apparently, you did not read my previous mails very carefully, because I
already explained.
--
Nicolas George
___
ffmpeg
n
external library, would be worthless for testing.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link ab
t; to find it easily?
https://ffmpeg.org/pipermail/ffmpeg-devel/2018-September/234714.html
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo
Steven Liu (12020-03-24):
> These member will be used for get more correct information of the MPD
>
> Suggested-by: Andreas Rheinhardt
> Suggested-by: Nicolas George
> Signed-off-by: Steven Liu
> ---
> libavformat/dashdec.c | 244 ---
very patch, you just need to rebase
it on top of the revert, it will actually be simpler.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/
ar *)"SegmentTemplate")) {
> @@ -1143,12 +1327,15 @@ static int
> parse_manifest_adaptationset(AVFormatContext *s, const char *url,
> adaptionset_segmentlist_node,
>
> adaption
lance.lmw...@gmail.com (12020-03-28):
> From: Limin Wang
>
> Signed-off-by: Limin Wang
> ---
> libavfilter/vf_mix.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
Why? What do you expect to change with this patch, and how is it
supposed to be better?
Regards,
--
use
> continue to avoid invalid access only.
It's not invalid, it's 0.
> Do you think it's better to
> print out one warning message?
With this correction, I think this change is not necessary at all.
Regards,
--
Nicolas
Limin Wang (12020-03-29):
> Anyway if the user option is typo,
> the result may be unexpected for user.
But your change does not address that. For that, you would print a
message and return an error. Which is probably the right thing to do,
actually.
Regards,
--
Nicolas
Limin Wang (12020-03-29):
> OK, update the patch to print a message and return error.
Thanks. I have no objection to that new version, but I do not maintain
that code.
Regards,
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.
A situation for
which I have yet to be told a single actual benefit.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscr
gainst bool, from either you
or somebody else, then I suggest we leave this one as it is and no
longer reject patches based on this.
--
Nicolas George
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-dev
Derek Buitenhuis (12020-04-02):
> Interesting... Altivec isn't standards compliant? TIL.
What I read is Apple isn't standards compliant. I knew that.
This fix seems harmless enough.
Regards,
--
Nicolas George
signature.asc
Description:
sion before the patch and the version after the patch.
Tests are there for a reason. If you cannot explain exactly why a change
in a reference file is beneficial, then the patch is not acceptable.
Regards,
--
Nicolas George
signature.asc
Description: PG
ons use this device or a similar one
specifically (I do in some of mine, I am certainly not alone), they
would hardcode rawvideo. Therefore, we cannot remove support for
rawvideo.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
static int opengl_write_frame(AVFormatContext *h, int
> stream_index,
> {
> if ((flags & AV_WRITE_UNCODED_FRAME_QUERY))
> return 0;
> -return opengl_draw(h, *frame, 0, 0);
> +return opengl_draw(h, *frame, 0);
> }
>
> #define OFFSET(x) offsetof(O
xv.c | 4
> libavformat/avformat.h | 7 +++
> libavformat/internal.h | 2 ++
> libavformat/mux.c| 16
> libavformat/uncodedframecrcenc.c | 6 ++
> libavformat/version.h | 6 +-
> 11 files changed, 58
g then.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmp
is generic code, it will handle any codec.
But anyway, you are reading this commit wrongly. It does not remove
support for rawvideo in null, rawvideo is still supported in null, as
any other codec. This commit only changes the default codec.
Regards,
--
Nicolas George
signature.asc
Description
DEFAULT_BORDERSTYLE, m->d.alignment);
Indentation is off. It was off before, but since the lines are changed
it should be ok now.
Can't judge on semantic.
> } else
> return ff_ass_subtitle_header_default(avctx);
> }
Regards,
--
Nicolas George
signature.asc
Descript
5[0-9A-Za-z+ ]]%c", section, &c) == 2) {
> buf += strcspn(buf, "\n");
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
for the track.
I think the private data is supposed to be the beginning of the file.
Also, I think the BOM should not be there when embedding, but we can
support slightly invalid files.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
_
; API bump.
No, let's keep it.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above,
7;s not the
default, specifying it would be necessary.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit
dp.str), 0, NULL, NULL, NULL,
> NULL);
> s->pb = &pb;
>
> /* sdp_read_header initializes this again */
> @@ -2532,9 +2559,14 @@ static int rtp_read_header(AVFormatContext *s)
>
> ret = sdp_read_header(s);
> s->pb = NULL;
> +av_bprint_finalize(
Paul B Mahol (12020-04-07):
> I rejected patch, because Lynee reported over IRC, which you
> thankfully completely ignored, bug that stops playing files.
Next time, save everybody some time and say it directly there.
Politeness is not for everybody else but you.
--
Nicolas
the FFmpeg doc.
>
> The microsecond implicit unit has caused confusion for both FFmpeg and
> obs-studio users:
> - https://github.com/Haivision/srt/issues/1223
> - https://obsproject.com/mantis/view.php?id=1617
I think it should stay in microseconds but be declared as a DURATION
op
Michael Niedermayer (12020-04-07):
> will apply
Sorry. No problem.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
etter accuracy, more will do as computers get
more powerful, and consistency is convenient.
In this instance, AV_OPT_TYPE_DURATION is undoubtedly the proper type
for this option, and it is defined in microseconds.
Regards,
--
Nicolas George
signature.asc
D
James Almer (12020-04-07):
> Can't you make PINK_UNIT 128UL or 128ULL? Or will that affect other
> checks negatively?
Elsewhere, it's used as index in a small array, that would be strange.
Regards,
--
Nicolas George
signature.asc
Descriptio
T_TYPE_DURATION, { .i64 =
> -1 }, -1, INT64_MAX, .flags = D|E },
> { "tlpktdrop", "Enable receiver pkt drop",
>OFFSET(tlpktdrop),AV_OPT_TYPE_BOOL, { .i64 =
> -1 }, -1, 1, .flags = D|E },
>
e variable does not outlive the
AVBPrint structure, just use the string directly and finalize to NULL.
> }
>
> -memcpy(filename + dirname_len, file, file_len + 1); // include the
> terminating zero
> dashenc_delete_file(s, filename);
>
> +av_freep(&filename);
>
n
> every application, that is why this ffmpeg behavior is a bit
> confusing.
We are thinking of FFmpeg users first here.
> On 07.04.20, 18:43, "Nicolas George" wrote:
Remember that top-posting is forbidden on this mailing-list. If you
don't know what it means, look
Dennis Mungai (12020-04-08):
> This should do:
No, it won't do. This question belongs to ffmpeg-user, not ffmpeg-devel.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ff
Andreas Rheinhardt (12020-04-08):
> You are commenting on an outdated version of this patch (and saying much
> the same as I did). Current version is [1].
I made the same comment as you on the same patch as you because I had
not seen your comment at the time I sent.
Regards,
--
N
Steven Liu (12020-04-08):
> As mkver suggestion, perhaps use bprint is better, is it?
It does not seem like a situation where BPrint is beneficial.
Other filename handling functions in this HLS code would, though.
Regards,
--
Nicolas George
signature.asc
Description: PGP signat
a
dynamic allocation is necessary anyway.
For this case: (1) there is only one snprintf(), (2) we don't use a
fixed-size buffer and (3) we'll keep the string.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-dev
av_freep(&sub_path);
> }
> -av_freep(&path);
> +av_bprint_clear(&path);
I would advise to put this before the first use instead of here: it will
be more robust if somebody adds "continue" in the loop.
> prev
ge, if only one or two or exceptions are available, none
will be tested. I do not know if it is on purpose, but it definitely
does not test *available* exceptions.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-dev
, crash.
I vote for properly checking memory allocations as they happen.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
T
for the check has been made to start in
libavformat, make a detour through libavutil and come back to
libavformat. This is terrible.
Let us re-add proper, clear checks where they belong.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
_
randomly.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg
s a terrible idea: NULL is not a valid file name, and therefore it
makes no sense to take its dir name.
This is "defensive programming": returning random results for invalid
values instead of errorring properly. It is a very bad habit, it leads
to corrupted files and security issues.
Rega
or the compact output.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-re
vu.
That would be the first step.
What do you think?
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, vi
choices.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg
ave no plan to do such work.
Ok. This is something I was intending to work on anyway, and it seems
ripe. I will bring it to the mailing-list.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ff
this project, I intend to finish and use
it, because it's exactly the kind of use I had in mind for it.
https://ffmpeg.org/pipermail/ffmpeg-devel/2019-December/254042.html
Please share your thoughts, including if only to say you think it is a
good idea.
Regards,
--
Nicolas George
hinder anybody's work much. And if it does, well, 2005
called and they want their SVN habits back.
Code maintainership is first and foremost a responsibility. It only
gives rights to sustain that responsibility.
Regards,
--
Nicolas George
signature.asc
Description: PG
of review, the strong correlation between patches
pushed without review and the appearance of new coverity errors is a
good argument for systematic reviews.
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-de
uch less so.
On the other hand, if among the collective there are elements who refuse
to cooperate, it harms the whole. It is sad to say, but if they are too
uncooperative, it is sometime better to isolate them from the whole,
however personally talented they may be.
--
Nicolas Geo
Paul B Mahol (12020-04-13):
> Because geq works with only one input.
> Gonna apply this filter immediately.
You literally just sent a reply on an objection: allow time for other
developers to read that reply and make a reply of their own.
--
Nicolas George
signature.asc
Descriptio
as circular.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ..
ery good idea.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@
, I say we need annealing for the way we handle structured data.
And I say I can do it, in a way that does not disrupt the project much.
You can trust me on this or ask for details.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
_
time device exist on machines with very
constrained hardware too.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscrib
mbarrassing! The earlier version forgot to check the allocation.
I am confused: does it not make unwrapped frames behave exactly the same
as wrapped frames?
AFAIU, Marton intends to remove all this code, and I think he is right,
because it was a hack.
Regards,
--
Nicolas George
signature.asc
Marton Balint (12020-04-11):
> Also change the default to that.
>
> Signed-off-by: Marton Balint
> ---
> libavdevice/xv.c | 22 ++
> 1 file changed, 14 insertions(+), 8 deletions(-)
No objection. Thanks.
Regards,
--
Nicolas George
signature.as
Marton Balint (12020-04-11):
> Also change the default to that.
>
> Signed-off-by: Marton Balint
> ---
> libavdevice/opengl_enc.c | 17 -
> 1 file changed, 12 insertions(+), 5 deletions(-)
No objection. Thanks.
Regards,
--
Nicolas George
signature.as
kes it inexcusable.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-deve
r the best. Ideally, an
explanation of the changes goes in the commit message.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-de
Signed-off-by: Nicolas George
---
libavfilter/formats.c | 41 +
libavfilter/formats.h | 10 ++
2 files changed, 51 insertions(+)
I need it in new code.
diff --git a/libavfilter/formats.c b/libavfilter/formats.c
index 33c64668a0..784f604483
Signed-off-by: Nicolas George
---
libavfilter/vf_crop.c | 21 -
1 file changed, 4 insertions(+), 17 deletions(-)
diff --git a/libavfilter/vf_crop.c b/libavfilter/vf_crop.c
index 502defd0a5..3d5cb95f78 100644
--- a/libavfilter/vf_crop.c
+++ b/libavfilter/vf_crop.c
@@ -94,24
Signed-off-by: Nicolas George
---
libavfilter/tests/formats.c | 136 ++--
1 file changed, 68 insertions(+), 68 deletions(-)
diff --git a/libavfilter/tests/formats.c b/libavfilter/tests/formats.c
index d8b8079ef6..ee497f3b90 100644
--- a/libavfilter/tests
Move the contents of all_channel_layouts.inc directly into
libavfilter/tests/formats.c.
Signed-off-by: Nicolas George
---
libavfilter/all_channel_layouts.inc | 68 ---
libavfilter/formats.c | 10
libavfilter/tests/formats.c | 72
l, anybody can do it.
vf_boxblur.c
vf_copy.c
vf_detelecine.c
vf_fieldhint.c
vf_fieldorder.c
vf_hflip.c
vf_hwdownload.c
vf_il.c
vf_mix.c
vf_noise.c
vf_stack.c
vf_swaprect.c
vf_swapuv.c
vf_telecine.c
vf_transpose.c
vf_weave.c
Regards,
--
Nicolas George
signature.asc
Descri
atums to push patches without reviews or
bypassing comments, should they keep their commit rights?
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffm
TODO APIchanges and minor bump.
Signed-off-by: Nicolas George
---
libavutil/rational.c | 9 +
libavutil/rational.h | 6 ++
2 files changed, 15 insertions(+)
This one too, I need for the code I am writing.
And lavfi/avf_concat could use it too to choose a better time base.
diff
Signed-off-by: Nicolas George
---
libavfilter/framesync.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/libavfilter/framesync.c b/libavfilter/framesync.c
index bc95f7d904..26e5219d1b 100644
--- a/libavfilter/framesync.c
+++ b/libavfilter/framesync.c
reasonably easy to offer them a simple
API that would not hinder development.
Regards,
--
Nicolas George
signature.asc
Description: PGP signature
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
401 - 500 of 4940 matches
Mail list logo
