BSD-like socket APIs,
for instance SRT or UDT.
tcp.c is used as base for SRT protocol implementation,
as SRT socket API closely ressambles TCP sockets.
Nablet Developer (3):
avformat/network: allow to specify custom socket API
avformat/tcp: use generic socket API
avformat/opensrt: add Haivision
this allows to implement other protocols which use
API similar to BSD sockets (e.g. Haivision SRT)
Signed-off-by: Nablet Developer
---
libavformat/tcp.c | 118 +++---
libavformat/tcp.h | 59 +++
2 files changed, 119
protocol requires libsrt (https://github.com/Haivision/srt) to be
installed
Signed-off-by: Nablet Developer
---
configure | 10 ++
libavformat/Makefile| 1 +
libavformat/opensrt.c | 418
libavformat/protocols.c | 1 +
4
Signed-off-by: Nablet Developer
---
libavformat/network.c | 196 --
libavformat/network.h | 34 +
2 files changed, 161 insertions(+), 69 deletions(-)
diff --git a/libavformat/network.c b/libavformat/network.c
index 6c3d9de..80d6f6e 100644
On 10-Nov-17 03:35, Nicolas George wrote:
Can you explain the logic of the implementation? I have a hard time
understanding why you call the tcp protocol from here after forcing it
to call back here.
Regards,
the idea is to avoid code duplication as much as possible, and try to
re-use existi
>
> Thanks for explaining. I think it is not the best decision.
>
> The reason the socket API resembles TCP is because all the sockets API
> resemble each other, since they are based on the old BSD socket API. And
> the protocol handlers of libavformat too.
>
> Therefore, I think all the trampo
> On 20 Nov 2017, at 13:35, nablet developer wrote:
>
>
>>
>> Thanks for explaining. I think it is not the best decision.
>>
>> The reason the socket API resembles TCP is because all the sockets API
>> resemble each other, since they are based on the
org).
GStreamer already integrated the protocol and VLC has already accepted the pull
request for adding the SRT protocol to VLC. We see a dramatic adoption of the
protocol in the market and a lot of our partners are asking us frequently on a
ffmpeg integration.
Nablet Developer (1):
avformat/open
protocol requires libsrt (https://github.com/Haivision/srt) to be
installed
Signed-off-by: Nablet Developer
---
configure | 10 +
doc/protocols.texi | 116 +
libavformat/Makefile| 1 +
libavformat/opensrt.c | 622
> On 13 Dec 2017, at 15:31, Nablet Developer wrote:
>
> The protocol is used by thousands of Haivision customers since 2013,
> in extremely sensitive medical, military and enterprise applications
> with FIPS compliant encryption requirements. Since April 2017, the protocol
>
On 19-Dec-17 15:01, nablet developer wrote:
On 13 Dec 2017, at 15:31, Nablet Developer wrote:
The protocol is used by thousands of Haivision customers since 2013,
in extremely sensitive medical, military and enterprise applications
with FIPS compliant encryption requirements. Since April
protocol requires libsrt (https://github.com/Haivision/srt) to be
installed
Signed-off-by: Nablet Developer
---
configure |5 +
libavformat/Makefile|1 +
libavformat/protocols.c |1 +
libavformat/srt.c | 1105
> SRT is a subtitle format: a more specific name would be better.
for example? haivision_srt?
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
> SRT is a subtitle format: a more specific name would be better.
Haivision suggested name "opensrt" - is it acceptable to distinguish
with SRT subtitile format?
if yes, I'll go ahead and submit new patch with name changed.
___
ffmpeg-devel mailing lis
protocol requires libsrt (https://github.com/Haivision/srt) to be
installed
Signed-off-by: Nablet Developer
---
configure |5 +
libavformat/Makefile|1 +
libavformat/opensrt.c | 1105 +++
libavformat/protocols.c |1
Has this patch been run under valgrind, on Windows, and with stuff like ASAN,
etc.?
Some stuff here would even trigger compiler warnings normally.
compiled on Windows, but didn't run under valgrind or ASAN yet.
Also, how much of this stuff is duplicated from the udp.c and pals?
you're absolute
On 10/10/2017 22:47, Derek Buitenhuis wrote:
On 10/10/2017 7:29 AM, Nablet Developer wrote:
@@ -293,6 +293,7 @@ External library support:
--enable-opengl enable OpenGL rendering [no]
--enable-openssl enable openssl, needed for https support
On 12-Oct-17 01:11, Derek Buitenhuis wrote:
So user options are overridden by URL params...?
exactly. at least in case of udp and few other protocols. it's
documented https://ffmpeg.org/ffmpeg-protocols.html#udp
The required syntax for an UDP URL is:
udp://hostname:port[?options]
options con
On 12-Oct-17 01:01, Derek Buitenhuis wrote:
Is it possible to deduplicate / share code with udp.c? It seems really iffy to
duplicate a large swath of code. For example, a bunch of my review comments may
also correspond to udp.c (in fact they may originate from udp.c).
that's true - 90% of your c
We have create 6 patches based on latest
ffmpeg-master: 3282e31baaa77d161a4451c27ad0d45f78e1da0a
With these patches:
1. We modify HEVC plugin loading order, default to HW plugin,
since HEVC can be supported in SKL platform.
2. Move code in vaapi_allocator.c to ffmpeg_qsv.c, and re
From: ChaoX A Liu
Signed-off-by: ChaoX A Liu
---
configure | 3 +
libavcodec/qsv.c | 2 +-
libavcodec/qsv_internal.h | 2 +-
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/vf_vpp.c | 863 +
From: ChaoX A Liu
Signed-off-by: ChaoX A Liu
---
libavcodec/qsv.c | 7 ++-
libavcodec/qsv_internal.h | 1 +
libavcodec/qsvdec.c | 22 +-
libavcodec/qsvdec_h2645.c | 12
libavcodec/qsvdec_mpeg2.c | 6 ++
libavcodec/qsvdec_vc1.c | 6 ++
From: ChaoX A Liu
Signed-off-by: ChaoX A Liu
---
libavcodec/qsvdec.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c
index 47dd818..2075a23 100644
--- a/libavcodec/qsvdec.c
+++ b/libavcodec/qsvdec.c
@@ -370,13 +370,18 @@
From: ChaoX A Liu
Signed-off-by: ChaoX A Liu
---
ffmpeg_qsv.c| 46 ---
libavcodec/libavcodec.v | 1 +
libavcodec/qsv.h| 2 +
libavfilter/vf_vpp.c| 153
4 files changed, 172 insertions(+), 30 deletions(-)
From: ChaoX A Liu
Signed-off-by: ChaoX A Liu
---
ffmpeg.c | 2 +-
ffmpeg.h | 2 +
ffmpeg_opt.c | 2 +-
ffmpeg_qsv.c | 636 +-
libavcodec/qsv.h | 3 +
libavcodec/qsv_internal.
From: ChaoX A Liu
Signed-off-by: ChaoX A Liu
---
libavcodec/qsv.c | 89 ---
libavcodec/qsv_internal.h | 6 ++--
libavcodec/qsvdec.c | 16 ++---
libavcodec/qsvdec_h2645.c | 17 ++---
libavcodec/qsvenc.c | 12 +--
libav
Hi Paul,
Do you have any ideas of better name for this?
The term VPP is Video Processing Pipeline. This
abbreviation is used by Intel in their documentation.
Ex https://software.intel.com/en-us/node/628415
On 16.08.2016 17:14, Paul B Mahol wrote:
On 8/16/16, Nablet Developer wrote:
From
Hi Micheal,
Sure. Fixed. Will send with other changes (if other comments will
require them)
On 16.08.2016 21:33, Michael Niedermayer wrote:
On Tue, Aug 16, 2016 at 05:10:03PM +0700, Nablet Developer wrote:
From: ChaoX A Liu
Signed-off-by: ChaoX A Liu
---
configure
From: ChaoX A Liu
Signed-off-by: ChaoX A Liu
---
ffmpeg.c | 2 +-
ffmpeg.h | 2 +
ffmpeg_opt.c | 2 +-
ffmpeg_qsv.c | 636 +-
libavcodec/qsv.h | 3 +
libavcodec/qsv_internal.
From: ChaoX A Liu
Signed-off-by: ChaoX A Liu
---
libavcodec/qsvdec.c | 11 ---
1 file changed, 8 insertions(+), 3 deletions(-)
diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c
index 47dd818..2075a23 100644
--- a/libavcodec/qsvdec.c
+++ b/libavcodec/qsvdec.c
@@ -370,13 +370,18 @@
From: ChaoX A Liu
Signed-off-by: ChaoX A Liu
---
ffmpeg_qsv.c| 46 ---
libavcodec/libavcodec.v | 1 +
libavcodec/qsv.h| 2 +
libavfilter/vf_qsvvpp.c | 153
4 files changed, 172 insertions(+), 30 deletions(-)
From: ChaoX A Liu
This is updated version of patchset.
Fix for license reference.
Rename vpp filter to qsvvpp
ChaoX A Liu (6):
lavc/qsv(hevc): Change default plugin from hevc_sw to hevc_default,
which will load hevc_hw first, due to newly released MSDK.
lavf/vpp: Enable vpp filter, an
From: ChaoX A Liu
Signed-off-by: ChaoX A Liu
---
libavcodec/qsv.c | 89 ---
libavcodec/qsv_internal.h | 6 ++--
libavcodec/qsvdec.c | 16 ++---
libavcodec/qsvdec_h2645.c | 17 ++---
libavcodec/qsvenc.c | 12 +--
libav
From: ChaoX A Liu
Signed-off-by: ChaoX A Liu
---
configure | 3 +
libavcodec/qsv.c | 2 +-
libavcodec/qsv_internal.h | 2 +-
libavfilter/Makefile | 1 +
libavfilter/allfilters.c | 1 +
libavfilter/vf_qsvvpp.c | 864 +
From: ChaoX A Liu
Signed-off-by: ChaoX A Liu
---
libavcodec/qsv.c | 7 ++-
libavcodec/qsv_internal.h | 1 +
libavcodec/qsvdec.c | 22 +-
libavcodec/qsvdec_h2645.c | 12
libavcodec/qsvdec_mpeg2.c | 6 ++
libavcodec/qsvdec_vc1.c | 6 ++
ffmpeg_qsv.c | 636 +-
libavcodec/qsv.h | 3 +
libavcodec/qsv_internal.h | 2 +
libavcodec/qsvdec.c | 5 +-
libavcodec/qsvenc.c | 2 +
8 files changed, 649 insertions(+), 5 deletions(-)
This is a giant patch
patch is taken from libav project, authored by Anton Khirnov
https://lists.libav.org/pipermail/libav-devel/2016-May/077126.html
the only differences from original libav patch:
1) replaced CONFIG_LIBMXF with CONFIG_QSV to match the rest of ffmpeg sources
2) changed copyright headers to match ffmpeg
From: Anton Khirnov
Signed-off-by: nablet developer
---
libavutil/Makefile | 3 +
libavutil/hwcontext.c | 3 +
libavutil/hwcontext.h | 1 +
libavutil/hwcontext_internal.h | 1 +
libavutil/hwcontext_qsv.c | 791
Signed-off-by: Nablet Developer
---
libavcodec/qsvenc_h264.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/qsvenc_h264.c b/libavcodec/qsvenc_h264.c
index c1f6003..f5b01bb 100644
--- a/libavcodec/qsvenc_h264.c
+++ b/libavcodec/qsvenc_h264.c
@@ -53,7 +53,7
>
> you have set the author for your git to "Nablet Developer"
> is this intended? Do you not want your name to be in the Author field ?
> If you dont mind your name to be in the author field then please
> resubmit the patch with correct Author
>
yes, it's int
Signed-off-by: nablet developer
---
libavcodec/qsv.c | 64 +--
libavcodec/qsv.h | 53 +++
libavcodec/qsv_api.c | 26 +++
libavcodec/qsv_internal.h | 15 +--
libavcodec
>>
>> diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c
>> index 4c8e6b0..81d1f0c 100644
>> --- a/libavcodec/qsv.c
>> +++ b/libavcodec/qsv.c
>> @@ -18,14 +18,19 @@
>> * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301
>> USA
>> */
>>
>> -#include
>> -#include
>> -
>>
> On 11 Apr 2016, at 18:30, nablet developer wrote:
>
>
>>>
>>> diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c
>>> index 4c8e6b0..81d1f0c 100644
>>> --- a/libavcodec/qsv.c
>>> +++ b/libavcodec/qsv.c
>>> @@ -18,14 +18,19 @@
>
> On 13 Apr 2016, at 14:16, Hendrik Leppkes wrote:
>
> On Thu, Apr 7, 2016 at 5:44 PM, nablet developer wrote:
>>
>> +/**
>> + * Initialize a MSDK session
>> + *
>> + * Media SDK is based on sessions, so this is the prerequisite
>> + * initial
> On 13 Apr 2016, at 14:08, wm4 wrote:
>
> On Thu, 7 Apr 2016 11:44:20 -0400
> nablet developer mailto:s...@nablet.com>> wrote:
>
>> Signed-off-by: nablet developer
>> ---
>> libavcodec/qsv.c | 64
>> +---
> On 13 Apr 2016, at 14:33, wm4 wrote:
>
> On Wed, 13 Apr 2016 14:14:37 +0600
> nablet developer wrote:
>
>>> Why would this API need to be exported?
>>
>> previously QuickSync was used only by libavcodec and its components - e.g.
>> there are Q
> On 13 Apr 2016, at 14:48, Mark Thompson wrote:
>
> On 13/04/16 09:14, nablet developer wrote:
>>
>>> On 13 Apr 2016, at 14:08, wm4 wrote:
>>>
>>> On Thu, 7 Apr 2016 11:44:20 -0400
>>> nablet developer mailto:s...@nablet.com
Signed-off-by: nablet developer
---
libavcodec/qsv.c | 35 +---
libavcodec/qsv_internal.h | 5
libavcodec/qsvdec.c | 1 +
libavcodec/qsvenc.c | 1 +
libavutil/Makefile| 1 +
libavutil/qsv_internal.c | 58
> On 24 May 2016, at 17:01, Mark Thompson wrote:
>
> On 13/04/16 09:18, nablet developer wrote:
>> Signed-off-by: nablet developer
>> ---
>> libavcodec/qsv.c | 35 +---
>> libavcodec/qsv_internal.h | 5
>> libavco
nded with suggestion to implementa hwcontext_qsv)
nablet developer (5):
avutil/qsv: move ff_qsv_error function from libavcodec into libavutil,
because it's going to be shared between libavcodec (existing QSV
encoders & decoders), libavfilter (upcoming QSV VPP filter) and
lib
Signed-off-by: nablet developer
---
libavcodec/qsvenc.c | 29 +++--
libavcodec/qsvenc.h | 3 +--
2 files changed, 24 insertions(+), 8 deletions(-)
diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c
index 6145121..8eefa06 100644
--- a/libavcodec/qsvenc.c
+++ b
Signed-off-by: nablet developer
---
libavcodec/qsvdec.c | 29 ++---
libavcodec/qsvdec.h | 4 +---
2 files changed, 23 insertions(+), 10 deletions(-)
diff --git a/libavcodec/qsvdec.c b/libavcodec/qsvdec.c
index 5253a57..e21ed20 100644
--- a/libavcodec/qsvdec.c
+++ b
Signed-off-by: nablet developer
---
libavutil/Makefile | 3 +
libavutil/hwcontext.c | 3 +
libavutil/hwcontext.h | 1 +
libavutil/hwcontext_internal.h | 1 +
libavutil/hwcontext_qsv.c | 255 +
libavutil
Signed-off-by: nablet developer
---
libavcodec/qsv.c | 41 -
libavcodec/qsv_internal.h | 5
libavcodec/qsvdec.c | 7 +++---
libavcodec/qsvenc.c | 11 +
libavutil/Makefile| 1 +
libavutil/qsv_internal.c | 58
Signed-off-by: nablet developer
---
libavcodec/qsv.c | 186 --
libavcodec/qsv_internal.h | 30
2 files changed, 216 deletions(-)
diff --git a/libavcodec/qsv.c b/libavcodec/qsv.c
index 8cd03e8..22c99cf 100644
--- a/libavcodec/qsv.c
ping. any feedback?
> On 25 May 2016, at 19:20, nablet developer wrote:
>
> added hwcontext_qsv (Intel QuickSync video)
> it will handle MFX session initialization and deinitialization,
> and will allow to share that code between libavcodec and libavfilter
> without adding new
> On 06 Jun 2016, at 16:40, Mark Thompson wrote:
>
> On 06/06/16 09:25, nablet developer wrote:
>> ping. any feedback?
>
> Perhaps you could comment on the merits and functionality of your version as
> compared with the one here
> <https://lists.libav.org/piperma
> On 10 Jun 2016, at 00:48, Michael Niedermayer wrote:
>
> On Mon, Jun 06, 2016 at 05:25:41PM +0700, nablet developer wrote:
>>
>>> On 06 Jun 2016, at 16:40, Mark Thompson wrote:
>>>
>>> On 06/06/16 09:25, nablet developer wrote:
>>>> pin
Signed-off-by: nablet developer
---
libavutil/Makefile | 3 +
libavutil/hwcontext.c | 3 +
libavutil/hwcontext.h | 1 +
libavutil/hwcontext_internal.h | 1 +
libavutil/hwcontext_qsv.c | 791 +
libavutil
add hwcontext_qsv (Intel QuickSync Video) implementation
basically it's adapted patch from libav
(https://lists.libav.org/pipermail/libav-devel/2016-May/077126.html)
hwcontext_qsv is needed for VPP filter (which cannot use API functions from
libavcodec)
nablet developer (1):
hwcontext:
> On 06 Jul 2016, at 15:48, Hendrik Leppkes wrote:
>
> On Wed, Jul 6, 2016 at 9:08 AM, nablet developer wrote:
>> add hwcontext_qsv (Intel QuickSync Video) implementation
>> basically it's adapted patch from libav
>> (https://lists.libav.org/pipermail/libav-dev
existing generic hwcontext
approach instead of adding QSV specific API
> On 06 Jul 2016, at 15:40, Carl Eugen Hoyos wrote:
>
> nablet developer nablet.com> writes:
>
>> hwcontext_qsv is needed for VPP filter (which cannot use API
>> functions from libavcodec)
&g
On 12/25/2017 10:52 AM, nablet developer wrote:
On 19-Dec-17 15:01, nablet developer wrote:
On 13 Dec 2017, at 15:31, Nablet Developer wrote:
The protocol is used by thousands of Haivision customers since 2013,
in extremely sensitive medical, military and enterprise applications
with FIPS
On 1/13/2018 4:40 AM, Michael Niedermayer wrote:
On Wed, Dec 13, 2017 at 03:31:04PM +0700, Nablet Developer wrote:
[...]
this is commented out ?
yes, looks like leftover, thanks for pointing. will send updated patch soon.
___
ffmpeg-devel mailing
protocol requires libsrt (https://github.com/Haivision/srt) to be
installed
Signed-off-by: Nablet Developer
---
configure | 9 +
doc/protocols.texi | 116 +
libavformat/Makefile| 1 +
libavformat/opensrt.c | 622
On 16-Jan-18 09:43, Michael Niedermayer wrote:
if you will maintain this code then you may want to include a
change to the MAINTAINERs file
also does anyone have any more comments on this patch ?
it seems to have not gotten much attention recently. There where
reviews/comments a few months ago b
protocol requires libsrt (https://github.com/Haivision/srt) to be
installed
Signed-off-by: Nablet Developer
---
MAINTAINERS | 1 +
configure | 9 +
doc/protocols.texi | 116 +
libavformat/Makefile| 1 +
libavformat/opensrt.c | 621
On 1/31/2018 4:11 AM, Nablet Developer wrote:
protocol requires libsrt (https://github.com/Haivision/srt) to be
installed
Signed-off-by: Nablet Developer
---
ping
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman
If you or any other developer is against someone receiving git write access
you only need to object to the patch adding him to the MAINTAINERS file.
Thats one of the reasons why there is a MAINTAINERs file.
It would be ideal IMO if for each part of teh codebase at least one person
with write a
69 matches
Mail list logo
