On Fri, Aug 16, 2019 at 10:35:43 -0700, Ross Nicholson wrote:
> Need anything else Moritz?
No. I only made one remark ("can't understand your issue"), hoping to
push things forward with new facts for others to take into
consideration. I can't and won't judge whether your fix is reasonable
or requi
On Thu, Aug 15, 2019 at 23:49:15 +0200, Michael Niedermayer wrote:
> Subject: [FFmpeg-devel] [PATCH 7/7] avcodec/truemotion2: Fix multiple integer
> overflows in
... in what? Spurious " in"?
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
On Tue, Aug 20, 2019 at 20:53:43 +0530, Shivam wrote:
> Please review,
(Untested, just visual code inspection.)
> +- DICOM decoder and demxer
Typo -> demuxer. Also, when splitting the commits, also split the
changes to the Changelog. (Can still be one line eventually.)
> +.props = A
On Tue, Aug 20, 2019 at 20:53:43 +0530, Shivam wrote:
> I have also uploaded DICOM samples here.
> https://1drv.ms/u/s!AosJ9_SrP4Tsh2WoPfQAI8cSsqUs?e=ZMd5fR
I found something else, with valgrind:
> +static int read_implicit_seq_item(AVFormatContext *s, DataElement *de)
> +{
> +int ret, f = -2
On Tue, Aug 20, 2019 at 20:53:43 +0530, Shivam wrote:
One more. Some more nitpicking around this. Please use valgrind with
all your samples and some demuxing and decoding command lines.
> +static int dicom_read_packet(AVFormatContext *s, AVPacket *pkt)
> +{
> +DICOMContext *dicom = s->priv_da
On Thu, Aug 22, 2019 at 00:28:28 +0530, Shivam wrote:
> >> + dicom->height = *(uint16_t *)bytes;
> > does this work on big endian ?
> > maybe you where looking for AV_RL16()
>
> Big endian DICOM files are retired and no longer supported by the standard.
What Michael means: What happens if you use
On Wed, Aug 21, 2019 at 18:03:23 -0700, James Zern wrote:
> > From: elliottk
> > Current default is 256kbps, which produces inconsistent
> > results (too high for low-res, too low for hi-res).
> > Use CRF instead, which will adapt.
>
> lgtm. I'll apply this soon if there aren't any other comments.
On Thu, Aug 22, 2019 at 08:56:28 +0800, Guo, Yejun wrote:
> +/* This list must be iterated in reverse, so for the case that
> + * two regions overlapping, the more important area takes effect.
Nit: "overlap" or "are overlapping".
> +#ifdef VPX_CTRL_VP9E_SET_ROI_MAP
[...]
> +#endif
> +
> +
On Thu, Aug 22, 2019 at 00:18:54 +0200, Michael Niedermayer wrote:
Nits:
> Fixes: undefined mempcpy() use
memcpy
> +avpriv_request_sample(avctx, "overlaping mask");
overlapping
Cheers,
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ff
On Tue, Aug 20, 2019 at 16:37:35 +0300, Nick Renieris wrote:
> +static float av_always_inline linear_to_srgb(float value) {
> +if (value <= 0.0031308)
> +return value * 12.92;
> +else
> +return pow(value * 1.055, 1.0 / 2.4) - 0.055;
> +}
Do you need the intermediate double
On Tue, Aug 20, 2019 at 16:37:37 +0300, Nick Renieris wrote:
> Some JPEGs [1] have incorrect DHT entries that map 2 codes to
This [1] becomes part of the commit message, ...
> ---
>
> [1]: Embedded JPEGs in "X7 RAW" and "X7 CinemaDNG" samples here:
> https://www.dji.com/gr/zenmuse-x7/info#do
On Tue, Aug 20, 2019 at 16:37:38 +0300, Nick Renieris wrote:
> In an image [1], the height was equal to the tile length (full-height
Nit: "[1]" doesn't refer to anything here.
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.o
On Tue, Aug 20, 2019 at 16:37:40 +0300, Nick Renieris wrote:
> +/* Force endianness as mentioned in 'DNG Specification: Chapter 3:
> BitsPerSample'
> +NOTE: The spec actually specifies big-endian, not sure why we
> need little-endian,
> + but such images don't
On Mon, Aug 12, 2019 at 23:39:52 +0800, lance.lmw...@gmail.com wrote:
This looks very wrong. Does it work?
> -if (tt == TEST_ALL && frame%test->max_frames) /* draw a black frame at
> the beginning of each test */
> -tt = (frame/test->max_frames)%(TEST_NB-1);
> +frame = frame/test
On Thu, Aug 22, 2019 at 14:47:41 -0700, Aman Gupta wrote:
> The single planar support was for NV21 only.
^
Nit: NV12
> Add NV21 and YUV420P support.
>
> Signed-off-by: Aman Gupta
Cheers,
Moritz
___
ffmpeg-devel mail
On Sun, Aug 25, 2019 at 22:53:19 +0800, Steven Liu wrote:
Nitpicking:
> + * Get the HTTP shurdown reponse status, be used after http_shutdown.
^^
Typos: shutdown, response.
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ff
On Sun, Aug 25, 2019 at 03:20:13 +0530, Shivam wrote:
> The patch contains DICOM decoder. I have improved the code as suggested.
Hi Shivan,
nice job.
First of all, all your samples now appear to demux and decode properly.
I didn't get a chance to look at their output, but I guess you have
that co
On Sun, Aug 25, 2019 at 03:22:02 +0530, Shivam wrote:
> The patch contains DICOM demuxer. I have improved the code as suggested.
Second part of my review:
> From: Shivam Goyal <1998.goyal.shi...@gmail.com>
> Date: Sun, 25 Aug 2019 02:57:35 +0530
> Subject: [PATCH] lavf: Add DICOM demuxer
>
> ---
On Wed, Aug 28, 2019 at 00:44:24 +0530, Shivam wrote:
> > Again, here, I expect this to be a switch/case with one case only if it
> > can be expanded later, i.e. de->ElementNumber has multiple meanings
> > which aren't covered here.
> This would be expanded in my next patch, so, i thought this may
On Tue, Sep 04, 2018 at 02:29:51 +0200, Michael Niedermayer wrote:
> Subject: [PATCH] libavcodec/pnm_parser: do not loose skipped parts in
> reporting of how much was consumed
Nit: ^ lose
___
ffmpeg-devel maili
On Tue, Sep 04, 2018 at 07:43:10 +, Roman Arzumanyan wrote:
> Hi Timo,
>
> Refactored the patch according to your review:
> +{ "interp_algo","Interpolation algorithm used for transposing",
> OFFSET(interp_algo), AV_OPT_TYPE_INT,{ .i64 = NPPI_INTER_CUBIC }, 0,
> INT_MAX, FLAGS, "
On Mon, Jul 02, 2018 at 13:38:04 +0200, Moritz Barsnick wrote:
> Fixes #7293.
Ping.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On Fri, Jul 06, 2018 at 23:49:50 +0200, Moritz Barsnick wrote:
> Possibly useful in the error case.
Ping.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On Tue, Sep 11, 2018 at 21:49:33 +0200, Paul B Mahol wrote:
> +@table @samp
> +@item nearest
> +Use values from the nearest neighbor interpolation.
> +@item bilinear
> +Interpolate values using the bilinear interpolation.
> +@end table
Nit: Default is @code{nearest}.
Moritz
__
On Fri, Sep 14, 2018 at 14:24:04 +0200, Paul B Mahol wrote:
> This decodes more or less single sample we have.
Which sample would that be? This one?:
https://samples.ffmpeg.org/V-codecs/IMM5/20120917072000_CH05_330672916.avi
After your patch, it fails to decode with
> Too many packets buffered fo
ps://github.com/hile/soundforest/blob/master/soundforest/tags/formats/aac.py
indicates it might be "bpm", as does
http://edd.wp-a2z.org/oik_api/getid3_quicktimecopytoappropriatecommentssection/
Moritz Barsnick (2):
avformat/mov: add mov_metadata_int16()
avformat/mov: parse tmpo
It is assigned to the "tmpo" metadatakey, which may be incorrect, but
corresponds to the key used by avformat/movenc.
Signed-off-by: Moritz Barsnick
---
libavformat/mov.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index 03c39d0e5d..
Allows to read 16-bit integer atoms (currently only tmpo known to
be such).
Signed-off-by: Moritz Barsnick
---
libavformat/mov.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/libavformat/mov.c b/libavformat/mov.c
index ec57a05803..03c39d0e5d 100644
--- a/libavformat/mov.c
+++ b
_metadata (s, pb, "tmpo","bpm" , 2, 2);
as an additional translation (at the risk of duplicating the atom).
Otherwise: where in the libs or the application are metadata keys
translated?
Moritz Barsnick (3):
avformat/movenc: allow padding to two bytes in
mov
Padding to four bytes was already possible. This is in preparation for
being able to also write 16-bit integer atoms (and other currently
unneeded scenarios).
Signed-off-by: Moritz Barsnick
---
libavformat/movenc.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a
Removes code duplication.
Signed-off-by: Moritz Barsnick
---
libavformat/movenc.c | 20 +---
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 0bb66e5fd1..52f661e061 100644
--- a/libavformat/movenc.c
+++ b/libavformat
Converted from mov_write_int8_metadata(), allowing to also write
16-bit and 32-bit integer atoms, at up to 32-bit total size.
Converted mov_write_int8_metadata() into a macro specifying a
truncation of one byte length.
Signed-off-by: Moritz Barsnick
---
libavformat/movenc.c | 22
On Sat, Sep 22, 2018 at 15:09:19 +0200, Paul B Mahol wrote:
> +@item bn
> +Set custom band noise for every one of 15 bands.
Nit: Probably need to explain the syntax (15, or upto 15(?), '|' separated
integers?).
Moritz
___
ffmpeg-devel mailing list
ffmp
On Sun, Sep 23, 2018 at 22:52:56 +0100, Mark Thompson wrote:
> const VAEntrypoint *usable_entrypoints;
> -const VAAPIEncodeProfile *profile;
> -const AVPixFmtDescriptor *desc;
> +const VAAPIEncodeProfile *profile;const AVPixFmtDescriptor *desc;
This change doesn't look intenti
On Mon, Sep 24, 2018 at 12:39:42 +0100, James Courtier-Dutton wrote:
> Automatically create sub-directories if needed based on date.
> E.g.
> ffmpeg ... -timelimit 2147483647 -f segment -strftime 1 -segment_time 10
> "%Y/%m/%d/%Y-%m-%d_%H-%M-%S.mkv"
[...]
> +static int mkdir_p(const char *path) {
On Tue, Sep 25, 2018 at 08:49:25 +, Jeyapal, Karthick wrote:
> > It is a duplicate from hisenc.c. hisenc already has this "create
> > sub-directories" feature, but I needed it for the segment use case.
> > I made it static so that it would be treated as local to the .c file.
> > I don't know f
> +The standard deviation of Gaussian blur to be applied on the scene. Must be
^ to
> +The power applied to the weight map to emphasis heigher weights. Must be
> chosen
^ emphasize
> +The angular e
On Mon, Oct 01, 2018 at 18:02:19 +0200, Mina wrote:
> >> +The power applied to the weight map to emphasis heigher weights. Must be
> >> chosen
> >^ emphasize
>
> British spelling but done.
Your call, but "emphasis" was wrong either way, because that's
On Sat, Oct 06, 2018 at 14:30:11 +0200, Paul B Mahol wrote:
> Signed-off-by: Paul B Mahol
> ---
> libavfilter/avf_showspectrum.c | 31 +++
> 1 file changed, 23 insertions(+), 8 deletions(-)
doc/filters.texi needs to be adapted as well.
Moritz
On Sun, Oct 07, 2018 at 18:02:27 +0200, Daniel Molkentin wrote:
> +to instead display short-term loundness (see @var{gaugetype}).
^ loudness
> +Set the value displayed by the gauge. Valid values are m (momentary) and s
> (short-term).
On Sun, Oct 07, 2018 at 23:19:54 +0200, Daniel Molkentin wrote:
> +enum {
> +GAUGE_TYPE_MOMENTARY = 0,
> +GAUGE_TYPE_SHORTTERM = 1,
> +};
> +{ "gauge", "set gauge display type", OFFSET(gauge_type),
> AV_OPT_TYPE_INT, {.i64 = 0 }, 0, INT_MAX, V|F, "gaugetype" },
min and max range shoul
On Sun, Oct 07, 2018 at 23:19:55 +0200, Daniel Molkentin wrote:
> +continous log output.
^ continuous
(Sorry, I probably missed this first time round.)
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffm
On Sun, Oct 07, 2018 at 23:19:56 +0200, Daniel Molkentin wrote:
> +Sets the display scale for the loudness. Valid parameters are @code{absolute}
> +(in LUFS) or @code{relative} (LU) relative to the target. This only affects
> the
> +video output, not the summary or continous log output.
On Thu, Oct 11, 2018 at 16:45:02 +0200, Timo Rothenpieler wrote:
> This patch is corrupted, also needs a more meaningful commit message.
Valery previously sent the patch as an attachment, which looked okay.
(Perhaps needed a better commit message nevertheless.)
Moritz
On Sat, Oct 13, 2018 at 23:14:59 +0200, Paul B Mahol wrote:
I see a few promotions from float to double arithmetic in here. Note
that initializations don't matter, the preprocessor handles assigning a
double to a float and downscales (casts) automatically. But
float_var = float_var * double_const
On Wed, Oct 17, 2018 at 21:40:58 +0200, Giulio Benetti wrote:
> PS: do I need to remove your e-mail on TO field every time I reply to
> you? It's not a problem, only to know.
This mailing list uses a Reply-To: header, pointing at the list
address. Your Thuderbird should honor that automatically (
On Sat, Oct 20, 2018 at 22:42:55 -0400, Leo Izen wrote:
> On 10/20/18 6:47 PM, Michael Niedermayer wrote:
> > This will not apply as it has too many newlines
> What do you mean by "this will not apply"? Do you mean attempting to
> apply the patch fails? What do newline characters have anything to
On Tue, Oct 23, 2018 at 15:52:40 +0800, Zachary Zhou wrote:
> It supports clockwise rotation by 0/90/180/270 degrees defined in
> va/va_vpp.h, tested following command line on SKL platform
Since these angles of rotation are called "transpose" in ffmpeg's other
filters (transpose, transpose_npp), s
On Tue, Oct 23, 2018 at 09:56:04 +, Li, Zhong wrote:
> Not sure vaapi can expose more angles or not.
VAAPI's rotation_state only supports those four "angles":
http://01org.github.io/libva_staging_doxygen/struct__VAProcPipelineParameterBuffer.html#ae05cc1f2189c9e85339f7c63e9a61e1c
> But using
On Thu, Oct 25, 2018 at 14:34:49 -0800, Lou Logan wrote:
> On Wed, Oct 24, 2018, at 11:04 AM, Paul B Mahol wrote:
Additional nit:
> > +The filter accept the following option:
^ accepts
Otherwise I agree with Lou's corrections.
Practical filter btw., should save users from a lot
On Thu, Oct 25, 2018 at 20:36:10 +0800, Zhong Li wrote:
> RepeatPPS is enabled by default in mfx. It is not necessary mostly and
> wasting encoding bits.
> Add an option to control it and disable it by default.
Could this change in behavior surprise anyone? If it's okay to change,
perhaps at least
On Thu, Oct 25, 2018 at 20:36:07 +0800, Zhong Li wrote:
> +{ "forced_idr", "Forcing I frames as IDR frames",
> OFFSET(qsv.forced_idr), AV_OPT_TYPE_INT, { .i64 = -1 }, -1, 1,
> VE }, \
ffmpeg uses imperative (mostly): "Force I frames as IDR frames"
On Fri, Oct 26, 2018 at 11:16:02 +0300, Anton Platov wrote:
> +{ "extra_ips", "Find available sources on extra ip addresses",
> OFFSET(extra_ips), AV_OPT_TYPE_STRING, {.str = NULL }, 0, 0, DEC },
^
This makes it sound like a boolean option (i.e. whether to find).
On Mon, Nov 05, 2018 at 09:50:13 +0800, Linjie Fu wrote:
> It's an experimental function(like lowpower in vaapi) with
Should it be under "-strict experimental" then?
> module parameter(i915.enable_guc=2 for linux kerner version >= 4.16)
^ kernel
> [
On Thu, Nov 15, 2018 at 00:29:00 +0100, Philippe Symons wrote:
> Here is the new version of the patch in which the comments on the curly
> braces have been resolved as well.
Style-wise, there are other issues. (I'm not judging technically here.)
> Subject: [PATCH] [HLS] Add LANGUAGE attribute to
> +if (dec_ctx->rc_max_rate > 0) print_val ("max_bit_rate",
> dec_ctx->rc_max_rate, unit_bit_per_second_str);
> +else print_str_opt("max_bit_rate", "N/A");
> if (dec_ctx && dec_ctx->bits_per_raw_sample > 0)
> print_fmt("bits_per_raw_sample", "%d", dec_ctx->bi
On Sat, Nov 24, 2018 at 02:44:45 +0100, Timo Rothenpieler wrote:
> +// available then add/substract them here.
^ nit: subtract
> -{"extra_hw_frames", "Number of extra hardware frames to allocate for the
> user", OFFSET(extra_hw_frames), AV_OPT_TYPE
On Wed, Nov 28, 2018 at 20:10:11 +0530, Karthick J wrote:
> +// If url is an empty string("") don't write sidx atom.
> +if (s->url[0] == '\0')
> +return res;
Probably clearer if you return 0, as res hasn't been assigned anything
up to this point, except its
On Mon, Oct 01, 2018 at 18:09:46 +0200, Mina wrote:
Nit:
> +be chosen in the range [1,20] and default value is 1.
[...]
> +chosen in the range [0.2,1024.0] and default value = 1.
A bit inconsistent here, with "is" vs. "=".
> +The max number of iterations for performing the algorithm. Must be ch
On Sun, Dec 02, 2018 at 13:38:49 +0800, Jun Zhao wrote:
> Changelog |2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
This belongs merged into the commit which implements this.
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
ht
On Sun, Dec 02, 2018 at 13:38:48 +0800, Jun Zhao wrote:
> +{"intra_ref_type", "Intra Refresh Type 0: No intra refresh 1: CRA (Open
> GOP) 2: IDR", OFFSET(svt_param.intra_ref_type), AV_OPT_TYPE_INT, { .i64 = 1
> }, 1, 2, VE },
[...]
> +{"profile", "Profile now support[1,2], Main Still Pict
On Tue, Dec 04, 2018 at 22:25:29 +0800, Jun Zhao wrote:
> This wrapper work with SVT-HEVC new_api branch, more information can get
> from https://github.com/intel/SVT-HEVC/blob/new_api/ffmpeg_plugin/.
Is this API stable? (I have heard voices that the external library
wrapper shouldn't aim at a mo
On Fri, Dec 07, 2018 at 14:01:03 +, Adrian Grzeca wrote:
Please read the coding guidelines here:
https://www.ffmpeg.org/developer.html#Coding-Rules-1
Your indentation is incorrect, incl. use of tabs, which is not
supported in the ffmpeg code base. Also, your brackets and whitespace
are incorr
On Mon, Dec 10, 2018 at 02:54:54 +0100, Carl Eugen Hoyos wrote:
> I hope somebody can prove me wrong!
Not sure, see below.
> This would need a slightly more sophisticated update to the decoder.
Because it is also presumed incorrect?
> put_bits(p, 16, 0x0102);
> put_bits(p, 8,
On Mon, Dec 10, 2018 at 13:19:57 +0100, Carl Eugen Hoyos wrote:
> > units (1 byte) Units for the X and Y densities.
> > units = 0: no units, X and Y specify the pixel aspect ratio
> > units = 1: X and Y are dots per inch
> > units = 2: X and Y are dots per cm
> > Xdensity (2 bytes)
On Wed, Dec 12, 2018 at 12:48:21 +0530, Karthick J wrote:
> Apple doesn't have an official spec for LHLS. Meanwhile hls.js player folks
> are
> trying to standardize a open LHLS spec. The draft spec is available in
> https://github.com/video-dev/hlsjs-rfcs/blob/lhls-spec/proposals/0001-lhls.md
>
On Wed, Dec 12, 2018 at 17:32:53 +0100, Paul B Mahol wrote:
> Based on patch by Bjorn Roche.
[...]
> + * Copyright (c) 2018 Byorn Roche
The second name is misspelt.
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/l
On Wed, Dec 12, 2018 at 17:32:56 +0100, Paul B Mahol wrote:
> -.long_name = NULL_IF_CONFIG_SMALL("GIF Animation"),
> +.long_name = NULL_IF_CONFIG_SMALL("CompuServe Graphics Interchange
> Format (GIF)"),
Why is this string different from the one in 6/6?
Moritz
__
On Tue, Feb 18, 2020 at 02:40:49 +, Soft Works wrote:
> It's often not obvious how option constants relate to numerical values.
> Defaults are sometimes printed as numbers and from/to are always printed as
> numbers.
> Printing the numeric values of options constants avoids this confusion.
> I
On Wed, Feb 26, 2020 at 13:53:34 +0800, Xinpeng Sun wrote:
> configure | 3 +
> doc/filters.texi | 51
> libavfilter/Makefile | 1 +
> libavfilter/allfilters.c | 1 +
> libavfilter/vf_overlay_vaapi.c | 426 +
Welcome to ffmpeg!
Since review has now started, I want to point out what was missed:
On Wed, Feb 26, 2020 at 12:26:37 +0530, Anamitra Ghorui wrote:
> a. Please tell me if I am right or wrong here:
> 1. Each audio/video/image file format has a parser for converting the
>file data into a form
Hi Wang,
On Wed, Mar 04, 2020 at 05:59:02 +0800, Wang Cao wrote:
> Subject: libavcodec/libaomenc.c: Add a libaom command-line opton 'tune'
^
typo -> option
> doc/encoders.texi | 11 +++
> libavcodec/libaomenc.c | 7 +
On Wed, Mar 04, 2020 at 05:59:03 +0800, Wang Cao wrote:
> Signed-off-by: Wang Cao
> ---
> doc/encoders.texi | 39 +++
> libavcodec/libaomenc.c | 38 ++
Again, I suggest bumping MICRO once more.
> +@item superres_denomin
On Mon, Mar 02, 2020 at 05:44:36 +0100, Andreas Rheinhardt wrote:
> -{ "header", "filename of the header where the initialization data will
> be written", OFFSET(header_filename), AV_OPT_TYPE_STRING, { 0 }, 0, 0,
> AV_OPT_FLAG_ENCODING_PARAM },
> +{ "header", "filename of the header where
On Thu, Mar 05, 2020 at 11:01:19 +0100, Alfred E. Heggestad wrote:
> -avio_printf(out,
> "\tsuggestedPresentationDelay=\"PT%"PRId64"S\"\n", c->last_duration /
> AV_TIME_BASE);
> +avio_printf(out,
> "\tsuggestedPresentationDelay=\"PT%.3fS\"\n", (double)c->last_duration /
> AV
On Thu, Mar 05, 2020 at 15:41:17 +0800, Linjie Fu wrote:
> +int SubWidthC, SubHeightC;
Style nit:
ffmpeg's own variables don't use CamelCase.
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-dev
On Sat, Mar 07, 2020 at 14:15:55 +, Zane van Iperen wrote:
> - cas video filter
> -
> +- High Voltage Software ADPCM decoder
> +- LEGO Racers ALP (.tun & .pcm) demuxer
Changelog (and doc, patch 4/4) should be added with the respective
functional patch.
Oh, and don't remove that empty line fr
On Tue, Mar 10, 2020 at 14:15:26 +, Zane van Iperen wrote:
> It was just to clean things up a bit by keeping them together.
> Otherwise, 'tis no matter.
Does it actually build? Nothing seems to depend on adpcm_data.o.
Moritz
___
ffmpeg-devel mailing
On Tue, Mar 10, 2020 at 15:10:39 +, Zane van Iperen wrote:
> "Moritz Barsnick" wrote:
> > Does it actually build? Nothing seems to depend on adpcm_data.o.
> As for dependencies, seems there's 48 references to adpcm_data.o, all in
> libavcodec/Makefile:
Sor
Hi Marshall,
On Sat, Mar 14, 2020 at 15:58:32 +0530, Marshall Murmu wrote:
> +{"soundfont", "location of soundfont",
> OFFSET(soundfont), AV_OPT_TYPE_STRING, {.str=NULL}, CHAR_MIN,
> CHAR_MAX, FLAGS},
I don't think we define ranges for AV_OPT_TYPE_STRING.
>
On Tue, Mar 17, 2020 at 01:21:15 +0800, numberwolf wrote:
> Subject: not display motionless vectors in examples/extract_mvs.c
Please do have a look at other commits in the repository. This would be
examples/extract_mvs: don't display motionless vectors.
> Here, dont need show motionless vectors,
On Sun, Mar 22, 2020 at 09:59:21 +0100, Steve Lhomme wrote:
> Always use a comma at the end, order elements by value.
IIUC, this is strictly a C99(+) "feature", so should probably be
mentioned here:
https://ffmpeg.org/developer.html#C-language-features
in case "all compilers we care about" support
On Tue, Feb 18, 2020 at 18:41:08 +0330, Mostafa Namazi fard wrote:
> I found this patch useful for prevent crash in http live stream.
> I'm using ffmpeg in my application for show http live when remote address
> send invalid data ffmpeg crash in this part and after my change it was
> fixed.
Can yo
On Sat, Mar 28, 2020 at 13:32:42 +, Tom Needham wrote:
> + * License along with FFmpeg; if not, write to the Free Software
> + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
> 02110-1301 USA
You've inlined your patch again, and again it's corrupted by newlines.
> +unsigned ch
On Sat, Mar 21, 2020 at 12:46:09 +0800, numberwolf wrote:
> Subject: examples/extract_mvs.c: dont disply motionless vectors
Two typos in the commit message: -> don't display
> Reviewed-by: Paul B Mahol
Please don't do this. (Not speaking for Paul here, but in general, this
doesn't really make s
On Mon, Mar 30, 2020 at 10:36:30 +0530, gautamr...@gmail.com wrote:
> -if (bytestream2_get_bytes_left(&s->g) == 0 && s->bit_index == 8) {
> -if (*tp_index < FF_ARRAY_ELEMS(tile->tile_part) - 1) {
> -s->g = tile->tile_part[++(*tp_index)].tpg;
> +// Select appropriate stre
On Mon, Mar 30, 2020 at 10:36:31 +0530, gautamr...@gmail.com wrote:
> +tile->has_ppt = 1; // this tile has a ppt marker
> +/*Zppt = */ bytestream2_get_byte(&s->g);
For readability, please place the explanation of what has been ignored
behind the statement. (This line looks commented out w
On Mon, Mar 30, 2020 at 10:36:32 +0530, gautamr...@gmail.com wrote:
> +av_log(s->avctx, AV_LOG_WARNING, "Mising EOC Marker.\n");
Typo: Missing
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/f
On Mon, Mar 30, 2020 at 15:27:46 -0700, John Rummell wrote:
> +if (c->aes_decrypt)
> +av_free(c->aes_decrypt);
av_free() already does the NULL pointer check for you.
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg
On Sat, Mar 28, 2020 at 22:12:45 +0100, Michael Niedermayer wrote:
> +if (ctx->tex_size != (avctx->coded_width / TEXTURE_BLOCK_W)
> +*(avctx->coded_height / TEXTURE_BLOCK_H)
> +*tex_rat[t]) {
It would be easier to recognize that this is a multiplication and not a
d
On Thu, Apr 02, 2020 at 15:33:02 +0200, Nicolas George wrote:
> If there are no actual practical arguments against bool, from either you
> or somebody else, then I suggest we leave this one as it is and no
> longer reject patches based on this.
I though this was the practical argument?:
http://ff
On Sun, Apr 05, 2020 at 10:28:17 +0530, gautamr...@gmail.com wrote:
> +tile->has_ppt = 1; // this tile has a ppt marker
> +/*Zppt = */ bytestream2_get_byte(&s->g); // Zppt is skipped and not used
I don't know what others think, but, as mentioned in my first review, I
really dislike this s
On Sat, Apr 04, 2020 at 18:53:41 +0900, Ryo Hirafuji wrote:
> AV1 support lossless encoding.
> In this patch, I added a command line flag to enable it.
> @@ -154,7 +158,7 @@ static av_cold void dump_enc_cfg(AVCodecContext *avctx,
> av_log(avctx, level, "aom_codec_enc_cfg\n");
> av_log(av
On Sun, Apr 05, 2020 at 17:59:28 +0200, Andreas Rheinhardt wrote:
> -if ((t = av_dict_get(c->metadata, "title", NULL, 0))) {
> +if (t = av_dict_get(c->metadata, "title", NULL, 0)) {
Isn't the extra set of brackets there to tell the compiler that the
assignment is on purpose?
Morit
On Mon, Apr 06, 2020 at 11:05:50 +0200, Andreas Rheinhardt wrote:
> > Isn't the extra set of brackets there to tell the compiler that the
> > assignment is on purpose?
> The assignment is already on purpose without these extra brackets.
> (What compiler thinks it is not on purpose? By "thinks" you
On Wed, Apr 08, 2020 at 09:45:57 +0800, Limin Wang wrote:
> On Wed, Apr 08, 2020 at 02:16:23AM +0200, pkv wrote:
> > Can you produce code broken by that change ?
>
> What's your command line?
> I recall If use AV_OPT_TYPE_DURATION for option, the default is in unit of
> second if your
> don't add
On Sat, Apr 11, 2020 at 21:44:07 +0800, Jun Zhao wrote:
> From: Jun Zhao
>
> dump dolby vison side data.
^ You have this typo in several of your commit messages
and sources.
Moritz
___
ffmpeg-devel mailing list
ffmpeg-devel@f
On Wed, Apr 15, 2020 at 01:32:16 +0530, YATENDRA SINGH wrote:
As Michael noted, please resend without broken like feeds. I can't read
most of the diff the way it is now.
Some notes nevertheless:
> Signed-off-by: Yatendra Singh
> ---
> libavfilter/Makefile| 1 +
> libavfilter/allf
On Thu, Apr 16, 2020 at 18:39:58 +0530, YATENDRA SINGH wrote:
> > As Michael noted, please resend without broken like feeds. I can't read
> > most of the diff the way it is now.
> >
> Sorry but I could not understand what broken by newlines mean. Can you
> explain a little bit further?
Your mailer
On Wed, Feb 03, 2021 at 20:37:35 +0200, Jan Ekström wrote:
>
> +@item @code{input_options @var{key=value:key2=value2}}
> +Input options passed on when reading a specific file, using a :-separated
> list
> +of key=value pairs. Requires @code{safe} to be non-positive. Global options
> for
> +all fi
101 - 200 of 1029 matches
Mail list logo
