Re: [FFmpeg-devel] [PATCH 1/2] checkasm: add sbrdsp tests

2017-06-28 Thread Matthieu Bouron
On Fri, Jun 23, 2017 at 05:01:35PM +0200, Matthieu Bouron wrote: > On Thu, Jun 22, 2017 at 12:53:52PM -0300, James Almer wrote: > > On 6/22/2017 9:56 AM, Matthieu Bouron wrote: > > > --- > > > > > > The following patchset applies o

Re: [FFmpeg-devel] [PATCH 1/2] checkasm: add sbrdsp tests

2017-06-30 Thread Matthieu Bouron
On Fri, Jun 30, 2017 at 03:55:52PM +0200, Michael Niedermayer wrote: > On Thu, Jun 29, 2017 at 10:53:06PM -0300, James Almer wrote: > > On 6/29/2017 10:14 PM, Henrik Gramner wrote: > > > On Fri, Jun 30, 2017 at 1:58 AM, Michael Niedermayer > > > wrote: > > >> Program received signal SIGSEGV, Segme

[FFmpeg-devel] [PATCH] lavf/utils: update stream duration only if it is not set or 0

2017-07-03 Thread Matthieu Bouron
--- The following patch makes lavf/utils only update stream duration only if it is not set or 0 in fill_all_stream_timings (which is called by avformat_find_stream_info). In the context of mov demuxing, the patch makes the last packet duration the same as the one declared in the stts table for ex

Re: [FFmpeg-devel] [PATCH 1/2] checkasm: add sbrdsp tests

2017-07-03 Thread Matthieu Bouron
On Fri, Jun 30, 2017 at 05:16:37PM +0200, Matthieu Bouron wrote: > On Fri, Jun 30, 2017 at 03:55:52PM +0200, Michael Niedermayer wrote: > > On Thu, Jun 29, 2017 at 10:53:06PM -0300, James Almer wrote: > > > On 6/29/2017 10:14 PM, Henrik Gramner wrote: > > > > O

Re: [FFmpeg-devel] [PATCH] lavc/mediacodec: add missing newline on warning

2017-07-03 Thread Matthieu Bouron
On Mon, Jul 03, 2017 at 11:07:36AM -0700, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/mediacodecdec_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mediacodecdec_common.c > b/libavcodec/mediacodecdec_common.c > index 1263188d34..f88b2c

Re: [FFmpeg-devel] [PATCH] lavc/mediacodec: rescale pts before decoding for both hw and sw buffers

2017-07-03 Thread Matthieu Bouron
On Mon, Jul 03, 2017 at 09:21:50AM -0700, Aman Gupta wrote: > From: Aman Gupta > > Replicates the logic used in the wrap_hw_buffer path to wrap_sw_buffer > as well. > > This fixes decoding issues observed on AMLogic devices with > OMX.amlogic.mpeg2.decoder.awesome, where the decoder would spit o

Re: [FFmpeg-devel] [PATCH] lavf/utils: update stream duration only if it is not set or 0

2017-07-04 Thread Matthieu Bouron
On Tue, Jul 04, 2017 at 12:31:59PM +0200, Michael Niedermayer wrote: > On Mon, Jul 03, 2017 at 02:02:24PM +0200, Matthieu Bouron wrote: > > --- > > > > The following patch makes lavf/utils only update stream duration only if it > > is > > not set or 0 in fill_al

Re: [FFmpeg-devel] [PATCH] lavf/utils: update stream duration only if it is not set or 0

2017-07-04 Thread Matthieu Bouron
On Tue, Jul 04, 2017 at 05:24:45PM +0200, Matthieu Bouron wrote: > On Tue, Jul 04, 2017 at 12:31:59PM +0200, Michael Niedermayer wrote: > > On Mon, Jul 03, 2017 at 02:02:24PM +0200, Matthieu Bouron wrote: > > > --- > > > > > > The following patch makes lavf/ut

Re: [FFmpeg-devel] [PATCH] checkasm/aarch64: fix tests returning a float

2017-07-05 Thread Matthieu Bouron
Le 6 juil. 2017 4:08 AM, "James Almer" a écrit : On 6/22/2017 5:35 AM, Matthieu Bouron wrote: > On Wed, Jun 21, 2017 at 10:19:33PM +0200, Matthieu Bouron wrote: >> On Wed, Jun 21, 2017 at 04:57:53PM -0300, James Almer wrote: >>> On 6/19/2017 6:08 AM, Matthieu Bouron w

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mxfenc: Check that the video codec in D-10 is MPEG-2

2017-08-29 Thread Matthieu Bouron
On Tue, Aug 29, 2017 at 02:13:20AM +0200, Michael Niedermayer wrote: > Others do not work, but nothing rejects them prior to this patch if the > parameters otherwise match > > Signed-off-by: Michael Niedermayer > --- > libavformat/mxfenc.c | 4 > 1 file changed, 4 insertions(+) > > diff --

Re: [FFmpeg-devel] [PATCH] avformat/mxfenc: add jpeg2000 support

2014-09-30 Thread Matthieu Bouron
On Tue, Sep 30, 2014 at 3:37 PM, Benoit Fouet wrote: > Hi, > Hi Benoit, Thanks for your patch. I've reviewed the ULs values and they look good to me. > > this patch adds support for j2k muxing in MXF. > tested with: > $ ffmpeg -t 5 -f lavfi -i testsrc -y -c:v libopenjpeg -y out.mxf > > Played

Re: [FFmpeg-devel] [PATCH] Changelog: add Android content URIs protocol entry

2024-03-26 Thread Matthieu Bouron
On Tue, Mar 26, 2024 at 04:30:53PM +0100, Stefano Sabatini wrote: > On date Monday 2024-03-25 09:14:15 +0100, Matthieu Bouron wrote: > > --- > > Changelog | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/Changelog b/Changelog > > index

Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec, avformat/ffjni: fix duplicate JNI symbols

2024-04-01 Thread Matthieu Bouron
On Wed, Mar 27, 2024 at 09:06:19AM -0400, Leo Izen wrote: > Use SHLIBOBJS and STLIBOBJS in the Makefiles for avcodec and avformat, > and add a stub ffjni.c to libavformat, which allows the symbols to be > duplicated for shared builds but not static builds. > > Signed-off-by: Leo Izen > --- > lib

Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec, avformat/ffjni: fix duplicate JNI symbols

2024-04-02 Thread Matthieu Bouron
On Mon, Apr 01, 2024 at 10:03:54AM +0200, Matthieu Bouron wrote: > On Wed, Mar 27, 2024 at 09:06:19AM -0400, Leo Izen wrote: > > Use SHLIBOBJS and STLIBOBJS in the Makefiles for avcodec and avformat, > > and add a stub ffjni.c to libavformat, which allows the symbols to be >

Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec, avformat/ffjni: fix duplicate JNI symbols

2024-04-04 Thread Matthieu Bouron
On Tue, Apr 02, 2024 at 02:55:16PM +0200, Matthieu Bouron wrote: > On Mon, Apr 01, 2024 at 10:03:54AM +0200, Matthieu Bouron wrote: > > On Wed, Mar 27, 2024 at 09:06:19AM -0400, Leo Izen wrote: > > > Use SHLIBOBJS and STLIBOBJS in the Makefiles for avcodec and avformat, &g

[FFmpeg-devel] [PATCH] avcodec/jni: fix mixed declaration and code

2024-04-04 Thread Matthieu Bouron
--- libavcodec/jni.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavcodec/jni.c b/libavcodec/jni.c index 1193c608c3..fcb4837413 100644 --- a/libavcodec/jni.c +++ b/libavcodec/jni.c @@ -84,11 +84,13 @@ void *av_jni_get_java_vm(void *log_ctx) int av_jni_set_android_app_

Re: [FFmpeg-devel] [RFC] Bump minimum required version of Android to 5.0

2024-04-12 Thread Matthieu Bouron
On Thu, Apr 11, 2024 at 2:17 PM Zhao Zhili wrote: > > We don’t have a minimum required version of Android in FFmpeg. > libavdevice/android_camera requires Android 7, Java MediaCodec > requires Android 4.1, and NDK MediaCodec requires Android 5.0. > > Without an explicit version, it’s unclear for d

Re: [FFmpeg-devel] [PATCH] avcodec/jni: fix mixed declaration and code

2024-04-15 Thread Matthieu Bouron
On Thu, Apr 04, 2024 at 10:07:25PM +0200, Matthieu Bouron wrote: > --- > libavcodec/jni.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/jni.c b/libavcodec/jni.c > index 1193c608c3..fcb4837413 100644 > --- a/libavcodec/jni.c >

Re: [FFmpeg-devel] [PATCH] avcodec/jni: fix mixed declaration and code

2024-04-21 Thread Matthieu Bouron
On Mon, Apr 15, 2024 at 07:02:36PM +0200, Matthieu Bouron wrote: > On Thu, Apr 04, 2024 at 10:07:25PM +0200, Matthieu Bouron wrote: > > --- > > libavcodec/jni.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/j

[FFmpeg-devel] [PATCH] avcodec/mediacodecdec_common: make INFO_TRY_AGAIN trace messages more consistent

2018-03-12 Thread Matthieu Bouron
--- libavcodec/mediacodecdec_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mediacodecdec_common.c b/libavcodec/mediacodecdec_common.c index 5064809cf6..058825a1a2 100644 --- a/libavcodec/mediacodecdec_common.c +++ b/libavcodec/mediacodecdec_common.c @

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec_common: make INFO_TRY_AGAIN trace messages more consistent

2018-03-12 Thread Matthieu Bouron
On Mon, Mar 12, 2018 at 01:24:02AM -0700, Aman Gupta wrote: > On Mon, Mar 12, 2018 at 1:16 AM, Matthieu Bouron > wrote: > > > --- > > libavcodec/mediacodecdec_common.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --gi

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: fix immediate EAGAIN with buffered packet

2018-03-13 Thread Matthieu Bouron
On Tue, Mar 13, 2018 at 02:46:57AM -0700, Aman Gupta wrote: > From: Aman Gupta > > In cases where the mediacodec decoder consumed a partial packet, > receive_frame() would start returning EAGAIN if the rest of the > packet couldn't be flushed and no frames were immediately available. > > This fi

[FFmpeg-devel] [PATCH] avcodec/mediacodecdec_common: make stride and slice-height non-mandatory fields

2018-04-11 Thread Matthieu Bouron
Fixes decoding on the Samsung Chromebook Pro which do not set the codec output format stride and slice-height fields. --- libavcodec/mediacodecdec_common.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mediacodecdec_common.c b/libavcodec/mediacodecdec_common.c

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec_common: make stride and slice-height non-mandatory fields

2018-04-16 Thread Matthieu Bouron
On Wed, Apr 11, 2018 at 3:14 PM, Matthieu Bouron wrote: > Fixes decoding on the Samsung Chromebook Pro which do not set the codec > output format stride and slice-height fields. > --- > libavcodec/mediacodecdec_common.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec_common: make stride and slice-height non-mandatory fields

2018-04-18 Thread Matthieu Bouron
On Mon, Apr 16, 2018 at 03:53:23PM +0200, Matthieu Bouron wrote: > On Wed, Apr 11, 2018 at 3:14 PM, Matthieu Bouron > wrote: > > > Fixes decoding on the Samsung Chromebook Pro which do not set the codec > > output format stride and slice-height fields. &g

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec_common: make stride and slice-height non-mandatory fields

2018-04-19 Thread Matthieu Bouron
On Wed, Apr 18, 2018 at 6:13 PM, Matthieu Bouron wrote: > On Mon, Apr 16, 2018 at 03:53:23PM +0200, Matthieu Bouron wrote: > > On Wed, Apr 11, 2018 at 3:14 PM, Matthieu Bouron < > matthieu.bou...@gmail.com> > > wrote: > > > > > Fixes decoding on the Sams

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec_common: make stride and slice-height non-mandatory fields

2018-04-19 Thread Matthieu Bouron
On Thu, Apr 19, 2018 at 02:08:58PM +0200, Hendrik Leppkes wrote: > On Thu, Apr 19, 2018 at 1:57 PM, Matthieu Bouron > wrote: > > On Wed, Apr 18, 2018 at 6:13 PM, Matthieu Bouron > > wrote: > > > >> On Mon, Apr 16, 2018 at 03:53:23PM +0200, Matthieu Bouron wrote:

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/mediacodecdec: use AV_TIME_BASE_Q

2018-04-25 Thread Matthieu Bouron
On Tue, Apr 24, 2018 at 01:59:24PM -0700, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/mediacodecdec_common.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/libavcodec/mediacodecdec_common.c > b/libavcodec/mediacodecdec_common.c > index 0c27624dea

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/mediacodecdec: refactor pts handling

2018-04-25 Thread Matthieu Bouron
On Tue, Apr 24, 2018 at 01:59:25PM -0700, Aman Gupta wrote: > From: Aman Gupta > > Also fixes a bug where EOS buffer was sent with incorrect > pts when not using surface generation. > --- > libavcodec/mediacodecdec_common.c | 17 ++--- > 1 file changed, 6 insertions(+), 11 deletions(

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/mediacodecdec: clarify delay_flush specific code

2018-04-25 Thread Matthieu Bouron
On Tue, Apr 24, 2018 at 01:59:23PM -0700, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/mediacodecdec.c| 24 +++- > libavcodec/mediacodecdec_common.c | 12 > 2 files changed, 15 insertions(+), 21 deletions(-) > > diff --git a/libavcodec/media

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/mediacodecdec: restructure mediacodec_receive_frame

2018-04-26 Thread Matthieu Bouron
On Tue, Apr 24, 2018 at 01:59:26PM -0700, Aman Gupta wrote: > From: Aman Gupta > > This fixes issues reported on some devices where both > avcodec_send_packet and avcodec_receive_frame can return EAGAIN > at the same time, instead of one or the other blocking. > > The new logic follows a recomme

Re: [FFmpeg-devel] [PATCH v2 4/4] avcodec/mediacodecdec: add workaround for buggy amlogic mpeg2 decoder

2018-05-03 Thread Matthieu Bouron
On Wed, May 02, 2018 at 07:25:00PM -0700, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/mediacodecdec.c | 22 +++--- > 1 file changed, 19 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c > index 2ac22dd1f6..3a4240

Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec/mediacodecdec: restructure mediacodec_receive_frame

2018-05-03 Thread Matthieu Bouron
On Wed, May 02, 2018 at 07:24:58PM -0700, Aman Gupta wrote: > From: Aman Gupta > > The new logic follows a recommendation by @rcombs to use > dequeueInputBuffer with a timeout of 0 as a way to detect > whether the codec wants more data. The dequeued buffer index is > kept in MediaCodecDecContext

Re: [FFmpeg-devel] [PATCH v2 3/4] avcodec/mediacodecdec: wait on first frame after input buffers are full

2018-05-03 Thread Matthieu Bouron
On Wed, May 02, 2018 at 07:24:59PM -0700, Aman Gupta wrote: > From: Aman Gupta > > The output_buffer_count==0 special case is no longer required, and > can cause spurious EAGAIN to surface to the user when input buffers > are filled up. Since the caller now knows if the decoder is accepting > new

Re: [FFmpeg-devel] [PATCH v2 2/4] avcodec/mediacodecdec: restructure mediacodec_receive_frame

2018-05-04 Thread Matthieu Bouron
On Thu, May 03, 2018 at 10:24:49AM -0700, Aman Gupta wrote: > On Thu, May 3, 2018 at 12:33 AM, Matthieu Bouron > wrote: > > > On Wed, May 02, 2018 at 07:24:58PM -0700, Aman Gupta wrote: > > > From: Aman Gupta > > > > > > The new logic

Re: [FFmpeg-devel] [PATCH v2] libavcodec/mediacodecdec: switch to new decoder api

2018-01-03 Thread Matthieu Bouron
if (got_frame) > +return 0; > + > +return AVERROR(EAGAIN); got_frame is always 1 here, returning 0 should be enough. [...] Let me know if the attached updated patch works for you. Best regards, -- Matthieu B. >From 1f2bd9721973de9a4d83f5b2c9a5f1de793f641d Mon Sep 17 00

[FFmpeg-devel] [PATCH] lavc/mediacodecdec: remove mediacodec_process_data() indirection

2018-01-03 Thread Matthieu Bouron
--- libavcodec/mediacodecdec.c | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c index b698ceaef9..c0e91c9429 100644 --- a/libavcodec/mediacodecdec.c +++ b/libavcodec/mediacodecdec.c @@ -415,15 +415,6 @@ done:

[FFmpeg-devel] [PATCH] lavc/mediacodec_wrapper: allocate MediaCodec.BufferInfo once

2018-01-03 Thread Matthieu Bouron
--- libavcodec/mediacodec_wrapper.c | 61 +++-- 1 file changed, 34 insertions(+), 27 deletions(-) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index d9f0e27a7d..dbc37bf463 100644 --- a/libavcodec/mediacodec_wrapper.c +++ b/liba

Re: [FFmpeg-devel] [PATCH] lavc/mediacodecdec: remove mediacodec_process_data() indirection

2018-01-06 Thread Matthieu Bouron
On Wed, Jan 03, 2018 at 04:53:07PM -0800, Aman Gupta wrote: > On Wed, Jan 3, 2018 at 4:17 AM, Matthieu Bouron > wrote: > > > --- > > libavcodec/mediacodecdec.c | 11 +-- > > 1 file changed, 1 insertion(+), 10 deletions(-) > > > > diff --git a/

Re: [FFmpeg-devel] [PATCH] lavc/mediacodec_wrapper: allocate MediaCodec.BufferInfo once

2018-01-06 Thread Matthieu Bouron
On Wed, Jan 03, 2018 at 04:53:39PM -0800, Aman Gupta wrote: > On Wed, Jan 3, 2018 at 6:05 AM, Matthieu Bouron > wrote: > > > --- > > libavcodec/mediacodec_wrapper.c | 61 +++--- > > --- > > 1 file changed, 34 insertions(+), 27

Re: [FFmpeg-devel] [PATCH v2] libavcodec/mediacodecdec: switch to new decoder api

2018-01-06 Thread Matthieu Bouron
On Wed, Jan 03, 2018 at 04:54:28PM -0800, Aman Gupta wrote: > On Wed, Jan 3, 2018 at 3:25 AM, Matthieu Bouron > wrote: > > > On Thu, Dec 28, 2017 at 05:33:14PM -0800, Aman Gupta wrote: > > > From: Aman Gupta > > > > > > Using the new API gives the dec

Re: [FFmpeg-devel] [PATCH] lavc/aarch64/sbrdsp_neon: fix build on old binutils

2018-01-26 Thread Matthieu Bouron
On Thu, Jan 25, 2018 at 09:44:55PM -0600, Rodger Combs wrote: > --- > libavcodec/aarch64/sbrdsp_neon.S | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/aarch64/sbrdsp_neon.S > b/libavcodec/aarch64/sbrdsp_neon.S > index d1d79b749c..d23717e760 100644 > --- a/liba

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: refactor to take advantage of new decoding api

2018-02-16 Thread Matthieu Bouron
On Thu, Feb 15, 2018 at 07:52:14PM -0800, Aman Gupta wrote: > From: Aman Gupta Hi, > > This refactor splits up the main mediacodec decode loop into two > send/receive helpers, which are then used to rewrite the receive_frame > callback and take full advantage of the new decoding api. Since we >

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: refactor to take advantage of new decoding api

2018-02-19 Thread Matthieu Bouron
On Fri, Feb 16, 2018 at 05:40:03PM +, Aman Gupta wrote: > On Fri, Feb 16, 2018 at 4:01 AM Matthieu Bouron > wrote: > > > On Thu, Feb 15, 2018 at 07:52:14PM -0800, Aman Gupta wrote: > > > From: Aman Gupta > > > > Hi, > > > > > > >

[FFmpeg-devel] [PATCH 1/7] avcodec/mediacodecdec_common: refactor mediacodec_dec_parse_format()

2018-03-02 Thread Matthieu Bouron
--- libavcodec/mediacodecdec_common.c | 82 ++- 1 file changed, 30 insertions(+), 52 deletions(-) diff --git a/libavcodec/mediacodecdec_common.c b/libavcodec/mediacodecdec_common.c index b44abaef7f..ab26df04bd 100644 --- a/libavcodec/mediacodecdec_common.c +++

[FFmpeg-devel] [PATCH 4/7] avcodec/mediacodec_wrapper: load and use MediaFormat.constainsKey()

2018-03-02 Thread Matthieu Bouron
Avoids triggering an exception in MediaFormat getter functions if the key does not exists. --- libavcodec/mediacodec_wrapper.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index dbc37b

[FFmpeg-devel] [PATCH 5/7] avcodec/mediacodecdec: add missing "libavutil/internal.h" include

2018-03-02 Thread Matthieu Bouron
libavutil/internal.h defines NULL_IF_CONFIG_SMALL. --- libavcodec/mediacodecdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c index 363e12427e..ad09d16398 100644 --- a/libavcodec/mediacodecdec.c +++ b/libavcodec/mediacodecdec.c @@ -28

[FFmpeg-devel] [PATCH 2/7] avcodec/mediacodecdec_common: remove spurious space

2018-03-02 Thread Matthieu Bouron
--- libavcodec/mediacodecdec_common.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/mediacodecdec_common.c b/libavcodec/mediacodecdec_common.c index ab26df04bd..195cc70ba7 100644 --- a/libavcodec/mediacodecdec_common.c +++ b/libavcodec/mediacodecdec_common.c @@ -415,7 +415,6 @@ fa

[FFmpeg-devel] [PATCH 3/7] avcodec/mediacodecdec_common: remove unused field from MediaCodecDecContext

2018-03-02 Thread Matthieu Bouron
--- libavcodec/mediacodecdec_common.c | 2 +- libavcodec/mediacodecdec_common.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/mediacodecdec_common.c b/libavcodec/mediacodecdec_common.c index 195cc70ba7..929db78361 100644 --- a/libavcodec/mediacodecdec_common.c ++

[FFmpeg-devel] [PATCH 7/7] avcodec/mediacodecdec: factorize codec declarations

2018-03-02 Thread Matthieu Bouron
--- libavcodec/mediacodecdec.c | 116 ++--- 1 file changed, 24 insertions(+), 92 deletions(-) diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c index 4579da1fa5..5e9714ee6e 100644 --- a/libavcodec/mediacodecdec.c +++ b/libavcodec/mediacod

[FFmpeg-devel] [PATCH 6/7] avcodec/mediacodecdec: factorize common extradata functions

2018-03-02 Thread Matthieu Bouron
--- libavcodec/mediacodecdec.c | 41 + 1 file changed, 9 insertions(+), 32 deletions(-) diff --git a/libavcodec/mediacodecdec.c b/libavcodec/mediacodecdec.c index ad09d16398..4579da1fa5 100644 --- a/libavcodec/mediacodecdec.c +++ b/libavcodec/mediacodecdec.

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/mediacodecdec: factorize codec declarations

2018-03-03 Thread Matthieu Bouron
On Fri, Mar 02, 2018 at 04:24:24PM -0800, Aman Gupta wrote: > On Fri, Mar 2, 2018 at 4:13 PM, Matthieu Bouron > wrote: > > > --- > > libavcodec/mediacodecdec.c | 116 ++ > > --- > > 1 file changed, 24 insertions(+), 92

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/mediacodecdec: factorize codec declarations

2018-03-03 Thread Matthieu Bouron
On Sat, Mar 03, 2018 at 02:12:32PM +0100, Matthieu Bouron wrote: > On Fri, Mar 02, 2018 at 04:24:24PM -0800, Aman Gupta wrote: > > On Fri, Mar 2, 2018 at 4:13 PM, Matthieu Bouron > > wrote: > > > > > --- > >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mediacodec: reduce loglevel for per-frame logging

2018-03-06 Thread Matthieu Bouron
On Tue, Mar 06, 2018 at 01:33:19PM -0800, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/mediacodecdec_common.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mediacodecdec_common.c > b/libavcodec/mediacodecdec_common.c > index 929db78361..0bd660

Re: [FFmpeg-devel] [PATCH 2/2] MAINTAINERS: add myself to mediacodec

2018-03-06 Thread Matthieu Bouron
+++ b/MAINTAINERS > @@ -268,7 +268,7 @@ Hardware acceleration: >crystalhd.c Philip Langdale >dxva2*Hendrik Leppkes, Laurent Aimar, > Steve Lhomme >d3d11va* Steve Lhomme > - media

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodec_wrapper: blacklist more software decoders

2018-03-06 Thread Matthieu Bouron
On Tue, Mar 06, 2018 at 06:00:27PM +, Stefan _ wrote: > Hi, > > for hwdec on Android the wrapper attempts to blacklist known software > decoders also provided through the mediacodec API. The list isn't complete > however and ffmpeg might e.g. prefer slower "external" HEVC software decoding

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodec_wrapper: fix false positives in swdec blacklist

2018-03-07 Thread Matthieu Bouron
On Wed, Mar 07, 2018 at 01:35:20AM +0200, Jan Ekström wrote: > On Wed, Mar 7, 2018 at 12:19 AM, Stefan _ wrote: > > Hi, > > > > attached patch fixes an issue with the previous mediacodec patch. > > > > LGTM. > > `strstr(name, "OMX.SEC") && strstr(name, ".sw.")` > > ..will most likely have less

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mediacodecdec: add delay_flush option

2018-03-07 Thread Matthieu Bouron
On Tue, Mar 06, 2018 at 01:15:55PM -0800, Aman Gupta wrote: > From: Aman Gupta > > The default behavior of the mediacodec decoder before this commit > was to delay flushes until all pending hardware frames were > returned to the decoder. This was useful for certain types of > applications, but wa

[FFmpeg-devel] Add protocol for Android content providers

2024-02-13 Thread Matthieu Bouron
Hi, On Android, content providers are used for accessing files through shared mechanisms. One typical case would be an app willing to open a video from Google Photos, gallery apps, TikTok, Instagram or some other providers. A content URI looks something like "content://authority/path/id", see: htt

[FFmpeg-devel] [PATCH 1/7] avcodec: move ffjni to avutil/jniutils

2024-02-13 Thread Matthieu Bouron
\ integer.o\ intmath.o \ + jni.o\ lfg.o

[FFmpeg-devel] [PATCH 2/7] avutil: add av_jni_{get, set}_android_app_ctx helper

2024-02-13 Thread Matthieu Bouron
This will allow users to pass the Android ApplicationContext which is mandatory to retrieve the ContentResolver responsible to resolve/open Android content-uri. --- libavutil/jni.c | 28 libavutil/jni.h | 17 + 2 files changed, 45 insertions(+) diff --

[FFmpeg-devel] [PATCH 3/7] avformat: add Android content resolver protocol support

2024-02-13 Thread Matthieu Bouron
Handles Android content-uri starting with content://. --- configure | 2 + doc/APIchanges | 3 + libavformat/Makefile| 1 + libavformat/file.c | 157 libavformat/protocols.c | 1 + 5 files changed, 164 insertions(+)

[FFmpeg-devel] [PATCH 4/7] avutil/jni: use size_t to store structure offsets

2024-02-13 Thread Matthieu Bouron
--- libavutil/jniutils.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavutil/jniutils.h b/libavutil/jniutils.h index 2be401c974..01f3acb88d 100644 --- a/libavutil/jniutils.h +++ b/libavutil/jniutils.h @@ -24,6 +24,7 @@ #define AVUTIL_JNIUTILS_H #include +#include

[FFmpeg-devel] [PATCH 6/7] avcodec/mediacodec_wrapper: use an OFFSET() macro where relevant

2024-02-13 Thread Matthieu Bouron
Reduces a bit the horizontal spacing. --- libavcodec/mediacodec_wrapper.c | 138 +--- 1 file changed, 72 insertions(+), 66 deletions(-) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index bc3eb0a80d..536b5b8e81 100644 --- a/libavcodec/m

[FFmpeg-devel] [PATCH 5/7] avutil/jni: remove unnecessary NULL checks before calling DeleteLocalRef()

2024-02-13 Thread Matthieu Bouron
Delete{Global,Local}Ref() already handle NULL. --- libavutil/jniutils.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/libavutil/jniutils.c b/libavutil/jniutils.c index 89623af3f8..beedf24c0d 100644 --- a/libavutil/jniutils.c +++ b/libavutil/jniutils.c @@ -236,

[FFmpeg-devel] [PATCH 7/7] avcodec/mediacodec_wrapper: remove unnecessary NULL checks before calling Delete{Global, Local}Ref()

2024-02-13 Thread Matthieu Bouron
Delete{Global,Local}Ref already handle NULL. --- libavcodec/mediacodec_wrapper.c | 189 1 file changed, 47 insertions(+), 142 deletions(-) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index 536b5b8e81..19d63e2ba0 100644 --- a/liba

Re: [FFmpeg-devel] [PATCH 1/7] avcodec: move ffjni to avutil/jniutils

2024-02-14 Thread Matthieu Bouron
On Wed, Feb 14, 2024 at 07:18:04PM +0100, Michael Niedermayer wrote: > On Tue, Feb 13, 2024 at 11:50:09PM +0100, Matthieu Bouron wrote: > > This will allow to use the jni utils in libavformat. This will be mostly > > useful > > to add Android content-uri support. > >

Re: [FFmpeg-devel] [PATCH 1/7] avcodec: move ffjni to avutil/jniutils

2024-02-14 Thread Matthieu Bouron
On Wed, Feb 14, 2024 at 11:31:21PM +, Mark Thompson wrote: > On 13/02/2024 22:50, Matthieu Bouron wrote: > > This will allow to use the jni utils in libavformat. This will be mostly > > useful > > to add Android content-uri support. > > > > This deprecates av

Re: [FFmpeg-devel] Add protocol for Android content providers

2024-02-14 Thread Matthieu Bouron
On Thu, Feb 15, 2024 at 12:13:59PM +0800, Zhao Zhili wrote: > > > > On Feb 14, 2024, at 06:50, Matthieu Bouron > > wrote: > > > > Hi, > > > > On Android, content providers are used for accessing files through shared > > mechanisms. One typi

Re: [FFmpeg-devel] Add protocol for Android content providers

2024-02-15 Thread Matthieu Bouron
Le jeu. 15 févr. 2024, 9:46 AM, Zhao Zhili a écrit : > > > 在 2024年2月15日,下午3:57,Matthieu Bouron 写道: > > > > On Thu, Feb 15, 2024 at 12:13:59PM +0800, Zhao Zhili wrote: > >> > >> > >>>> On Feb 14, 2024, at 06:50, Matthieu Bouron > wrote:

Re: [FFmpeg-devel] Add protocol for Android content providers

2024-02-24 Thread Matthieu Bouron
On Thu, Feb 15, 2024 at 10:13:03AM +0100, Matthieu Bouron wrote: > Le jeu. 15 févr. 2024, 9:46 AM, Zhao Zhili a > écrit : > > > > > > 在 2024年2月15日,下午3:57,Matthieu Bouron 写道: > > > > > > On Thu, Feb 15, 2024 at 12:13:59PM +0800, Zhao Zhili wrote: > &

Re: [FFmpeg-devel] Add protocol for Android content providers

2024-02-26 Thread Matthieu Bouron
On Sat, Feb 24, 2024 at 12:29:24PM +0100, Matthieu Bouron wrote: > On Thu, Feb 15, 2024 at 10:13:03AM +0100, Matthieu Bouron wrote: > > Le jeu. 15 févr. 2024, 9:46 AM, Zhao Zhili a > > écrit : > > > > > > > > > 在 2024年2月15日,下午3:57,Matthieu Bouron 写道: &

Re: [FFmpeg-devel] Add protocol for Android content providers

2024-02-27 Thread Matthieu Bouron
On Tue, Feb 27, 2024 at 09:14:04PM +0800, Zhao Zhili wrote: > > > > On Feb 27, 2024, at 15:17, Matthieu Bouron > > wrote: > > > > On Sat, Feb 24, 2024 at 12:29:24PM +0100, Matthieu Bouron wrote: > >> On Thu, Feb 15, 2024 at 10:13:03AM +0100, Matthieu Bo

Re: [FFmpeg-devel] [PATCH 2/7] avutil: add av_jni_{get, set}_android_app_ctx helper

2024-02-27 Thread Matthieu Bouron
On Tue, Feb 27, 2024 at 02:42:01PM +0100, Andreas Rheinhardt wrote: > Matthieu Bouron: > > This will allow users to pass the Android ApplicationContext which is > > mandatory > > to retrieve the ContentResolver responsible to resolve/open Android > > content-uri. &

[FFmpeg-devel] Add protocol for Android content providers (v2)

2024-02-27 Thread Matthieu Bouron
Diff from initial patchset: - directly include libavcodec/ffjni.c from libavformat/file.c instead of migrating ffjni to libavutil (avpriv_*) - check that the passed application context reference is a global one and error out if it's not the case -- Matthieu __

[FFmpeg-devel] [PATCH v2 1/6] avcodec: add av_jni_{get, set}_android_app_ctx helper

2024-02-27 Thread Matthieu Bouron
This will allow users to pass the Android ApplicationContext which is mandatory to retrieve the ContentResolver responsible to resolve/open Android content-uri. --- libavcodec/jni.c | 40 libavcodec/jni.h | 17 + 2 files changed, 57 insertio

[FFmpeg-devel] [PATCH v2 2/6] avformat: add Android content resolver protocol support

2024-02-27 Thread Matthieu Bouron
Handles Android content-uri starting with content://. --- configure | 2 + doc/APIchanges | 3 + libavcodec/jni.c| 3 +- libavformat/Makefile| 1 + libavformat/file.c | 157 libavformat/protocols.c | 1 + 6

[FFmpeg-devel] [PATCH v2 3/6] avutil/jni: use size_t to store structure offsets

2024-02-27 Thread Matthieu Bouron
--- libavcodec/ffjni.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/ffjni.h b/libavcodec/ffjni.h index 6027bac0ab..d5894609ed 100644 --- a/libavcodec/ffjni.h +++ b/libavcodec/ffjni.h @@ -24,6 +24,7 @@ #define AVCODEC_FFJNI_H #include +#include /* * At

[FFmpeg-devel] [PATCH v2 4/6] avutil/jni: remove unnecessary NULL checks before calling DeleteLocalRef()

2024-02-27 Thread Matthieu Bouron
Delete{Global,Local}Ref() already handle NULL. --- libavcodec/ffjni.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/libavcodec/ffjni.c b/libavcodec/ffjni.c index e3cf24d3e2..69d9a9faa3 100644 --- a/libavcodec/ffjni.c +++ b/libavcodec/ffjni.c @@ -236,17 +236,9

[FFmpeg-devel] [PATCH v2 5/6] avcodec/mediacodec_wrapper: use an OFFSET() macro where relevant

2024-02-27 Thread Matthieu Bouron
Reduces a bit the horizontal spacing. --- libavcodec/mediacodec_wrapper.c | 138 +--- 1 file changed, 72 insertions(+), 66 deletions(-) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index 0880ddd3ef..78cd28f53d 100644 --- a/libavcodec/m

[FFmpeg-devel] [PATCH v2 6/6] avcodec/mediacodec_wrapper: remove unnecessary NULL checks before calling Delete{Global, Local}Ref()

2024-02-27 Thread Matthieu Bouron
Delete{Global,Local}Ref already handle NULL. --- libavcodec/mediacodec_wrapper.c | 189 1 file changed, 47 insertions(+), 142 deletions(-) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index 78cd28f53d..306359071e 100644 --- a/liba

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecenc: Add a hint message to use nv12 pix_fmt

2024-03-04 Thread Matthieu Bouron
On Mon, Mar 04, 2024 at 11:37:58AM +0800, Zhao Zhili wrote: > From: Zhao Zhili > > --- > libavcodec/mediacodecenc.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/mediacodecenc.c b/libavcodec/mediacodecenc.c > index 086b545590..984014f1b1 100644 > --- a/libavcodec/mediac

Re: [FFmpeg-devel] Add protocol for Android content providers (v2)

2024-03-04 Thread Matthieu Bouron
On Tue, Feb 27, 2024 at 03:50:36PM +0100, Matthieu Bouron wrote: > Diff from initial patchset: > - directly include libavcodec/ffjni.c from libavformat/file.c instead of > migrating ffjni to libavutil (avpriv_*) > - check that the passed application context reference is a global one

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec: add av_jni_{get, set}_android_app_ctx helper

2024-03-04 Thread Matthieu Bouron
On Mon, Mar 4, 2024 at 12:29 PM Andreas Rheinhardt wrote: > > Matthieu Bouron: > > This will allow users to pass the Android ApplicationContext which is > > mandatory > > to retrieve the ContentResolver responsible to resolve/open Android > > content-uri. >

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec: add av_jni_{get, set}_android_app_ctx helper

2024-03-04 Thread Matthieu Bouron
On Mon, Mar 4, 2024 at 4:11 PM Matthieu Bouron wrote: > > On Mon, Mar 4, 2024 at 12:29 PM Andreas Rheinhardt > wrote: > > > > Matthieu Bouron: > > > This will allow users to pass the Android ApplicationContext which is > > > mandatory > > > to ret

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec: add av_jni_{get, set}_android_app_ctx helper

2024-03-04 Thread Matthieu Bouron
On Mon, Mar 04, 2024 at 05:35:36PM +0100, Matthieu Bouron wrote: > On Mon, Mar 4, 2024 at 4:11 PM Matthieu Bouron > wrote: > > > > On Mon, Mar 4, 2024 at 12:29 PM Andreas Rheinhardt > > wrote: [...] > > > > > > I am against adding stub functions on

Re: [FFmpeg-devel] [PATCH v2 2/6] avformat: add Android content resolver protocol support

2024-03-04 Thread Matthieu Bouron
On Tue, Feb 27, 2024 at 03:50:38PM +0100, Matthieu Bouron wrote: > Handles Android content-uri starting with content://. > --- [...] New patch attached (I moved an unrelated chunk to the previous commit). >From 6ef059b721c1b1635565cc9e7d836be4733c928d Mon Sep 17 00:00:00 2001 From:

Re: [FFmpeg-devel] [PATCH v2 3/6] avutil/jni: use size_t to store structure offsets

2024-03-04 Thread Matthieu Bouron
On Mon, Mar 04, 2024 at 09:10:49PM +0100, Andreas Rheinhardt wrote: > Matthieu Bouron: > > --- > > libavcodec/ffjni.h | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/ffjni.h b/libavcodec/ffjni.h > > index

Re: [FFmpeg-devel] Add protocol for Android content providers (v2)

2024-03-14 Thread Matthieu Bouron
On Mon, Mar 04, 2024 at 09:21:43AM +0100, Matthieu Bouron wrote: > On Tue, Feb 27, 2024 at 03:50:36PM +0100, Matthieu Bouron wrote: > > Diff from initial patchset: > > - directly include libavcodec/ffjni.c from libavformat/file.c instead of > > migrating ffjni to libavutil (

[FFmpeg-devel] Add protocol for Android content providers (v4)

2024-03-17 Thread Matthieu Bouron
Diff with previous iteration: - rebaed on latest master - applied feedback from Zhao (removed HAVE_SETMODE block, use a typedef struct, check that the fd is seekable, moved doc/APIChanges changes to the right commit) ___ ffmpeg-devel mailing list ffm

[FFmpeg-devel] [PATCH v4 1/6] avcodec: add av_jni_{get, set}_android_app_ctx helper

2024-03-17 Thread Matthieu Bouron
This will allow users to pass the Android ApplicationContext which is mandatory to retrieve the ContentResolver responsible to resolve/open Android content-uri. --- doc/APIchanges | 3 +++ libavcodec/jni.c | 42 ++ libavcodec/jni.h | 17 +

[FFmpeg-devel] [PATCH v4 2/6] avformat: add Android content resolver protocol support

2024-03-17 Thread Matthieu Bouron
Handles Android content-uri starting with content://. --- configure | 2 + libavcodec/jni.c| 1 + libavformat/Makefile| 1 + libavformat/file.c | 160 libavformat/protocols.c | 1 + 5 files changed, 165 insertions(+)

[FFmpeg-devel] [PATCH v4 3/6] avcodec/jni: use size_t to store structure offsets

2024-03-17 Thread Matthieu Bouron
--- libavcodec/ffjni.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/ffjni.h b/libavcodec/ffjni.h index 6027bac0ab..d1e86f8329 100644 --- a/libavcodec/ffjni.h +++ b/libavcodec/ffjni.h @@ -24,6 +24,7 @@ #define AVCODEC_FFJNI_H #include +#include /* * At

[FFmpeg-devel] [PATCH v4 4/6] avcodec/jni: remove unnecessary NULL checks before calling DeleteLocalRef()

2024-03-17 Thread Matthieu Bouron
Delete{Global,Local}Ref() already handle NULL. --- libavcodec/ffjni.c | 14 +++--- 1 file changed, 3 insertions(+), 11 deletions(-) diff --git a/libavcodec/ffjni.c b/libavcodec/ffjni.c index e3cf24d3e2..69d9a9faa3 100644 --- a/libavcodec/ffjni.c +++ b/libavcodec/ffjni.c @@ -236,17 +236,9

[FFmpeg-devel] [PATCH v4 5/6] avcodec/mediacodec_wrapper: use an OFFSET() macro where relevant

2024-03-17 Thread Matthieu Bouron
Reduces a bit the horizontal spacing. --- libavcodec/mediacodec_wrapper.c | 138 +--- 1 file changed, 72 insertions(+), 66 deletions(-) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index 0880ddd3ef..78cd28f53d 100644 --- a/libavcodec/m

[FFmpeg-devel] [PATCH v4 6/6] avcodec/mediacodec_wrapper: remove unnecessary NULL checks before calling Delete{Global, Local}Ref()

2024-03-17 Thread Matthieu Bouron
Delete{Global,Local}Ref already handle NULL. --- libavcodec/mediacodec_wrapper.c | 189 1 file changed, 47 insertions(+), 142 deletions(-) diff --git a/libavcodec/mediacodec_wrapper.c b/libavcodec/mediacodec_wrapper.c index 78cd28f53d..306359071e 100644 --- a/liba

Re: [FFmpeg-devel] [PATCH v2 2/6] avformat: add Android content resolver protocol support

2024-03-17 Thread Matthieu Bouron
On Sun, Mar 17, 2024 at 12:33:04PM +0800, Zhao Zhili wrote: > Sorry for the long delay of review. > > > On Mar 5, 2024, at 03:37, Matthieu Bouron wrote: > > > > On Tue, Feb 27, 2024 at 03:50:38PM +0100, Matthieu Bouron wrote: > >> Handles Android

Re: [FFmpeg-devel] [PATCH v4 1/6] avcodec: add av_jni_{get, set}_android_app_ctx helper

2024-03-17 Thread Matthieu Bouron
On Sun, Mar 17, 2024 at 11:38 PM Andreas Rheinhardt wrote: > > Matthieu Bouron: > > This will allow users to pass the Android ApplicationContext which is > > mandatory > > to retrieve the ContentResolver responsible to resolve/open Android > > content-uri. >

Re: [FFmpeg-devel] Add protocol for Android content providers (v4)

2024-03-19 Thread Matthieu Bouron
On Sun, Mar 17, 2024 at 11:28:31PM +0100, Matthieu Bouron wrote: > Diff with previous iteration: > - rebaed on latest master > - applied feedback from Zhao (removed HAVE_SETMODE block, use a typedef > struct, > check that the fd is seekable, moved doc/APIChanges changes to the r

Re: [FFmpeg-devel] Add protocol for Android content providers (v4)

2024-03-23 Thread Matthieu Bouron
On Tue, Mar 19, 2024 at 06:49:43PM +0100, Matthieu Bouron wrote: > On Sun, Mar 17, 2024 at 11:28:31PM +0100, Matthieu Bouron wrote: > > Diff with previous iteration: > > - rebaed on latest master > > - applied feedback from Zhao (removed HAVE_SETMODE block, use a typedef &g

<    1   2   3   4   5   6   7   >