[FFmpeg-devel] Does ffmpeg allow negative cts_offset in mp4 trun box?

2016-09-30 Thread Matt Wolenetz
Per spec, if cts_offset is signed, the box version needs to be set to 1. Yet I see no corresponding condition around this in libavformat/movenc.c; version is hardcoded to 0 and the *signed int32* typed value is written out. This can cause issues in players if they follow the spec and expect a vers

Re: [FFmpeg-devel] [PATCH 2/2] avformat/oggdec: Fix metadata memleak on multiple headers

2018-03-07 Thread Matt Wolenetz
Friendly ping. I'd like to not have to land this in Chromium before upstream ffmpeg, but I may need to soon. On Tue, Mar 6, 2018 at 1:56 PM, Michael Niedermayer wrote: > Fixes: Chromium bug 800123 > Reported-by: Matt Wolenetz > Reviewed-by: Matt Wolenetz > Signed-off-by: Mi

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mov: Fix integer overflow in mov_get_stsc_samples()

2018-03-07 Thread Matt Wolenetz
> Fixes: Chromium bug 817338 > Reviewed-by: Matt Wolenetz > Reported-by: Matt Wolenetz > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/oggparsevorbis: Fix memleak on multiple headers

2018-03-07 Thread Matt Wolenetz
Friendly ping. I'd like to not have to land this in Chromium before upstream ffmpeg, but I may need to soon. On Tue, Mar 6, 2018 at 1:56 PM, Michael Niedermayer wrote: > Fixes: Chromium bug 800123 > Reported-by: Matt Wolenetz > Reviewed-by: Matt Wolenetz > Signed-off-by: Mi