[FFmpeg-devel] [PATCH] libaom: Dont use aom_codec_av1_dx_algo.

2021-10-20 Thread Matt Oliver
This fixes linking errors where variables cannot be correctly linked in from an external shared library such as with msvc (requires dllimport which is not used by libaom). Instead just call the function that returns the same variable. --- libavcodec/libaomdec.c | 2 +- 1 file changed, 1 insertion(

Re: [FFmpeg-devel] [PATCH] libaom: Dont use aom_codec_av1_dx_algo.

2021-10-29 Thread Matt Oliver
> > lgtm. > Thanks, I will push this assuming no other comments. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subje

Re: [FFmpeg-devel] [PATCH] libaom: Dont use aom_codec_av1_dx_algo.

2021-10-29 Thread Matt Oliver
> > Does this compile and link with libaom 1.0.0? We unfortunately still > support that version (despite being unusable speed wise) because distros > like Debian still ship it. > Just looked it up and yes version 1.0.0 includes the required aom_codec_av1_dx() function (line 37 of aomdx.h for those

[FFmpeg-devel] [PATCH] libx264: Do not explicitly set X264_API_IMPORTS

2021-10-29 Thread Matt Oliver
igure changes that I'm not sure how best to do (assistance welcome). Signed-off-by: Matt Oliver --- configure| 8 +++- libavcodec/libx264.c | 4 2 files changed, 3 insertions(+), 9 deletions(-) diff --git a/configure b/configure index ede8f9777b..b35728aace 100755 --- a

Re: [FFmpeg-devel] [PATCH] libaom: Dont use aom_codec_av1_dx_algo.

2021-10-29 Thread Matt Oliver
On Sat, 30 Oct 2021 at 14:13, Matt Oliver wrote: > Does this compile and link with libaom 1.0.0? We unfortunately still >> support that version (despite being unusable speed wise) because distros >> like Debian still ship it. >> > > Just looked it up and yes version

Re: [FFmpeg-devel] [PATCH] libaom: Dont use aom_codec_av1_dx_algo.

2021-11-01 Thread Matt Oliver
On Tue, 2 Nov 2021 at 04:41, James Zern wrote: > On Fri, Oct 29, 2021 at 8:51 PM Matt Oliver wrote: > > > > On Sat, 30 Oct 2021 at 14:13, Matt Oliver wrote: > > > > > Does this compile and link with libaom 1.0.0? We unfortunately still > > >> support

[FFmpeg-devel] [PATCH] libvpxdec: Correct linking against variables.

2021-11-03 Thread Matt Oliver
Instead link against the function that returns the correct variable. This fixes linking errors with dlls with msvc. --- libavcodec/libvpxdec.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index 42d1b8ab1c..b2aa205036

Re: [FFmpeg-devel] [PATCH] libvpxdec: Correct linking against variables.

2021-11-22 Thread Matt Oliver
On Thu, 4 Nov 2021 at 15:44, Matt Oliver wrote: > Instead link against the function that returns the correct variable. This > fixes linking errors with dlls with msvc. > --- > libavcodec/libvpxdec.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > di

Re: [FFmpeg-devel] [PATCH] libx264: Do not explicitly set X264_API_IMPORTS

2021-11-30 Thread Matt Oliver
On Sat, 30 Oct 2021 at 14:16, Matt Oliver wrote: > Setting X264_API_IMPORTS only affects msvc builds and it breaks linking to > static builds (although is required for shared builds). This flag is set by > x264 in its pkgconfig as required since

[FFmpeg-devel] [PATCH 2/2] configure: Use no-narrowing for cuda_llvm compilation.

2021-02-12 Thread Matt Oliver
This fixes llvm compiler generating errors about narrowing conversion with recent releases. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index df298b4b9b..e716f6f932 100755 --- a/configure +++ b/configure @@ -6242,7 +6242,7 @@ fi if enabl

[FFmpeg-devel] [PATCH 1/2] cuda_runtime.h: Correct ushort4 to use ushort.

2021-02-12 Thread Matt Oliver
--- compat/cuda/cuda_runtime.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/cuda/cuda_runtime.h b/compat/cuda/cuda_runtime.h index 0bf3de85d3..c5450b2542 100644 --- a/compat/cuda/cuda_runtime.h +++ b/compat/cuda/cuda_runtime.h @@ -73,7 +73,7 @@ typedef struct __device

[FFmpeg-devel] [PATCH] avutil/hwcontext_d3d11va: Use secure dlopen.

2019-12-30 Thread Matt Oliver
dlopen contains additional security to prevent dll hijacking compared to standard LoadLibrary. --- libavutil/hwcontext_d3d11va.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavutil/hwcontext_d3d11va.c b/libavutil/hwcontext_d3d11va.c index 6670c47579..c8ae58f908 10064

[FFmpeg-devel] [PATCH] compat/avisynth: Fix unicode compilation.

2019-12-30 Thread Matt Oliver
--- compat/avisynth/avisynth_c.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compat/avisynth/avisynth_c.h b/compat/avisynth/avisynth_c.h index 8d17125adc..9ff9321552 100644 --- a/compat/avisynth/avisynth_c.h +++ b/compat/avisynth/avisynth_c.h @@ -1096,7 +1096,7 @@ AVSC_INLI

Re: [FFmpeg-devel] [PATCH] compat/avisynth: Fix unicode compilation.

2019-12-30 Thread Matt Oliver
On Tue, 31 Dec 2019 at 14:16, Stephen Hutchinson wrote: > On 12/30/2019 11:11 AM, Matt Oliver wrote: > > --- > > compat/avisynth/avisynth_c.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/compat/avisynth/avisynth_c.h b/compa

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_d3d11va: Use secure dlopen.

2020-01-11 Thread Matt Oliver
On Tue, 31 Dec 2019 at 03:37, Andriy Gelman wrote: > On Mon, 30. Dec 11:31, Andriy Gelman wrote: > > On Tue, 31. Dec 03:02, Matt Oliver wrote: > > > dlopen contains additional security to prevent dll hijacking compared > to > > > standard LoadLibra

Re: [FFmpeg-devel] [PATCH 4/4] avformat/udp: do not use thread cancellation when receiving data

2020-01-17 Thread Matt Oliver
On Fri, 17 Jan 2020 at 18:44, Hendrik Leppkes wrote: > On Fri, Jan 17, 2020 at 12:30 AM Michael Niedermayer > wrote: > > > > On Thu, Jan 16, 2020 at 01:20:16AM +0100, Marton Balint wrote: > > > It is not supported by every threading implementation, and the only > thing we > > > gain with it is a

Re: [FFmpeg-devel] [PATCHv2] avutil/thread: Add pthread_cond_timedwait function

2020-01-19 Thread Matt Oliver
On Mon, 20 Jan 2020 at 11:14, Marton Balint wrote: > From: Matt Oliver > > v2: fix calculating milisecond times and use SleepConditionVariableSRW. > > Signed-off-by: Matt Oliver > --- > compat/os2threads.h | 25 + > c

Re: [FFmpeg-devel] [PATCH 4/4] avformat/udp: do not use thread cancellation when receiving data

2020-01-23 Thread Matt Oliver
On Thu, 23 Jan 2020 at 08:12, Marton Balint wrote: > > > On Wed, 22 Jan 2020, Nicolas George wrote: > > > Marton Balint (12020-01-16): > >> It is not supported by every threading implementation, and the only > thing we > >> gain with it is an immediate shutdown of receiving packets on close and >

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_d3d11va: Use secure dlopen.

2020-02-09 Thread Matt Oliver
final ping. If no objections still ill apply this later. On Sun, 12 Jan 2020 at 06:50, Matt Oliver wrote: > On Tue, 31 Dec 2019 at 03:37, Andriy Gelman > wrote: > >> On Mon, 30. Dec 11:31, Andriy Gelman wrote: >> > On Tue, 31. Dec 03:02, Matt Oliver wrote: >>

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread Matt Oliver
On 13 April 2017 at 17:20, Aaron Levinson wrote: > I wanted to build a debug build of ffmpeg using Visual C++ today, one > without any optimizations. This implies the use of the -Od compiler > option. Unfortunately, I quickly discovered that the build fails soon > after it starts because it can

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread Matt Oliver
On 14 April 2017 at 02:11, Rostislav Pehlivanov wrote: > > > On 13 April 2017 at 16:51, wm4 wrote: > >> On Thu, 13 Apr 2017 17:39:57 +1000 >> Matt Oliver wrote: >> >> > On 13 April 2017 at 17:20, Aaron Levinson wrote: >> > >> > &

Re: [FFmpeg-devel] Debug builds and if (ARCH_...) linking issues

2017-04-13 Thread Matt Oliver
On 14 April 2017 at 03:31, Hendrik Leppkes wrote: > On Thu, Apr 13, 2017 at 7:16 PM, Matt Oliver wrote: > > On 14 April 2017 at 02:11, Rostislav Pehlivanov > wrote: > > > >> > >> > >> On 13 April 2017 at 16:51, wm4 wrote: > >> > >&g

Re: [FFmpeg-devel] [PATCH] configure: Correct detection of pre-processor defines for configure _LISTS.

2017-04-22 Thread Matt Oliver
On 22 April 2017 at 21:09, Matt Oliver wrote: > Currently the find_things configure function will scan a code file (e.g. > allfilters.c) and then create a list of pre-processor values to be added > to configure. > Unfortunately the way it currently does it is incorrect with what the

[FFmpeg-devel] [PATCH] configure: Correct detection of pre-processor defines for configure _LISTS.

2017-04-22 Thread Matt Oliver
Currently the find_things configure function will scan a code file (e.g. allfilters.c) and then create a list of pre-processor values to be added to configure. Unfortunately the way it currently does it is incorrect with what the original c code expects. For example the following exists in allfilte

Re: [FFmpeg-devel] [PATCH] libavformat: LibreSSL (libtls) support

2017-12-09 Thread Matt Oliver
On 5 November 2017 at 02:11, Stefan _ wrote: > Attached patch adds support for LibreSSL. Instead of trying to implement > support into the existing tls_openssl.c using lots of #ifdefs (which was > rejected previously(?)) this adds a new TLS backend making use of the > new libtls library. > > Thin

Re: [FFmpeg-devel] Don't use _tzcnt instrinics with clang for windows w/o BMI.

2017-10-25 Thread Matt Oliver
On 25 October 2017 at 07:15, Dale Curtis wrote: > Technically _tzcnt* intrinsics are only available when the BMI > instruction set is present. However the instruction encoding > degrades to "rep bsf" on older processors. > > Clang for Windows debatably restricts the _tzcnt* instrinics behind > th

[FFmpeg-devel] [PATCH] openssl: Support version 1.1.0.

2016-10-09 Thread Matt Oliver
--- configure | 3 +- libavformat/tls_openssl.c | 159 -- 2 files changed, 98 insertions(+), 64 deletions(-) diff --git a/configure b/configure index df6ffa2..750684a 100755 --- a/configure +++ b/configure @@ -5813,7 +5813,8 @@ enabled

Re: [FFmpeg-devel] [PATCH] openssl: Support version 1.1.0.

2016-10-09 Thread Matt Oliver
On 10 October 2016 at 03:18, Michael Niedermayer wrote: > On Mon, Oct 10, 2016 at 02:39:51AM +1100, Matt Oliver wrote: > > --- > > configure | 3 +- > > libavformat/tls_openssl.c | 159 > > -- > >

Re: [FFmpeg-devel] [PATCH] openssl: Support version 1.1.0.

2016-10-09 Thread Matt Oliver
>From ad4d838ed6673c6d12aeaa7b00036b66371b4d63 Mon Sep 17 00:00:00 2001 From: Matt Oliver Date: Mon, 10 Oct 2016 06:49:54 +1100 Subject: [PATCH] openssl: Support version 1.1.0. Fixes #5675 Signed-off-by: Matt Oliver --- configure | 3 +- libavformat/tls_openssl.c |

Re: [FFmpeg-devel] [PATCH] openssl: Support version 1.1.0.

2016-10-09 Thread Matt Oliver
On 10 October 2016 at 05:48, Lou Logan wrote: > On Sun, Oct 9, 2016, at 07:39 AM, Matt Oliver wrote: > > --- > > configure | 3 +- > > libavformat/tls_openssl.c | 159 > > -- > > 2 files change

Re: [FFmpeg-devel] [PATCH] openssl: Support version 1.1.0.

2016-10-14 Thread Matt Oliver
--- configure | 3 +- libavformat/tls_openssl.c | 163 -- 2 files changed, 102 insertions(+), 64 deletions(-) diff --git a/configure b/configure index e014615..3a92eb3 100755 --- a/configure +++ b/configure @@ -5816,7 +5816,8 @@ enable

Re: [FFmpeg-devel] [PATCH] openssl: Support version 1.1.0.

2016-10-14 Thread Matt Oliver
On 14 October 2016 at 23:04, wm4 wrote: > On Mon, 10 Oct 2016 02:39:51 +1100 > Matt Oliver wrote: > > > --- > > configure | 3 +- > > libavformat/tls_openssl.c | 159 > > -- > > 2 files

Re: [FFmpeg-devel] [PATCH] openssl: Support version 1.1.0.

2016-10-20 Thread Matt Oliver
On 15 October 2016 at 14:22, Matt Oliver wrote: > --- > configure | 3 +- > libavformat/tls_openssl.c | 163 -- > > 2 files changed, 102 insertions(+), 64 deletions(-) > > diff --git a/configure b/configure >

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

2016-10-29 Thread Matt Oliver
> > FYI, last time i tried to include this file from libavcodec i was told >> not to since it's libavformat specific. >> >> The proper place for these wrappers is probably the compat folder, in >> a new file similar to w32threads.h >> > OK finally updated the patch. it now adds the safe dll functio

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

2016-10-29 Thread Matt Oliver
On 29 October 2016 at 23:54, Moritz Barsnick wrote: > On Sat, Oct 29, 2016 at 18:35:19 +1100, Matt Oliver wrote: > > > +#endif /* COMPAT_W32DLFCN_H */ > > \ No newline at end of file > > This shouldn't happen. t

Re: [FFmpeg-devel] [PATCH] Fix build with LibreSSL

2016-10-29 Thread Matt Oliver
On 30 October 2016 at 09:39, Michael Niedermayer wrote: > On Fri, Oct 28, 2016 at 12:47:08AM -0700, Michael Forney wrote: > > Signed-off-by: Michael Forney > > --- > > libavformat/tls_openssl.c | 12 ++-- > > 1 file changed, 6 insertions(+), 6 deletions(-) > > > > diff --git a/libavform

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

2016-10-29 Thread Matt Oliver
On 30 October 2016 at 03:41, Stephen Hutchinson wrote: > On 10/29/2016 11:22 AM, Michael Niedermayer wrote: > >> On Sat, Oct 29, 2016 at 06:35:19PM +1100, Matt Oliver wrote: >> >>> configure |5 + >>> libavformat/avisynth.c | 14 ++

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

2016-10-30 Thread Matt Oliver
On 30 October 2016 at 20:21, Hendrik Leppkes wrote: > On Sun, Oct 30, 2016 at 5:13 AM, Matt Oliver wrote: > > On 30 October 2016 at 03:41, Stephen Hutchinson > wrote: > > > >> On 10/29/2016 11:22 AM, Michael Niedermayer wrote: > >> > >>> On Sa

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

2016-10-30 Thread Matt Oliver
On 31 October 2016 at 05:30, James Almer wrote: > On 10/30/2016 8:31 AM, Matt Oliver wrote: > > From 1dc1f59158cfb12d9160ee47342f5742d67ad864 Mon Sep 17 00:00:00 2001 > > From: Matt Oliver > > Date: Sun, 30 Oct 2016 15:13:47 +1100 > > Subject: [PATCH] avformat/avis

[FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-02 Thread Matt Oliver
--- configure | 6 -- libavformat/udp.c | 48 +++- 2 files changed, 19 insertions(+), 35 deletions(-) diff --git a/configure b/configure index b5bfad6..cec94c4 100755 --- a/configure +++ b/configure @@ -1934,7 +1934,6 @@ SYSTEM_FUNCS="

[FFmpeg-devel] [PATCH 1/2] avutil/thread: Add pthread_cond_timedwait function.

2016-12-02 Thread Matt Oliver
Signed-off-by: Matt Oliver --- compat/os2threads.h | 24 compat/w32pthreads.h | 50 ++ libavutil/thread.h | 6 ++ 3 files changed, 80 insertions(+) diff --git a/compat/os2threads.h b/compat/os2threads.h index

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-02 Thread Matt Oliver
On 2 December 2016 at 22:16, Nicolas George wrote: > Le duodi 12 frimaire, an CCXXV, Matt Oliver a écrit : > > --- > > configure | 6 -- > > libavformat/udp.c | 48 +++- > > 2 files changed, 19 insertions(+), 3

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Matt Oliver
On 3 December 2016 at 05:17, Nicolas George wrote: > Le duodi 12 frimaire, an CCXXV, Matt Oliver a écrit : > > Which changes would those be? > > The fix of errno / return value for pthread_cond_timedwait() for > example. > That was because the pthread wrappers dont set err

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Matt Oliver
On 3 December 2016 at 22:05, Nicolas George wrote: > Le tridi 13 frimaire, an CCXXV, Matt Oliver a écrit : > > That was because the pthread wrappers dont set errno, so its a required > > change to remove dependency on pthread. > > The pthread wrappers are supposed to match

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Matt Oliver
On 3 December 2016 at 22:33, Nicolas George wrote: > Le tridi 13 frimaire, an CCXXV, Matt Oliver a écrit : > > I was just writing an email to rephrase but you beet me to it (sorry i > > wasnt faster) > > No problem. > > > I should rephrase this to "Why is p

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Matt Oliver
On 3 December 2016 at 23:40, Hendrik Leppkes wrote: > On Sat, Dec 3, 2016 at 1:33 PM, Matt Oliver wrote: > > > > I havent fully tested Hendriks idea as the msdn docs dont recommend > calling > > multiple winsock functions at the same time from different threads so i

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-03 Thread Matt Oliver
> > Indeed, in theory that would work. I always forget about these options. > In my experience they do not work reliably, and I would argue against > their use in portable code. For example, starting there: > http://pubs.opengroup.org/onlinepubs/9699919799/basedefs/sys_socket.h.html > can you tell

[FFmpeg-devel] [PATCH 1/3] avutil/thread: Add pthread_cond_timedwait function.

2016-12-06 Thread Matt Oliver
Signed-off-by: Matt Oliver --- compat/os2threads.h | 24 compat/w32pthreads.h | 50 ++ libavutil/thread.h | 6 ++ 3 files changed, 80 insertions(+) diff --git a/compat/os2threads.h b/compat/os2threads.h index

[FFmpeg-devel] [PATCH 2/3] avformat/udp: Use avutil compat pthread_cond_timedwait.

2016-12-06 Thread Matt Oliver
Signed-off-by: Matt Oliver --- libavformat/udp.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index 3835f98..f8c861d 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -60,14 +60,14 @@ #define IPPROTO_UDPLITE

[FFmpeg-devel] [PATCH 3/3] avformat/udp: Enable FIFO when using windows sockets.

2016-12-06 Thread Matt Oliver
Signed-off-by: Matt Oliver --- libavformat/udp.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index f8c861d..0e4766f 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -64,6 +64,14 @@ #define

Re: [FFmpeg-devel] [PATCH] Fix build with LibreSSL

2016-12-06 Thread Matt Oliver
On 30 October 2016 at 17:57, Michael Forney wrote: > On 10/29/16, Matt Oliver wrote: > > This also seems a bit odd, why is libreSSL setting an openssl version > > number of 1.1.0 or higher when it doesnt actually conform to the > > corresponding openssl version. LibreSS

Re: [FFmpeg-devel] [PATCH 2/2] avformat/udp: Replace use of pthread_cancel.

2016-12-06 Thread Matt Oliver
On 4 December 2016 at 01:56, Matt Oliver wrote: > Indeed, in theory that would work. I always forget about these options. >> In my experience they do not work reliably, and I would argue against >> their use in portable code. For example, starting there: >> http://pubs.ope

Re: [FFmpeg-devel] [PATCH 1/3] avutil/thread: Add pthread_cond_timedwait function.

2016-12-07 Thread Matt Oliver
On 7 December 2016 at 21:32, Hendrik Leppkes wrote: > On Wed, Dec 7, 2016 at 7:04 AM, Matt Oliver wrote: > > Signed-off-by: Matt Oliver > > --- > > compat/os2threads.h | 24 > >

Re: [FFmpeg-devel] [PATCH 3/3] avformat/udp: Enable FIFO when using windows sockets.

2016-12-07 Thread Matt Oliver
On 7 December 2016 at 21:19, Mark Thompson wrote: > On 07/12/16 06:05, Matt Oliver wrote: > > Signed-off-by: Matt Oliver > > --- > > libavformat/udp.c | 19 +-- > > 1 file changed, 17 insertions(+), 2 deletions(-) > > > > diff --git

Re: [FFmpeg-devel] [PATCH 3/3] avformat/udp: Enable FIFO when using windows sockets.

2016-12-08 Thread Matt Oliver
On 8 December 2016 at 04:49, Nicolas George wrote: > Le septidi 17 frimaire, an CCXXV, Hendrik Leppkes a écrit : > > I'm not sure you can safely avoid that in this design when dealing > > with a fully generic library and no information or control whats going > > on in other threads. > > You are r

Re: [FFmpeg-devel] [PATCH 2/3] avformat/udp: Use avutil compat pthread_cond_timedwait.

2016-12-11 Thread Matt Oliver
On 11 December 2016 at 00:21, Carl Eugen Hoyos wrote: > 2016-12-07 7:04 GMT+01:00 Matt Oliver : > > > -#if HAVE_PTHREAD_CANCEL > > -#include > > -#endif > > - > > > #ifndef HAVE_PTHREAD_CANCEL > > #define HAVE_PTHREAD_CANCEL 0 > > #endif &g

Re: [FFmpeg-devel] [PATCH 3/3] avformat/udp: Enable FIFO when using windows sockets.

2016-12-11 Thread Matt Oliver
--- libavformat/udp.c | 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/libavformat/udp.c b/libavformat/udp.c index f8c861d..3cafb32 100644 --- a/libavformat/udp.c +++ b/libavformat/udp.c @@ -64,6 +64,14 @@ #define HAVE_PTHREAD_CANCEL 0 #endif +#if HAVE_THREA

Re: [FFmpeg-devel] [PATCH] configure: fix linking with MSVC when using --disable-optimizations

2016-12-15 Thread Matt Oliver
On 16 December 2016 at 11:20, Carl Eugen Hoyos wrote: > 2016-12-14 16:47 GMT+01:00 Steve Lhomme : > > From: Steve Lhomme > > > > Without any optimization flags, MSVC does no dead code elimination (DCE) > at > > all, even for the most trivial cases. DCE is a prerequisite for building > ffmpeg > >

Re: [FFmpeg-devel] [PATCH] lavf/wavdec.c: Fix unresolved symbols on Mac and VS2015 Update 3

2016-12-15 Thread Matt Oliver
On 16 December 2016 at 09:54, Hendrik Leppkes wrote: > On Thu, Dec 15, 2016 at 8:43 PM, Matthew Wolenetz > wrote: > >> > >> This seems like a rather odd issue to be toolchain specific. Can you > >> please provide a configure command line that would result in a broken > >> build? > > > > > > I be

Re: [FFmpeg-devel] [PATCH 3/3] avformat/udp: Enable FIFO when using windows sockets.

2016-12-15 Thread Matt Oliver
On 15 December 2016 at 21:42, Nicolas George wrote: > Le duodi 22 frimaire, an CCXXV, Matt Oliver a écrit : > > --- > > libavformat/udp.c | 17 - > > 1 file changed, 16 insertions(+), 1 deletion(-) > > > > diff --git a/libavformat/udp.c b/li

[FFmpeg-devel] Removing DCE

2016-12-15 Thread Matt Oliver
Recently we have again received several patches that are trying to add workarounds for ffmpegs use of DCE. This is not the first time this has happened and wont be the last until a decision is made about the use of DCE. So I think its time that we made a official decision on the use of DCE. This is

Re: [FFmpeg-devel] [PATCH] lavfi/framequeue: avoid empty structs.

2016-12-19 Thread Matt Oliver
On 19 December 2016 at 18:58, Nicolas George wrote: > Le nonidi 29 frimaire, an CCXXV, Nicolas George a écrit : > > Fix compilation on MSVC. > > Forgot to write in the comment beore sending: this is obviously > untested. > tested and it fixes the issue. LGTM.

Re: [FFmpeg-devel] Removing DCE

2016-12-20 Thread Matt Oliver
On 16 December 2016 at 13:48, Matt Oliver wrote: > Recently we have again received several patches that are trying to add > workarounds for ffmpegs use of DCE. This is not the first time this has > happened and wont be the last until a decision is made about the use of > DCE. So I th

Re: [FFmpeg-devel] Removing DCE

2016-12-21 Thread Matt Oliver
On 21 December 2016 at 19:26, Carl Eugen Hoyos wrote: > 2016-12-16 3:48 GMT+01:00 Matt Oliver : > > > For DCE: > > 1) Ends up with a horrible mess of ifdefs. > > This argument alone has often been sufficient to refuse patches here. > Hence the initial email as I

Re: [FFmpeg-devel] Removing DCE

2016-12-22 Thread Matt Oliver
On 21 December 2016 at 23:55, wm4 wrote: > On Fri, 16 Dec 2016 13:48:16 +1100 > Matt Oliver wrote: > > > Recently we have again received several patches that are trying to add > > workarounds for ffmpegs use of DCE. This is not the first time this has > > happened a

Re: [FFmpeg-devel] Removing DCE

2016-12-22 Thread Matt Oliver
On 23 December 2016 at 15:35, Matt Oliver wrote: > On 21 December 2016 at 23:55, wm4 wrote: > >> On Fri, 16 Dec 2016 13:48:16 +1100 >> Matt Oliver wrote: >> >> > Recently we have again received several patches that are trying to add >> > workaroun

Re: [FFmpeg-devel] [PATCH] cmdutils: remove the current working directory from the DLL search path on win32

2016-08-08 Thread Matt Oliver
On 8 August 2016 at 23:27, Hendrik Leppkes wrote: > --- > cmdutils.c | 9 + > cmdutils.h | 5 + > ffmpeg.c | 2 ++ > ffplay.c | 2 ++ > ffprobe.c | 2 ++ > ffserver.c | 1 + > 6 files changed, 21 insertions(+) > > diff --git a/cmdutils.c b/cmdutils.c > index 03a4836..6960f8c 100

Re: [FFmpeg-devel] [PATCH] avcodec/nvenc: Include nvEncodeAPI v7 SDK header

2016-08-27 Thread Matt Oliver
On 27 August 2016 at 23:12, Timo Rothenpieler wrote: > On 8/27/2016 3:07 PM, Thomas Volkert wrote: > > Hi, > > > > On 27.08.2016 14:58, Timo Rothenpieler wrote: > >> As Nvidia has put the most recent Video Codec SDK behind a double > >> registration wall, of which one needs manual approval of a l

[FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

2016-08-28 Thread Matt Oliver
The dlopen function is modified to prevent loading dll's from the current directory for improved program security for library users. This extends similar functionality from the recently applied SetDllDirectory patch except that it adds additional security for library users as well (as opposed to j

[FFmpeg-devel] [PATCH] configure: Remove fifo muxers dependency on pthreads.

2016-08-28 Thread Matt Oliver
The fifo muxer works without pthreads due to the existing pthread wrappers already available within ffmpeg for other platforms. --- configure | 1 - 1 file changed, 1 deletion(-) diff --git a/configure b/configure index 5c11040..e225b7d 100755 --- a/configure +++ b/configure @@ -2834,7 +2834,6 @

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

2016-08-28 Thread Matt Oliver
On 28 August 2016 at 19:58, Michael Niedermayer wrote: > On Sun, Aug 28, 2016 at 06:50:58PM +1000, Matt Oliver wrote: > > The dlopen function is modified to prevent loading dll's from the current > > directory for improved program security for library users. This

Re: [FFmpeg-devel] [PATCH] configure: Remove fifo muxers dependency on pthreads.

2016-08-29 Thread Matt Oliver
On 29 August 2016 at 16:43, Carl Eugen Hoyos wrote: > Hi! > > 2016-08-29 8:17 GMT+02:00 Matt Oliver : > > The fifo muxer works without pthreads due to the existing pthread > > wrappers already available within ffmpeg for other platforms. > > It should probably still d

Re: [FFmpeg-devel] [PATCH] configure: Remove fifo muxers dependency on pthreads.

2016-08-29 Thread Matt Oliver
On 29 August 2016 at 17:28, Carl Eugen Hoyos wrote: > Hi! > > 2016-08-29 9:00 GMT+02:00 Matt Oliver : > > On 29 August 2016 at 16:43, Carl Eugen Hoyos wrote: > > > >> How did you test this? > >> (How can I test?) > > > > There is a FATE te

Re: [FFmpeg-devel] [PATCH] lavf/os_support: Add safe win32 dlopen/dlclose/dlsym functions.

2016-08-29 Thread Matt Oliver
. On 30 August 2016 at 02:26, Jean-Baptiste Kempf wrote: > On 28 Aug, Matt Oliver wrote : > > The dlopen function is modified to prevent loading dll's from the current > > directory for improved program security for library users. This extends > > similar functional

Re: [FFmpeg-devel] Patch for fixing of nvenc.c compilation using msvc tools

2016-09-14 Thread Matt Oliver
On 14 September 2016 at 20:22, Yogender Kumar Gupta < yogender.gu...@gmail.com> wrote: > Currently libavcodec.c/nvenc.c is not compilable using MSVC tools. I am > attaching a patch that fixes this issue. > > Thanks, > Yogender > What version of msvc are you using? 2015 and 2013 all work fine curr

Re: [FFmpeg-devel] [PATCH 0/3] Include headers for cuvid

2016-09-20 Thread Matt Oliver
On 21 September 2016 at 14:38, Philip Langdale wrote: > The cuvid header situation is a mess - the only feature-complete headers > are > in the Video SDK and not in the cuda header collection. The headers in the > Video SDK are MIT licenced, and so we can bundle them like we do the nvenc > header

Re: [FFmpeg-devel] [PATCH 0/3] Include headers for cuvid

2016-09-21 Thread Matt Oliver
On 21 September 2016 at 15:28, Philip Langdale wrote: > On Wed, 21 Sep 2016 15:09:36 +1000 > Matt Oliver wrote: > > > On 21 September 2016 at 14:38, Philip Langdale > > wrote: > > > > > The cuvid header situation is a mess - the only feature-complete >

Re: [FFmpeg-devel] [patch] gdigrab-mouse-dpi-awareness

2016-02-14 Thread Matt Oliver
On 13 February 2016 at 05:33, Γιώργος Μεταξάκης wrote: > checked with patcheck also. > only "problem" is > "Missing changelog entry (ignore if minor change)' > LGTM, applied. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailm

Re: [FFmpeg-devel] GSoC 2016 own ideas

2016-02-19 Thread Matt Oliver
On 19 February 2016 at 09:20, Gerion Entrup wrote: > On Donnerstag, 18. Februar 2016 21:02:09 CET wm4 wrote: > > On Thu, 18 Feb 2016 20:41:29 +0100 > > > > Gerion Entrup wrote: > > > On Donnerstag, 18. Februar 2016 20:10:47 CET wm4 wrote: > > > > On Thu, 18 Feb 2016 18:27:45 +0100 > > > > > > >

[FFmpeg-devel] [PATCH] avfilter/hwupload_cuda: Add missing semicolon.

2016-02-24 Thread Matt Oliver
This is a really simple patch as apparently when the cuda hwcontext filter was added a semicolon was forgotten. For such simple patches as this is it worth even posting to the mailing list or just directly applying it straight away? --- libavfilter/vf_hwupload_cuda.c | 2 +- 1 file changed, 1 in

Re: [FFmpeg-devel] [PATCH 1/3] lavu/attributes: introduce av_likely, av_unlikely

2016-02-24 Thread Matt Oliver
On 25 February 2016 at 13:20, Ganesh Ajjanagadde wrote: > From: Ganesh Ajjanagadde > > These use __builtin_expect, and may be useful for optimizing nearly > certain branches, to yield size and/or speed improvements. > > Note that this is used in the Linux kernel for the same purpose. For > some

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/dxva2_h264: Fix incorrect assert statement.

2016-03-19 Thread Matt Oliver
On 16 March 2016 at 22:32, Clément Bœsch wrote: > On Wed, Mar 16, 2016 at 12:31:35PM +0100, Matt Oliver wrote: > > ffmpeg | branch: master | Matt Oliver | Wed Mar > 16 22:28:29 2016 +1100| [109dfed7fc265f3e071854d5e6de5dd7f82ff9fb] | > committer: Matt Oliver > > >

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/dxva2_h264: Fix incorrect assert statement.

2016-03-19 Thread Matt Oliver
On 16 March 2016 at 23:04, wm4 wrote: > On Wed, 16 Mar 2016 22:55:09 +1100 > Matt Oliver wrote: > > > On 16 March 2016 at 22:32, Clément Bœsch wrote: > > > > > On Wed, Mar 16, 2016 at 12:31:35PM +0100, Matt Oliver wrote: > > > > ffmpeg | branch: master

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavc/dxva2_h264: Fix incorrect assert statement.

2016-03-20 Thread Matt Oliver
On 16 March 2016 at 23:10, Hendrik Leppkes wrote: > On Wed, Mar 16, 2016 at 1:04 PM, wm4 wrote: > > On Wed, 16 Mar 2016 22:55:09 +1100 > > Matt Oliver wrote: > > > >> On 16 March 2016 at 22:32, Clément Bœsch wrote: > >> > >> > On Wed,

Re: [FFmpeg-devel] [PATCH 2/2] lavf: Add coreimage filter for GPU based image filtering on OSX.

2016-03-28 Thread Matt Oliver
> > +enabled coreimage_filter && { check_header_objcc QuartzCore/CoreImage.h > || disable coreimage_filter; } > +enabled coreimagesrc_filter && { check_header_objcc > QuartzCore/CoreImage.h || disable coreimagesrc_filter; } > Wouldnt it be simpler to just add an item to HEADERS_LIST for QuartzCor

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-04-25 Thread Matt Oliver
On 23 April 2016 at 23:46, wm4 wrote: > On Sat, 23 Apr 2016 14:52:12 +0200 > Reimar Döffinger wrote: > > > On 23.04.2016, at 13:21, wm4 wrote: > > > > > On Sat, 23 Apr 2016 01:16:31 +0200 > > > Hendrik Leppkes wrote: > > > > > >> On Sat, Apr 23, 2016 at 1:02 AM, Bruce Dawson > > >> wrote: > >

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-04-25 Thread Matt Oliver
On 25 April 2016 at 20:42, Michael Niedermayer wrote: > On Mon, Apr 25, 2016 at 06:17:22PM +1000, Matt Oliver wrote: > > On 23 April 2016 at 23:46, wm4 wrote: > > > > > On Sat, 23 Apr 2016 14:52:12 +0200 > > > Reimar Döffinger wrote: > > > &

Re: [FFmpeg-devel] CONFIG_W64_DEMUXER and dead-code elimination

2016-04-25 Thread Matt Oliver
On 26 April 2016 at 01:49, Carl Eugen Hoyos wrote: > Matt Oliver gmail.com> writes: > > > Even so icl does also suffer from issues when using lto > > with optimised builds aswell so its not just limited to > > debug builds. > > Can you confirm that this is Windo

[FFmpeg-devel] [PATCH] lavf/os_support.h: Fix for unicode filenames on windows.

2016-06-06 Thread Matt Oliver
Fixes #819 #5256 #5281 --- libavformat/file.c | 4 libavformat/os_support.h | 24 2 files changed, 28 insertions(+) diff --git a/libavformat/file.c b/libavformat/file.c index 5765ce7..264542a 100644 --- a/libavformat/file.c +++ b/libavformat/file.c @@ -148,7 +

[FFmpeg-devel] [PATCH] lavu/intmath.h: fix compilation with msvc10.

2016-06-06 Thread Matt Oliver
--- libavutil/x86/intmath.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/x86/intmath.h b/libavutil/x86/intmath.h index f58b0d0..de177dd 100644 --- a/libavutil/x86/intmath.h +++ b/libavutil/x86/intmath.h @@ -47,6 +47,7 @@ static av_always_inline av_const int ff_log2_x86(unsigned

Re: [FFmpeg-devel] [PATCH] lavf/os_support.h: Fix for unicode filenames on windows.

2016-06-06 Thread Matt Oliver
On 6 June 2016 at 19:27, Hendrik Leppkes wrote: > On Mon, Jun 6, 2016 at 9:12 AM, Matt Oliver wrote: > > Fixes #819 #5256 #5281 > > --- > > libavformat/file.c | 4 > > libavformat/os_support.h | 24 > > 2 files changed, 28 i

Re: [FFmpeg-devel] [PATCH] lavf/os_support.h: Fix for unicode filenames on windows.

2016-06-06 Thread Matt Oliver
On 6 June 2016 at 19:55, Hendrik Leppkes wrote: > On Mon, Jun 6, 2016 at 11:34 AM, Matt Oliver wrote: > > On 6 June 2016 at 19:27, Hendrik Leppkes wrote: > > > >> On Mon, Jun 6, 2016 at 9:12 AM, Matt Oliver > wrote: > >> > Fixes #819 #5256 #528

Re: [FFmpeg-devel] [PATCH] lavu/intmath.h: fix compilation with msvc10.

2016-06-10 Thread Matt Oliver
On 10 June 2016 at 05:30, Michael Niedermayer wrote: > On Mon, Jun 06, 2016 at 05:11:34PM +1000, Matt Oliver wrote: > > --- > > libavutil/x86/intmath.h | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libavutil/x86/intmath.h b/libavutil/x86/int

Re: [FFmpeg-devel] [FFmpeg-cvslog] lavf/os_support.h: Fix for unicode filenames on windows.

2016-06-13 Thread Matt Oliver
On 13 June 2016 at 18:29, Benoit Fouet wrote: > Hi, > > > > On 13/06/2016 10:21, Clément Bœsch wrote: > >> On Mon, Jun 13, 2016 at 05:50:18AM +0200, Matt Oliver wrote: >> >>> ffmpeg | branch: master | Matt Oliver | Mon Jun >>> 6 17:04:39 2016

Re: [FFmpeg-devel] Removing DCE

2017-01-10 Thread Matt Oliver
On 23 December 2016 at 19:40, Nicolas George wrote: > Le primidi 1er nivôse, an CCXXV, Michael Niedermayer a écrit : > > how hard would it be to write a preprocessor like tool to convert > > all if (ARCH/HAVE/CONFIG_SYMBOL ...) > > to > > #if > > ? > > For a very general case, quite hard, but we

Re: [FFmpeg-devel] [PATCH] lavf/tls_openssl: Support building with LibreSSL

2017-01-29 Thread Matt Oliver
On 29 January 2017 at 01:00, Marek Behun wrote: > On Sat, 28 Jan 2017 14:07:45 +0100 > wm4 wrote: > > > On Sat, 28 Jan 2017 13:01:54 + > > Mark Thompson wrote: > > > > > On 28/01/17 11:28, wm4 wrote: > > > > On Fri, 27 Jan 2017 19:53:50 + > > > > Mark Thompson wrote: > > > > > > > >> O

Re: [FFmpeg-devel] [PATCH 2/2] configure: instruct MSVC 2015 to properly process UTF-8 string literals

2017-02-03 Thread Matt Oliver
On 4 February 2017 at 02:32, Hendrik Leppkes wrote: > On Fri, Feb 3, 2017 at 3:05 PM, James Almer wrote: > > On 2/3/2017 5:41 AM, Hendrik Leppkes wrote: > >> Without the /UTF-8 switch, the MSVC compiler treats all files as in the > >> system codepage, instead of in UTF-8, which causes UTF-8 stri

Re: [FFmpeg-devel] [PATCH 2/2] configure: instruct MSVC 2015 to properly process UTF-8 string literals

2017-02-05 Thread Matt Oliver
On 4 February 2017 at 21:23, Hendrik Leppkes wrote: > On Sat, Feb 4, 2017 at 10:29 AM, Carl Eugen Hoyos > wrote: > > 2017-02-04 10:25 GMT+01:00 Hendrik Leppkes : > > > >> Another MSVC workaround is an undocumented compiler pragma, which > >> works in 2013, but not in 2012 (#pragma > >> execution

[FFmpeg-devel] [PATCH] win32_dlfcn: Support WinRT/UWP.

2017-07-01 Thread Matt Oliver
This only enables dlls that are packaged with the application to be loaded. Due to the limitations of WinRT/UWP it is not allowed to load external/system dlls so this cannot be used as a complete replacement for normal win32 dll loading. --- compat/w32dlfcn.h | 9 - 1 file changed, 8 inser

Re: [FFmpeg-devel] [PATCH] win32_dlfcn: Support WinRT/UWP.

2017-07-01 Thread Matt Oliver
On 2 July 2017 at 00:14, Hendrik Leppkes wrote: > On Sat, Jul 1, 2017 at 3:18 PM, Matt Oliver wrote: > > This only enables dlls that are packaged with the application to be > > loaded. Due to the limitations of WinRT/UWP it is not allowed to load > > external/system dlls s

  1   2   >